210752 2020-04-20 10:25:54 -0700 Fix CheckIsConstant for non-constant values and checking for empty 2020-04-20 11:07:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1643503 0 keith_miller 2020-04-20 10:25:54 -0700 Fix CheckIsConstant for non-constant values and checking for empty 1643504 1 396987 keith_miller 2020-04-20 10:26:41 -0700 Created attachment 396987 Patch 1643510 2 396989 keith_miller 2020-04-20 10:33:28 -0700 Created attachment 396989 Patch 1643512 3 396989 saam 2020-04-20 10:37:27 -0700 Comment on attachment 396989 Patch test? 1643513 4 keith_miller 2020-04-20 10:37:45 -0700 (In reply to Saam Barati from comment #3) > Comment on attachment 396989 [details] > Patch > > test? ToT has broken tests. 1643529 5 ews-feeder 2020-04-20 11:06:31 -0700 Committed r260377: <https://trac.webkit.org/changeset/260377> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396989. 1643533 6 webkit-bug-importer 2020-04-20 11:07:42 -0700 <rdar://problem/62066519> 396987 2020-04-20 10:26:41 -0700 2020-04-20 10:33:25 -0700 Patch bug-210752-20200420102641.patch text/plain 1866 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZTg2ODE4MWRkMmIyMWQ1ZGM5NmEyMjgwYmYxYjllNjNhYjVlNWJmLi4wZWE5ZjkzMDVhNGMxOGM1 Y2JmNGQ0MmViM2RhNjJiNWQ0OTdhZjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0yMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggQ2hlY2tJc0NvbnN0YW50IGZvciBub24tY29uc3RhbnQgdmFs dWVzIGFuZCBjaGVja2luZyBmb3IgZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDc1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgd2Ugb25seSBoYXZl IG9uZSBzcGVjdWxhdGVkIHR5cGUgaWYgb3VyIHZhbHVlCisgICAgICAgIGlzIGVtcHR5LgorCisg ICAgICAgICogZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6CisgICAgICAgIChK U0M6OkRGRzo6QWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVF ZmZlY3RzKToKKwogMjAyMC0wNC0yMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFN0cnVjdHVyZWRDbG9uZSBhbGdvcml0aG0gc2hvdWxkIGJlIGF3YXJlIG9m IEJpZ0ludApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0 cmFjdEludGVycHJldGVySW5saW5lcy5oCmluZGV4IDIyMWExNTU3NzliZmU0NGY0YjlkOGM4NjEx YzAxZDFhZDZiYjNjNTEuLmZmNzkzYTE2NDNmODg3MDNhMmRjYTI0ZWJmNzhhYTE2M2Y1ZTE1N2Eg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnBy ZXRlcklubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0 SW50ZXJwcmV0ZXJJbmxpbmVzLmgKQEAgLTM4MTYsMTAgKzM4MTYsOSBAQCBib29sIEFic3RyYWN0 SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5cGU+OjpleGVjdXRlRWZmZWN0cyh1bnNpZ25lZCBj bG9iYmVyTGltaQogICAgIH0KICAgICAKICAgICBjYXNlIENoZWNrSXNDb25zdGFudDogewotICAg ICAgICBKU1ZhbHVlIHZhbHVlID0gZm9yTm9kZShub2RlLT5jaGlsZDEoKSkudmFsdWUoKTsKLSAg ICAgICAgaWYgKHZhbHVlID09IG5vZGUtPmNvbnN0YW50KCktPnZhbHVlKCkpIHsKKyAgICAgICAg QWJzdHJhY3RWYWx1ZSYgdmFsdWUgPSBmb3JOb2RlKG5vZGUtPmNoaWxkMSgpKTsKKyAgICAgICAg aWYgKHZhbHVlLnZhbHVlKCkgPT0gbm9kZS0+Y29uc3RhbnQoKS0+dmFsdWUoKSAmJiAodmFsdWUu dmFsdWUoKSB8fCBhYnN0cmFjdFZhbHVlLm1fdHlwZSA9PSBTcGVjRW1wdHkpKSB7CiAgICAgICAg ICAgICBtX3N0YXRlLnNldFNob3VsZFRyeUNvbnN0YW50Rm9sZGluZyh0cnVlKTsKLSAgICAgICAg ICAgIEFTU0VSVCh2YWx1ZSB8fCBmb3JOb2RlKG5vZGUtPmNoaWxkMSgpKS5tX3R5cGUgPT0gU3Bl Y0VtcHR5KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGZpbHRlckJ5 VmFsdWUobm9kZS0+Y2hpbGQxKCksICpub2RlLT5jb25zdGFudCgpKTsK 396989 2020-04-20 10:33:28 -0700 2020-04-20 11:06:31 -0700 Patch bug-210752-20200420103327.patch text/plain 1858 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ZTg2ODE4MWRkMmIyMWQ1ZGM5NmEyMjgwYmYxYjllNjNhYjVlNWJmLi4wZWE5ZjkzMDVhNGMxOGM1 Y2JmNGQ0MmViM2RhNjJiNWQ0OTdhZjM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0yMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggQ2hlY2tJc0NvbnN0YW50IGZvciBub24tY29uc3RhbnQgdmFs dWVzIGFuZCBjaGVja2luZyBmb3IgZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDc1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoYXQgd2Ugb25seSBoYXZl IG9uZSBzcGVjdWxhdGVkIHR5cGUgaWYgb3VyIHZhbHVlCisgICAgICAgIGlzIGVtcHR5LgorCisg ICAgICAgICogZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6CisgICAgICAgIChK U0M6OkRGRzo6QWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVF ZmZlY3RzKToKKwogMjAyMC0wNC0yMCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgogCiAgICAgICAgIFN0cnVjdHVyZWRDbG9uZSBhbGdvcml0aG0gc2hvdWxkIGJlIGF3YXJlIG9m IEJpZ0ludApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0 cmFjdEludGVycHJldGVySW5saW5lcy5oCmluZGV4IDIyMWExNTU3NzliZmU0NGY0YjlkOGM4NjEx YzAxZDFhZDZiYjNjNTEuLjJjNzI3YzdmODQ1Njg0ZjhmYjE2OWM2M2RjNjcwMmIzNThkNDYyMjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnBy ZXRlcklubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0 SW50ZXJwcmV0ZXJJbmxpbmVzLmgKQEAgLTM4MTYsMTAgKzM4MTYsOSBAQCBib29sIEFic3RyYWN0 SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5cGU+OjpleGVjdXRlRWZmZWN0cyh1bnNpZ25lZCBj bG9iYmVyTGltaQogICAgIH0KICAgICAKICAgICBjYXNlIENoZWNrSXNDb25zdGFudDogewotICAg ICAgICBKU1ZhbHVlIHZhbHVlID0gZm9yTm9kZShub2RlLT5jaGlsZDEoKSkudmFsdWUoKTsKLSAg ICAgICAgaWYgKHZhbHVlID09IG5vZGUtPmNvbnN0YW50KCktPnZhbHVlKCkpIHsKKyAgICAgICAg QWJzdHJhY3RWYWx1ZSYgdmFsdWUgPSBmb3JOb2RlKG5vZGUtPmNoaWxkMSgpKTsKKyAgICAgICAg aWYgKHZhbHVlLnZhbHVlKCkgPT0gbm9kZS0+Y29uc3RhbnQoKS0+dmFsdWUoKSAmJiAodmFsdWUu dmFsdWUoKSB8fCB2YWx1ZS5tX3R5cGUgPT0gU3BlY0VtcHR5KSkgewogICAgICAgICAgICAgbV9z dGF0ZS5zZXRTaG91bGRUcnlDb25zdGFudEZvbGRpbmcodHJ1ZSk7Ci0gICAgICAgICAgICBBU1NF UlQodmFsdWUgfHwgZm9yTm9kZShub2RlLT5jaGlsZDEoKSkubV90eXBlID09IFNwZWNFbXB0eSk7 CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBmaWx0ZXJCeVZhbHVlKG5v ZGUtPmNoaWxkMSgpLCAqbm9kZS0+Y29uc3RhbnQoKSk7Cg==