210748 2020-04-20 08:22:39 -0700 [Clang 10] Fix warning: definition of implicit copy assignment operator for 'PageBlock' is deprecated because it has a user-declared copy constructor 2020-04-21 09:21:36 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner aperez benjamin bugs-noreply cdumez cmarcelo darin ews-watchlist oldest_to_newest 1643455 0 cturner 2020-04-20 08:22:39 -0700 This warning was spamming the build process a lot. 1643516 1 396990 cturner 2020-04-20 10:43:33 -0700 Created attachment 396990 Patch 1643835 2 aperez 2020-04-21 04:21:37 -0700 Patch LGTM, I am tempted to r+ given that all the EWS builders are green, but would be more confident if someone else would also take a quick look as this is fairly low-level code 🤔️ 1643840 3 396990 aperez 2020-04-21 04:28:37 -0700 Comment on attachment 396990 Patch Let's wait until tomorrow to land this in case someone else wants to take a look, but the more I stare at it, the more I am convinced it's all right :D 1643887 4 darin 2020-04-21 08:57:00 -0700 Looks right to me. 1643894 5 ews-feeder 2020-04-21 09:21:35 -0700 Committed r260431: <https://trac.webkit.org/changeset/260431> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396990. 396990 2020-04-20 10:43:33 -0700 2020-04-21 09:21:35 -0700 Patch bug-210748-20200420184332.patch text/plain 3035 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGIwZGE0NDFkNDE2ZTkyYzY0ZDg2OTY3 YzhmZDIwZDkzOTA4MWU4ZjYuLjZmYjJjZDY2MTMwNDdhZTc1ZDEzYjcwNzA2YTYwNDk2MThjNjYz ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDQtMjAgIENoYXJsaWUgVHVybmVyICA8Y3R1 cm5lckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDbGFuZyAxMF0gRml4IHdhcm5pbmc6IGRlZmlu aXRpb24gb2YgaW1wbGljaXQgY29weSBhc3NpZ25tZW50IG9wZXJhdG9yIGZvciAnUGFnZUJsb2Nr JyBpcyBkZXByZWNhdGVkIGJlY2F1c2UgaXQgaGFzIGEgdXNlci1kZWNsYXJlZCBjb3B5IGNvbnN0 cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTA3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZWNlbnQgQ2xhbmcncyB3aWxsIGlzc3VlIGEgd2FybmluZyBpZiB5b3UgZGVjbGFyZSBhbiBleHBs aWNpdAorICAgICAgICBjb3B5IGNvbnN0cnVjdGlvbiwgYnV0IGxlYXZlIHRoZSBjb21waWxlciB0 byBmaWxsIGluIGFuIGltcGxpY2l0CisgICAgICAgIGFzc2lnbm1lbnQgb3BlcmF0b3IuIEkgdGhp bmsgdGhpcyBpcyB0byBjYXRjaCBjYXNlcyB3aGVyZSB5b3UgZG8KKyAgICAgICAgc29tZXRoaW5n IGV4Y2l0aW5nIGluIGFuIGFzc2lnbm1lbnQgb3BlcmF0b3IvY29weSBjb25zdHJ1Y3RvciBhbmQK KyAgICAgICAgZm9yZ2V0IHRvIGRvIHRoZSBzYW1lIGV4Y2l0aW5nIHRoaW5nIGluIHRoZSBvdGhl ci4KKworICAgICAgICAqIHd0Zi9QYWdlQWxsb2NhdGlvbi5oOiBJbXBvcnQgdGhlIGJhc2UncyBj b25zdHJ1Y3RvciB0byBhdm9pZAorICAgICAgICBkZWZpbmluZyBvdXIgb3duIGlkZW50aWNhbCBv bmUuCisgICAgICAgICogd3RmL1BhZ2VCbG9jay5oOiBSZW1vdmUgdHJpdmlhbCBjb25zdHJ1Y3Rv ciBhbmQgcmVwbGFjZSB3aXRoCisgICAgICAgIG1lbWJlciBpbml0aWFsaXplcnMuIFJlbW92ZSBj b3B5IGNvbnN0cnVjdG9yLiBUaGlzIGxvb2tzIGlkZW50aWNhbAorICAgICAgICB0byB3aGF0IHRo ZSBjb21waWxlciB3b3VsZCBnZW5lcmF0ZSBhbnl3YXkuCisKIDIwMjAtMDQtMTggIFJvYmluIE1v cmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwb3J0IGFuIGlubGlu ZWQgcmVwcmVzZW50YXRpb24gaW4gSlNWYWx1ZSBvZiBzbWFsbCBCaWdJbnRzICgiQmlnSW50MzIi KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGFnZUFsbG9jYXRpb24uaCBiL1NvdXJjZS9X VEYvd3RmL1BhZ2VBbGxvY2F0aW9uLmgKaW5kZXggYjI5NjIwM2EzODU5YWZhMDc3Njk2ZjFmOThh N2E4YTc5MGFjYmQzMC4uZjk1ZTAwZDc2N2VkZDA5N2NlMDFlYmRmNjFjZjg5NzIxNjcyYjZjNSAx MDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFnZUFsbG9jYXRpb24uaAorKysgYi9Tb3VyY2Uv V1RGL3d0Zi9QYWdlQWxsb2NhdGlvbi5oCkBAIC02OSwxMCArNjksNyBAQCBuYW1lc3BhY2UgV1RG IHsKIAogY2xhc3MgUGFnZUFsbG9jYXRpb24gOiBwcml2YXRlIFBhZ2VCbG9jayB7CiBwdWJsaWM6 Ci0gICAgUGFnZUFsbG9jYXRpb24oKQotICAgIHsKLSAgICB9Ci0KKyAgICB1c2luZyBQYWdlQmxv Y2s6OlBhZ2VCbG9jazsKICAgICB1c2luZyBQYWdlQmxvY2s6OnNpemU7CiAgICAgdXNpbmcgUGFn ZUJsb2NrOjpiYXNlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QYWdlQmxvY2suaCBi L1NvdXJjZS9XVEYvd3RmL1BhZ2VCbG9jay5oCmluZGV4IGU2NzBlNDM3MTMzMDNjYjA3Y2EyMzY0 NzFhZjFiYmNlOWNhYjFkOTMuLmNmNWNmMzFiMmM5M2UwMjE5ZDM3MjMxNDZiN2ZiOTViZTg0MGIz YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BhZ2VCbG9jay5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL1BhZ2VCbG9jay5oCkBAIC02Niw4ICs2Niw3IEBAIGlubGluZSBib29sIGlzUG93ZXJP ZlR3byhzaXplX3Qgc2l6ZSkgeyByZXR1cm4gIShzaXplICYgKHNpemUgLSAxKSk7IH0KIGNsYXNz IFBhZ2VCbG9jayB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6Ci0gICAg UGFnZUJsb2NrKCk7Ci0gICAgUGFnZUJsb2NrKGNvbnN0IFBhZ2VCbG9jayYpOworICAgIFBhZ2VC bG9jaygpID0gZGVmYXVsdDsKICAgICBQYWdlQmxvY2sodm9pZCosIHNpemVfdCwgYm9vbCBoYXNH dWFyZFBhZ2VzKTsKICAgICAKICAgICB2b2lkKiBiYXNlKCkgY29uc3QgeyByZXR1cm4gbV9iYXNl OyB9CkBAIC04MiwyNSArODEsMTEgQEAgcHVibGljOgogICAgIH0KIAogcHJpdmF0ZToKLSAgICB2 b2lkKiBtX3JlYWxCYXNlOwotICAgIHZvaWQqIG1fYmFzZTsKLSAgICBzaXplX3QgbV9zaXplOwor ICAgIHZvaWQqIG1fcmVhbEJhc2UgeyBudWxscHRyIH07CisgICAgdm9pZCogbV9iYXNlIHsgbnVs bHB0ciB9OworICAgIHNpemVfdCBtX3NpemUgeyAwIH07CiB9OwogCi1pbmxpbmUgUGFnZUJsb2Nr OjpQYWdlQmxvY2soKQotICAgIDogbV9yZWFsQmFzZSgwKQotICAgICwgbV9iYXNlKDApCi0gICAg LCBtX3NpemUoMCkKLXsKLX0KLQotaW5saW5lIFBhZ2VCbG9jazo6UGFnZUJsb2NrKGNvbnN0IFBh Z2VCbG9jayYgb3RoZXIpCi0gICAgOiBtX3JlYWxCYXNlKG90aGVyLm1fcmVhbEJhc2UpCi0gICAg LCBtX2Jhc2Uob3RoZXIubV9iYXNlKQotICAgICwgbV9zaXplKG90aGVyLm1fc2l6ZSkKLXsKLX0K LQogaW5saW5lIFBhZ2VCbG9jazo6UGFnZUJsb2NrKHZvaWQqIGJhc2UsIHNpemVfdCBzaXplLCBi b29sIGhhc0d1YXJkUGFnZXMpCiAgICAgOiBtX3JlYWxCYXNlKGJhc2UpCiAgICAgLCBtX2Jhc2Uo c3RhdGljX2Nhc3Q8Y2hhcio+KGJhc2UpICsgKChiYXNlICYmIGhhc0d1YXJkUGFnZXMpID8gcGFn ZVNpemUoKSA6IDApKQo=