210742 2020-04-20 05:24:43 -0700 [CMake] gst-build-backed build fails 2020-04-21 01:42:15 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand annulen calvaris cturner ews-watchlist gyuyoung.kim ryuan.choi sergio vjaquez webkit-bug-importer oldest_to_newest 1643424 0 pnormand 2020-04-20 05:24:43 -0700 Because in gst-build the headers are stored in different subdirectories, it exposes an issue in the CMake build definitions. 1643425 1 396967 pnormand 2020-04-20 05:27:52 -0700 Created attachment 396967 Patch 1643450 2 vjaquez 2020-04-20 08:13:35 -0700 Oddly, this is also needed, only for WPE diff --git a/Source/WebKit/PlatformWPE.cmake b/Source/WebKit/PlatformWPE.cmake index 700ff0a480d..43e93e3b07f 100644 --- a/Source/WebKit/PlatformWPE.cmake +++ b/Source/WebKit/PlatformWPE.cmake @@ -279,6 +279,9 @@ list(APPEND WebKit_SYSTEM_INCLUDE_DIRECTORIES ${GIO_UNIX_INCLUDE_DIRS} ${GLIB_INCLUDE_DIRS} ${GSTREAMER_INCLUDE_DIRS} + ${GSTREAMER_AUDIO_INCLUDE_DIRS} + ${GSTREAMER_PBUTILS_INCLUDE_DIRS} + ${GSTREAMER_VIDEO_INCLUDE_DIRS} ${LIBSECCOMP_INCLUDE_DIRS} ${LIBSOUP_INCLUDE_DIRS} ) 1643466 3 pnormand 2020-04-20 09:01:27 -0700 Right: In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:36: In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitBackForwardListPrivate.h:28: In file included from ../../Source/WebKit/UIProcess/WebBackForwardList.h:30: In file included from ../../Source/WebKit/UIProcess/WebPageProxy.h:50: In file included from ../../Source/WebKit/UIProcess/SuspendedPageProxy.h:32: In file included from DerivedSources/WebKit/WebPageProxyMessagesReplies.h:27: In file included from ../../Source/WebKit/Shared/WebPageCreationParameters.h:32: In file included from ../../Source/WebKit/Shared/UserContentControllerParameters.h:29: In file included from ../../Source/WebKit/Shared/WebCompiledContentRuleListData.h:31: In file included from DerivedSources/ForwardingHeaders/WebCore/SharedBuffer.h:52: In file included from DerivedSources/ForwardingHeaders/WebCore/GStreamerCommon.h:25: DerivedSources/ForwardingHeaders/WebCore/GUniquePtrGStreamer.h:24:10: fatal error: 'gst/audio/audio.h' file not found 1643467 4 pnormand 2020-04-20 09:03:52 -0700 (In reply to Víctor M. Jáquez L. from comment #2) > Oddly, this is also needed, only for WPE > The issue doesn't happen there for GTK because PlatformGTK.cmake pulls in pbutils, hence -base. 1643469 5 396979 pnormand 2020-04-20 09:09:38 -0700 Created attachment 396979 Patch 1643480 6 396979 cturner 2020-04-20 09:38:58 -0700 Comment on attachment 396979 Patch I don't understand why this has suddenly started breaking, but I can confirm it fixed my GTK build here as well (no flatpak here), so informal r+ from me. 1643805 7 pnormand 2020-04-21 01:41:28 -0700 Committed r260419: <https://trac.webkit.org/changeset/260419> 1643806 8 webkit-bug-importer 2020-04-21 01:42:15 -0700 <rdar://problem/62096815> 396967 2020-04-20 05:27:52 -0700 2020-04-20 09:09:34 -0700 Patch bug-210742-20200420132751.patch text/plain 2266 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWZjODVhMmQyN2I5NzdhNTQ1MWZiNzcwNDAzYzFiMGEw YmVlZDdlZC4uNDgxMjg0ODQ5Zjg4YmE4MWEwYjEyZmY2OWQ0NWU2MTI1MTg5YjM2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTA0LTIwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbQ01ha2VdW0ZsYXRwYWsgU0RLXSBnc3QtYnVpbGQtYmFja2VkIGJ1aWxkIGZh aWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA3 NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg bm9uLWNvcmUgR1N0cmVhbWVyIGluY2x1ZGUtZGlycyBuZWNlc3NhcnkgZm9yIHRoZSBjb21waWxh dGlvbgorICAgICAgICBvZiB0aGUgR1N0cmVhbWVyIEFQSSB0ZXN0LiBVc3VhbGx5IEdTVFJFQU1F Ul9JTkNMVURFX0RJUlMgaXMKKyAgICAgICAgc3VmZmljaWVudCBiZWNhdXNlIG9uIGEgR1N0cmVh bWVyIHN5c3RlbS13aWRlIGluc3RhbGxhdGlvbiwgYWxsCisgICAgICAgIGhlYWRlcnMgYXJlIHN0 b3JlZCBpbiB0aGUgc2FtZSByb290IGluY2x1ZGUgZGlyLCB0aGUgc2FtZSBhcyB0aGUKKyAgICAg ICAgY29yZSBHU3RyZWFtZXIgbGlicmFyeS4KKworICAgICAgICBCdXQgd2hlbiBidWlsZGluZyB3 aXRoIGdzdC1idWlsZCwgaW5jbHVkZS1kaXJzIGFyZSBzY2F0dGVyZWQgYWxsCisgICAgICAgIG92 ZXIgdGhlIHBsYWNlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUdUSy5jbWFr ZToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRmb3JtV1BFLmNtYWtlOgorCiAyMDIwLTA0 LTIwICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtXZWJYUl1bV1BFXSBMZXQgWFJfUlVOVElNRV9KU09OIGVudmlyb25tZW50IHZhcmlhYmxlIGdv IHRocm91Z2ggZm9yIHRlc3RpbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxh dGZvcm1HVEsuY21ha2UgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlCmlu ZGV4IGQwOGMwODkxNzQ0YzNiYzFkZTcyMmEwNGY4YmM0YmVhOGMyZDlmNWUuLmI3NTVhNTk5NGNj N2QyMGYwNDQ0MDZmYjJhZTJjMTg1Y2Y4MjM0ZjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9y bUdUSy5jbWFrZQpAQCAtNDEsNiArNDEsOSBAQCBsaXN0KEFQUEVORCBUZXN0V2ViQ29yZV9TT1VS Q0VTCiBsaXN0KEFQUEVORCBUZXN0V2ViQ29yZV9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklFUwog ICAgICR7R0xJQl9JTkNMVURFX0RJUlN9CiAgICAgJHtHU1RSRUFNRVJfSU5DTFVERV9ESVJTfQor ICAgICR7R1NUUkVBTUVSX0FVRElPX0lOQ0xVREVfRElSU30KKyAgICAke0dTVFJFQU1FUl9QQlVU SUxTX0lOQ0xVREVfRElSU30KKyAgICAke0dTVFJFQU1FUl9WSURFT19JTkNMVURFX0RJUlN9CiAg ICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KICkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl YktpdEFQSS9QbGF0Zm9ybVdQRS5jbWFrZSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1X UEUuY21ha2UKaW5kZXggODAyMjE1NTUyNTY1NzgyMGMxZTFjMjAyNGMwMGQ4YTc4MDM5NTcwMC4u MmE2YWI4ODFhZTA2YWMwN2ZmMDg0MjU3NmRmNWYxODZiODFlMTRjOCAxMDA2NDQKLS0tIGEvVG9v bHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdQRS5jbWFrZQorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1BsYXRmb3JtV1BFLmNtYWtlCkBAIC0zNyw2ICszNyw5IEBAIGxpc3QoQVBQRU5EIFRlc3RX ZWJDb3JlX1NPVVJDRVMKIGxpc3QoQVBQRU5EIFRlc3RXZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJ UkVDVE9SSUVTCiAgICAgJHtHTElCX0lOQ0xVREVfRElSU30KICAgICAke0dTVFJFQU1FUl9JTkNM VURFX0RJUlN9CisgICAgJHtHU1RSRUFNRVJfQVVESU9fSU5DTFVERV9ESVJTfQorICAgICR7R1NU UkVBTUVSX1BCVVRJTFNfSU5DTFVERV9ESVJTfQorICAgICR7R1NUUkVBTUVSX1ZJREVPX0lOQ0xV REVfRElSU30KICAgICAke0xJQlNPVVBfSU5DTFVERV9ESVJTfQogKQogCg== 396979 2020-04-20 09:09:38 -0700 2020-04-20 23:44:14 -0700 Patch bug-210742-20200420170937.patch text/plain 2833 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Bs YXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCA3 MDBmZjBhNDgwZDZhNTQ2MWNkN2E3ZGY3NTA1M2I1N2YwNTcxNDgwLi40M2U5M2UzYjA3ZjY0MTU1 MDIwMTZhOWRmYzhiZjdlZDBmZTJmMjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRm b3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTI3 OSw2ICsyNzksOSBAQCBsaXN0KEFQUEVORCBXZWJLaXRfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJ RVMKICAgICAke0dJT19VTklYX0lOQ0xVREVfRElSU30KICAgICAke0dMSUJfSU5DTFVERV9ESVJT fQogICAgICR7R1NUUkVBTUVSX0lOQ0xVREVfRElSU30KKyAgICAke0dTVFJFQU1FUl9BVURJT19J TkNMVURFX0RJUlN9CisgICAgJHtHU1RSRUFNRVJfUEJVVElMU19JTkNMVURFX0RJUlN9CisgICAg JHtHU1RSRUFNRVJfVklERU9fSU5DTFVERV9ESVJTfQogICAgICR7TElCU0VDQ09NUF9JTkNMVURF X0RJUlN9CiAgICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KICkKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMjY0NGIyMjJkOTMwZjQzM2Y5OTNh NmUzYzMxMjJhYzM0YmYxODVhLi5lZTg4ODFjN2UxOTJmOTk5NmZjOTEyYzQ4MGZlNDRmNjQ4MzI4 OWI4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMjAtMDQtMjAgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV1bRmxhdHBhayBTREtdIGdzdC1idWlsZC1iYWNr ZWQgYnVpbGQgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMDc0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBub24tY29yZSBHU3RyZWFtZXIgaW5jbHVkZS1kaXJzIG5lY2Vzc2FyeSBmb3Ig dGhlIGNvbXBpbGF0aW9uCisgICAgICAgIG9mIHRoZSBHU3RyZWFtZXIgQVBJIHRlc3QuIFVzdWFs bHkgR1NUUkVBTUVSX0lOQ0xVREVfRElSUyBpcworICAgICAgICBzdWZmaWNpZW50IGJlY2F1c2Ug b24gYSBHU3RyZWFtZXIgc3lzdGVtLXdpZGUgaW5zdGFsbGF0aW9uLCBhbGwKKyAgICAgICAgaGVh ZGVycyBhcmUgc3RvcmVkIGluIHRoZSBzYW1lIHJvb3QgaW5jbHVkZSBkaXIsIHRoZSBzYW1lIGFz IHRoZQorICAgICAgICBjb3JlIEdTdHJlYW1lciBsaWJyYXJ5LgorCisgICAgICAgIEJ1dCB3aGVu IGJ1aWxkaW5nIHdpdGggZ3N0LWJ1aWxkLCBpbmNsdWRlLWRpcnMgYXJlIHNjYXR0ZXJlZCBhbGwK KyAgICAgICAgb3ZlciB0aGUgcGxhY2UuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1BsYXRm b3JtR1RLLmNtYWtlOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvUGxhdGZvcm1XUEUuY21ha2U6 CisKIDIwMjAtMDQtMjAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFVzZSAjaW1wb3J0IGluc3RlYWQgb2YgI2luY2x1ZGUgaW4gT2JqZWN0aXZlLUMgYW5kIGRvbid0 IHVzZSAjcHJhZ21hIG9uY2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZv cm1HVEsuY21ha2UgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4 IGQwOGMwODkxNzQ0YzNiYzFkZTcyMmEwNGY4YmM0YmVhOGMyZDlmNWUuLmI3NTVhNTk5NGNjN2Qy MGYwNDQ0MDZmYjJhZTJjMTg1Y2Y4MjM0ZjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvUGxhdGZvcm1HVEsuY21ha2UKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybUdU Sy5jbWFrZQpAQCAtNDEsNiArNDEsOSBAQCBsaXN0KEFQUEVORCBUZXN0V2ViQ29yZV9TT1VSQ0VT CiBsaXN0KEFQUEVORCBUZXN0V2ViQ29yZV9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklFUwogICAg ICR7R0xJQl9JTkNMVURFX0RJUlN9CiAgICAgJHtHU1RSRUFNRVJfSU5DTFVERV9ESVJTfQorICAg ICR7R1NUUkVBTUVSX0FVRElPX0lOQ0xVREVfRElSU30KKyAgICAke0dTVFJFQU1FUl9QQlVUSUxT X0lOQ0xVREVfRElSU30KKyAgICAke0dTVFJFQU1FUl9WSURFT19JTkNMVURFX0RJUlN9CiAgICAg JHtMSUJTT1VQX0lOQ0xVREVfRElSU30KICkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9QbGF0Zm9ybVdQRS5jbWFrZSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1XUEUu Y21ha2UKaW5kZXggODAyMjE1NTUyNTY1NzgyMGMxZTFjMjAyNGMwMGQ4YTc4MDM5NTcwMC4uMmE2 YWI4ODFhZTA2YWMwN2ZmMDg0MjU3NmRmNWYxODZiODFlMTRjOCAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS9QbGF0Zm9ybVdQRS5jbWFrZQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1BsYXRmb3JtV1BFLmNtYWtlCkBAIC0zNyw2ICszNyw5IEBAIGxpc3QoQVBQRU5EIFRlc3RXZWJD b3JlX1NPVVJDRVMKIGxpc3QoQVBQRU5EIFRlc3RXZWJDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVD VE9SSUVTCiAgICAgJHtHTElCX0lOQ0xVREVfRElSU30KICAgICAke0dTVFJFQU1FUl9JTkNMVURF X0RJUlN9CisgICAgJHtHU1RSRUFNRVJfQVVESU9fSU5DTFVERV9ESVJTfQorICAgICR7R1NUUkVB TUVSX1BCVVRJTFNfSU5DTFVERV9ESVJTfQorICAgICR7R1NUUkVBTUVSX1ZJREVPX0lOQ0xVREVf RElSU30KICAgICAke0xJQlNPVVBfSU5DTFVERV9ESVJTfQogKQogCg==