210737 2020-04-20 01:07:59 -0700 [Flatpak SDK] Prevent exception when calling git in a non-git repository 2020-04-20 08:25:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino pnormand webkit-bug-importer oldest_to_newest 1643385 0 dpino 2020-04-20 01:07:59 -0700 [Flatpak SDK] Prevent exception when calling git in a non-git repository 1643386 1 396957 dpino 2020-04-20 01:09:17 -0700 Created attachment 396957 Patch 1643387 2 dpino 2020-04-20 01:13:04 -0700 This error came up when I tried to switch the WPE build bot to flatpak: https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/31955/steps/compile-webkit/logs/stdio I think it didn't work because the bot uses SVN to fetch the code (https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/31955) 1643409 3 dpino 2020-04-20 03:14:43 -0700 *** This bug has been marked as a duplicate of bug 210557 *** 1643453 4 pnormand 2020-04-20 08:18:21 -0700 Sorry, this isn't a duplicate actually. It's a valid patch, thanks Diego :) 1643456 5 ews-feeder 2020-04-20 08:24:21 -0700 Committed r260365: <https://trac.webkit.org/changeset/260365> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396957. 1643457 6 webkit-bug-importer 2020-04-20 08:25:13 -0700 <rdar://problem/62058978> 396957 2020-04-20 01:09:17 -0700 2020-04-20 08:24:22 -0700 Patch bug-210737-20200420100916.patch text/plain 1688 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWJjNmExNjMwOGRhNDYzZGE5OGYwZTU3NTBmMTI1YmRm NmJiMjBjMS4uZjg3NGMwZGExYmVjODAzNzc3NmNiYjc4NzIyMDhlNTA3MjIxNWYxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA0LTIwICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0ZsYXRwYWsgU0RLXSBQcmV2ZW50IGV4Y2VwdGlvbiB3aGVuIGNhbGxpbmcgZ2l0 IGluIGEgbm9uLWdpdCByZXBvc2l0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTA3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGZsYXRwYWsvZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoV2Vi a2l0RmxhdHBhay5pc19icmFuY2hfYnVpbGQpOiBSZXR1cm4gZmFsc2UgaWYgY29tbWFuZCBleGVj dXRlcyBpbiBhCisgICAgICAgIG5vbi1naXQgcmVwb3NpdG9yeSAoaS5lIFNWTikuCisKIDIwMjAt MDQtMTkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBX S1NjcmlwdE1lc3NhZ2VIYW5kbGVyIEFQSSB0aGF0IGFzeW5jaHJvbm91c2x5IHJlc3BvbmRzIHdp dGggYSBwcm9taXNlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkg Yi9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQppbmRleCBmZGY5MzEwOGE2OTI2OTIzZTIw OGRmNTEwMTE5YzIyOGEyYmM5MDMyLi43NjZiZTE5MjU5YjExNzRiNTM4MmY2NzJlODVhNTYzZTZl MmQ5ZmQ4IDEwMDY0NAotLS0gYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQorKysgYi9U b29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weQpAQCAtNTU4LDcgKzU1OCwxMSBAQCBjbGFzcyBX ZWJraXRGbGF0cGFrOgogICAgICAgICByZXR1cm4gW29zLnBhdGguam9pbihnc3RfZGlyLCAnZ3N0 LWVudi5weScpLCAnLS1idWlsZGRpcicsIGdzdF9idWlsZGRpciwgJy0tc3JjZGlyJywgZ3N0X2Rp cl0KIAogICAgIGRlZiBpc19icmFuY2hfYnVpbGQoc2VsZik6Ci0gICAgICAgIGdpdF9icmFuY2hf bmFtZSA9IHN1YnByb2Nlc3MuY2hlY2tfb3V0cHV0KCgiZ2l0IiwgInJldi1wYXJzZSIsICItLWFi YnJldi1yZWYiLCAiSEVBRCIpKS5kZWNvZGUoInV0Zi04Iikuc3RyaXAoKQorICAgICAgICB0cnk6 CisgICAgICAgICAgICByZXZfcGFyc2UgPSBzdWJwcm9jZXNzLmNoZWNrX291dHB1dCgoImdpdCIs ICJyZXYtcGFyc2UiLCAiLS1hYmJyZXYtcmVmIiwgIkhFQUQiKSkKKyAgICAgICAgZXhjZXB0IHN1 YnByb2Nlc3MuQ2FsbGVkUHJvY2Vzc0Vycm9yOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisg ICAgICAgIGdpdF9icmFuY2hfbmFtZSA9IHJldl9wYXJzZS5kZWNvZGUoInV0Zi04Iikuc3RyaXAo KQogICAgICAgICBmb3Igb3B0aW9uX25hbWUgaW4gKCJicmFuY2guJXMud2ViS2l0QnJhbmNoQnVp bGQiICUgZ2l0X2JyYW5jaF9uYW1lLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ3ZWJL aXRCcmFuY2hCdWlsZCIpOgogICAgICAgICAgICAgdHJ5Ogo=