210734 2020-04-19 22:59:02 -0700 check-webkit-style should not complain about missing config.h header in WebKitLegacy source files 2020-04-20 01:26:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210724 InRadar P2 Normal --- 205840 1 ddkilzer ddkilzer darin ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1643335 0 ddkilzer 2020-04-19 22:59:02 -0700 check-webkit-style should not complain about missing config.h header in WebKitLegacy source files. This was a rather easy fix once I found that support for this was added for Source/bmalloc via Bug 205840 in r254140. check-webkit-style: bmalloc doesn't use config.h <https://bugs.webkit.org/show_bug.cgi?id=205840> <https://trac.webkit.org/r254140> 1643336 1 396944 ddkilzer 2020-04-19 23:05:19 -0700 Created attachment 396944 Patch v1 1643341 2 396944 darin 2020-04-19 23:13:04 -0700 Comment on attachment 396944 Patch v1 Also true for many files in WebKit, although not all. Not sure what the rule is. 1643358 3 ddkilzer 2020-04-19 23:41:31 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 396944 [details] > Patch v1 > > Also true for many files in WebKit, although not all. Not sure what the rule > is. Probably things in "Cocoa" directories? I can run the style checker and find them all (probably need to add a `grep` to that): $ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WebKit That's for another patch, though. 1643388 4 ews-feeder 2020-04-20 01:25:38 -0700 Committed r260355: <https://trac.webkit.org/changeset/260355> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396944. 1643389 5 webkit-bug-importer 2020-04-20 01:26:18 -0700 <rdar://problem/62048173> 396944 2020-04-19 23:05:19 -0700 2020-04-20 01:25:38 -0700 Patch v1 bug-210734-20200419230653.patch text/plain 2648 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTA5Yzg2MTBhODhlNDI3ZjQwNzE5MjdjNTRjMDZjNDhh NWU0OTE1My4uOTlkMDkwNmUwMjI0ZGI5NGFiOWJhY2YzNjE4NzZkNzNjOTY1Y2EyNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTA0LTE5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCBub3QgY29tcGxhaW4gYWJvdXQgbWlzc2lu ZyBjb25maWcuaCBoZWFkZXIgaW4gV2ViS2l0TGVnYWN5IHNvdXJjZSBmaWxlcworICAgICAgICA8 aHR0cHM6Ly93ZWJraXQub3JnL2IvMjEwNzM0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHk6CisgICAgICAgIChfTk9fQ09ORklHX0hfUEFUSF9QQVRURVJOUyk6CisgICAgICAgIC0g QWRkICdeU291cmNlL1dlYktpdExlZ2FjeS8nIHRvIHRoZSBsaXN0LgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoT3Jk ZXJPZkluY2x1ZGVzVGVzdC50ZXN0X3ByaW1hcnlfaGVhZGVyKToKKyAgICAgICAgLSBBZGQgdGVz dCBmb3IgU291cmNlL1dlYktpdExlZ2FjeSBzb3VyY2UgZmlsZS4KKwogMjAyMC0wNC0xOSAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlICNpbXBvcnQgaW5zdGVh ZCBvZiAjaW5jbHVkZSBpbiBPYmplY3RpdmUtQyBhbmQgZG9uJ3QgdXNlICNwcmFnbWEgb25jZQpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBlYmE4 MmUxYTE4YjlkZDM2YzhjZDA0OWU5YjEyNzA3YTdiOTM1OGNjLi5hMmRhZGI1ODQ2MjZjMTM3YTZl MmQ2ODIxOTcxYjE5MWVhMjAyODU3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weQpAQCAtMTQwLDYgKzE0MCw3IEBAIF91bml0X3Rlc3RfY29uZmlnID0g e30KIAogX05PX0NPTkZJR19IX1BBVEhfUEFUVEVSTlMgPSBbCiAgICAgJ15Tb3VyY2UvYm1hbGxv Yy8nLAorICAgICdeU291cmNlL1dlYktpdExlZ2FjeS8nLAogXQogCiBfRVhQT1JUX01BQ1JPX1NQ RUMgPSB7CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5CmluZGV4IGUzOGVkZWU2NTY5NGY1YThlNzM0MjU5OWVlYjYxMzNkZDFj ZWU1MjQuLmJkZjcwN2FiZmI5YjcwZjA4NTEzYjdlODBhNTQ3ZmU1NGU2YzdiNGMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5CkBAIC0zMzM1LDYgKzMzMzUsMTMgQEAgY2xhc3MgT3JkZXJPZkluY2x1ZGVzVGVzdChDcHBT dHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg J1Nob3VsZCBiZTogY29uZmlnLmgsIHByaW1hcnkgaGVhZGVyLCBibGFuayBsaW5lLCBhbmQgdGhl biAnCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdhbHBoYWJldGlj YWxseSBzb3J0ZWQuICBbYnVpbGQvaW5jbHVkZV9vcmRlcl0gWzRdJykKIAorICAgICAgICAjIERp cmVjdG9yaWVzIGluIF9OT19DT05GSUdfSF9QQVRIX1BBVFRFUk5TIHN0YXJ0IHdpdGggYSBwcmlt YXJ5IGhlYWRlciAobm8gY29uZmlnLmgpLgorICAgICAgICBzZWxmLmFzc2VydF9sYW5ndWFnZV9y dWxlc19jaGVjaygnU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQWx0 ZXJuYXRpdmVUZXh0Q2xpZW50Lm1tJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJyNpbXBvcnQgIldlYkFsdGVybmF0aXZlVGV4dENsaWVudC5oIlxuJworICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnXG4nCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICcjaW1wb3J0ICJXZWJWaWV3SW50ZXJuYWwuaCI+XG4n LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJykKKwogICAgICAg ICAjICpTb2Z0TGluay5jcHAgZmlsZXMgc2hvdWxkIG5vdCBpbmNsdWRlIHRoZWlyIGhlYWRlcnMg LT4gbm8gZXJyb3IuCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdG b29Tb2Z0TGluay5jcHAnLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnI2luY2x1ZGUgImNvbmZpZy5oIlxuJwo=