210727 2020-04-19 18:13:04 -0700 [JSC] SlowPathCall is not supported by callOperation in Windows 2020-04-19 18:57:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1643275 0 ysuzuki 2020-04-19 18:13:04 -0700 Baseline JIT should use JITSlowPathCall. 1643276 1 396932 ysuzuki 2020-04-19 18:15:50 -0700 Created attachment 396932 Patch 1643278 2 396932 ross.kirsling 2020-04-19 18:50:18 -0700 Comment on attachment 396932 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396932&action=review > Source/JavaScriptCore/jit/SlowPathCall.h:68 > + static_assert(JIT::regT0 == GPRInfo::returnValueGPR); > + static_assert(JIT::regT1 == GPRInfo::returnValueGPR2); Should we update this instead? https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/GPRInfo.h#L796-L799 1643279 3 396932 ysuzuki 2020-04-19 18:51:43 -0700 Comment on attachment 396932 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396932&action=review >> Source/JavaScriptCore/jit/SlowPathCall.h:68 >> + static_assert(JIT::regT1 == GPRInfo::returnValueGPR2); > > Should we update this instead? > https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/jit/GPRInfo.h#L796-L799 For non-Windows x64, returnValueGPR2 is not regT1. We are using this static_assert only inside `OS(WINDOWS)`. 1643280 4 ysuzuki 2020-04-19 18:56:30 -0700 Committed r260346: <https://trac.webkit.org/changeset/260346> 1643281 5 webkit-bug-importer 2020-04-19 18:57:16 -0700 <rdar://problem/62037858> 396932 2020-04-19 18:15:50 -0700 2020-04-19 18:50:18 -0700 Patch bug-210727-20200419181549.patch text/plain 2926 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 YTUyNDk3NzY3MzZhODIzOWUwOWMyNDg3MTA0MjE5NTFhODI4MGFhLi43OGYyNjExNmFhYWI5YTZk MmMyNGVlM2M0MmI5YWNmNTljY2FlNjdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wNC0xOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFNsb3dQYXRoQ2FsbCBpcyBub3Qgc3VwcG9ydGVkIGJ5IGNhbGxP cGVyYXRpb24gaW4gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjEwNzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW4gV2luZG93cywgU2xvd1BhdGhDYWxsIHNob3VsZCBiZSBoYW5kbGVkIGJ5 IEpJVFNsb3dQYXRoQ2FsbCwgb3RoZXJ3aXNlLCBzdGFjayBpcyBub3QgY29ycmVjdGx5IGFsbG9j YXRlZC4KKworICAgICAgICAqIGppdC9KSVRDYWxsLmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpl bWl0X29wX2l0ZXJhdG9yX29wZW4pOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfaXRlcmF0 b3JfbmV4dCk6CisgICAgICAgICogaml0L1Nsb3dQYXRoQ2FsbC5oOgorICAgICAgICAoSlNDOjpK SVRTbG93UGF0aENhbGw6OmNhbGwpOgorCiAyMDIwLTA0LTE5ICBZdXN1a2UgU3V6dWtpICA8eXN1 enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gRW5hYmxlIEJpZ0ludApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRDYWxsLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUQ2FsbC5jcHAKaW5kZXggNjRkNTllMzM2ZjVlZjlkMTA0ZTdhZGIzOWFi MWMwYjQ0OWE0OGZmMi4uMGJhYTFkOWE1ZmE0ZGY4MThlOTBhYzRiMTA4YTY3ZGI5M2MyNzM3NCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRDYWxsLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENhbGwuY3BwCkBAIC0zOTMsOCArMzkzLDkgQEAg dm9pZCBKSVQ6OmVtaXRfb3BfaXRlcmF0b3Jfb3Blbihjb25zdCBJbnN0cnVjdGlvbiogaW5zdHJ1 Y3Rpb24pCiAgICAgICAgIGRlZmF1bHQ6IFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAg ICAgICAgIH0KICAgICB9KSgpOwotICAgIHNldHVwQXJndW1lbnRzPGRlY2x0eXBlKHRyeUZhc3RG dW5jdGlvbik+KGluc3RydWN0aW9uKTsKLSAgICBhcHBlbmRDYWxsV2l0aEV4Y2VwdGlvbkNoZWNr KHRyeUZhc3RGdW5jdGlvbik7CisKKyAgICBKSVRTbG93UGF0aENhbGwgc2xvd1BhdGhDYWxsKHRo aXMsIGluc3RydWN0aW9uLCB0cnlGYXN0RnVuY3Rpb24pOworICAgIHNsb3dQYXRoQ2FsbC5jYWxs KCk7CiAgICAgSnVtcCBmYXN0Q2FzZSA9IGJyYW5jaDMyKE5vdEVxdWFsLCBHUFJJbmZvOjpyZXR1 cm5WYWx1ZUdQUjIsIFRydXN0ZWRJbW0zMihzdGF0aWNfY2FzdDx1aW50MzJfdD4oSXRlcmF0aW9u TW9kZTo6R2VuZXJpYykpKTsKIAogICAgIGNvbXBpbGVPcENhbGw8T3BJdGVyYXRvck9wZW4+KGlu c3RydWN0aW9uLCBtX2NhbGxMaW5rSW5mb0luZGV4KyspOwpAQCAtNDU0LDggKzQ1NSw5IEBAIHZv aWQgSklUOjplbWl0X29wX2l0ZXJhdG9yX25leHQoY29uc3QgSW5zdHJ1Y3Rpb24qIGluc3RydWN0 aW9uKQogCiAgICAgZW1pdEdldFZpcnR1YWxSZWdpc3RlcihieXRlY29kZS5tX25leHQsIHJlZ1Qw KTsKICAgICBKdW1wIGdlbmVyaWNDYXNlID0gYnJhbmNoSWZOb3RFbXB0eShyZWdUMCk7Ci0gICAg c2V0dXBBcmd1bWVudHM8ZGVjbHR5cGUodHJ5RmFzdEZ1bmN0aW9uKT4oaW5zdHJ1Y3Rpb24pOwot ICAgIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2sodHJ5RmFzdEZ1bmN0aW9uKTsKKworICAg IEpJVFNsb3dQYXRoQ2FsbCBzbG93UGF0aENhbGwodGhpcywgaW5zdHJ1Y3Rpb24sIHRyeUZhc3RG dW5jdGlvbik7CisgICAgc2xvd1BhdGhDYWxsLmNhbGwoKTsKICAgICBKdW1wIGZhc3RDYXNlID0g YnJhbmNoMzIoTm90RXF1YWwsIEdQUkluZm86OnJldHVyblZhbHVlR1BSMiwgVHJ1c3RlZEltbTMy KHN0YXRpY19jYXN0PHVpbnQzMl90PihJdGVyYXRpb25Nb2RlOjpHZW5lcmljKSkpOwogCiAgICAg Z2VuZXJpY0Nhc2UubGluayh0aGlzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvU2xvd1BhdGhDYWxsLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1Nsb3dQYXRo Q2FsbC5oCmluZGV4IGMxMWU3OWIwYzU2MWNhMzNjY2IyYmJlMGE4ZWIzYWY2ZWRhNmJjZTMuLjhl YzFhNGU2MjMyMDM2NzJiNTY2ZGZlNDNmMzA0MDQ5YTAzN2Y1M2UgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvU2xvd1BhdGhDYWxsLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9TbG93UGF0aENhbGwuaApAQCAtNjQsNiArNjQsOCBAQCBjbGFzcyBKSVRTbG93 UGF0aENhbGwgewogI2lmIENQVShYODZfNjQpICYmIE9TKFdJTkRPV1MpCiAgICAgICAgIG1faml0 LT5wb3AoSklUOjpyZWdUMCk7IC8vIHZQQwogICAgICAgICBtX2ppdC0+cG9wKEpJVDo6cmVnVDEp OyAvLyBjYWxsRnJhbWUgcmVnaXN0ZXIKKyAgICAgICAgc3RhdGljX2Fzc2VydChKSVQ6OnJlZ1Qw ID09IEdQUkluZm86OnJldHVyblZhbHVlR1BSKTsKKyAgICAgICAgc3RhdGljX2Fzc2VydChKSVQ6 OnJlZ1QxID09IEdQUkluZm86OnJldHVyblZhbHVlR1BSMik7CiAjZW5kaWYKIAogI2lmIEVOQUJM RShPUENPREVfU0FNUExJTkcpCg==