21072 2008-09-24 13:52:29 -0700 Minor dirtyZOrderLists() cleanup 2008-09-24 14:08:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino hyatt oldest_to_newest 92578 0 simon.fraser 2008-09-24 13:52:29 -0700 There are several places that do: RenderLayer* stackingContext = stackingContext(); if (stackingContext) stackingContext->dirtyZOrderLists(); This should be wrapped into a single method. 92579 1 23762 simon.fraser 2008-09-24 13:57:05 -0700 Created attachment 23762 Patch, changelog 92580 2 23762 hyatt 2008-09-24 13:58:28 -0700 Comment on attachment 23762 Patch, changelog r=me 92584 3 simon.fraser 2008-09-24 14:08:35 -0700 Committed r36864 M WebCore/rendering/RenderObject.cpp M WebCore/rendering/RenderLayer.cpp M WebCore/rendering/RenderLayer.h M WebCore/ChangeLog r36864 = 557a047e17efaaa00f818db80aba502ad4469800 (trunk) 23762 2008-09-24 13:57:05 -0700 2008-09-24 13:58:28 -0700 Patch, changelog stacking_context_dirty.txt text/plain 5091 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWQzMWQ0ZC4uY2ExZWUxNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOC0wOS0yNCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXcmFwIHVwIGRpcnR5aW5nIHRoZSB6LW9yZGVyIGxpc3Qgb2Yg dGhlIHN0YWNraW5nIGNvbnRleHQKKyAgICAgICAgUmVuZGVyTGF5ZXIgaW50byBhIG1ldGhvZC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDcyCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyTGF5ZXI6OnNldEhhc1Zpc2libGVDb250ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyOjphZGRDaGlsZCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6cmVt b3ZlQ2hpbGQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmRpcnR5U3RhY2tpbmdD b250ZXh0Wk9yZGVyTGlzdHMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnN0eWxl Q2hhbmdlZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmpl Y3Q6OnNldFN0eWxlKToKKwogMjAwOC0wOS0yNCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgQmFjayBvdXQgdGhlIGFsdGVybmF0ZSBmb3JtcyBvZiBDU1MgdmFyaWFi bGUgY2FsbCBzeW50YXggKGxlYXZpbmcgb25seSB0aGUgLXdlYmtpdC12YXIgdmVyc2lvbikuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggOWNhYjQ4Yi4uZjQ0ZWVmZiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcApAQCAtMjc4LDEwICsyNzgsOCBAQCB2b2lkIFJlbmRlckxheWVy OjpzZXRIYXNWaXNpYmxlQ29udGVudChib29sIGIpCiAgICAgaWYgKG1faGFzVmlzaWJsZUNvbnRl bnQpIHsKICAgICAgICAgbV9yZXBhaW50UmVjdCA9IHJlbmRlcmVyKCktPmFic29sdXRlQ2xpcHBl ZE92ZXJmbG93UmVjdCgpOwogICAgICAgICBtX291dGxpbmVCb3ggPSByZW5kZXJlcigpLT5hYnNv bHV0ZU91dGxpbmVCb3goKTsKLSAgICAgICAgaWYgKCFpc092ZXJmbG93T25seSgpKSB7Ci0gICAg ICAgICAgICBpZiAoUmVuZGVyTGF5ZXIqIHNjID0gc3RhY2tpbmdDb250ZXh0KCkpCi0gICAgICAg ICAgICAgICAgc2MtPmRpcnR5Wk9yZGVyTGlzdHMoKTsKLSAgICAgICAgfQorICAgICAgICBpZiAo IWlzT3ZlcmZsb3dPbmx5KCkpCisgICAgICAgICAgICBkaXJ0eVN0YWNraW5nQ29udGV4dFpPcmRl ckxpc3RzKCk7CiAgICAgfQogICAgIGlmIChwYXJlbnQoKSkKICAgICAgICAgcGFyZW50KCktPmNo aWxkVmlzaWJpbGl0eUNoYW5nZWQobV9oYXNWaXNpYmxlQ29udGVudCk7CkBAIC01ODIsOSArNTgw LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6YWRkQ2hpbGQoUmVuZGVyTGF5ZXIqIGNoaWxkLCBSZW5k ZXJMYXllciogYmVmb3JlQ2hpbGQpCiAgICAgICAgIC8vIERpcnR5IHRoZSB6LW9yZGVyIGxpc3Qg aW4gd2hpY2ggd2UgYXJlIGNvbnRhaW5lZC4gIFRoZSBzdGFja2luZ0NvbnRleHQoKSBjYW4gYmUg bnVsbCBpbiB0aGUKICAgICAgICAgLy8gY2FzZSB3aGVyZSB3ZSdyZSBidWlsZGluZyB1cCBnZW5l cmF0ZWQgY29udGVudCBsYXllcnMuICBUaGlzIGlzIG9rLCBzaW5jZSB0aGUgbGlzdHMgd2lsbCBz dGFydAogICAgICAgICAvLyBvZmYgZGlydHkgaW4gdGhhdCBjYXNlIGFueXdheS4KLSAgICAgICAg UmVuZGVyTGF5ZXIqIHN0YWNraW5nQ29udGV4dCA9IGNoaWxkLT5zdGFja2luZ0NvbnRleHQoKTsK LSAgICAgICAgaWYgKHN0YWNraW5nQ29udGV4dCkKLSAgICAgICAgICAgIHN0YWNraW5nQ29udGV4 dC0+ZGlydHlaT3JkZXJMaXN0cygpOworICAgICAgICBjaGlsZC0+ZGlydHlTdGFja2luZ0NvbnRl eHRaT3JkZXJMaXN0cygpOwogICAgIH0KIAogICAgIGNoaWxkLT51cGRhdGVWaXNpYmlsaXR5U3Rh dHVzKCk7CkBAIC02MTEsOSArNjA3LDcgQEAgUmVuZGVyTGF5ZXIqIFJlbmRlckxheWVyOjpyZW1v dmVDaGlsZChSZW5kZXJMYXllciogb2xkQ2hpbGQpCiAgICAgICAgIC8vIERpcnR5IHRoZSB6LW9y ZGVyIGxpc3QgaW4gd2hpY2ggd2UgYXJlIGNvbnRhaW5lZC4gIFdoZW4gY2FsbGVkIHZpYSB0aGUK ICAgICAgICAgLy8gcmVhdHRhY2htZW50IHByb2Nlc3MgaW4gcmVtb3ZlT25seVRoaXNMYXllciwg dGhlIGxheWVyIG1heSBhbHJlYWR5IGJlIGRpc2Nvbm5lY3RlZAogICAgICAgICAvLyBmcm9tIHRo ZSBtYWluIGxheWVyIHRyZWUsIHNvIHdlIG5lZWQgdG8gbnVsbC1jaGVjayB0aGUgfHN0YWNraW5n Q29udGV4dHwgdmFsdWUuCi0gICAgICAgIFJlbmRlckxheWVyKiBzdGFja2luZ0NvbnRleHQgPSBv bGRDaGlsZC0+c3RhY2tpbmdDb250ZXh0KCk7Ci0gICAgICAgIGlmIChzdGFja2luZ0NvbnRleHQp Ci0gICAgICAgICAgICBzdGFja2luZ0NvbnRleHQtPmRpcnR5Wk9yZGVyTGlzdHMoKTsKKyAgICAg ICAgb2xkQ2hpbGQtPmRpcnR5U3RhY2tpbmdDb250ZXh0Wk9yZGVyTGlzdHMoKTsKICAgICB9CiAK ICAgICBvbGRDaGlsZC0+c2V0UHJldmlvdXNTaWJsaW5nKDApOwpAQCAtMjI2NCw2ICsyMjU4LDEz IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OmRpcnR5Wk9yZGVyTGlzdHMoKQogICAgIG1fek9yZGVyTGlz dHNEaXJ0eSA9IHRydWU7CiB9CiAKK3ZvaWQgUmVuZGVyTGF5ZXI6OmRpcnR5U3RhY2tpbmdDb250 ZXh0Wk9yZGVyTGlzdHMoKQoreworICAgIFJlbmRlckxheWVyKiBzYyA9IHN0YWNraW5nQ29udGV4 dCgpOworICAgIGlmIChzYykKKyAgICAgICAgc2MtPmRpcnR5Wk9yZGVyTGlzdHMoKTsKK30KKwog dm9pZCBSZW5kZXJMYXllcjo6ZGlydHlPdmVyZmxvd0xpc3QoKQogewogICAgIGlmIChtX292ZXJm bG93TGlzdCkKQEAgLTIzNTYsMTEgKzIzNTcsOSBAQCB2b2lkIFJlbmRlckxheWVyOjpzdHlsZUNo YW5nZWQoUmVuZGVyU3R5bGUqIG9sZFN0eWxlKQogICAgIGlmIChpc092ZXJmbG93T25seSAhPSBt X2lzT3ZlcmZsb3dPbmx5KSB7CiAgICAgICAgIG1faXNPdmVyZmxvd09ubHkgPSBpc092ZXJmbG93 T25seTsKICAgICAgICAgUmVuZGVyTGF5ZXIqIHAgPSBwYXJlbnQoKTsKLSAgICAgICAgUmVuZGVy TGF5ZXIqIHNjID0gc3RhY2tpbmdDb250ZXh0KCk7CiAgICAgICAgIGlmIChwKQogICAgICAgICAg ICAgcC0+ZGlydHlPdmVyZmxvd0xpc3QoKTsKLSAgICAgICAgaWYgKHNjKQotICAgICAgICAgICAg c2MtPmRpcnR5Wk9yZGVyTGlzdHMoKTsKKyAgICAgICAgZGlydHlTdGFja2luZ0NvbnRleHRaT3Jk ZXJMaXN0cygpOwogICAgIH0KIAogICAgIGlmIChtX29iamVjdC0+c3R5bGUoKS0+b3ZlcmZsb3dY KCkgPT0gT01BUlFVRUUgJiYgbV9vYmplY3QtPnN0eWxlKCktPm1hcnF1ZWVCZWhhdmlvcigpICE9 IE1OT05FKSB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAppbmRleCBkMzk3Mzk5Li44NmQ1NjYzIDEw MDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCisrKyBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTI2Miw2ICsyNjIsNyBAQCBwdWJsaWM6CiAgICAg Ym9vbCBpc1N0YWNraW5nQ29udGV4dCgpIGNvbnN0IHsgcmV0dXJuICFoYXNBdXRvWkluZGV4KCkg fHwgcmVuZGVyZXIoKS0+aXNSZW5kZXJWaWV3KCk7IH0KIAogICAgIHZvaWQgZGlydHlaT3JkZXJM aXN0cygpOworICAgIHZvaWQgZGlydHlTdGFja2luZ0NvbnRleHRaT3JkZXJMaXN0cygpOwogICAg IHZvaWQgdXBkYXRlWk9yZGVyTGlzdHMoKTsKICAgICBWZWN0b3I8UmVuZGVyTGF5ZXIqPiogcG9z Wk9yZGVyTGlzdCgpIGNvbnN0IHsgcmV0dXJuIG1fcG9zWk9yZGVyTGlzdDsgfQogICAgIFZlY3Rv cjxSZW5kZXJMYXllcio+KiBuZWdaT3JkZXJMaXN0KCkgY29uc3QgeyByZXR1cm4gbV9uZWdaT3Jk ZXJMaXN0OyB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3Bw IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCA2YTZhNmVmLi4wZTNm N2RmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCisrKyBi L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKQEAgLTIxODMsNyArMjE4Myw3IEBA IHZvaWQgUmVuZGVyT2JqZWN0OjpzZXRTdHlsZShSZW5kZXJTdHlsZSogc3R5bGUpCiAgICAgICAg ICAgICBpZiAoKG1fc3R5bGUtPmhhc0F1dG9aSW5kZXgoKSAhPSBzdHlsZS0+aGFzQXV0b1pJbmRl eCgpIHx8CiAgICAgICAgICAgICAgICAgICAgIG1fc3R5bGUtPnpJbmRleCgpICE9IHN0eWxlLT56 SW5kZXgoKSB8fAogICAgICAgICAgICAgICAgICAgICBtX3N0eWxlLT52aXNpYmlsaXR5KCkgIT0g c3R5bGUtPnZpc2liaWxpdHkoKSkgJiYgaGFzTGF5ZXIoKSkgewotICAgICAgICAgICAgICAgIGxh eWVyKCktPnN0YWNraW5nQ29udGV4dCgpLT5kaXJ0eVpPcmRlckxpc3RzKCk7CisgICAgICAgICAg ICAgICAgbGF5ZXIoKS0+ZGlydHlTdGFja2luZ0NvbnRleHRaT3JkZXJMaXN0cygpOwogICAgICAg ICAgICAgICAgIGlmIChtX3N0eWxlLT5oYXNBdXRvWkluZGV4KCkgIT0gc3R5bGUtPmhhc0F1dG9a SW5kZXgoKSB8fAogICAgICAgICAgICAgICAgICAgICAgICAgbV9zdHlsZS0+dmlzaWJpbGl0eSgp ICE9IHN0eWxlLT52aXNpYmlsaXR5KCkpCiAgICAgICAgICAgICAgICAgICAgIGxheWVyKCktPmRp cnR5Wk9yZGVyTGlzdHMoKTsK