210711 2020-04-18 19:42:13 -0700 REGRESSION (r259610): Leak of RBSAssertionInvalidationCallbackType due to missing -dealloc 2020-04-20 00:11:33 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210065 1 ddkilzer ddkilzer cdumez ggaren webkit-bug-importer oldest_to_newest 1643138 0 ddkilzer 2020-04-18 19:42:13 -0700 Leak of RBSAssertionInvalidationCallbackType due to missing -dealloc. Found by clang static analyzer: 'WKRBSAssertionDelegate' lacks a 'dealloc' instance method but must release '_invalidationCallback' Regressed with the fix for Bug 210065 in r259610: Bug 196659: [iOS] Transition most process assertions to RunningBoard <https://bugs.webkit.org/show_bug.cgi?id=210065> <rdar://problem/61354901> <https://trac.webkit.org/r259610> 1643139 1 webkit-bug-importer 2020-04-18 19:43:32 -0700 <rdar://problem/61993361> 1643140 2 396889 ddkilzer 2020-04-18 19:44:56 -0700 Created attachment 396889 Patch v1 1643141 3 396889 ddkilzer 2020-04-18 19:45:26 -0700 Comment on attachment 396889 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396889&action=review > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:275 > +- (void)dealloc I chose to implement dealloc because using RetainPtr<> would require an instance variable and a custom getter (and maybe a setter). When switching to ARC, we simply delete the -dealloc method and the @property will work as expected. 1643269 4 396889 ggaren 2020-04-19 17:45:30 -0700 Comment on attachment 396889 Patch v1 r=me 1643282 5 396933 ddkilzer 2020-04-19 18:58:11 -0700 Created attachment 396933 Patch for landing 1643283 6 396934 ddkilzer 2020-04-19 19:01:31 -0700 Created attachment 396934 Patch for landing v2 1643302 7 ews-feeder 2020-04-19 20:54:31 -0700 Found 1 new test failure: fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html 1643378 8 ews-feeder 2020-04-20 00:11:33 -0700 Committed r260354: <https://trac.webkit.org/changeset/260354> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396934. 396889 2020-04-18 19:44:56 -0700 2020-04-19 18:58:10 -0700 Patch v1 bug-210711-20200418194621.patch text/plain 1585 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQzMDA1OTc3MjNhMDdhYjE5 M2FkOTJiMjY5M2EzMDRhMzY4MjEwZTYuLjhhZDZiZTMxMDg3YTdkNTRmY2U4OWQxMDk4YTE5YjQ0 NTE0YTI4OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjU5NjEw KTogTGVhayBvZiBSQlNBc3NlcnRpb25JbnZhbGlkYXRpb25DYWxsYmFja1R5cGUgZHVlIHRvIG1p c3NpbmcgLWRlYWxsb2MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIxMDcxMT4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxOTkzMzYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9u SU9TLm1tOgorICAgICAgICAoLVtXS1JCU0Fzc2VydGlvbkRlbGVnYXRlIGRlYWxsb2NdKTogQWRk LgorICAgICAgICAtIFJlbGVhc2UgX2ludmFsaWRhdGlvbkNhbGxiYWNrIHRvIGZpeCB0aGUgbGVh ay4KKwogMjAyMC0wNC0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKHIyNDQwOTEpOiBMZWFrIG9mIFRhc2tTdGF0ZUNoYW5nZWRDYWxs YmFja1R5cGUgZHVlIHRvIG1pc3NpbmcgLWRlYWxsb2MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1MubW0KaW5kZXggMjYwZDY5OWUxYmQxZGEy MDRjMjBjYWE5MGE4YzdkOWVjZmIyODI5OC4uMGU1ZmJmMzFkYWQ4YjM1MDhmZDJiMjVjYmJkZjcz NzdlNDlmNjY0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nl c3NBc3NlcnRpb25JT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nl c3NBc3NlcnRpb25JT1MubW0KQEAgLTI3Miw2ICsyNzIsMTQgQEAgQHByb3BlcnR5IChjb3B5KSBS QlNBc3NlcnRpb25JbnZhbGlkYXRpb25DYWxsYmFja1R5cGUgaW52YWxpZGF0aW9uQ2FsbGJhY2s7 CiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXS1JCU0Fzc2VydGlvbkRlbGVnYXRlCistICh2b2lk KWRlYWxsb2MKK3sKKyAgICBbX2ludmFsaWRhdGlvbkNhbGxiYWNrIHJlbGVhc2VdOworICAgIF9p bnZhbGlkYXRpb25DYWxsYmFjayA9IG5pbDsKKworICAgIFtzdXBlciBkZWFsbG9jXTsKK30KKwog LSAodm9pZClhc3NlcnRpb25XaWxsSW52YWxpZGF0ZTooUkJTQXNzZXJ0aW9uICopYXNzZXJ0aW9u CiB7CiAgICAgUkVMRUFTRV9MT0coUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFdLUkJTQXNzZXJ0 aW9uRGVsZWdhdGU6IGFzc2VydGlvbldpbGxJbnZhbGlkYXRlIiwgc2VsZik7Cg== 396933 2020-04-19 18:58:11 -0700 2020-04-19 19:01:30 -0700 Patch for landing bug-210711-20200419185943.patch text/plain 2861 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUxYmI1ZTAwNjVlYjA1MzUw MGI5YTUzOWVmNGQyNDczYjA5OTBhM2EuLjc2ZjQ3OGIyYzJlYjUzNmVlYjgzMWI4MzE2NWQwMDYz NjdiMjYzZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjAtMDQtMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjU5NjEw KTogTGVhayBvZiBSQlNBc3NlcnRpb25JbnZhbGlkYXRpb25DYWxsYmFja1R5cGUgZHVlIHRvIG1p c3NpbmcgLWRlYWxsb2MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIxMDcxMT4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxOTkzMzYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IEdl b2ZmcmV5IEdhcmVuLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9u SU9TLm1tOgorICAgICAgICAoLVtXS1JCU0Fzc2VydGlvbkRlbGVnYXRlIGRlYWxsb2NdKTogQWRk LgorICAgICAgICAtIFJlbGVhc2UgX2ludmFsaWRhdGlvbkNhbGxiYWNrIHRvIGZpeCB0aGUgbGVh ay4KKworMjAyMC0wNC0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT04gKHIyNDQwOTEpOiBMZWFrIG9mIFRhc2tTdGF0ZUNoYW5nZWRDYWxs YmFja1R5cGUgZHVlIHRvIG1pc3NpbmcgLWRlYWxsb2MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzIxMDcxMD4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxOTkyODU2PgorCisgICAg ICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgorCisgICAgICAgICogU2hhcmVkL0NvY29h L1Byb2Nlc3NUYXNrU3RhdGVPYnNlcnZlci5tbToKKyAgICAgICAgKC1bV0tQcm9jZXNzVGFza1N0 YXRlT2JzZXJ2ZXJEZWxlZ2F0ZSBkZWFsbG9jXSk6IEFkZC4KKyAgICAgICAgLSBSZWxlYXNlIF90 YXNrU3RhdGVDaGFuZ2VkQ2FsbGJhY2sgdG8gZml4IHRoZSBsZWFrLgorCiAyMDIwLTA0LTE4ICBE YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgaGVhZGVyIHBv c3Rwcm9jZXNzaW5nIHZlcnNpb24gY3V0b2ZmIHRvIGtlZXAgQXBwbGUgaW50ZXJuYWwgYnVpbGRz IHdvcmtpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL1Byb2Nlc3NU YXNrU3RhdGVPYnNlcnZlci5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL1Byb2Nlc3NU YXNrU3RhdGVPYnNlcnZlci5tbQppbmRleCA1NWNiMTVlZDNlNzllNTBmYWUzMzc1YWExMGMwMTBk YWY1ZDA1OWM1Li43YjIwYWExZGVkY2NhZjM2ZDM1NjU0MTczY2FiNWNkOTU5NGNmM2JlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9Qcm9jZXNzVGFza1N0YXRlT2JzZXJ2 ZXIubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvUHJvY2Vzc1Rhc2tTdGF0ZU9i c2VydmVyLm1tCkBAIC00Myw2ICs0MywxNCBAQCBAcHJvcGVydHkgKGNvcHkpIFRhc2tTdGF0ZUNo YW5nZWRDYWxsYmFja1R5cGUgdGFza1N0YXRlQ2hhbmdlZENhbGxiYWNrOwogQGVuZAogCiBAaW1w bGVtZW50YXRpb24gV0tQcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXJEZWxlZ2F0ZQorLSAodm9pZClk ZWFsbG9jCit7CisgICAgW190YXNrU3RhdGVDaGFuZ2VkQ2FsbGJhY2sgcmVsZWFzZV07CisgICAg X3Rhc2tTdGF0ZUNoYW5nZWRDYWxsYmFjayA9IG5pbDsKKworICAgIFtzdXBlciBkZWFsbG9jXTsK K30KKwogLSAodm9pZClwcm9jZXNzOihCS1NQcm9jZXNzICopcHJvY2VzcyB0YXNrU3RhdGVEaWRD aGFuZ2U6KEJLU1Byb2Nlc3NUYXNrU3RhdGUpbmV3U3RhdGUKIHsKICAgICBSRUxFQVNFX0xPRyhQ cm9jZXNzU3VzcGVuc2lvbiwgIiVwIC1bV0tQcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXJEZWxlZ2F0 ZSBwcm9jZXNzOnRhc2tTdGF0ZURpZENoYW5nZTpdLCBwcm9jZXNzKCVwKSwgbmV3U3RhdGUoJWQp Iiwgc2VsZiwgcHJvY2VzcywgKGludCluZXdTdGF0ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbSBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCmluZGV4IDI2MGQ2OTllMWJkMWRh MjA0YzIwY2FhOTBhOGM3ZDllY2ZiMjgyOTguLjQ2ZDdlMzRlNDgxMWExYjA3YzgzZGUyZTMzMmM3 MmY5YjU1ODM2ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9Qcm9j ZXNzQXNzZXJ0aW9uSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9Qcm9j ZXNzQXNzZXJ0aW9uSU9TLm1tCkBAIC0yNzIsNiArMjcyLDEyIEBAIEBwcm9wZXJ0eSAoY29weSkg UkJTQXNzZXJ0aW9uSW52YWxpZGF0aW9uQ2FsbGJhY2tUeXBlIGludmFsaWRhdGlvbkNhbGxiYWNr OwogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV0tSQlNBc3NlcnRpb25EZWxlZ2F0ZQorLSAodm9p ZClkZWFsbG9jCit7CisgICAgW19pbnZhbGlkYXRpb25DYWxsYmFjayByZWxlYXNlXTsKKyAgICBb c3VwZXIgZGVhbGxvY107Cit9CisKIC0gKHZvaWQpYXNzZXJ0aW9uV2lsbEludmFsaWRhdGU6KFJC U0Fzc2VydGlvbiAqKWFzc2VydGlvbgogewogICAgIFJFTEVBU0VfTE9HKFByb2Nlc3NTdXNwZW5z aW9uLCAiJXAgLSBXS1JCU0Fzc2VydGlvbkRlbGVnYXRlOiBhc3NlcnRpb25XaWxsSW52YWxpZGF0 ZSIsIHNlbGYpOwo= 396934 2020-04-19 19:01:31 -0700 2020-04-20 00:11:33 -0700 Patch for landing v2 bug-210711-20200419190303.patch text/plain 1549 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE2NmU5M2QwMDY0NTk2ZDA5 ZDJjOTQ4YTNiNTkwYTBjYjM2ZTI5NGMuLmFhYzkwMDk2ZTk0OWIzOTdhODg0Yjc3NjQwODk0ZjA1 MjVmOTQ3ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjU5NjEw KTogTGVhayBvZiBSQlNBc3NlcnRpb25JbnZhbGlkYXRpb25DYWxsYmFja1R5cGUgZHVlIHRvIG1p c3NpbmcgLWRlYWxsb2MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIxMDcxMT4KKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxOTkzMzYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IEdl b2ZmcmV5IEdhcmVuLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9u SU9TLm1tOgorICAgICAgICAoLVtXS1JCU0Fzc2VydGlvbkRlbGVnYXRlIGRlYWxsb2NdKTogQWRk LgorICAgICAgICAtIFJlbGVhc2UgX2ludmFsaWRhdGlvbkNhbGxiYWNrIHRvIGZpeCB0aGUgbGVh ay4KKwogMjAyMC0wNC0xOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKHIyNDQwOTEpOiBMZWFrIG9mIFRhc2tTdGF0ZUNoYW5nZWRDYWxs YmFja1R5cGUgZHVlIHRvIG1pc3NpbmcgLWRlYWxsb2MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1MubW0KaW5kZXggMjYwZDY5OWUxYmQxZGEy MDRjMjBjYWE5MGE4YzdkOWVjZmIyODI5OC4uNDZkN2UzNGU0ODExYTFiMDdjODNkZTJlMzMyYzcy ZjliNTU4MzY4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nl c3NBc3NlcnRpb25JT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nl c3NBc3NlcnRpb25JT1MubW0KQEAgLTI3Miw2ICsyNzIsMTIgQEAgQHByb3BlcnR5IChjb3B5KSBS QlNBc3NlcnRpb25JbnZhbGlkYXRpb25DYWxsYmFja1R5cGUgaW52YWxpZGF0aW9uQ2FsbGJhY2s7 CiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXS1JCU0Fzc2VydGlvbkRlbGVnYXRlCistICh2b2lk KWRlYWxsb2MKK3sKKyAgICBbX2ludmFsaWRhdGlvbkNhbGxiYWNrIHJlbGVhc2VdOworICAgIFtz dXBlciBkZWFsbG9jXTsKK30KKwogLSAodm9pZClhc3NlcnRpb25XaWxsSW52YWxpZGF0ZTooUkJT QXNzZXJ0aW9uICopYXNzZXJ0aW9uCiB7CiAgICAgUkVMRUFTRV9MT0coUHJvY2Vzc1N1c3BlbnNp b24sICIlcCAtIFdLUkJTQXNzZXJ0aW9uRGVsZWdhdGU6IGFzc2VydGlvbldpbGxJbnZhbGlkYXRl Iiwgc2VsZik7Cg==