210710 2020-04-18 19:26:57 -0700 REGRESSION (r244091): Leak of TaskStateChangedCallbackType due to missing -dealloc 2020-04-19 20:46:45 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 196659 1 ddkilzer ddkilzer darin eric.carlson jer.noble webkit-bug-importer oldest_to_newest 1643132 0 ddkilzer 2020-04-18 19:26:57 -0700 Leak of TaskStateChangedCallbackType due to missing -dealloc. Found by clang static analyzer: 'WKProcessTaskStateObserverDelegate' lacks a 'dealloc' instance method but must release '_taskStateChangedCallback' Regressed with the fix for Bug 196659 in r244091: Bug 196659: [Cocoa] Awaken UIProcess if WebContent process is awakened from suspensions unexpectedly. <https://bugs.webkit.org/show_bug.cgi?id=196659> <rdar://problem/49745738> <https://trac.webkit.org/r244091> 1643133 1 webkit-bug-importer 2020-04-18 19:27:31 -0700 <rdar://problem/61992856> 1643135 2 396887 ddkilzer 2020-04-18 19:36:02 -0700 Created attachment 396887 Patch v1 1643136 3 396887 ddkilzer 2020-04-18 19:37:25 -0700 Comment on attachment 396887 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396887&action=review > Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm:46 > +- (void)dealloc I chose to implement dealloc because using RetainPtr<> would require an instance variable and a custom getter (and maybe a setter). When switching to ARC, we simply delete the -dealloc method and the @property will work as expected. 1643274 4 396887 darin 2020-04-19 18:07:46 -0700 Comment on attachment 396887 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396887&action=review > Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm:49 > + _taskStateChangedCallback = nil; Seems unnecessary to set things to nil in dealloc. 1643284 5 396935 ddkilzer 2020-04-19 19:08:06 -0700 Created attachment 396935 Patch for landing 1643300 6 ews-feeder 2020-04-19 20:46:44 -0700 Committed r260348: <https://trac.webkit.org/changeset/260348> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396935. 396887 2020-04-18 19:36:02 -0700 2020-04-19 19:08:05 -0700 Patch v1 bug-210710-20200418193727.patch text/plain 1698 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc5MGQ2N2M3NmUyMzdjODM3 MDRkNzVmOTM0MTllZDY5ZjgyMWVhMGMuLjQzMDA1OTc3MjNhMDdhYjE5M2FkOTJiMjY5M2EzMDRh MzY4MjEwZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjQ0MDkx KTogTGVhayBvZiBUYXNrU3RhdGVDaGFuZ2VkQ2FsbGJhY2tUeXBlIGR1ZSB0byBtaXNzaW5nIC1k ZWFsbG9jCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMTA3MTA+CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82MTk5Mjg1Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNoYXJlZC9Db2NvYS9Qcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXIu bW06CisgICAgICAgICgtW1dLUHJvY2Vzc1Rhc2tTdGF0ZU9ic2VydmVyRGVsZWdhdGUgZGVhbGxv Y10pOiBBZGQuCisgICAgICAgIC0gUmVsZWFzZSBfdGFza1N0YXRlQ2hhbmdlZENhbGxiYWNrIHRv IGZpeCB0aGUgbGVhay4KKwogMjAyMC0wNC0xOCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgRml4IFdlYlVzZXJDb250ZW50Q29udHJvbGxlclByb3h5IHZzIENv bnRlbnRXb3JsZCBsaWZldGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29j b2EvUHJvY2Vzc1Rhc2tTdGF0ZU9ic2VydmVyLm1tIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29j b2EvUHJvY2Vzc1Rhc2tTdGF0ZU9ic2VydmVyLm1tCmluZGV4IDU1Y2IxNWVkM2U3OWU1MGZhZTMz NzVhYTEwYzAxMGRhZjVkMDU5YzUuLjdiMjBhYTFkZWRjY2FmMzZkMzU2NTQxNzNjYWI1Y2Q5NTk0 Y2YzYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL1Byb2Nlc3NUYXNr U3RhdGVPYnNlcnZlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9Qcm9jZXNz VGFza1N0YXRlT2JzZXJ2ZXIubW0KQEAgLTQzLDYgKzQzLDE0IEBAIEBwcm9wZXJ0eSAoY29weSkg VGFza1N0YXRlQ2hhbmdlZENhbGxiYWNrVHlwZSB0YXNrU3RhdGVDaGFuZ2VkQ2FsbGJhY2s7CiBA ZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXS1Byb2Nlc3NUYXNrU3RhdGVPYnNlcnZlckRlbGVnYXRl CistICh2b2lkKWRlYWxsb2MKK3sKKyAgICBbX3Rhc2tTdGF0ZUNoYW5nZWRDYWxsYmFjayByZWxl YXNlXTsKKyAgICBfdGFza1N0YXRlQ2hhbmdlZENhbGxiYWNrID0gbmlsOworCisgICAgW3N1cGVy IGRlYWxsb2NdOworfQorCiAtICh2b2lkKXByb2Nlc3M6KEJLU1Byb2Nlc3MgKilwcm9jZXNzIHRh c2tTdGF0ZURpZENoYW5nZTooQktTUHJvY2Vzc1Rhc2tTdGF0ZSluZXdTdGF0ZQogewogICAgIFJF TEVBU0VfTE9HKFByb2Nlc3NTdXNwZW5zaW9uLCAiJXAgLVtXS1Byb2Nlc3NUYXNrU3RhdGVPYnNl cnZlckRlbGVnYXRlIHByb2Nlc3M6dGFza1N0YXRlRGlkQ2hhbmdlOl0sIHByb2Nlc3MoJXApLCBu ZXdTdGF0ZSglZCkiLCBzZWxmLCBwcm9jZXNzLCAoaW50KW5ld1N0YXRlKTsK 396935 2020-04-19 19:08:06 -0700 2020-04-19 20:46:45 -0700 Patch for landing bug-210710-20200419190938.patch text/plain 1675 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUxYmI1ZTAwNjVlYjA1MzUw MGI5YTUzOWVmNGQyNDczYjA5OTBhM2EuLjJlOTdkZTEzOTMxN2QzZWIzNTUyMmJlNTQ2MzA2YWQ1 ZDQ4NDJkY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMTggIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjQ0MDkx KTogTGVhayBvZiBUYXNrU3RhdGVDaGFuZ2VkQ2FsbGJhY2tUeXBlIGR1ZSB0byBtaXNzaW5nIC1k ZWFsbG9jCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMTA3MTA+CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82MTk5Mjg1Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KKworICAgICAgICAqIFNoYXJlZC9Db2NvYS9Qcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXIubW06 CisgICAgICAgICgtW1dLUHJvY2Vzc1Rhc2tTdGF0ZU9ic2VydmVyRGVsZWdhdGUgZGVhbGxvY10p OiBBZGQuCisgICAgICAgIC0gUmVsZWFzZSBfdGFza1N0YXRlQ2hhbmdlZENhbGxiYWNrIHRvIGZp eCB0aGUgbGVhay4KKwogMjAyMC0wNC0xOCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgVXBkYXRlIGhlYWRlciBwb3N0cHJvY2Vzc2luZyB2ZXJzaW9uIGN1dG9mZiB0 byBrZWVwIEFwcGxlIGludGVybmFsIGJ1aWxkcyB3b3JraW5nCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9Db2NvYS9Qcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXIubW0gYi9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9Db2NvYS9Qcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXIubW0KaW5kZXggNTVj YjE1ZWQzZTc5ZTUwZmFlMzM3NWFhMTBjMDEwZGFmNWQwNTljNS4uZTYwYjRiOGJhY2E2ZmM0ZTVi NmQxOTFhMTk5N2E0MWRmMDkwYjgzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQv Q29jb2EvUHJvY2Vzc1Rhc2tTdGF0ZU9ic2VydmVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL0NvY29hL1Byb2Nlc3NUYXNrU3RhdGVPYnNlcnZlci5tbQpAQCAtNDMsNiArNDMsMTIgQEAg QHByb3BlcnR5IChjb3B5KSBUYXNrU3RhdGVDaGFuZ2VkQ2FsbGJhY2tUeXBlIHRhc2tTdGF0ZUNo YW5nZWRDYWxsYmFjazsKIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdLUHJvY2Vzc1Rhc2tTdGF0 ZU9ic2VydmVyRGVsZWdhdGUKKy0gKHZvaWQpZGVhbGxvYworeworICAgIFtfdGFza1N0YXRlQ2hh bmdlZENhbGxiYWNrIHJlbGVhc2VdOworICAgIFtzdXBlciBkZWFsbG9jXTsKK30KKwogLSAodm9p ZClwcm9jZXNzOihCS1NQcm9jZXNzICopcHJvY2VzcyB0YXNrU3RhdGVEaWRDaGFuZ2U6KEJLU1By b2Nlc3NUYXNrU3RhdGUpbmV3U3RhdGUKIHsKICAgICBSRUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVu c2lvbiwgIiVwIC1bV0tQcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXJEZWxlZ2F0ZSBwcm9jZXNzOnRh c2tTdGF0ZURpZENoYW5nZTpdLCBwcm9jZXNzKCVwKSwgbmV3U3RhdGUoJWQpIiwgc2VsZiwgcHJv Y2VzcywgKGludCluZXdTdGF0ZSk7Cg==