210678 2020-04-17 16:00:26 -0700 REGRESSION(r260279): Throwing error would be more efficient, having a generic code is still worth doing (Requested by yusukesuzuki on #webkit). 2020-04-17 16:02:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210667 1 commit-queue commit-queue msaboff webkit-bug-importer ysuzuki oldest_to_newest 1642885 0 commit-queue 2020-04-17 16:00:26 -0700 https://trac.webkit.org/changeset/260279 broke the build: Throwing error would be more efficient, having a generic code is still worth doing (Requested by yusukesuzuki on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1642887 1 396813 commit-queue 2020-04-17 16:00:31 -0700 Created attachment 396813 REVERT of r260279 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1642888 2 ews-feeder 2020-04-17 16:01:45 -0700 Committed r260297: <https://trac.webkit.org/changeset/260297> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396813. 1642889 3 webkit-bug-importer 2020-04-17 16:02:13 -0700 <rdar://problem/61954478> 396813 2020-04-17 16:00:31 -0700 2020-04-17 16:01:45 -0700 REVERT of r260279 bug-210678-20200417160030.patch text/plain 1732 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YWU3ZmIzN2ZmNDQ0NmE2MDY4YjVkODUxMWI5YWI5ODlmNmRhMTk4Li5jZWI1ZGNhMDU0MzhlMjhi MmJmNWE3YzJiZGFjYjlhMjI3MGU4NGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wNC0xNyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNjAyNzkuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA2NzgKKworICAgICAg ICBUaHJvd2luZyBlcnJvciB3b3VsZCBiZSBtb3JlIGVmZmljaWVudCwgaGF2aW5nIGEgZ2VuZXJp YyBjb2RlCisgICAgICAgIGlzIHN0aWxsIHdvcnRoIGRvaW5nIChSZXF1ZXN0ZWQgYnkgeXVzdWtl c3V6dWtpIG9uICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKworICAg ICAgICAiW0pTQ10gV2UgZG8gbm90IG5lZWQgdG8gaGF2ZSBleGl0LWNoZWNrIGZvciBNYXAvU2V0 IGl0ZXJhdG9yCisgICAgICAgIGZ1bmN0aW9ucyIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDY2NworICAgICAgICBodHRwczovL3RyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvMjYwMjc5CisKIDIwMjAtMDQtMTcgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgR2V0VHlwZWRBcnJheUJ5dGVPZmZzZXQgaXMgYnJva2Vu IG9uIGFybTY0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRl Q29kZVBhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFy c2VyLmNwcAppbmRleCA1YjkxNzJkYTlmMDNjYjY5ZDEyZjkyYzU2MTJhYjg1YzU0Zjk2OTkwLi5m ZWEyOGJjNDZlNDI1OWViYjY3NzQ4ZDkxMzQxNDg1Yjc5OTAwYjI1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcApAQCAtMzE4OCw2ICszMTg4 LDkgQEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6aGFuZGxlSW50cmluc2ljQ2FsbChOb2RlKiBjYWxs ZWUsIFZpcnR1YWxSZWdpc3RlciByZXN1bHQsIEkKICAgICAgICAgY2FzZSBKU01hcFZhbHVlc0lu dHJpbnNpYzoKICAgICAgICAgY2FzZSBKU1NldEVudHJpZXNJbnRyaW5zaWM6CiAgICAgICAgIGNh c2UgSlNTZXRWYWx1ZXNJbnRyaW5zaWM6IHsKKyAgICAgICAgICAgIGlmIChtX2lubGluZVN0YWNr VG9wLT5tX2V4aXRQcm9maWxlLmhhc0V4aXRTaXRlKG1fY3VycmVudEluZGV4LCBCYWRDZWxsKSB8 fCBtX2lubGluZVN0YWNrVG9wLT5tX2V4aXRQcm9maWxlLmhhc0V4aXRTaXRlKG1fY3VycmVudElu ZGV4LCBCYWRUeXBlKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICAgICAg ICAgIGluc2VydENoZWNrcygpOwogCiAgICAgICAgICAgICBJdGVyYXRpb25LaW5kIGtpbmQgPSBJ dGVyYXRpb25LaW5kOjpWYWx1ZXM7Cg==