210667 2020-04-17 13:13:56 -0700 [JSC] We do not need to have exit-check for Map/Set iterator functions 2020-04-18 14:17:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 210678 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1642795 0 ysuzuki 2020-04-17 13:13:56 -0700 [JSC] We do not need to have exit-check for Map/Set iterator functions 1642797 1 396788 ysuzuki 2020-04-17 13:16:21 -0700 Created attachment 396788 Patch 1642813 2 396788 msaboff 2020-04-17 13:52:18 -0700 Comment on attachment 396788 Patch r=me 1642821 3 ysuzuki 2020-04-17 14:03:13 -0700 Committed r260279: <https://trac.webkit.org/changeset/260279> 1642822 4 webkit-bug-importer 2020-04-17 14:04:14 -0700 <rdar://problem/61949524> 1642879 5 396788 saam 2020-04-17 15:53:38 -0700 Comment on attachment 396788 Patch But throwing an exception is something the compiler can handle. Exitting always will pessimize the code to a lower tier 1642884 6 ysuzuki 2020-04-17 15:59:22 -0700 (In reply to Saam Barati from comment #5) > Comment on attachment 396788 [details] > Patch > > But throwing an exception is something the compiler can handle. Exitting > always will pessimize the code to a lower tier Oh, interesting. So maybe we should keep this thing. 1642886 7 commit-queue 2020-04-17 16:00:28 -0700 Re-opened since this is blocked by bug 210678 396788 2020-04-17 13:16:21 -0700 2020-04-17 13:52:18 -0700 Patch bug-210667-20200417131621.patch text/plain 2179 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 Mzk3ZGQ0MDk5ODM1MGYyMzk5N2U2OGE1ZDJjOThiYjI3ODY0MzM5Li42N2U5YmY3ZThjZDhkNDAx NDNmMmU1MmY5NGFlNjIzNjA3MzE1N2YxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wNC0xNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFdlIGRvIG5vdCBuZWVkIHRvIGhhdmUgZXhpdC1jaGVjayBmb3Ig TWFwL1NldCBpdGVyYXRvciBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMDY2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIElmIHRoZSBpbnRyaW5zaWMncyBERkcgbm9kZSBkb2VzIG5vdCBz dXBwb3J0IGdlbmVyYWwgY2FzZXMsIHdlIHNob3VsZCBjaGVjayBleGl0LWZyZXF1ZW5jeSB0byBh dm9pZCBleGl0LXJlY29tcGlsZSBsb29wLgorICAgICAgICBIb3dldmVyLCBNYXAvU2V0IGl0ZXJh dG9yIGNyZWF0aW9uIGZ1bmN0aW9ucyAodmFsdWVzLCBrZXlzLCBlbnRyaWVzKSBhbHdheXMgcmVx dWlyZSBNYXAgLyBTZXQgdHlwZXMuIEFuZCB0aHJvd2luZyBhbiBlcnJvcgorICAgICAgICB3aGVu IHRoaXMgaXMgbm90IG1ldC4gU28sIHRoZSBjdXJyZW50IERGRyBub2RlcyBmb3IgdGhlc2UgaW50 cmluc2ljIHN1cHBvcnRzIGFsbCB0aGUgY2FzZXMgZXhjZXB0IGZvciB0aGUgY2FzZSB0aHJvd2lu ZyBhbgorICAgICAgICBlcnJvciwgYW5kIGVycm9yIHdpbGwgZXhpdCBhbnl3YXkuIFNvIHdlIGRv IG5vdCBuZWVkIHRvIGhhdmUgdGhpcyBleGl0LWZyZXF1ZW5jeSBndWFyZCBoZXJlLgorCisgICAg ICAgIFRoaXMgcGF0aCBpcyBhbHJlYWR5IHRlc3RlZCBieSBtYXAtaXRlcmF0b3ItY2hlY2stYmVm b3JlLWZhaWwuanMgLyBzZXQtaXRlcmF0b3ItY2hlY2stYmVmb3JlLWZhaWwuanMuCisKKyAgICAg ICAgKiBkZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVD b2RlUGFyc2VyOjpoYW5kbGVJbnRyaW5zaWNDYWxsKToKKwogMjAyMC0wNC0xNyAgRGV2aW4gUm91 c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIE51bGxpc2hFcSAvIE5V TExJU0hFUVVBTCB0byBDb2FsZXNjZUVxIC8gQ09BTEVTQ0VFUVVBTCB0byBtYXRjaCB0aGUgc3Bl YwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNl ci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcApp bmRleCBmZWEyOGJjNDZlNDI1OWViYjY3NzQ4ZDkxMzQxNDg1Yjc5OTAwYjI1Li41YjkxNzJkYTlm MDNjYjY5ZDEyZjkyYzU2MTJhYjg1YzU0Zjk2OTkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcApAQCAtMzE4OCw5ICszMTg4LDYgQEAgYm9v bCBCeXRlQ29kZVBhcnNlcjo6aGFuZGxlSW50cmluc2ljQ2FsbChOb2RlKiBjYWxsZWUsIFZpcnR1 YWxSZWdpc3RlciByZXN1bHQsIEkKICAgICAgICAgY2FzZSBKU01hcFZhbHVlc0ludHJpbnNpYzoK ICAgICAgICAgY2FzZSBKU1NldEVudHJpZXNJbnRyaW5zaWM6CiAgICAgICAgIGNhc2UgSlNTZXRW YWx1ZXNJbnRyaW5zaWM6IHsKLSAgICAgICAgICAgIGlmIChtX2lubGluZVN0YWNrVG9wLT5tX2V4 aXRQcm9maWxlLmhhc0V4aXRTaXRlKG1fY3VycmVudEluZGV4LCBCYWRDZWxsKSB8fCBtX2lubGlu ZVN0YWNrVG9wLT5tX2V4aXRQcm9maWxlLmhhc0V4aXRTaXRlKG1fY3VycmVudEluZGV4LCBCYWRU eXBlKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICAgICAgICAgIGluc2Vy dENoZWNrcygpOwogCiAgICAgICAgICAgICBJdGVyYXRpb25LaW5kIGtpbmQgPSBJdGVyYXRpb25L aW5kOjpWYWx1ZXM7Cg==