210641 2020-04-17 00:54:41 -0700 Reduce test iterations for stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js on mips 2020-04-17 08:42:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pmatos pmatos ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1642599 0 pmatos 2020-04-17 00:54:41 -0700 Reduce test iterations for mips 1642600 1 396745 pmatos 2020-04-17 00:57:49 -0700 Created attachment 396745 Patch 1642608 2 396746 pmatos 2020-04-17 02:00:12 -0700 Created attachment 396746 Patch 1642630 3 396746 ticaiolima 2020-04-17 04:03:26 -0700 Comment on attachment 396746 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396746&action=review > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4 > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations; It is possible to use `iterations = iterations === undefined ? 10000000 : iterations;` 1642650 4 pmatos 2020-04-17 06:03:02 -0700 (In reply to Caio Lima from comment #3) > Comment on attachment 396746 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396746&action=review > > > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4 > > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations; > > It is possible to use `iterations = iterations === undefined ? 10000000 : > iterations;` After discussing elsewhere with Caio on this, we decided to keep as is since other parts of the codebase use the `typeof(X) === 'undefined'` style. 1642691 5 396746 ysuzuki 2020-04-17 08:40:12 -0700 Comment on attachment 396746 Patch r=me 1642692 6 ews-feeder 2020-04-17 08:42:01 -0700 Committed r260253: <https://trac.webkit.org/changeset/260253> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396746. 1642693 7 webkit-bug-importer 2020-04-17 08:42:12 -0700 <rdar://problem/61936417> 396745 2020-04-17 00:57:49 -0700 2020-04-17 02:00:09 -0700 Patch bug-210641-20200417095737.patch text/plain 1653 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjM3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVjYTcwY2QzOWQ3ZWU4YzQwMDc4NTE2NDAzYTg1 YmY0NzczZjk1YzUuLmMxM2RhMGQyZDRhMjQ3NWZkYTBkNTUyNWIyYTEyYWYwYWFmYjg2N2EgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMjAtMDQtMTcgIFBhdWxvIE1hdG9zICA8cG1hdG9zQGlnYWxpYS5jb20+ CisKKyAgICAgICAgUmVkdWNlIHRlc3QgaXRlcmF0aW9ucyBmb3IgbWlwcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNjQxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVkdWNlIHRlc3QgaXRlcmF0aW9u IGNvdW50IG9uIG1pcHMgZm9yIHdoaWNoIHRoZSBjdXJyZW50IHZhbHVlIGlzIHRvbyBoaWdoLgor CisgICAgICAgICogc3RyZXNzL2FycmF5LWJ1ZmZlci12aWV3LXdhdGNocG9pbnQtY2FuLWJlLWZp cmVkLWluLXJlYWxseS1hZGQtaW4tZGZnLmpzOgorCiAyMDIwLTA0LTE2ICBSb3NzIEtpcnNsaW5n ICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNTk0ODAp OiBUd28gbmV3IGZhaWxpbmcgaTE4biB0ZXN0cwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3Mv YXJyYXktYnVmZmVyLXZpZXctd2F0Y2hwb2ludC1jYW4tYmUtZmlyZWQtaW4tcmVhbGx5LWFkZC1p bi1kZmcuanMgYi9KU1Rlc3RzL3N0cmVzcy9hcnJheS1idWZmZXItdmlldy13YXRjaHBvaW50LWNh bi1iZS1maXJlZC1pbi1yZWFsbHktYWRkLWluLWRmZy5qcwppbmRleCBmZjM3MjUyMDk0YTEwMGZj YjVkNjY1YmVmMjY1OWQ0YTc1NDFhOWQ0Li4zOTU5YTQxNTQ5NzgxNzQ4NjliNzVlY2RkMjUwYzAx OTQ2ZTdhM2YzIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9hcnJheS1idWZmZXItdmlldy13 YXRjaHBvaW50LWNhbi1iZS1maXJlZC1pbi1yZWFsbHktYWRkLWluLWRmZy5qcworKysgYi9KU1Rl c3RzL3N0cmVzcy9hcnJheS1idWZmZXItdmlldy13YXRjaHBvaW50LWNhbi1iZS1maXJlZC1pbi1y ZWFsbHktYWRkLWluLWRmZy5qcwpAQCAtMSw1ICsxLDggQEAKKy8vQCByZXF1aXJlT3B0aW9ucygi LWUiLCAibGV0IGl0ZXJhdGlvbnM9NDAwMDAiKSBpZiBbIm1pcHMiXS5pbmNsdWRlPygkYXJjaGl0 ZWN0dXJlKQogLy9AIHJ1bkRlZmF1bHQoIi0taml0UG9saWN5U2NhbGU9MCIpCiAKK2l0ZXJhdGlv bnMgPSB0eXBlb2YoaXRlcmF0aW9ucykgPT09ICd1bmRlZmluZWQnID8gMTAwMDAwMDAgOiBpdGVy YXRpb25zOworCiBmdW5jdGlvbiB4eHgoKSB7CiAgIGNvbnN0IGEgPSB7fTsKICAgT2JqZWN0LmRl ZmluZVByb3BlcnR5KGEsIDAsIHsgZ2V0OiBmb28gfSk7CkBAIC04LDcgKzExLDcgQEAgZnVuY3Rp b24geHh4KCkgewogICAgIG5ldyBVaW50OEFycmF5KGEpOwogICB9CiAgIG5ldyBQcm9taXNlKGZv byk7Ci0gIGZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDAwMDA7IGkrKykKKyAgZm9yIChsZXQgaSA9 IDA7IGkgPCBpdGVyYXRpb25zOyBpKyspCiAgICAgbmV3IEFycmF5QnVmZmVyKDEwMDApCiB9CiAK 396746 2020-04-17 02:00:12 -0700 2020-04-17 08:42:01 -0700 Patch bug-210641-20200417110000.patch text/plain 1729 pmatos U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjM3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVjYTcwY2QzOWQ3ZWU4YzQwMDc4NTE2NDAzYTg1 YmY0NzczZjk1YzUuLjMwZTU0NDJkNDgyZTVkMGJhNTE4MTA5OTRiMmRhODZiYTVmOWY3N2IgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMjAtMDQtMTcgIFBhdWxvIE1hdG9zICA8cG1hdG9zQGlnYWxpYS5jb20+ CisKKyAgICAgICAgUmVkdWNlIHRlc3QgaXRlcmF0aW9ucyBmb3Igc3RyZXNzL2FycmF5LWJ1ZmZl ci12aWV3LXdhdGNocG9pbnQtY2FuLWJlLWZpcmVkLWluLXJlYWxseS1hZGQtaW4tZGZnLmpzIG9u IG1pcHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MDY0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl ZHVjZSB0ZXN0IGl0ZXJhdGlvbiBjb3VudCBvbiBtaXBzIGZvciB3aGljaCB0aGUgY3VycmVudCB2 YWx1ZSBpcyB0b28gaGlnaC4KKworICAgICAgICAqIHN0cmVzcy9hcnJheS1idWZmZXItdmlldy13 YXRjaHBvaW50LWNhbi1iZS1maXJlZC1pbi1yZWFsbHktYWRkLWluLWRmZy5qczoKKwogMjAyMC0w NC0xNiAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTihyMjU5NDgwKTogVHdvIG5ldyBmYWlsaW5nIGkxOG4gdGVzdHMKZGlmZiAtLWdp dCBhL0pTVGVzdHMvc3RyZXNzL2FycmF5LWJ1ZmZlci12aWV3LXdhdGNocG9pbnQtY2FuLWJlLWZp cmVkLWluLXJlYWxseS1hZGQtaW4tZGZnLmpzIGIvSlNUZXN0cy9zdHJlc3MvYXJyYXktYnVmZmVy LXZpZXctd2F0Y2hwb2ludC1jYW4tYmUtZmlyZWQtaW4tcmVhbGx5LWFkZC1pbi1kZmcuanMKaW5k ZXggZmYzNzI1MjA5NGExMDBmY2I1ZDY2NWJlZjI2NTlkNGE3NTQxYTlkNC4uMzk1OWE0MTU0OTc4 MTc0ODY5Yjc1ZWNkZDI1MGMwMTk0NmU3YTNmMyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3Mv YXJyYXktYnVmZmVyLXZpZXctd2F0Y2hwb2ludC1jYW4tYmUtZmlyZWQtaW4tcmVhbGx5LWFkZC1p bi1kZmcuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvYXJyYXktYnVmZmVyLXZpZXctd2F0Y2hwb2lu dC1jYW4tYmUtZmlyZWQtaW4tcmVhbGx5LWFkZC1pbi1kZmcuanMKQEAgLTEsNSArMSw4IEBACisv L0AgcmVxdWlyZU9wdGlvbnMoIi1lIiwgImxldCBpdGVyYXRpb25zPTQwMDAwIikgaWYgWyJtaXBz Il0uaW5jbHVkZT8oJGFyY2hpdGVjdHVyZSkKIC8vQCBydW5EZWZhdWx0KCItLWppdFBvbGljeVNj YWxlPTAiKQogCitpdGVyYXRpb25zID0gdHlwZW9mKGl0ZXJhdGlvbnMpID09PSAndW5kZWZpbmVk JyA/IDEwMDAwMDAwIDogaXRlcmF0aW9uczsKKwogZnVuY3Rpb24geHh4KCkgewogICBjb25zdCBh ID0ge307CiAgIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShhLCAwLCB7IGdldDogZm9vIH0pOwpAQCAt OCw3ICsxMSw3IEBAIGZ1bmN0aW9uIHh4eCgpIHsKICAgICBuZXcgVWludDhBcnJheShhKTsKICAg fQogICBuZXcgUHJvbWlzZShmb28pOwotICBmb3IgKGxldCBpID0gMDsgaSA8IDEwMDAwMDAwOyBp KyspCisgIGZvciAobGV0IGkgPSAwOyBpIDwgaXRlcmF0aW9uczsgaSsrKQogICAgIG5ldyBBcnJh eUJ1ZmZlcigxMDAwKQogfQogCg==