210639 2020-04-16 23:40:27 -0700 offlineasm is generating the wrong load/store for the "orh" instruction. 2020-04-17 12:27:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 210665 207330 1 mark.lam mark.lam angelos fpizlo guijemont keith_miller msaboff pmatos rmorisset saam ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1642586 0 mark.lam 2020-04-16 23:40:27 -0700 For example, on ARM64E, it was generating the following: "\tldr w17, [x1, #0]\n" // JavaScriptCore/llint/LowLevelInterpreter64.asm:919 "\torr w17, w17, #64\n" // JavaScriptCore/llint/LowLevelInterpreter64.asm:919 "\tstr w17, [x1, #0]\n" // JavaScriptCore/llint/LowLevelInterpreter64.asm:919 i.e. a 32-bit load, followed by a 32-bit OR, followed by a 32-bit store. Instead, it should be generating the following: "\tldrh w17, [x1, #0]\n" // JavaScriptCore/llint/LowLevelInterpreter64.asm:919 "\torr w17, w17, #64\n" // JavaScriptCore/llint/LowLevelInterpreter64.asm:919 "\tstrh w17, [x1, #0]\n" // JavaScriptCore/llint/LowLevelInterpreter64.asm:919 i.e. a 16-bit load, followed by a 32-bit OR, followed by a 16-bit store. This bug also affects ARM64, ARMv7, and MIPS (basically any backend that uses riscLowerMisplacedAddresses() from rise.rb). It does not affect x86, x86_64, and C_LOOP (which was written based on x86). <rdar://problem/21501876> 1642587 1 396743 mark.lam 2020-04-16 23:49:48 -0700 Created attachment 396743 proposed patch. 1642602 2 396743 rmorisset 2020-04-17 01:25:36 -0700 Comment on attachment 396743 proposed patch. r=me 1642665 3 mark.lam 2020-04-17 07:39:50 -0700 Thanks for the review. Landed in r260246: <http://trac.webkit.org/r260246>. 396743 2020-04-16 23:49:48 -0700 2020-04-17 01:25:36 -0700 proposed patch. bug-210639.patch text/plain 3515 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYwMjM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBA CisyMDIwLTA0LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBv ZmZsaW5lYXNtIGlzIGdlbmVyYXRpbmcgdGhlIHdyb25nIGxvYWQvc3RvcmUgZm9yIHRoZSAib3Jo IiBpbnN0cnVjdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMDYzOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjE1MDE4NzY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIGV4YW1wbGUsIG9u IEFSTTY0RSwgdGhlICJvcmgiIGluc3RydWN0aW9uIHdhcyBnZW5lcmF0aW5nIHRoZSBmb2xsb3dp bmc6CisKKyAgICAgICAgICAgICJcdGxkciB3MTcsIFt4MSwgIzBdXG4iICAgICAvLyBKYXZhU2Ny aXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOjkxOQorICAgICAgICAgICAg Ilx0b3JyIHcxNywgdzE3LCAjNjRcbiIgICAgIC8vIEphdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXI2NC5hc206OTE5CisgICAgICAgICAgICAiXHRzdHIgdzE3LCBbeDEsICMw XVxuIiAgICAgLy8gSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFz bTo5MTkKKworICAgICAgICBpLmUuIGEgMzItYml0IGxvYWQsIGZvbGxvd2VkIGJ5IGEgMzItYml0 IE9SLCBmb2xsb3dlZCBieSBhIDMyLWJpdCBzdG9yZS4KKworICAgICAgICBJbnN0ZWFkLCBpdCBz aG91bGQgYmUgZ2VuZXJhdGluZyB0aGUgZm9sbG93aW5nOgorCisgICAgICAgICAgICAiXHRsZHJo IHcxNywgW3gxLCAjMF1cbiIgICAgLy8gSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl cnByZXRlcjY0LmFzbTo5MTkKKyAgICAgICAgICAgICJcdG9yciB3MTcsIHcxNywgIzY0XG4iICAg ICAvLyBKYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOjkxOQor ICAgICAgICAgICAgIlx0c3RyaCB3MTcsIFt4MSwgIzBdXG4iICAgIC8vIEphdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc206OTE5CisKKyAgICAgICAgaS5lLiBhIDE2 LWJpdCBsb2FkLCBmb2xsb3dlZCBieSBhIDMyLWJpdCBPUiwgZm9sbG93ZWQgYnkgYSAxNi1iaXQg c3RvcmUuCisKKyAgICAgICAgVGhpcyBidWcgYWxzbyBhZmZlY3RzIEFSTTY0LCBBUk12NywgYW5k IE1JUFMgKGJhc2ljYWxseSBhbnkgYmFja2VuZCB0aGF0IHVzZXMKKyAgICAgICAgcmlzY0xvd2Vy TWlzcGxhY2VkQWRkcmVzc2VzKCkgZnJvbSByaXNlLnJiKS4gIEl0IGRvZXMgbm90IGFmZmVjdCB4 ODYsIHg4Nl82NCwgYW5kCisgICAgICAgIENfTE9PUCAod2hpY2ggd2FzIHdyaXR0ZW4gYmFzZWQg b24geDg2KS4KKworICAgICAgICAqIG9mZmxpbmVhc20vcmlzYy5yYjoKKwogMjAyMC0wNC0xNiAg Um9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTihyMjU5NDgwKTogVHdvIG5ldyBmYWlsaW5nIGkxOG4gdGVzdHMKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3Jpc2MucmIKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL29mZmxpbmVhc20vcmlzYy5yYgkocmV2aXNpb24gMjYwMjM3KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vcmlzYy5yYgkod29ya2luZyBjb3B5KQpAQCAt MSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChDKSAyMDExLTIwMTggQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTEtMjAyMCBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFu ZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTQ2MiwxMiAr NDYyLDE3IEBAIGRlZiByaXNjTG93ZXJNaXNwbGFjZWRBZGRyZXNzZXMobGlzdCkKICAgICAgICAg ICAgIHBvc3RJbnN0cnVjdGlvbnMgPSBbXQogICAgICAgICAgICAgYW5ub3RhdGlvbiA9IG5vZGUu YW5ub3RhdGlvbgogICAgICAgICAgICAgY2FzZSBub2RlLm9wY29kZQotICAgICAgICAgICAgd2hl biAiYWRkaSIsICJhZGRpcyIsICJhbmRpIiwgImxzaGlmdGkiLCAibXVsaSIsICJuZWdpIiwgIm5v dGkiLCAib3JpIiwgIm9yaCIsICJvcmlzIiwKKyAgICAgICAgICAgIHdoZW4gImFkZGkiLCAiYWRk aXMiLCAiYW5kaSIsICJsc2hpZnRpIiwgIm11bGkiLCAibmVnaSIsICJub3RpIiwgIm9yaSIsICJv cmlzIiwKICAgICAgICAgICAgICAgICAicnNoaWZ0aSIsICJ1cnNoaWZ0aSIsICJzdWJpIiwgInN1 YmlzIiwgInhvcmkiLCAvXmJpLywgL15idGkvLCAvXmNpLywgL150aS8KICAgICAgICAgICAgICAg ICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLmNvZGVPcmlnaW4sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbm9kZS5vcGNvZGUsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmlzY0FzUmVnaXN0ZXJzKG5ld0xpc3Qs IHBvc3RJbnN0cnVjdGlvbnMsIG5vZGUub3BlcmFuZHMsICJpIiksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5ub3RhdGlvbikKKyAgICAgICAgICAgIHdoZW4g Im9yaCIKKyAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLmNv ZGVPcmlnaW4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbm9k ZS5vcGNvZGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmlz Y0FzUmVnaXN0ZXJzKG5ld0xpc3QsIHBvc3RJbnN0cnVjdGlvbnMsIG5vZGUub3BlcmFuZHMsICJo IiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5ub3RhdGlv bikKICAgICAgICAgICAgIHdoZW4gImFkZHAiLCAiYW5kcCIsICJsc2hpZnRwIiwgIm11bHAiLCAi bmVncCIsICJvcnAiLCAicnNoaWZ0cCIsICJ1cnNoaWZ0cCIsCiAgICAgICAgICAgICAgICAgInN1 YnAiLCAieG9ycCIsIC9eYnAvLCAvXmJ0cC8sIC9eY3AvCiAgICAgICAgICAgICAgICAgbmV3TGlz dCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLAo=