210632 2020-04-16 19:42:35 -0700 [WebGL] Confirm there are no errors when setting up framebuffers 2020-04-17 16:31:18 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino cdumez dino esprehn+autocc ews-watchlist graouts gyuyoung.kim kondapallykalyan noam simon.fraser webkit-bug-importer oldest_to_newest 1642548 0 dino 2020-04-16 19:42:35 -0700 We're seeing crashes on macOS inside GraphicsContextGL::reshape(). Specifically when we submit work at the end of the function via glFlush. At the moment the cause is a mystery, because we should bail out before then if the multisample renderbuffer was not complete. In the hope that it helps somewhat, add a call to glGetError to double check that there isn't anything horribly wrong before we talk to the GPU. 1642549 1 webkit-bug-importer 2020-04-16 19:42:48 -0700 <rdar://problem/61916680> 1642883 2 396812 dino 2020-04-17 15:56:06 -0700 Created attachment 396812 Patch 1642897 3 dino 2020-04-17 16:31:18 -0700 Committed r260301: <https://trac.webkit.org/changeset/260301> 396812 2020-04-17 15:56:06 -0700 2020-04-17 16:09:53 -0700 Patch bug-210632-20200418085605.patch text/plain 5831 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE0MGVlMzQ0ZGRmNzVh YzVlMmE2YWRjZGQ0YTcxODdiM2YzNDE5ZS4uZDI2M2E5NDBiYWI1NDA0Mzg3NDQzMDZiNzk5ODgw ZmZiZWI4MWI3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIwLTA0LTE3ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR0xdIENvbmZpcm0gdGhl cmUgYXJlIG5vIGVycm9ycyB3aGVuIHNldHRpbmcgdXAgZnJhbWVidWZmZXJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA2MzIKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzYxOTE2NjgwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlJ3JlIHNlZWluZyBjcmFzaGVzIG9uIG1hY09TIGluc2lkZSBHcmFw aGljc0NvbnRleHRHTDo6cmVzaGFwZSgpLgorICAgICAgICBTcGVjaWZpY2FsbHkgd2hlbiB3ZSBz dWJtaXQgd29yayBhdCB0aGUgZW5kIG9mIHRoZSBmdW5jdGlvbiB2aWEKKyAgICAgICAgZ2xGbHVz aC4KKworICAgICAgICBBdCB0aGUgbW9tZW50IHRoZSBjYXVzZSBpcyBhIG15c3RlcnksIGJlY2F1 c2Ugd2Ugc2hvdWxkIGJhaWwgb3V0CisgICAgICAgIGJlZm9yZSB0aGVuIGlmIHRoZSBtdWx0aXNh bXBsZSByZW5kZXJidWZmZXIgd2FzIG5vdCBjb21wbGV0ZS4gSW4KKyAgICAgICAgdGhlIGhvcGUg dGhhdCBpdCBoZWxwcyBzb21ld2hhdCwgYWRkIGEgY2FsbCB0byBnbEdldEVycm9yIHRvIGRvdWJs ZQorICAgICAgICBjaGVjayB0aGF0IHRoZXJlIGlzbid0IGFueXRoaW5nIGhvcnJpYmx5IHdyb25n IGJlZm9yZSB3ZSB0YWxrIHRvCisgICAgICAgIHRoZSBHUFUuCisKKyAgICAgICAgKiBodG1sL2Nh bnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdM MlJlbmRlcmluZ0NvbnRleHQ6OldlYkdMMlJlbmRlcmluZ0NvbnRleHQpOiBJZiB0aGUgdW5kZXJs eWluZworICAgICAgICBHQ0dMIGNvbnRleHQgd2FzIG1hcmtlZCBhcyAiTE9TVCIgZHVyaW5nIGlu aXRpYWxpemF0aW9uLCBza2lwIHRoZSByZXN0IG9mIG91cgorICAgICAgICBpbml0aWFsaXphdGlv bi4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6V2ViR0xSZW5kZXJp bmdDb250ZXh0KToKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRC YXNlLmNwcDogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHRC YXNlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlKToKKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dEdMQU5HTEUuY3BwOiBDaGVjayBmb3IgYSBHTCBl cnJvciBkdXJpbmcKKyAgICAgICAgc2V0dXAgYW5kLCBpZiB0aGVyZSBpcyBvbmUsIHNraXAgZGly ZWN0bHkgaW50byBhIExPU1Qgc3RhdGUuCisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRl eHRHTE9wZW5HTDo6cmVzaGFwZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3Blbmds L0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dEdMT3BlbkdMOjpyZXNoYXBlKToKKwogMjAyMC0wNC0xNSAgQW50b2luZSBR dWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWIgQW5pbWF0aW9uc10gQWRk IHN1cHBvcnQgZm9yIGBwc2V1ZG9FbGVtZW50YCBvbiBgS2V5ZnJhbWVFZmZlY3RgIGFuZCBgS2V5 ZnJhbWVFZmZlY3RPcHRpb25zYApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR0wyUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCAxODg2MmEwNzk1MWIyNjVkM2M2OGJk YTRlODExZjQ3MTM0YmJkN2NlLi40ZWM3YzY3NWU3MDMyNDA4ODlkOTBjOWQ0NGNmMWUzM2Y4MjZk NzM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTDJSZW5kZXJp bmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTDJSZW5k ZXJpbmdDb250ZXh0LmNwcApAQCAtOTYsNiArOTYsOSBAQCBXZWJHTDJSZW5kZXJpbmdDb250ZXh0 OjpXZWJHTDJSZW5kZXJpbmdDb250ZXh0KENhbnZhc0Jhc2UmIGNhbnZhcywgR3JhcGhpY3NDb250 ZQogV2ViR0wyUmVuZGVyaW5nQ29udGV4dDo6V2ViR0wyUmVuZGVyaW5nQ29udGV4dChDYW52YXNC YXNlJiBjYW52YXMsIFJlZjxHcmFwaGljc0NvbnRleHRHTE9wZW5HTD4mJiBjb250ZXh0LCBHcmFw aGljc0NvbnRleHRHTEF0dHJpYnV0ZXMgYXR0cmlidXRlcykKICAgICA6IFdlYkdMUmVuZGVyaW5n Q29udGV4dEJhc2UoY2FudmFzLCBXVEZNb3ZlKGNvbnRleHQpLCBhdHRyaWJ1dGVzKQogeworICAg IGlmIChpc0NvbnRleHRMb3N0KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGluaXRpYWxpemVT aGFkZXJFeHRlbnNpb25zKCk7CiAgICAgaW5pdGlhbGl6ZVZlcnRleEFycmF5T2JqZWN0cygpOwog ICAgIGluaXRpYWxpemVUcmFuc2Zvcm1GZWVkYmFja0J1ZmZlckNhY2hlKCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRl eCA2ODM2NmExZmVlMWY3NWIzMGI3YTQ2Y2IyODVjMmYwOTg0MGM2NTEwLi4zMjc2MjMyNzVhNTU2 M2I0YWIwNjUxMjQ2NWEzNWUxYzAzOWExMDk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTk5LDYgKzk5LDkgQEAg V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpXZWJHTFJlbmRlcmluZ0NvbnRleHQoQ2FudmFzQmFzZSYg Y2FudmFzLCBHcmFwaGljc0NvbnRleHQKIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6V2ViR0xSZW5k ZXJpbmdDb250ZXh0KENhbnZhc0Jhc2UmIGNhbnZhcywgUmVmPEdyYXBoaWNzQ29udGV4dEdMT3Bl bkdMPiYmIGNvbnRleHQsIEdyYXBoaWNzQ29udGV4dEdMQXR0cmlidXRlcyBhdHRyaWJ1dGVzKQog ICAgIDogV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZShjYW52YXMsIFdURk1vdmUoY29udGV4dCks IGF0dHJpYnV0ZXMpCiB7CisgICAgaWYgKGlzQ29udGV4dExvc3QoKSkKKyAgICAgICAgcmV0dXJu OworCiAgICAgaW5pdGlhbGl6ZVZlcnRleEFycmF5T2JqZWN0cygpOwogfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2Uu Y3BwCmluZGV4IDFhOTA0YjZlYjhiMDQ0MzA3ZTgxZDkwMDE1ZTI2NGQ5NTBlNDE5N2UuLmUzYjhj MjYzMjk2ZTU3MGU0OTk5YzFhMmE4M2U3ZTcxZjFmMzdkNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCkBA IC02NDgsNiArNjQ4LDEyIEBAIFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OldlYkdMUmVuZGVy aW5nQ29udGV4dEJhc2UoQ2FudmFzQmFzZSYgY2FudmFzLCBSZWY8R3JhCiAKICAgICBzZXR1cEZs YWdzKCk7CiAgICAgaW5pdGlhbGl6ZU5ld0NvbnRleHQoKTsKKworICAgIC8vIElmIHNvbWV0aGlu ZyBnb2VzIHdyb25nIGluIGluaXRpYWxpemVOZXdDb250ZXh0LCBpdCBzaG91bGQgaGF2ZQorICAg IC8vIHRyaWdnZXJlZCBhIGxvc3QgY29udGV4dC4gQ2hlY2sgdGhhdCBiZWZvcmUgc2V0dGluZyBh bnl0aGluZyBlbHNlIHVwLgorICAgIGlmIChpc0NvbnRleHRMb3N0KCkpCisgICAgICAgIHJldHVy bjsKKwogICAgIHJlZ2lzdGVyV2l0aFdlYkdMU3RhdGVUcmFja2VyKCk7CiAgICAgbV9jaGVja0Zv ckNvbnRleHRMb3NzSGFuZGxpbmdUaW1lci5zdGFydE9uZVNob3QoY2hlY2tDb250ZXh0TG9zc0hh bmRsaW5nRGVsYXkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hbmdsZS9HcmFwaGljc0NvbnRleHRHTEFOR0xFLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dEdMQU5HTEUuY3BwCmluZGV4IGI1 M2I2YWU3YzUyNDU0OGVlYjYxMjQ0N2UxMzg0ZWYxNTI0YTFjMmEuLjhkNzI3ZTg2MzNjY2U1YzAx OTQwNDljZWQyYzE3ODZhNGVkNGY5OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dEdMQU5HTEUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0dyYXBoaWNzQ29udGV4dEdMQU5HTEUu Y3BwCkBAIC02MjMsNiArNjIzLDExIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OnJl c2hhcGUoaW50IHdpZHRoLCBpbnQgaGVpZ2h0KQogICAgICAgICAgICAgZ2w6OkJpbmRGcmFtZWJ1 ZmZlcihHcmFwaGljc0NvbnRleHRHTDo6UkVBRF9GUkFNRUJVRkZFUiwgbV9zdGF0ZS5ib3VuZFJl YWRGQk8pOwogICAgIH0KIAorICAgIGlmIChnbDo6R2V0RXJyb3IoKSAhPSBHTF9OT19FUlJPUikg eworICAgICAgICBmb3JjZUNvbnRleHRMb3N0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisK ICAgICBnbDo6Rmx1c2goKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29tbW9uLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHRHTE9w ZW5HTENvbW1vbi5jcHAKaW5kZXggODAyYTMyYmIxNWU0NGU2MDlhMGZkOGE1YmM1MThkODBlZGZk NDljOC4uYzRiY2JhNTExN2Y3YzRjZWIwMzk4MzliOWM4ZTQxZTQyMjc2ZjhhMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4 dEdMT3BlbkdMQ29tbW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb21tb24uY3BwCkBAIC0zNzIsNiArMzcy LDExIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OnJlc2hhcGUoaW50IHdpZHRoLCBp bnQgaGVpZ2h0KQogICAgIGlmIChtdXN0UmVzdG9yZUZCTykKICAgICAgICAgOjpnbEJpbmRGcmFt ZWJ1ZmZlckVYVChHcmFwaGljc0NvbnRleHRHTDo6RlJBTUVCVUZGRVIsIG1fc3RhdGUuYm91bmRE cmF3RkJPKTsKIAorICAgIGlmICg6OmdsR2V0RXJyb3IoKSAhPSBHTF9OT19FUlJPUikgeworICAg ICAgICBmb3JjZUNvbnRleHRMb3N0KCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICA6 OmdsRmx1c2goKTsKIH0KIAo=