210628 2020-04-16 16:20:51 -0700 Distinguish between an empty WKAppBoundDomains array and a missing entry 2020-04-16 18:13:29 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney aestes bfulgham webkit-bug-importer wilander oldest_to_newest 1642487 0 katherine_cheney 2020-04-16 16:20:51 -0700 Currently we treat a missing WKAppBoundDomains key the same as an empty key, which is incorrect. Having the key present, even with no entries, should opt an app into app-bound domain behavior. 1642491 1 webkit-bug-importer 2020-04-16 16:21:27 -0700 <rdar://problem/61909669> 1642511 2 396723 katherine_cheney 2020-04-16 16:55:00 -0700 Created attachment 396723 Patch 1642521 3 396723 bfulgham 2020-04-16 17:23:19 -0700 Comment on attachment 396723 Patch r=me 1642536 4 ews-feeder 2020-04-16 18:13:29 -0700 Committed r260233: <https://trac.webkit.org/changeset/260233> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396723. 396723 2020-04-16 16:55:00 -0700 2020-04-16 18:13:29 -0700 Patch bug-210628-20200416165459.patch text/plain 2704 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM1ZWExZWFjOGI3ZjM3MDJh NDNlY2VjMGJkZGE1M2JiNzFmMGJhODcuLjhlNmFkYjRhNzU5NGE1ZTc0OTM4MzY2NGEyZmY4MmIy YWRhZTI0ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDQtMTYgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgRGlzdGluZ3Vpc2gg YmV0d2VlbiBhbiBlbXB0eSBXS0FwcEJvdW5kRG9tYWlucyBhcnJheSBhbmQgYSBtaXNzaW5nIGVu dHJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA2 MjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxOTA5NjY5PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSB3ZSB0cmVhdCBhIG1pc3Np bmcgV0tBcHBCb3VuZERvbWFpbnMga2V5IHRoZSBzYW1lIGFzIGFuIGVtcHR5CisgICAgICAgIGtl eSwgd2hpY2ggaXMgaW5jb3JyZWN0LiBIYXZpbmcgdGhlIGtleSBwcmVzZW50LCBldmVuIHdpdGgg bm8gZW50cmllcywKKyAgICAgICAgc2hvdWxkIG9wdCBhbiBhcHAgaW50byBhcHAtYm91bmQgZG9t YWluIGJlaGF2aW9yLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dl YnNpdGVEYXRhU3RvcmVDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9y ZTo6aW5pdGlhbGl6ZUFwcEJvdW5kRG9tYWlucyk6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVE YXRhU3RvcmU6OmJlZ2luQXBwQm91bmREb21haW5DaGVjayk6CisKIDIwMjAtMDQtMTYgIEJyZW50 IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBTd2l0Y2gg dW51c2VkIElPS2l0IGNsYXNzZXMgZnJvbSBhbGxvdy13aXRoLXJlcG9ydCB0byBkZW55LXdpdGgt cmVwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9D b2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0KaW5kZXggNWZiZjU2MjUz OTZmMmNkYmM1NDFkZGJlOTcwOWE0N2YyMWI3YzczYi4uODdkZDg4NTFkMjg2Mjg2YTdiMjdiZGFi NDVkMDQ3NmNkZWZjY2M2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi c2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbQpA QCAtNzUsNiArNzUsNyBAQCBzdGF0aWMgV29ya1F1ZXVlJiBhcHBCb3VuZERvbWFpblF1ZXVlKCkK IH0KIAogc3RhdGljIHN0ZDo6YXRvbWljPGJvb2w+IGhhc0luaXRpYWxpemVkQXBwQm91bmREb21h aW5zID0gZmFsc2U7CitzdGF0aWMgc3RkOjphdG9taWM8Ym9vbD4ga2V5RXhpc3RzID0gZmFsc2U7 CiAKICNpZiBFTkFCTEUoUkVTT1VSQ0VfTE9BRF9TVEFUSVNUSUNTKQogV2ViQ29yZTo6VGhpcmRQ YXJ0eUNvb2tpZUJsb2NraW5nTW9kZSBXZWJzaXRlRGF0YVN0b3JlOjp0aGlyZFBhcnR5Q29va2ll QmxvY2tpbmdNb2RlKCkgY29uc3QKQEAgLTQwOSw2ICs0MTAsNyBAQCB2b2lkIFdlYnNpdGVEYXRh U3RvcmU6OmluaXRpYWxpemVBcHBCb3VuZERvbWFpbnMoRm9yY2VSZWluaXRpYWxpemF0aW9uIGZv cmNlUmVpbgogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAKICAgICAgICAgTlNBcnJheTxO U1N0cmluZyAqPiAqZG9tYWlucyA9IFtbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gb2JqZWN0Rm9ySW5m b0RpY3Rpb25hcnlLZXk6QCJXS0FwcEJvdW5kRG9tYWlucyJdOworICAgICAgICBrZXlFeGlzdHMg PSBkb21haW5zID8gdHJ1ZSA6IGZhbHNlOwogICAgICAgICAKICAgICAgICAgUnVuTG9vcDo6bWFp bigpLmRpc3BhdGNoKFtpc0luQXBwQnJvd3NlclByaXZhY3lFbmFibGVkLCBmb3JjZVJlaW5pdGlh bGl6YXRpb24sIGRvbWFpbnMgPSByZXRhaW5QdHIoZG9tYWlucyldIHsKICAgICAgICAgICAgIGlm IChmb3JjZVJlaW5pdGlhbGl6YXRpb24gPT0gRm9yY2VSZWluaXRpYWxpemF0aW9uOjpZZXMpCkBA IC00NjUsNyArNDY3LDcgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpiZWdpbkFwcEJvdW5kRG9t YWluQ2hlY2soY29uc3QgVVJMJiByZXF1ZXN0VVJMLCBXZWJGcmFtZVAKICAgICB9CiAKICAgICBl bnN1cmVBcHBCb3VuZERvbWFpbnMoW2RvbWFpbiA9IFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9tYWlu KHJlcXVlc3RVUkwpLCBsaXN0ZW5lciA9IG1ha2VSZWYobGlzdGVuZXIpXSAoYXV0byYgZG9tYWlu cykgbXV0YWJsZSB7Ci0gICAgICAgIGlmIChkb21haW5zLmlzRW1wdHkoKSkgeworICAgICAgICBp ZiAoZG9tYWlucy5pc0VtcHR5KCkgJiYgIWtleUV4aXN0cykgewogICAgICAgICAgICAgbGlzdGVu ZXItPmRpZFJlY2VpdmVBcHBCb3VuZERvbWFpblJlc3VsdChXVEY6Om51bGxvcHQpOwogICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICB9Cg==