210606 2020-04-16 09:23:05 -0700 Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled 2020-04-17 11:59:51 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts calvaris eric.carlson esprehn+autocc ews-watchlist glenn graouts gyuyoung.kim jer.noble koivisto macpherson menard philipj sergio webkit-bug-importer oldest_to_newest 1642275 0 graouts 2020-04-16 09:23:05 -0700 Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled 1642277 1 396654 graouts 2020-04-16 09:25:24 -0700 Created attachment 396654 Patch 1642674 2 396764 graouts 2020-04-17 08:04:49 -0700 Created attachment 396764 Patch 1642679 3 396764 dbates 2020-04-17 08:18:27 -0700 Comment on attachment 396764 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396764&action=review This patch looks good. A better patch would add tests for the UA stylesheet changes and the runtime enabled branch. > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25 > body:-webkit-full-page-media { The optimal solution would remove this because it duplicates the style in html.css now. If it cannot be removed, why? 1642689 4 graouts 2020-04-17 08:38:20 -0700 (In reply to Daniel Bates from comment #3) > Comment on attachment 396764 [details] > Patch > > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:25 > > body:-webkit-full-page-media { > > The optimal solution would remove this because it duplicates the style in > html.css now. If it cannot be removed, why? It can, just an oversight! 1642730 5 graouts 2020-04-17 10:24:30 -0700 Committed r260261: <https://trac.webkit.org/changeset/260261> 1642731 6 webkit-bug-importer 2020-04-17 10:25:22 -0700 <rdar://problem/61940561> 1642755 7 ryanhaddad 2020-04-17 11:56:51 -0700 Follow up build fix in https://trac.webkit.org/changeset/260269/webkit 1642756 8 graouts 2020-04-17 11:59:51 -0700 (In reply to Ryan Haddad from comment #7) > Follow up build fix in https://trac.webkit.org/changeset/260269/webkit Actually, this was for the wrong bug :) This was a bug fix for bug 210653. 396654 2020-04-16 09:25:24 -0700 2020-04-17 08:04:45 -0700 Patch bug-210606-20200416182523.patch text/plain 2938 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTkzZWI4NGE0YjZkM2Mw MDMyYmZhOGI3MDMyZDJhM2ViZGMzZDE2ZC4uODhlMzkwMmMzNTdhODM4MDA2MTk4MzdmZWFkNjQ4 ODA1MDliN2MxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA0LTE2ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCBpbmNsdWRpbmcg c3R5bGUgcnVsZXMgcmVsYXRlZCB0byBtZWRpYSBjb250cm9scyBpbiB0aGUgVUEgc3R5bGUgc2hl ZXQgd2hlbiBNb2Rlcm4gTWVkaWEgQ29udHJvbHMgYXJlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDYwNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG5vIG5lZWQgdG8gaW5z ZXJ0IHN0eWxlIHJ1bGVzIHJlbGF0ZWQgdG8gbWVkaWEgY29udHJvbHMgaW4gdGhlIFVBIHN0eWxl c2hlZXQgd2hlbiBNb2Rlcm4gTWVkaWEgQ29udHJvbHMgYXJlIGVuYWJsZWQuCisgICAgICAgIFRo ZXJlIGlzIG9uZSBydWxlIGZyb20gbWVkaWFDb250cm9sc0FwcGxlLmNzcyBmb3IgdGhlIGRlZmF1 bHQgc2l6aW5nIG9mIDxhdWRpbz4gdGhhdCBtYWtlcyBzZW5zZSBicm9hZGx5IGZvciBjb250ZW50 IG9uIHRoZSBXZWIKKyAgICAgICAgc28gd2UgbW92ZSB0aGF0IHRvIGh0bWwuY3NzLiAKKworICAg ICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUuY3NzOgorICAg ICAgICAoYXVkaW8pOiBEZWxldGVkLgorICAgICAgICAqIGNzcy9odG1sLmNzczoKKyAgICAgICAg KGF1ZGlvKToKKyAgICAgICAgKiBzdHlsZS9Vc2VyQWdlbnRTdHlsZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTdHlsZTo6VXNlckFnZW50U3R5bGU6OmVuc3VyZURlZmF1bHRTdHlsZVNoZWV0c0Zv ckVsZW1lbnQpOgorCiAyMDIwLTA0LTE2ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGln YWxpYS5jb20+CiAKICAgICAgICAgQ2xlYW4gYSBjb3VwbGUgb2YgdW51c2VkLXBhcmFtZXRlcnMg d2FybmluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9s cy9tZWRpYUNvbnRyb2xzQXBwbGUuY3NzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5jc3MKaW5kZXggYjc4ODRkMjg1MWNlNjkzNWUwMjYw ZTAwNTc5MWFlNmM3MWZiMzlmZS4uMTEzNzExODdhZDhjYjUwZWExM2UzNDQxNWRmMzY2YWI5NDRl OTk5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNBcHBsZS5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5jc3MKQEAgLTIyLDExICsyMiw2IEBACiAgKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLiAKICAqLwogCi1hdWRpbyB7Ci0gICAgd2lkdGg6IDIwMHB4OwotICAgIGhlaWdodDog MjVweDsKLX0KLQogYm9keTotd2Via2l0LWZ1bGwtcGFnZS1tZWRpYSB7CiAgICAgYmFja2dyb3Vu ZC1jb2xvcjogcmdiKDM4LCAzOCwgMzgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL2h0bWwuY3NzIGIvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCmluZGV4IDJkYWFhOWQ5 YmE1ZjE0ZTc0NTQxNDNjMTc2MzBhNmRlNDUzODkzZmUuLmIwNDQwYWYzY2NlZDAxODYxNjc4NjM1 ZDAxNzAzMWI1ZGEzYTI5NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNz cworKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MKQEAgLTExMyw2ICsxMTMsMTEgQEAg dmlkZW8gewogI2VuZGlmCiB9CiAKK2F1ZGlvIHsKKyAgICB3aWR0aDogMjAwcHg7CisgICAgaGVp Z2h0OiAyNXB4OworfQorCiAvKiBoZWFkaW5nIGVsZW1lbnRzICovCiAKIGgxIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1VzZXJBZ2VudFN0eWxlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3N0eWxlL1VzZXJBZ2VudFN0eWxlLmNwcAppbmRleCA1MjJkMmZjN2Q0NzU3MmZlOGM2MGRl ZmZhNzI0ODU0ZGZkZjlkMjE4Li44NzE1ZDI3NGU3ZmNkY2UyMTA3M2VkMDAyYjU3Zjk5NDBhYzll MjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9Vc2VyQWdlbnRTdHlsZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvVXNlckFnZW50U3R5bGUuY3BwCkBAIC0yMzcsNyAr MjM3LDcgQEAgdm9pZCBVc2VyQWdlbnRTdHlsZTo6ZW5zdXJlRGVmYXVsdFN0eWxlU2hlZXRzRm9y RWxlbWVudChjb25zdCBFbGVtZW50JiBlbGVtZW50KQogICAgICAgICAgICAgfQogICAgICAgICB9 CiAjaWYgRU5BQkxFKFZJREVPKQotICAgICAgICBlbHNlIGlmIChpczxIVE1MTWVkaWFFbGVtZW50 PihlbGVtZW50KSkgeworICAgICAgICBlbHNlIGlmIChpczxIVE1MTWVkaWFFbGVtZW50PihlbGVt ZW50KSAmJiAhUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS5tb2Rlcm5N ZWRpYUNvbnRyb2xzRW5hYmxlZCgpKSB7CiAgICAgICAgICAgICBpZiAoIW1lZGlhQ29udHJvbHNT dHlsZVNoZWV0KSB7CiAgICAgICAgICAgICAgICAgU3RyaW5nIG1lZGlhUnVsZXMgPSBSZW5kZXJU aGVtZTo6c2luZ2xldG9uKCkubWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKTsKICAgICAgICAgICAg ICAgICBpZiAobWVkaWFSdWxlcy5pc0VtcHR5KCkpCg== 396764 2020-04-17 08:04:49 -0700 2020-04-17 08:18:27 -0700 Patch bug-210606-20200417170447.patch text/plain 4145 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDE5ZWVkOTZkOGIxNjcy MTRkYzgxZmViYjViMmYwYmEyYWU1MzQ2NS4uM2E1ZWIyMDFkMDNiMDZjMzM4NDlkMTk2NmNjMTRi Y2E0YjJhYjA1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA0LTE3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCBpbmNsdWRpbmcg c3R5bGUgcnVsZXMgcmVsYXRlZCB0byBtZWRpYSBjb250cm9scyBpbiB0aGUgVUEgc3R5bGUgc2hl ZXQgd2hlbiBNb2Rlcm4gTWVkaWEgQ29udHJvbHMgYXJlIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDYwNgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG5vIG5lZWQgdG8gaW5z ZXJ0IHN0eWxlIHJ1bGVzIHJlbGF0ZWQgdG8gbWVkaWEgY29udHJvbHMgaW4gdGhlIFVBIHN0eWxl c2hlZXQgd2hlbiBNb2Rlcm4gTWVkaWEgQ29udHJvbHMgYXJlIGVuYWJsZWQuCisgICAgICAgIFRo ZXJlIGlzIG9uZSBydWxlIGZyb20gbWVkaWFDb250cm9sc0FwcGxlLmNzcyBmb3IgdGhlIGRlZmF1 bHQgc2l6aW5nIG9mIDxhdWRpbz4gdGhhdCBtYWtlcyBzZW5zZSBicm9hZGx5IGZvciBjb250ZW50 IG9uIHRoZSBXZWIKKyAgICAgICAgc28gd2UgbW92ZSB0aGF0IHRvIGh0bWwuY3NzLiBXZSBhbHNv IHNldCB0aGUgYmFja2dyb3VuZC1jb2xvciBwcm9wZXJ0eSBmb3IgbWVkaWEgZG9jdW1lbnRzIGlu IGh0bWwuY3NzLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJv bHNBcHBsZS5jc3M6CisgICAgICAgIChhdWRpbyk6IERlbGV0ZWQuCisgICAgICAgICogTW9kdWxl cy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvbWVkaWEtZG9jdW1lbnQuY3NzOgorICAg ICAgICAoOmhvc3QoLm1lZGlhLWRvY3VtZW50KSk6CisgICAgICAgICogY3NzL2h0bWwuY3NzOgor ICAgICAgICAoYm9keTotd2Via2l0LWZ1bGwtcGFnZS1tZWRpYSk6CisgICAgICAgIChhdWRpbyk6 CisgICAgICAgICogc3R5bGUvVXNlckFnZW50U3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U3R5bGU6OlVzZXJBZ2VudFN0eWxlOjplbnN1cmVEZWZhdWx0U3R5bGVTaGVldHNGb3JFbGVtZW50 KToKKwogMjAyMC0wNC0xNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K IAogICAgICAgICBTY3JvbGxpbmctdHJlZSBoaXQtdGVzdGluZyBpcyBvZmYgYnkgdG9wIGNvbnRl bnQgaW5zZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9s cy9tZWRpYUNvbnRyb2xzQXBwbGUuY3NzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5jc3MKaW5kZXggYjc4ODRkMjg1MWNlNjkzNWUwMjYw ZTAwNTc5MWFlNmM3MWZiMzlmZS4uMTEzNzExODdhZDhjYjUwZWExM2UzNDQxNWRmMzY2YWI5NDRl OTk5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21l ZGlhQ29udHJvbHNBcHBsZS5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5jc3MKQEAgLTIyLDExICsyMiw2IEBACiAgKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLiAKICAqLwogCi1hdWRpbyB7Ci0gICAgd2lkdGg6IDIwMHB4OwotICAgIGhlaWdodDog MjVweDsKLX0KLQogYm9keTotd2Via2l0LWZ1bGwtcGFnZS1tZWRpYSB7CiAgICAgYmFja2dyb3Vu ZC1jb2xvcjogcmdiKDM4LCAzOCwgMzgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvbWVkaWEtZG9jdW1lbnQuY3Nz IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMv bWVkaWEtZG9jdW1lbnQuY3NzCmluZGV4IDJkMzgzZjRlNzE1MjIzOGU0ZTUyM2M1ZTI0MGE0YTNh MTU5ODZjNjYuLmM1MGRmYTA1OWVmOGFjODQzOTI5ZjZmMzJjZWZlODYzMDYwYmJjN2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRy b2xzL21lZGlhLWRvY3VtZW50LmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVy bi1tZWRpYS1jb250cm9scy9jb250cm9scy9tZWRpYS1kb2N1bWVudC5jc3MKQEAgLTI3LDYgKzI3 LDEzIEBACiAgICAgbWF4LXdpZHRoOiAxMDAlICFpbXBvcnRhbnQ7CiAgICAgbWF4LWhlaWdodDog MTAwJSAhaW1wb3J0YW50OwogICAgIG1pbi1oZWlnaHQ6IDUwcHggIWltcG9ydGFudDsKKworICAg IG1hcmdpbjogYXV0byAhaW1wb3J0YW50OworICAgIHBvc2l0aW9uOiBhYnNvbHV0ZSAhaW1wb3J0 YW50OworICAgIHRvcDogMCAhaW1wb3J0YW50OworICAgIHJpZ2h0OiAwICFpbXBvcnRhbnQ7Cisg ICAgYm90dG9tOiAwICFpbXBvcnRhbnQ7CisgICAgbGVmdDogMCAhaW1wb3J0YW50OwogfQogCiAv KiBBdWRpbyAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzIGIvU291 cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCmluZGV4IDJkYWFhOWQ5YmE1ZjE0ZTc0NTQxNDNjMTc2 MzBhNmRlNDUzODkzZmUuLmMxYjQ2NzY2MzM4ZDQ3ODk0ZjMxNjUwYWQxNmFjYzM2ZjI5N2M4YTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNzcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvaHRtbC5jc3MKQEAgLTEwNiw2ICsxMDYsMTIgQEAgaHIgewogICAgIGJvcmRlci13 aWR0aDogMXB4OwogfQogCisvKiBtZWRpYSBlbGVtZW50cyAqLworCitib2R5Oi13ZWJraXQtZnVs bC1wYWdlLW1lZGlhIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2IoMzgsIDM4LCAzOCk7Cit9 CisKIHZpZGVvIHsKICAgICBvYmplY3QtZml0OiBjb250YWluOwogI2lmIGRlZmluZWQoV1RGX1BM QVRGT1JNX0lPU19GQU1JTFkpICYmIFdURl9QTEFURk9STV9JT1NfRkFNSUxZCkBAIC0xMTMsNiAr MTE5LDExIEBAIHZpZGVvIHsKICNlbmRpZgogfQogCithdWRpbyB7CisgICAgd2lkdGg6IDIwMHB4 OworICAgIGhlaWdodDogMjVweDsKK30KKwogLyogaGVhZGluZyBlbGVtZW50cyAqLwogCiBoMSB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9Vc2VyQWdlbnRTdHlsZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9zdHlsZS9Vc2VyQWdlbnRTdHlsZS5jcHAKaW5kZXggNTIyZDJmYzdkNDc1 NzJmZThjNjBkZWZmYTcyNDg1NGRmZGY5ZDIxOC4uODcxNWQyNzRlN2ZjZGNlMjEwNzNlZDAwMmI1 N2Y5OTQwYWM5ZTI4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvVXNlckFnZW50 U3R5bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1VzZXJBZ2VudFN0eWxlLmNwcApA QCAtMjM3LDcgKzIzNyw3IEBAIHZvaWQgVXNlckFnZW50U3R5bGU6OmVuc3VyZURlZmF1bHRTdHls ZVNoZWV0c0ZvckVsZW1lbnQoY29uc3QgRWxlbWVudCYgZWxlbWVudCkKICAgICAgICAgICAgIH0K ICAgICAgICAgfQogI2lmIEVOQUJMRShWSURFTykKLSAgICAgICAgZWxzZSBpZiAoaXM8SFRNTE1l ZGlhRWxlbWVudD4oZWxlbWVudCkpIHsKKyAgICAgICAgZWxzZSBpZiAoaXM8SFRNTE1lZGlhRWxl bWVudD4oZWxlbWVudCkgJiYgIVJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVz KCkubW9kZXJuTWVkaWFDb250cm9sc0VuYWJsZWQoKSkgewogICAgICAgICAgICAgaWYgKCFtZWRp YUNvbnRyb2xzU3R5bGVTaGVldCkgewogICAgICAgICAgICAgICAgIFN0cmluZyBtZWRpYVJ1bGVz ID0gUmVuZGVyVGhlbWU6OnNpbmdsZXRvbigpLm1lZGlhQ29udHJvbHNTdHlsZVNoZWV0KCk7CiAg ICAgICAgICAgICAgICAgaWYgKG1lZGlhUnVsZXMuaXNFbXB0eSgpKQo=