210603 2020-04-16 06:28:41 -0700 [GTK][X11] REGRESSION(r259944): Wrong position of select popup menu in X11 2020-04-17 08:25:02 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210069 Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply mcatanzaro oldest_to_newest 1642229 0 cgarcia 2020-04-16 06:28:41 -0700 It works in Wayland, but fails in X11. 1642247 1 cgarcia 2020-04-16 07:30:40 -0700 Does anybody know how to make gdk_window_move_to_rect() work in X11? It seems we need to convert the coordinates somehow, but I don't know exactly how. gtk_window_move() works fine in X11, so if I can't make gdk_window_move_to_rect() work for both I'll use it only under wayland. 1642260 2 mcatanzaro 2020-04-16 08:27:11 -0700 Jonas says: "i don't understand the question. that API is used internally in gtk by both wayland and x11" (In reply to Carlos Garcia Campos from comment #1) > gtk_window_move() works fine in X11, so if I can't make > gdk_window_move_to_rect() work for both I'll use it only under wayland. I learned a Finnish proverb from Adrian: "the reindeer will go where the fence is the lowest." The reindeer are wise.... 1642484 3 aperez 2020-04-16 16:18:44 -0700 Maybe the long-term solution for this is using GtkPopover[Menu], like I just did for bug #170553 — then we can let GTK do the positioning work using gtk_popover_set_pointing_to(widget, rect) and gtk_popover_set_position(widget, GTK_POS_BOTTOM) to make the popover appear below the button. If we want to remove the arrow that would point to the button or change the appearance I *think* there are some CSS classes we can set. As for making the popover width at least as long as the button, I think *maybe* we could use a GtkSizeGroup, but maybe if we end up using a popover there is not much point in doing that 🤔️ 1642651 4 396761 cgarcia 2020-04-17 06:18:18 -0700 Created attachment 396761 Patch Managed to make it work in the end. 1642675 5 396761 mcatanzaro 2020-04-17 08:09:38 -0700 Comment on attachment 396761 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396761&action=review > Source/WebKit/ChangeLog:9 > + gdk_window_move_to_rect expects the given rectangle in coordinates relative to the top-left corner of the window > + that the popup window is transient for. We were using screen coordinates. Yup. 1642682 6 ews-feeder 2020-04-17 08:25:00 -0700 Committed r260252: <https://trac.webkit.org/changeset/260252> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396761. 396761 2020-04-17 06:18:18 -0700 2020-04-17 08:25:01 -0700 Patch wk2-popup-position-x11.diff text/plain 2528 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMWI0ZTU5Y2RkY2U5Li40MWFkZDkxOGMwOGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMDQtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1gxMV0gUkVHUkVTU0lPTihyMjU5OTQ0KTogV3Jvbmcg cG9zaXRpb24gb2Ygc2VsZWN0IHBvcHVwIG1lbnUgaW4gWDExCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA2MDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBnZGtfd2luZG93X21vdmVfdG9fcmVjdCBleHBl Y3RzIHRoZSBnaXZlbiByZWN0YW5nbGUgaW4gY29vcmRpbmF0ZXMgcmVsYXRpdmUgdG8gdGhlIHRv cC1sZWZ0IGNvcm5lciBvZiB0aGUgd2luZG93CisgICAgICAgIHRoYXQgdGhlIHBvcHVwIHdpbmRv dyBpcyB0cmFuc2llbnQgZm9yLiBXZSB3ZXJlIHVzaW5nIHNjcmVlbiBjb29yZGluYXRlcy4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9ndGsvV2ViUG9wdXBNZW51UHJveHlHdGsuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVQcm94eUd0azo6c2hvd1BvcHVwTWVudSk6IFRyYW5zbGF0 ZSB3aWRnZXQgY29vcmRpbmF0ZXMgdG8gd2luZG93IGNvb3JkaW5hdGVzIGJlZm9yZSBwYXNzaW5n CisgICAgICAgIHRoZSByZWN0YW5nbGUgdG8gZ2RrX3dpbmRvd19tb3ZlX3RvX3JlY3QoKS4KKwog MjAyMC0wNC0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gVUkgcHJvY2VzcyBjcmFzaCB3aGVuIGVudGVyaW5nIGNvbXBvc2l0aW5n IG1vZGUgd2hlbiBXUEVfUkVOREVSRVIgaXMgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvZ3RrL1dlYlBvcHVwTWVudVByb3h5R3RrLmNwcCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2d0ay9XZWJQb3B1cE1lbnVQcm94eUd0ay5jcHAKaW5kZXggNGVhZDc3ZDEw ZDY4Li5mMmI5NzQ1NDdjMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0 ay9XZWJQb3B1cE1lbnVQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Z3RrL1dlYlBvcHVwTWVudVByb3h5R3RrLmNwcApAQCAtMjc2LDE1ICsyNzYsMTYgQEAgdm9pZCBX ZWJQb3B1cE1lbnVQcm94eUd0azo6c2hvd1BvcHVwTWVudShjb25zdCBJbnRSZWN0JiByZWN0LCBU ZXh0RGlyZWN0aW9uLCBkb3UKICAgICBndGtfd2lkZ2V0X3NldF9zaXplX3JlcXVlc3QobV9wb3B1 cCwgd2lkdGgsIC0xKTsKICAgICBndGtfc2Nyb2xsZWRfd2luZG93X3NldF9taW5fY29udGVudF9o ZWlnaHQoc3dpbmRvdywgaXRlbUNvdW50ICogaXRlbUhlaWdodCk7CiAKLSAgICBJbnRQb2ludCBt ZW51UG9zaXRpb24gPSBjb252ZXJ0V2lkZ2V0UG9pbnRUb1NjcmVlblBvaW50KG1fd2ViVmlldywg cmVjdC5sb2NhdGlvbigpKTsKICNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigzLCAyNCwgMCkKLSAgICBH ZGtSZWN0YW5nbGUgd2luZG93UmVjdCA9IHsgbWVudVBvc2l0aW9uLngoKSwgbWVudVBvc2l0aW9u LnkoKSwgcmVjdC53aWR0aCgpLCByZWN0LmhlaWdodCgpIH07CisgICAgR2RrUmVjdGFuZ2xlIHdp bmRvd1JlY3QgPSB7IHJlY3QueCgpLCByZWN0LnkoKSwgcmVjdC53aWR0aCgpLCByZWN0LmhlaWdo dCgpIH07CisgICAgZ3RrX3dpZGdldF90cmFuc2xhdGVfY29vcmRpbmF0ZXMobV93ZWJWaWV3LCB0 b3BsZXZlbCwgd2luZG93UmVjdC54LCB3aW5kb3dSZWN0LnksICZ3aW5kb3dSZWN0LngsICZ3aW5k b3dSZWN0LnkpOwogICAgIGdka193aW5kb3dfbW92ZV90b19yZWN0KGd0a193aWRnZXRfZ2V0X3dp bmRvdyhtX3BvcHVwKSwgJndpbmRvd1JlY3QsIEdES19HUkFWSVRZX1NPVVRIX1dFU1QsIEdES19H UkFWSVRZX05PUlRIX1dFU1QsCiAgICAgICAgIHN0YXRpY19jYXN0PEdka0FuY2hvckhpbnRzPihH REtfQU5DSE9SX0ZMSVAgfCBHREtfQU5DSE9SX1NMSURFIHwgR0RLX0FOQ0hPUl9SRVNJWkUpLCAw LCAwKTsKICNlbHNlCiAgICAgR3RrUmVxdWlzaXRpb24gbWVudVJlcXVpc2l0aW9uOwogICAgIGd0 a193aWRnZXRfZ2V0X3ByZWZlcnJlZF9zaXplKG1fcG9wdXAsICZtZW51UmVxdWlzaXRpb24sIG51 bGxwdHIpOwogCisgICAgSW50UG9pbnQgbWVudVBvc2l0aW9uID0gY29udmVydFdpZGdldFBvaW50 VG9TY3JlZW5Qb2ludChtX3dlYlZpZXcsIHJlY3QubG9jYXRpb24oKSk7CiAgICAgaWYgKG1lbnVQ b3NpdGlvbi54KCkgKyBtZW51UmVxdWlzaXRpb24ud2lkdGggPiBhcmVhLnggKyBhcmVhLndpZHRo KQogICAgICAgICBtZW51UG9zaXRpb24uc2V0WChhcmVhLnggKyBhcmVhLndpZHRoIC0gbWVudVJl cXVpc2l0aW9uLndpZHRoKTsKIAo=