21060 2008-09-24 08:53:16 -0700 Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR 2019-02-06 09:03:24 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED GoogleBug P2 Normal --- 1 nanto ap ap cdumez jparent ojan oldest_to_newest 92530 0 nanto 2008-09-24 08:53:16 -0700 The surroundContents method of a range can throw BAD_BOUNDARYPOINTS_ERR when the container node of its boundary point is an element node, even if the range contains no partially selected node. See the attachment. Actual: BAD_BOUNDARYPOINTS_ERR is thrown. Expected: The em element is surrounded by the strong element. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/528+ (KHTML, like Gecko) Version/4.0 Safari/528.1.1 WebKit-r36766 92531 1 23751 nanto 2008-09-24 08:55:03 -0700 Created attachment 23751 Testcase 1 Firefox and Opera works fine but Safari doesn't. 96968 2 ap 2008-10-29 03:58:46 -0700 Confirmed with r37970. 97662 3 24907 ap 2008-11-05 03:19:07 -0800 Created attachment 24907 proposed fix 97680 4 24907 mjs 2008-11-05 07:57:10 -0800 Comment on attachment 24907 proposed fix r=me 97715 5 ap 2008-11-05 11:19:39 -0800 Committed revision 38132. 1502961 6 lforschler 2019-02-06 09:03:24 -0800 Mass moving XML DOM bugs to the "DOM" Component. 23751 2008-09-24 08:55:03 -0700 2008-09-24 08:55:03 -0700 Testcase 1 surround-contents-20080924.html text/html 697 nanto PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIg Imh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQiPgo8aHRt bCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+CjxoZWFkPgo8dGl0bGU+UmFu Z2Ujc3Vycm91bmRDb250ZW50czwvdGl0bGU+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0 Ij4KLy8gPCFbQ0RBVEFbCgp3aW5kb3cub25sb2FkID0gZnVuY3Rpb24gKCkgewogIHZhciByYW5n ZSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdlKCk7CiAgdmFyIGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVu dHNCeVRhZ05hbWUoJ2VtJylbMF07CiAgcmFuZ2Uuc2VsZWN0Tm9kZShlbSk7CiAgdmFyIHN0cm9u ZyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3N0cm9uZycpOwogIHRyeSB7CiAgICByYW5nZS5z dXJyb3VuZENvbnRlbnRzKHN0cm9uZyk7CiAgICBhbGVydCgnc3VjY2VzcycpOwogIH0gY2F0Y2gg KGV4KSB7CiAgICBhbGVydChleCk7CiAgfQp9OwoKLy8gXV0+Cjwvc2NyaXB0Pgo8c3R5bGUgdHlw ZT0idGV4dC9jc3MiPgpzdHJvbmcgeyBiYWNrZ3JvdW5kLWNvbG9yOiAjM2YzOyB9Cjwvc3R5bGU+ CjwvaGVhZD4KPGJvZHk+Cgo8cD5IZWxsbywgPGVtPlJhbmdlPC9lbT4gd29ybGQhPC9wPgoKPC9i b2R5Pgo8L2h0bWw+Cg== 24907 2008-11-05 03:19:07 -0800 2008-11-05 07:57:10 -0800 proposed fix BAD_BOUNDARYPOINTS_ERR.txt text/plain 5889 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODEyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEtMDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA2MAorICAgICAgICBS YW5nZSNzdXJyb3VuZENvbnRlbnRzIGluY29ycmVjdGx5IHRocm93cyBCQURfQk9VTkRBUllQT0lO VFNfRVJSCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vUmFuZ2Uvc3Vycm91bmRDb250ZW50cy1j aGVjay1ib3VuZGFyeS1wb2ludHMuaHRtbAorCisgICAgICAgICogZG9tL1JhbmdlLmNwcDogKFdl YkNvcmU6OlJhbmdlOjpzdXJyb3VuZENvbnRlbnRzKTogRml4IEJBRF9CT1VOREFSWVBPSU5UU19F UlIgY2hlY2tzLgorCiAyMDA4LTExLTA0ICBDYW1lcm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxl LmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2Vi Q29yZS9kb20vUmFuZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1JhbmdlLmNwcAko cmV2aXNpb24gMzgxMTkpCisrKyBXZWJDb3JlL2RvbS9SYW5nZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE0MjUsMTggKzE0MjUsMTYgQEAgdm9pZCBSYW5nZTo6c3Vycm91bmRDb250ZW50cyhQYXNz UmVmUHRyPAogICAgIC8vIGFsbG93ZWQgYnkgdGhlIHR5cGUgb2Ygbm9kZT8KIAogICAgIC8vIEJB RF9CT1VOREFSWVBPSU5UU19FUlI6IFJhaXNlZCBpZiB0aGUgUmFuZ2UgcGFydGlhbGx5IHNlbGVj dHMgYSBub24tVGV4dCBub2RlLgotICAgIGlmIChtX3N0YXJ0LmNvbnRhaW5lcigpLT5ub2RlVHlw ZSgpICE9IE5vZGU6OlRFWFRfTk9ERSkgewotICAgICAgICBpZiAobV9zdGFydC5vZmZzZXQoKSA+ IDAgJiYgbV9zdGFydC5vZmZzZXQoKSA8IG1heFN0YXJ0T2Zmc2V0KCkpIHsKLSAgICAgICAgICAg IGVjID0gUmFuZ2VFeGNlcHRpb246OkJBRF9CT1VOREFSWVBPSU5UU19FUlI7Ci0gICAgICAgICAg ICByZXR1cm47Ci0gICAgICAgIH0KKyAgICBOb2RlKiBzdGFydE5vblRleHRDb250YWluZXIgPSBt X3N0YXJ0LmNvbnRhaW5lcigpOworICAgIGlmIChzdGFydE5vblRleHRDb250YWluZXItPm5vZGVU eXBlKCkgPT0gTm9kZTo6VEVYVF9OT0RFKQorICAgICAgICBzdGFydE5vblRleHRDb250YWluZXIg PSBzdGFydE5vblRleHRDb250YWluZXItPnBhcmVudE5vZGUoKTsKKyAgICBOb2RlKiBlbmROb25U ZXh0Q29udGFpbmVyID0gbV9lbmQuY29udGFpbmVyKCk7CisgICAgaWYgKGVuZE5vblRleHRDb250 YWluZXItPm5vZGVUeXBlKCkgPT0gTm9kZTo6VEVYVF9OT0RFKQorICAgICAgICBlbmROb25UZXh0 Q29udGFpbmVyID0gZW5kTm9uVGV4dENvbnRhaW5lci0+cGFyZW50Tm9kZSgpOworICAgIGlmIChz dGFydE5vblRleHRDb250YWluZXIgIT0gZW5kTm9uVGV4dENvbnRhaW5lcikgeworICAgICAgICBl YyA9IFJhbmdlRXhjZXB0aW9uOjpCQURfQk9VTkRBUllQT0lOVFNfRVJSOworICAgICAgICByZXR1 cm47CiAgICAgfQotICAgIGlmIChtX2VuZC5jb250YWluZXIoKS0+bm9kZVR5cGUoKSAhPSBOb2Rl OjpURVhUX05PREUpIHsKLSAgICAgICAgaWYgKG1fZW5kLm9mZnNldCgpID4gMCAmJiBtX2VuZC5v ZmZzZXQoKSA8IG1heEVuZE9mZnNldCgpKSB7Ci0gICAgICAgICAgICBlYyA9IFJhbmdlRXhjZXB0 aW9uOjpCQURfQk9VTkRBUllQT0lOVFNfRVJSOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAg ICB9Ci0gICAgfSAgICAKIAogICAgIGVjID0gMDsKICAgICB3aGlsZSAoTm9kZSogbiA9IG5ld1Bh cmVudC0+Zmlyc3RDaGlsZCgpKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzODEyMikKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDA4LTEx LTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL1JhbmdlL3Jhbmdl LWV4Y2VwdGlvbnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL1JhbmdlL3N1cnJv dW5kQ29udGVudHMtY2hlY2stYm91bmRhcnktcG9pbnRzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogZmFzdC9kb20vUmFuZ2Uvc3Vycm91bmRDb250ZW50cy1jaGVjay1ib3VuZGFyeS1w b2ludHMuaHRtbDogQWRkZWQuCisKKzIwMDgtMTEtMDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9kb20vUmFuZ2UvcmFuZ2UtZXhjZXB0aW9ucy1leHBlY3RlZC50eHQ6CisK IDIwMDgtMTEtMDUgIFBpZXJyZS1PbGl2aWVyIExhdG91ciAgPHBvbEBhcHBsZS5jb20+CiAKICAg ICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL1JhbmdlL3JhbmdlLWV4Y2VwdGlvbnMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3JhbmdlLWV4Y2VwdGlvbnMtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAzODExOSkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3Jhbmdl LWV4Y2VwdGlvbnMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC01LDcgKzUsNyBAQCBP biBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBCiAKIFBBU1Mgbm9kZS5pbm5l ckhUTUwgaXMgJzxiYXI+QUI8bW9vPkM8L21vbz5ERTwvYmFyPicKIFBBU1MgZm9vLm91dGVySFRN TCBpcyAnPGZvbz48L2Zvbz4nCi1QQVNTIHJhbmdlLnN1cnJvdW5kQ29udGVudHMoZm9vKSB0aHJl dyBleGNlcHRpb24gRXJyb3I6IEJBRF9CT1VOREFSWVBPSU5UU19FUlI6IERPTSBSYW5nZSBFeGNl cHRpb24gMS4KK1BBU1MgcmFuZ2Uuc3Vycm91bmRDb250ZW50cyhmb28pIHRocmV3IGV4Y2VwdGlv biBFcnJvcjogSU5WQUxJRF9OT0RFX1RZUEVfRVJSOiBET00gUmFuZ2UgRXhjZXB0aW9uIDIuCiBQ QVNTIHIuc3Vycm91bmRDb250ZW50cyhkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdhJykpIHRocmV3 IGV4Y2VwdGlvbiBFcnJvcjogQkFEX0JPVU5EQVJZUE9JTlRTX0VSUjogRE9NIFJhbmdlIEV4Y2Vw dGlvbiAxLgogUEFTUyByLnN1cnJvdW5kQ29udGVudHMoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgn YScpKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IEhJRVJBUkNIWV9SRVFVRVNUX0VSUjogRE9NIEV4 Y2VwdGlvbiAzLgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9kb20vUmFuZ2Uvc3Vycm91bmRDb250ZW50cy1jaGVjay1ib3VuZGFyeS1wb2lu dHMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1Jhbmdl L3N1cnJvdW5kQ29udGVudHMtY2hlY2stYm91bmRhcnktcG9pbnRzLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3N1cnJvdW5kQ29udGVudHMt Y2hlY2stYm91bmRhcnktcG9pbnRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw0IEBACitUZXN0IGZvciBidWcgMjEwNjA6IFJhbmdlI3N1cnJvdW5kQ29udGVudHMgaW5jb3Jy ZWN0bHkgdGhyb3dzIEJBRF9CT1VOREFSWVBPSU5UU19FUlIuCisKKworUEFTUwoKUHJvcGVydHkg Y2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9kb20vUmFuZ2Uvc3Vycm91bmRDb250ZW50cy1j aGVjay1ib3VuZGFyeS1wb2ludHMtZXhwZWN0ZWQudHh0Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1p bWUtdHlwZQogICArIHRleHQvcGxhaW4KTmFtZTogc3ZuOmVvbC1zdHlsZQogICArIG5hdGl2ZQoK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3N1cnJvdW5kQ29udGVudHMtY2hlY2st Ym91bmRhcnktcG9pbnRzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20v UmFuZ2Uvc3Vycm91bmRDb250ZW50cy1jaGVjay1ib3VuZGFyeS1wb2ludHMuaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3N1cnJvdW5kQ29udGVudHMtY2hl Y2stYm91bmRhcnktcG9pbnRzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjkgQEAKKzxo dG1sPgorPGJvZHk+Cis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNjAiPmJ1ZyAyMTA2MDwvYT46CitSYW5nZSNzdXJyb3VuZENv bnRlbnRzIGluY29ycmVjdGx5IHRocm93cyBCQURfQk9VTkRBUllQT0lOVFNfRVJSLjwvcD4KKwor PHAgc3R5bGU9InZpc2liaWxpdHk6aGlkZGVuIj5IZWxsbywgPGVtPlJhbmdlPC9lbT4gd29ybGQh PC9wPgorCis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworCisKKyAgdmFyIHJhbmdlID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKKyAgdmFy IGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2VtJylbMF07CisgIHJhbmdlLnNl bGVjdE5vZGUoZW0pOworICB2YXIgc3Ryb25nID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnc3Ry b25nJyk7CisgIHRyeSB7CisgICAgcmFuZ2Uuc3Vycm91bmRDb250ZW50cyhzdHJvbmcpOworICAg IHZhciBtYXJrdXAgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgicCIpWzFdLmlubmVy SFRNTDsKKyAgICBkb2N1bWVudC53cml0ZSgobWFya3VwID09ICdIZWxsbywgPHN0cm9uZz48ZW0+ UmFuZ2U8L2VtPjwvc3Ryb25nPiB3b3JsZCEnKSA/CisgICAgICAgICJQQVNTIiA6ICgiRkFJTDog aW5jb3JyZWN0IHJlc3VsdGluZyBtYXJrdXAsICciICsgbWFya3VwLnJlcGxhY2UoLzwvZywgIiZs dDsiKSArICInIikpOworICB9IGNhdGNoIChleCkgeworICAgIGRvY3VtZW50LndyaXRlKCJGQUlM OiAiICsgZXgpOworICB9CisKKzwvc2NyaXB0PgorCis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0 eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9SYW5nZS9zdXJyb3VuZENvbnRlbnRz LWNoZWNrLWJvdW5kYXJ5LXBvaW50cy5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlw ZQogICArIHRleHQvaHRtbAoK