210595 2020-04-16 01:15:15 -0700 The <style> element should not convert \n into <br> 2023-08-26 00:31:25 -0700 1 1 1 Unclassified WebKit HTML Editing Other Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 mcrha webkit-unassigned annevk bugs-noreply cdumez cgarcia esprehn+autocc ews-watchlist gyuyoung.kim wenson_hsieh oldest_to_newest 1642175 0 mcrha 2020-04-16 01:15:15 -0700 The <style> element inside <head> can use \n as a separator between CSS rules (yes, they should be in a comment, but it's still possible to write them as regular text inside the element). When I want to get the content of the HTML document the \n are converted into <br> tags, which can lead to broken CSS rules when this HTML is loaded back. This conversion happens when setting style.innerText value. Steps: a) open the MiniBrowser and there the Inspector b) run in the Inspector Console: document.documentElement.innerHTML = "<head><style> body {color:orange;}\nbody {background:blue;}</style></head><body>text</body>" * you see a blue document with orange 'text' at the top, as expected. * the 'Elements' tab shows the <style> element content as one long line, as expected. c) run in the Inspector Console: document.head.firstElementChild.innerText = "body {color:green;}\nbody {background:red;}" * you see a red document with green 'text' at the top, as expected. * the 'Elements' tab shows the <style> element content with <br> element, where \n was used, which is wrong. d) run in the Inspector Console: document.documentElement.innerHTML = document.documentElement.innerHTML * you see a white document with green 'text' at the top, which is wrong. * the 'Elements' tab shows the <style> element content with <br> as a regular text, not as an element, which is wrong. The expected is that: * after c) the <style>'s content will not contain <br> element * after d) there will be absolutely no change in the view, neither in the HTML content/structure This is with the trunk at r259630. 1642178 1 mcrha 2020-04-16 01:32:18 -0700 It seems I can workaround this by using style.innerHTML instead of style.innerText, but I'm afraid it would have some side effects when the content has >, <, & or some such characters. 1642187 2 396630 mcrha 2020-04-16 02:45:26 -0700 Created attachment 396630 proposed patch This helps, though I'm not sure whether it's the way you'd like to have it. 1973754 3 annevk 2023-08-26 00:31:25 -0700 This is how innerText and innerHTML are supposed to behave. Firefox does the exact same thing. See https://html.spec.whatwg.org/#the-innertext-idl-attribute. 396630 2020-04-16 02:45:26 -0700 2020-04-16 02:45:26 -0700 proposed patch wk.patch text/plain 1775 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1M2NjNTY4MjUxZS4uYzc2N2YyMWUwZjIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wNC0xNiAgTWlsYW4gQ3JoYSAgPG1jcmhhQHJlZGhhdC5jb20+CisK KyAgICAgICAgW0dUS10gVGhlIDxzdHlsZT4gZWxlbWVudCBzaG91bGQgbm90IGNvbnZlcnQgXG4g aW50byA8YnI+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTA1OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGh0bWwvSFRNTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEVsZW1lbnQ6 OnNldElubmVyVGV4dCk6IERvIG5vdCBjb252ZXJ0IG5ldyBsaW5lcworICAgICAgICB0byA8QlI+ IGVsZW1lbnRzIGluIDxTVFlMRT4gZWxlbWVudC4KKwogMjAyMC0wNC0wNyAgRG91ZyBLZWxseSAg PGRvdWdrQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgcmVsZWFzZSBhc3NlcnRzIHRvIEtleWZy YW1lRWZmZWN0U3RhY2s6OmVuc3VyZUVmZmVjdHNBcmVTb3J0ZWQoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxFbGVtZW50LmNwcAppbmRleCAzMmVkNGFkMzFiZC4uYWRjZTM5YzY2M2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTEVsZW1lbnQuY3BwCkBAIC01NCw2ICs1NCw3IEBACiAjaW5jbHVkZSAiSFRNTE9w dGlvbkVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCiAjaW5jbHVkZSAi SFRNTFNlbGVjdEVsZW1lbnQuaCIKKyNpbmNsdWRlICJIVE1MU3R5bGVFbGVtZW50LmgiCiAjaW5j bHVkZSAiSFRNTFRleHRBcmVhRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50LmgiCiAjaW5jbHVkZSAiTm9kZVRyYXZlcnNhbC5oIgpAQCAtNTQ0LDcgKzU0NSw3 IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IEhUTUxFbGVtZW50OjpzZXRJbm5lclRleHQoY29uc3QgU3Ry aW5nJiB0ZXh0KQogICAgIC8vIEZJWE1FOiBDYW4gdGhlIHJlbmRlcmVyIGJlIG91dCBvZiBkYXRl IGhlcmU/IERvIHdlIG5lZWQgdG8gY2FsbCB1cGRhdGVTdHlsZUlmTmVlZGVkPwogICAgIC8vIEZv ciBleGFtcGxlLCBmb3IgdGhlIGNvbnRlbnRzIG9mIHRleHRhcmVhIGVsZW1lbnRzIHRoYXQgYXJl IGRpc3BsYXk6bm9uZT8KICAgICBhdXRvKiByID0gcmVuZGVyZXIoKTsKLSAgICBpZiAoKHIgJiYg ci0+c3R5bGUoKS5wcmVzZXJ2ZU5ld2xpbmUoKSkgfHwgKGlzQ29ubmVjdGVkKCkgJiYgaXNUZXh0 Q29udHJvbElubmVyVGV4dEVsZW1lbnQoKSkpIHsKKyAgICBpZiAoKHIgJiYgci0+c3R5bGUoKS5w cmVzZXJ2ZU5ld2xpbmUoKSkgfHwgKGlzQ29ubmVjdGVkKCkgJiYgaXNUZXh0Q29udHJvbElubmVy VGV4dEVsZW1lbnQoKSkgfHwgKGlzPEhUTUxTdHlsZUVsZW1lbnQ+KCp0aGlzKSkpIHsKICAgICAg ICAgaWYgKCF0ZXh0LmNvbnRhaW5zKCdccicpKSB7CiAgICAgICAgICAgICByZXBsYWNlQWxsQ2hp bGRyZW4oZG9jdW1lbnQoKS5jcmVhdGVUZXh0Tm9kZSh0ZXh0KSk7CiAgICAgICAgICAgICByZXR1 cm4geyB9Owo=