210594 2020-04-16 01:02:34 -0700 Validate socket in NetworkRTCProvider::wrapNewTCPConnection 2020-04-17 10:18:05 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist webkit-bug-importer youennf oldest_to_newest 1642171 0 youennf 2020-04-16 01:02:34 -0700 Validate socket in NetworkRTCProvider::wrapNewTCPConnection 1642172 1 youennf 2020-04-16 01:03:03 -0700 rdar://problem/61783652 1642173 2 396627 youennf 2020-04-16 01:04:58 -0700 Created attachment 396627 Patch 1642238 3 396627 eric.carlson 2020-04-16 06:59:58 -0700 Comment on attachment 396627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396627&action=review > Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:176 > + if (auto socket = m_pendingIncomingSockets.take(newConnectionSocketIdentifier)) > + addSocket(identifier, makeUnique<LibWebRTCSocketClient>(identifier, *this, WTFMove(socket), Socket::Type::ServerConnectionTCP)); Would logging when the socket is NULL be helpful? 1642644 4 396757 youennf 2020-04-17 05:38:45 -0700 Created attachment 396757 Patch for landing 1642728 5 ews-feeder 2020-04-17 10:18:04 -0700 Committed r260260: <https://trac.webkit.org/changeset/260260> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396757. 396627 2020-04-16 01:04:58 -0700 2020-04-17 05:38:41 -0700 Patch bug-210594-20200416100457.patch text/plain 1997 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ4MjM0YTA1NzNhZGM2YWFi YjcwYjQ5ZDI1NzhlODI1NGY2ZWYyYWYuLjk1MDIwZWI3ZDNhYWQ4ZTAxZjIzZTQxOGE0MDRhYTNm ZTU5M2ViYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDQtMTYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFZhbGlkYXRlIHNvY2tldCBpbiBO ZXR3b3JrUlRDUHJvdmlkZXI6OndyYXBOZXdUQ1BDb25uZWN0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA1OTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9O ZXR3b3JrUlRDUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUlRDUHJvdmlk ZXI6OndyYXBOZXdUQ1BDb25uZWN0aW9uKToKKyAgICAgICAgQWRkIGEgbnVsbCBjaGVjayBpbiBj YXNlIHRoZSBpZGVudGlmaWVyIGRvZXMgbm90IHJlbGF0ZSB0byBhbiBleGlzdGluZyBwZW5kaW5n IHNvY2tldC4KKwogMjAyMC0wNC0xNCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBEbyBtb3JlIGNoZWNraW5nIGJlZm9yZSByZXVzaW5nIHByZWNvbXBpbGVk IHNhbmRib3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRj L05ldHdvcmtSVENQcm92aWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3dl YnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwCmluZGV4IDQ4NDExZDE2MzZjZDZkMmEwYTViYjdi OTEzYzgyMDBlMzBmNTk2ZDYuLjFiYjUwYWNjM2UzOGYwNDlhN2E5YjU5MWNhYzg3MTI2N2M0MTE1 OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdv cmtSVENQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJy dGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcApAQCAtMTcyLDggKzE3Miw4IEBAIHZvaWQgTmV0d29y a1JUQ1Byb3ZpZGVyOjpjcmVhdGVDbGllbnRUQ1BTb2NrZXQoTGliV2ViUlRDU29ja2V0SWRlbnRp ZmllciBpZGVudGlmCiB2b2lkIE5ldHdvcmtSVENQcm92aWRlcjo6d3JhcE5ld1RDUENvbm5lY3Rp b24oTGliV2ViUlRDU29ja2V0SWRlbnRpZmllciBpZGVudGlmaWVyLCBMaWJXZWJSVENTb2NrZXRJ ZGVudGlmaWVyIG5ld0Nvbm5lY3Rpb25Tb2NrZXRJZGVudGlmaWVyKQogewogICAgIGNhbGxPblJU Q05ldHdvcmtUaHJlYWQoW3RoaXMsIGlkZW50aWZpZXIsIG5ld0Nvbm5lY3Rpb25Tb2NrZXRJZGVu dGlmaWVyXSgpIHsKLSAgICAgICAgc3RkOjp1bmlxdWVfcHRyPHJ0Yzo6QXN5bmNQYWNrZXRTb2Nr ZXQ+IHNvY2tldCA9IG1fcGVuZGluZ0luY29taW5nU29ja2V0cy50YWtlKG5ld0Nvbm5lY3Rpb25T b2NrZXRJZGVudGlmaWVyKTsKLSAgICAgICAgYWRkU29ja2V0KGlkZW50aWZpZXIsIG1ha2VVbmlx dWU8TGliV2ViUlRDU29ja2V0Q2xpZW50PihpZGVudGlmaWVyLCAqdGhpcywgV1RGTW92ZShzb2Nr ZXQpLCBTb2NrZXQ6OlR5cGU6OlNlcnZlckNvbm5lY3Rpb25UQ1ApKTsKKyAgICAgICAgaWYgKGF1 dG8gc29ja2V0ID0gbV9wZW5kaW5nSW5jb21pbmdTb2NrZXRzLnRha2UobmV3Q29ubmVjdGlvblNv Y2tldElkZW50aWZpZXIpKQorICAgICAgICAgICAgYWRkU29ja2V0KGlkZW50aWZpZXIsIG1ha2VV bmlxdWU8TGliV2ViUlRDU29ja2V0Q2xpZW50PihpZGVudGlmaWVyLCAqdGhpcywgV1RGTW92ZShz b2NrZXQpLCBTb2NrZXQ6OlR5cGU6OlNlcnZlckNvbm5lY3Rpb25UQ1ApKTsKICAgICB9KTsKIH0K IAo= 396757 2020-04-17 05:38:45 -0700 2020-04-17 10:18:04 -0700 Patch for landing bug-210594-20200417143844.patch text/plain 2124 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNiZTUyYzMyM2U1NTM1MGZk YjI5ODdhNDI0YTQ5MTNiZmI5ODE3YzYuLmUyMmIxNDA0N2Q1NTk4MDkwZTI2ZDE4ZmM4OWMwZTQw NTY4NWExYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDQtMTcgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFZhbGlkYXRlIHNvY2tldCBpbiBO ZXR3b3JrUlRDUHJvdmlkZXI6OndyYXBOZXdUQ1BDb25uZWN0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA1OTQKKworICAgICAgICBSZXZpZXdl ZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0 d29ya1JUQ1Byb3ZpZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1JUQ1Byb3ZpZGVy Ojp3cmFwTmV3VENQQ29ubmVjdGlvbik6CisgICAgICAgIEFkZCBhIG51bGwgY2hlY2sgaW4gY2Fz ZSB0aGUgaWRlbnRpZmllciBkb2VzIG5vdCByZWxhdGUgdG8gYW4gZXhpc3RpbmcgcGVuZGluZyBz b2NrZXQuCisKIDIwMjAtMDQtMTYgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAog ICAgICAgICBDbGVhbnVwIHRoZSB1c2FnZSBvZiBFTkFCTEVfRlVMTFNDUkVFTl9BUEkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92 aWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRD UHJvdmlkZXIuY3BwCmluZGV4IDQ4NDExZDE2MzZjZDZkMmEwYTViYjdiOTEzYzgyMDBlMzBmNTk2 ZDYuLmEyYmNjNmI3NTIyYjIxY2YyYTg4NWQzYmY3MjIwZGM5MmU4YTMzYjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5j cHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1By b3ZpZGVyLmNwcApAQCAtMTcyLDggKzE3MiwxMCBAQCB2b2lkIE5ldHdvcmtSVENQcm92aWRlcjo6 Y3JlYXRlQ2xpZW50VENQU29ja2V0KExpYldlYlJUQ1NvY2tldElkZW50aWZpZXIgaWRlbnRpZgog dm9pZCBOZXR3b3JrUlRDUHJvdmlkZXI6OndyYXBOZXdUQ1BDb25uZWN0aW9uKExpYldlYlJUQ1Nv Y2tldElkZW50aWZpZXIgaWRlbnRpZmllciwgTGliV2ViUlRDU29ja2V0SWRlbnRpZmllciBuZXdD b25uZWN0aW9uU29ja2V0SWRlbnRpZmllcikKIHsKICAgICBjYWxsT25SVENOZXR3b3JrVGhyZWFk KFt0aGlzLCBpZGVudGlmaWVyLCBuZXdDb25uZWN0aW9uU29ja2V0SWRlbnRpZmllcl0oKSB7Ci0g ICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxydGM6OkFzeW5jUGFja2V0U29ja2V0PiBzb2NrZXQgPSBt X3BlbmRpbmdJbmNvbWluZ1NvY2tldHMudGFrZShuZXdDb25uZWN0aW9uU29ja2V0SWRlbnRpZmll cik7Ci0gICAgICAgIGFkZFNvY2tldChpZGVudGlmaWVyLCBtYWtlVW5pcXVlPExpYldlYlJUQ1Nv Y2tldENsaWVudD4oaWRlbnRpZmllciwgKnRoaXMsIFdURk1vdmUoc29ja2V0KSwgU29ja2V0OjpU eXBlOjpTZXJ2ZXJDb25uZWN0aW9uVENQKSk7CisgICAgICAgIGF1dG8gc29ja2V0ID0gbV9wZW5k aW5nSW5jb21pbmdTb2NrZXRzLnRha2UobmV3Q29ubmVjdGlvblNvY2tldElkZW50aWZpZXIpOwor ICAgICAgICBSRUxFQVNFX0xPR19JRighc29ja2V0LCBXZWJSVEMsICJOZXR3b3JrUlRDUHJvdmlk ZXI6OndyYXBOZXdUQ1BDb25uZWN0aW9uIHJlY2VpdmVkIGFuIGludmFsaWQgc29ja2V0IGlkZW50 aWZpZXIiKTsKKyAgICAgICAgaWYgKHNvY2tldCkKKyAgICAgICAgICAgIGFkZFNvY2tldChpZGVu dGlmaWVyLCBtYWtlVW5pcXVlPExpYldlYlJUQ1NvY2tldENsaWVudD4oaWRlbnRpZmllciwgKnRo aXMsIFdURk1vdmUoc29ja2V0KSwgU29ja2V0OjpUeXBlOjpTZXJ2ZXJDb25uZWN0aW9uVENQKSk7 CiAgICAgfSk7CiB9CiAK