<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>210592</bug_id>
          
          <creation_ts>2020-04-15 23:09:19 -0700</creation_ts>
          <short_desc>MSVC: LayoutUnits.h(248): warning C4245: &apos;argument&apos;: conversion from &apos;const int&apos; to &apos;size_t&apos;, signed/unsigned mismatch</short_desc>
          <delta_ts>2020-04-20 13:49:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1642157</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-04-15 23:09:19 -0700</bug_when>
    <thetext>MSVC: LayoutUnits.h(248): warning C4245: &apos;argument&apos;: conversion from &apos;const int&apos; to &apos;size_t&apos;, signed/unsigned mismatch

Since Bug 210399 (r259981)

&gt; C:\Buildbot\WinCairo-EWS\build\Source\WebCore\layout\LayoutUnits.h(248): warning C4245: &apos;argument&apos;: conversion from &apos;const int&apos; to &apos;size_t&apos;, signed/unsigned mismatch
&gt; C:\Buildbot\WinCairo-EWS\build\Source\WebCore\layout\LayoutUnits.h(250): warning C4245: &apos;argument&apos;: conversion from &apos;const int&apos; to &apos;size_t&apos;, signed/unsigned mismatch
&gt; C:\Buildbot\WinCairo-EWS\build\Source\WebCore\layout\LayoutUnits.h(251): warning C4245: &apos;argument&apos;: conversion from &apos;const int&apos; to &apos;size_t&apos;, signed/unsigned mismatch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1643369</commentid>
    <comment_count>1</comment_count>
      <attachid>396951</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-04-19 23:53:58 -0700</bug_when>
    <thetext>Created attachment 396951
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1643617</commentid>
    <comment_count>2</comment_count>
      <attachid>396951</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-04-20 13:39:17 -0700</bug_when>
    <thetext>Comment on attachment 396951
Patch

Clearing flags on attachment: 396951

Committed r260396: &lt;https://trac.webkit.org/changeset/260396&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1643618</commentid>
    <comment_count>3</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-04-20 13:39:20 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1643623</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-04-20 13:49:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/62074213&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>396951</attachid>
            <date>2020-04-19 23:53:58 -0700</date>
            <delta_ts>2020-04-20 13:39:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-210592-20200420155356.patch</filename>
            <type>text/plain</type>
            <size>2536</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzhiNzRmYjYwMDBkMWI2
OGQ5NDY0NzVlNjY5MTJkOTkyZDk2MjE1YS4uY2NiZThiYThhZjQwOGZmY2FiNTEyM2Y3OGY0NjMy
Yzc0Zjk3ZGM0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTE5ICBGdWpp
aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIE1TVkM6IExh
eW91dFVuaXRzLmgoMjQ4KTogd2FybmluZyBDNDI0NTogJ2FyZ3VtZW50JzogY29udmVyc2lvbiBm
cm9tICdjb25zdCBpbnQnIHRvICdzaXplX3QnLCBzaWduZWQvdW5zaWduZWQgbWlzbWF0Y2gKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDU5MgorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGF5b3V0L0xh
eW91dFVuaXRzLmg6CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6TGF5b3V0OjpT
bG90UG9zaXRpb24+OjplbXB0eVZhbHVlKToKKyAgICAgICAgKFdURjo6SGFzaFRyYWl0czxXZWJD
b3JlOjpMYXlvdXQ6OlNsb3RQb3NpdGlvbj46OmNvbnN0cnVjdERlbGV0ZWRWYWx1ZSk6CisgICAg
ICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6TGF5b3V0OjpTbG90UG9zaXRpb24+Ojppc0Rl
bGV0ZWRWYWx1ZSk6CisgICAgICAgIFVzZSBzdGQ6Om51bWVyaWNfbGltaXRzPHNpemVfdD46Om1h
eCgpIGZvciBlbXB0eSBhbmQgZGVsZXRlZAorICAgICAgICB2YWx1ZXMgaW5zdGVhZCBvZiBXZWJD
b3JlOjppbnRNaW5Gb3JMYXlvdXRVbml0LgorCiAyMDIwLTA0LTE5ICBSb2IgQnVpcyAgPHJidWlz
QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVubmVlZGVkIGNvZGUgZnJvbSBGcmFtZUxv
YWRlcjo6bG9hZFVSTApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0xheW91dFVu
aXRzLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0VW5pdHMuaAppbmRleCA5M2JjNjY3
MGU0NTU2YWZiMTcxZTNhYWY1Y2Y2NzFiMmE3YTZkNzRmLi45MDkzMjRkNGUyOTAxZjUxYjllYWNl
ZDdlNzViNGJmNGVhOGQ1NWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5
b3V0VW5pdHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0VW5pdHMuaApAQCAt
MjQ1LDEwICsyNDUsMTAgQEAgc3RydWN0IFNsb3RQb3NpdGlvbkhhc2ggewogICAgIHN0YXRpYyBj
b25zdCBib29sIHNhZmVUb0NvbXBhcmVUb0VtcHR5T3JEZWxldGVkID0gdHJ1ZTsKIH07CiB0ZW1w
bGF0ZTw+IHN0cnVjdCBIYXNoVHJhaXRzPFdlYkNvcmU6OkxheW91dDo6U2xvdFBvc2l0aW9uPiA6
IEdlbmVyaWNIYXNoVHJhaXRzPFdlYkNvcmU6OkxheW91dDo6U2xvdFBvc2l0aW9uPiB7Ci0gICAg
c3RhdGljIFdlYkNvcmU6OkxheW91dDo6U2xvdFBvc2l0aW9uIGVtcHR5VmFsdWUoKSB7IHJldHVy
biBXZWJDb3JlOjpMYXlvdXQ6OlNsb3RQb3NpdGlvbigwLCBXZWJDb3JlOjppbnRNaW5Gb3JMYXlv
dXRVbml0KTsgfQorICAgIHN0YXRpYyBXZWJDb3JlOjpMYXlvdXQ6OlNsb3RQb3NpdGlvbiBlbXB0
eVZhbHVlKCkgeyByZXR1cm4gV2ViQ29yZTo6TGF5b3V0OjpTbG90UG9zaXRpb24oMCwgc3RkOjpu
dW1lcmljX2xpbWl0czxzaXplX3Q+OjptYXgoKSk7IH0KIAotICAgIHN0YXRpYyB2b2lkIGNvbnN0
cnVjdERlbGV0ZWRWYWx1ZShXZWJDb3JlOjpMYXlvdXQ6OlNsb3RQb3NpdGlvbiYgc2xvdCkgeyBz
bG90ID0gV2ViQ29yZTo6TGF5b3V0OjpTbG90UG9zaXRpb24oV2ViQ29yZTo6aW50TWluRm9yTGF5
b3V0VW5pdCwgMCk7IH0KLSAgICBzdGF0aWMgYm9vbCBpc0RlbGV0ZWRWYWx1ZShjb25zdCBXZWJD
b3JlOjpMYXlvdXQ6OlNsb3RQb3NpdGlvbiYgc2xvdCkgeyByZXR1cm4gc2xvdCA9PSBXZWJDb3Jl
OjpMYXlvdXQ6OlNsb3RQb3NpdGlvbihXZWJDb3JlOjppbnRNaW5Gb3JMYXlvdXRVbml0LCAwKTsg
fQorICAgIHN0YXRpYyB2b2lkIGNvbnN0cnVjdERlbGV0ZWRWYWx1ZShXZWJDb3JlOjpMYXlvdXQ6
OlNsb3RQb3NpdGlvbiYgc2xvdCkgeyBzbG90ID0gV2ViQ29yZTo6TGF5b3V0OjpTbG90UG9zaXRp
b24oc3RkOjpudW1lcmljX2xpbWl0czxzaXplX3Q+OjptYXgoKSwgMCk7IH0KKyAgICBzdGF0aWMg
Ym9vbCBpc0RlbGV0ZWRWYWx1ZShjb25zdCBXZWJDb3JlOjpMYXlvdXQ6OlNsb3RQb3NpdGlvbiYg
c2xvdCkgeyByZXR1cm4gc2xvdCA9PSBXZWJDb3JlOjpMYXlvdXQ6OlNsb3RQb3NpdGlvbihzdGQ6
Om51bWVyaWNfbGltaXRzPHNpemVfdD46Om1heCgpLCAwKTsgfQogfTsKIHRlbXBsYXRlPD4gc3Ry
dWN0IERlZmF1bHRIYXNoPFdlYkNvcmU6OkxheW91dDo6U2xvdFBvc2l0aW9uPiB7CiAgICAgdHlw
ZWRlZiBTbG90UG9zaXRpb25IYXNoIEhhc2g7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>