210570 2020-04-15 14:01:12 -0700 Captured ThreadedScrollingTree should check its m_scrollingCoordinator before calling its methods 2020-04-26 18:49:10 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa cmarcelo ews-watchlist fred.wang gsnedders jamesr luiz simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1641963 0 sabouhallawa 2020-04-15 14:01:12 -0700 Before <https://trac.webkit.org/changeset/258679>, m_scrollingCoordinator was protected. But this was changed in this revision such that "*this" is now protected. This change was done because we needed to call strongThis->removeWheelEventTestCompletionDeferralForReason() also. In <https://trac.webkit.org/changeset/258753>, the call to strongThis->removeWheelEventTestCompletionDeferralForReason() was removed. But the protection capture code was not changed back. Protecting "*this" does not guarantee the protection of m_scrollingCoordinator since it is a RefPtr. And this RefPtr can be nullified in ThreadedScrollingTree::invalidate(). 1641967 1 396570 sabouhallawa 2020-04-15 14:05:00 -0700 Created attachment 396570 Patch 1641970 2 sabouhallawa 2020-04-15 14:07:41 -0700 <rdar://problem/61691082> 1641995 3 396570 simon.fraser 2020-04-15 14:57:15 -0700 Comment on attachment 396570 Patch If we've cleared the m_scrollingCoordinator on the ThreadedScrolling tree, I don't think we need to keep the scrollingCoordinator alive in order to call scheduleUpdateScrollPositionAfterAsyncScroll. We should just null-check m_scrollingCoordinator in the block. 1642128 4 396612 sabouhallawa 2020-04-15 20:40:14 -0700 Created attachment 396612 Patch 1642341 5 ews-feeder 2020-04-16 11:04:31 -0700 Committed r260199: <https://trac.webkit.org/changeset/260199> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396612. 1645875 6 ap 2020-04-26 18:49:10 -0700 *** Bug 210987 has been marked as a duplicate of this bug. *** 396570 2020-04-15 14:05:00 -0700 2020-04-15 20:40:12 -0700 Patch bug-210570-20200415140459.patch text/plain 2346 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI2MmZkYTVlYTZiOGRm YmE0NDNkMDBiYzg4ZGQxOTVkYzVjMTIyZC4uMGQxOGNlMmUyMGY5ZjIxMDEwYTQ0ZDZjMzNiMzUx ZTMxY2I2NGJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTE1ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgVGhyZWFk ZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdUcmVlTm9kZURpZFNjcm9sbCgpIHNob3VsZCBwcm90 ZWN0IHRoZSBtX3Njcm9sbGluZ0Nvb3JkaW5hdG9yIHdoZW4gZGlzcGF0Y2hpbmcgaXRzIGFzeW5j IG9wZXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEwNTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgbV9zY3JvbGxpbmdDb29yZGluYXRvciBuZWVkcyB0byBiZSBwcm9lY3R0ZWQuIFByb3RlY3Rp bmcgIip0aGlzIiBkb2VzCisgICAgICAgIG5vdCBndWFyYW50ZWUgaXRzIHByb3RlY3Rpb24gb2Yg c2luY2UgaXQgaXMgYSBSZWZQdHIuIEFuZCB0aGlzIFJlZlB0cgorICAgICAgICBjYW4gYmUgbnVs bGlmaWVkIGluIFRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6aW52YWxpZGF0ZSgpLgorCisgICAgICAg ICogcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6c2Nyb2xsaW5nVHJlZU5vZGVEaWRTY3JvbGwp OgorCiAyMDIwLTA0LTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLNF0gRml4IHVzZSBvZiBndGsgaW5pdCBmdW5jdGlvbnMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJl ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1Ry ZWUuY3BwCmluZGV4IGQ4M2U3YTdhMjlkNGRjMWZiMzBhNzAwNDEwZTg4NTJmMGYzNDU2YTUuLmQx NmI2NmQwZGI3NzBiYWRhMGRhYmE3ZmQ0NjViODFiY2UxOWRlOWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcApA QCAtMTEzLDggKzExMyw4IEBAIHZvaWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdU cmVlTm9kZURpZFNjcm9sbChTY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kCiAgICAgICAgIGRlZmVy V2hlZWxFdmVudFRlc3RDb21wbGV0aW9uRm9yUmVhc29uKHJlaW50ZXJwcmV0X2Nhc3Q8V2hlZWxF dmVudFRlc3RNb25pdG9yOjpTY3JvbGxhYmxlQXJlYUlkZW50aWZpZXI+KG5vZGUuc2Nyb2xsaW5n Tm9kZUlEKCkpLCBXaGVlbEV2ZW50VGVzdE1vbml0b3I6OlNjcm9sbGluZ1RocmVhZFN5bmNOZWVk ZWQpOwogI2VuZGlmCiAKLSAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3N0cm9uZ1RoaXMg PSBtYWtlUmVmKCp0aGlzKSwgbm9kZUlEID0gbm9kZS5zY3JvbGxpbmdOb2RlSUQoKSwgc2Nyb2xs UG9zaXRpb24sIGxheW91dFZpZXdwb3J0T3JpZ2luLCBzY3JvbGxpbmdMYXllclBvc2l0aW9uQWN0 aW9uXSB7Ci0gICAgICAgIHN0cm9uZ1RoaXMtPm1fc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPnNjaGVk dWxlVXBkYXRlU2Nyb2xsUG9zaXRpb25BZnRlckFzeW5jU2Nyb2xsKG5vZGVJRCwgc2Nyb2xsUG9z aXRpb24sIGxheW91dFZpZXdwb3J0T3JpZ2luLCBzY3JvbGxpbmdMYXllclBvc2l0aW9uQWN0aW9u KTsKKyAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW3Njcm9sbGluZ0Nvb3JkaW5hdG9yID0g bV9zY3JvbGxpbmdDb29yZGluYXRvciwgbm9kZUlEID0gbm9kZS5zY3JvbGxpbmdOb2RlSUQoKSwg c2Nyb2xsUG9zaXRpb24sIGxheW91dFZpZXdwb3J0T3JpZ2luLCBzY3JvbGxpbmdMYXllclBvc2l0 aW9uQWN0aW9uXSB7CisgICAgICAgIHNjcm9sbGluZ0Nvb3JkaW5hdG9yLT5zY2hlZHVsZVVwZGF0 ZVNjcm9sbFBvc2l0aW9uQWZ0ZXJBc3luY1Njcm9sbChub2RlSUQsIHNjcm9sbFBvc2l0aW9uLCBs YXlvdXRWaWV3cG9ydE9yaWdpbiwgc2Nyb2xsaW5nTGF5ZXJQb3NpdGlvbkFjdGlvbik7CiAgICAg fSk7CiB9CiAK 396612 2020-04-15 20:40:14 -0700 2020-04-16 11:04:31 -0700 Patch bug-210570-20200415204013.patch text/plain 2014 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI2MmZkYTVlYTZiOGRm YmE0NDNkMDBiYzg4ZGQxOTVkYzVjMTIyZC4uYzQ1MzAzZjJmZTIwZDFhNGI4NjA0OTQ2NGQ2Zjhl NjI4NTY3YjEwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTE1ICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FwdHVy ZWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlIHNob3VsZCBjaGVjayBpdHMgbV9zY3JvbGxpbmdDb29y ZGluYXRvciBiZWZvcmUgY2FsbGluZyBpdHMgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbV9zY3JvbGxpbmdDb29yZGluYXRvciBtYXkgYmUg bnVsbGlmaWVkIGJlZm9yZSBhc3luY2hyb25vdXNseSBjYWxsaW5nIGl0cworICAgICAgICBtZXRo b2Qgc2NoZWR1bGVVcGRhdGVTY3JvbGxQb3NpdGlvbkFmdGVyQXN5bmNTY3JvbGwoKS4gQ2hlY2sg aWYgaXQgaXMKKyAgICAgICAgbm90IG51bGwgYmVmb3JlIGNhbGxpbmcgdGhpcyBtZXRob2QuCisK KyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpzY3JvbGxpbmdUcmVlTm9kZURp ZFNjcm9sbCk6CisKIDIwMjAtMDQtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEs0XSBGaXggdXNlIG9mIGd0ayBpbml0IGZ1bmN0aW9u cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3Jv bGxpbmdUcmVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Ny b2xsaW5nVHJlZS5jcHAKaW5kZXggZDgzZTdhN2EyOWQ0ZGMxZmIzMGE3MDA0MTBlODg1MmYwZjM0 NTZhNS4uYjQ1NTZiZGU2YTA2MWQ0ZWUxMDU5M2Y5ZDUwNTg0N2I4OGNiNmZhOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1Ry ZWUuY3BwCkBAIC0xMTQsNyArMTE0LDggQEAgdm9pZCBUaHJlYWRlZFNjcm9sbGluZ1RyZWU6OnNj cm9sbGluZ1RyZWVOb2RlRGlkU2Nyb2xsKFNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2QKICNlbmRp ZgogCiAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtzdHJvbmdUaGlzID0gbWFrZVJlZigq dGhpcyksIG5vZGVJRCA9IG5vZGUuc2Nyb2xsaW5nTm9kZUlEKCksIHNjcm9sbFBvc2l0aW9uLCBs YXlvdXRWaWV3cG9ydE9yaWdpbiwgc2Nyb2xsaW5nTGF5ZXJQb3NpdGlvbkFjdGlvbl0gewotICAg ICAgICBzdHJvbmdUaGlzLT5tX3Njcm9sbGluZ0Nvb3JkaW5hdG9yLT5zY2hlZHVsZVVwZGF0ZVNj cm9sbFBvc2l0aW9uQWZ0ZXJBc3luY1Njcm9sbChub2RlSUQsIHNjcm9sbFBvc2l0aW9uLCBsYXlv dXRWaWV3cG9ydE9yaWdpbiwgc2Nyb2xsaW5nTGF5ZXJQb3NpdGlvbkFjdGlvbik7CisgICAgICAg IGlmIChhdXRvKiBzY3JvbGxpbmdDb29yZGluYXRvciA9IHN0cm9uZ1RoaXMtPm1fc2Nyb2xsaW5n Q29vcmRpbmF0b3IuZ2V0KCkpCisgICAgICAgICAgICBzY3JvbGxpbmdDb29yZGluYXRvci0+c2No ZWR1bGVVcGRhdGVTY3JvbGxQb3NpdGlvbkFmdGVyQXN5bmNTY3JvbGwobm9kZUlELCBzY3JvbGxQ b3NpdGlvbiwgbGF5b3V0Vmlld3BvcnRPcmlnaW4sIHNjcm9sbGluZ0xheWVyUG9zaXRpb25BY3Rp b24pOwogICAgIH0pOwogfQogCg==