210550 2020-04-15 08:29:21 -0700 [GTK4] Fix use of gtk init functions 2020-04-16 05:45:54 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 210100 1 cgarcia webkit-unassigned annulen aperez bugs-noreply ews-watchlist gyuyoung.kim pnormand ryuan.choi sergio oldest_to_newest 1641805 0 cgarcia 2020-04-15 08:29:21 -0700 Add gtk_init and gtk_init_check receiving parameters to GtkVersioning 1641810 1 396539 cgarcia 2020-04-15 08:33:22 -0700 Created attachment 396539 Patch Patch doesn't include the plugin process main (because we should disable plugin process in gtk4) and MiniBrowser that should probably use GtkApplication instead. 1641821 2 cgarcia 2020-04-15 09:06:28 -0700 Committed r260132: <https://trac.webkit.org/changeset/260132> 1642199 3 pnormand 2020-04-16 04:50:59 -0700 Why was this landed with red EWS? A clean build fails here, same as in the EWS: ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: 'WebCore/GtkVersioning.h' file not found #include <WebCore/GtkVersioning.h> ^~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. $ find WebKitBuild/GTK/ -name GtkVersioning.h $ 1642213 4 cgarcia 2020-04-16 05:45:54 -0700 (In reply to Philippe Normand from comment #3) > Why was this landed with red EWS? Because I fixed the build error before landing, at least locally. > A clean build fails here, same as in the EWS: > > > ../../../Tools/TestWebKitAPI/gtk/main.cpp:29:10: fatal error: > 'WebCore/GtkVersioning.h' file not found > #include <WebCore/GtkVersioning.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > $ find WebKitBuild/GTK/ -name GtkVersioning.h > $ That's different error, we should probably make WebCore a dependency of TestWebKitAPI to ensure the forwarding header is generated before. 396539 2020-04-15 08:33:22 -0700 2020-04-15 08:39:13 -0700 Patch wgtk-init.diff text/plain 5794 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiODhhYTBmNzY0M2QuLmRhNTZjMDRhZGVhNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIwLTA0LTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLNF0gRml4IHVzZSBvZiBndGsgaW5pdCBmdW5jdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDU1 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBn dGtfaW5pdCBhbmQgZ3RrX2luaXRfY2hlY2sgcmVjZWl2aW5nIHBhcmFtZXRlcnMgdG8gR3RrVmVy c2lvbmluZy4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3Rr L0d0a1ZlcnNpb25pbmcuaDoKKyAgICAgICAgKGd0a19pbml0KToKKyAgICAgICAgKGd0a19pbml0 X2NoZWNrKToKKwogMjAyMC0wNC0xNSAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1ha2UgUGxhdGZvcm1TY3JlZW46OnNjcmVlbkRQSSgp IEdUSzQtcmVhZHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtl IGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNjRmZmU1NTg3MmNlLi41 YjNhMjcxODZlZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtl CisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC02MCw2ICs2MCw3IEBA IGxpc3QoQVBQRU5EIFdlYkNvcmVfUFJJVkFURV9GUkFNRVdPUktfSEVBREVSUwogICAgIHBsYXRm b3JtL2d0ay9HUmVmUHRyR3RrLmgKICAgICBwbGF0Zm9ybS9ndGsvR1VuaXF1ZVB0ckd0ay5oCiAg ICAgcGxhdGZvcm0vZ3RrL0d0a1V0aWxpdGllcy5oCisgICAgcGxhdGZvcm0vZ3RrL0d0a1ZlcnNp b25pbmcuaAogICAgIHBsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkSGVscGVyLmgKICAgICBwbGF0Zm9y bS9ndGsvU2Nyb2xsYmFyVGhlbWVHdGsuaAogICAgIHBsYXRmb3JtL2d0ay9TZWxlY3Rpb25EYXRh LmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3Jt RGlzcGxheS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURp c3BsYXkuY3BwCmluZGV4IDlhNWExYjY0NzU5NC4uY2M3NjJhMDRlMjljIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAKQEAg LTQ3LDcgKzQ3LDcgQEAKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oR1RLKQotI2luY2x1ZGUgPGd0 ay9ndGsuaD4KKyNpbmNsdWRlICJHdGtWZXJzaW9uaW5nLmgiCiAjZW5kaWYKIAogI2lmIFBMQVRG T1JNKEdUSykgJiYgUExBVEZPUk0oWDExKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9H dGtWZXJzaW9uaW5nLmgKaW5kZXggZGMzYmVjY2MwYTAyLi40NTIxNTUzZTY0OWQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5nLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuaApAQCAtNDUsNCArNDUsMTYg QEAgZ3RrX3dpbmRvd19nZXRfcG9zaXRpb24oR3RrV2luZG93KiwgaW50KiB4LCBpbnQqIHkpCiAg ICAgKnggPSAqeSA9IDA7CiB9CiAKK3N0YXRpYyBpbmxpbmUgdm9pZAorZ3RrX2luaXQoaW50Kiwg Y2hhcioqKikKK3sKKyAgICBndGtfaW5pdCgpOworfQorCitzdGF0aWMgaW5saW5lIGdib29sZWFu CitndGtfaW5pdF9jaGVjayhpbnQqLCBjaGFyKioqKQoreworICAgIHJldHVybiBndGtfaW5pdF9j aGVjaygpOworfQorCiAjZW5kaWYgLy8gVVNFKEdUSzQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZkYTliMDVmMjk1 Mi4uM2Q1MmI2ZWU1MjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA0LTE1ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL NF0gRml4IHVzZSBvZiBndGsgaW5pdCBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDU1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY2x1ZGUgR3RrVmVyc2lvbmluZy5oIGluc3RlYWQg b2YgZ3RrLmgKKworICAgICAgICAqIFdlYlByb2Nlc3MvZ3RrL1dlYlByb2Nlc3NNYWluR3RrLmNw cDoKKwogMjAyMC0wNC0xNSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEs0XSBQcm92aWRlIGFuIGFsdGVybmF0aXZlIHRvIGd0a193aWRn ZXRfe2dldCxpc31fdG9wbGV2ZWwoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2d0ay9XZWJQcm9jZXNzTWFpbkd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv Z3RrL1dlYlByb2Nlc3NNYWluR3RrLmNwcAppbmRleCBlZTBhZWM4OWE3ZWYuLjYyZGM5MWU1N2Nk NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2d0ay9XZWJQcm9jZXNzTWFp bkd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2d0ay9XZWJQcm9jZXNzTWFp bkd0ay5jcHAKQEAgLTI4LDggKzI4LDggQEAKICNpbmNsdWRlICJXZWJQcm9jZXNzTWFpbi5oIgog CiAjaW5jbHVkZSAiQXV4aWxpYXJ5UHJvY2Vzc01haW4uaCIKKyNpbmNsdWRlICJHdGtWZXJzaW9u aW5nLmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgotI2luY2x1ZGUgPGd0ay9ndGsuaD4KICNp bmNsdWRlIDxsaWJpbnRsLmg+CiAKICNpZiBQTEFURk9STShYMTEpCmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDViMjYxZjM2OWVjLi4xNzljYThi MDA0ZWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAyMC0wNC0xNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUSzRdIEZpeCB1c2Ugb2YgZ3RrIGluaXQgZnVu Y3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTA1NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bmNsdWRlIEd0a1ZlcnNpb25pbmcuaCBpbnN0ZWFkIG9mIGd0ay5oLgorCisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvQWNjZXNzaWJpbGl0eVRlc3RTZXJ2ZXIuY3BwOgor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL0luc3BlY3RvclRlc3RTZXJ2 ZXIuY3BwOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvZ3RrL21haW4uY3BwOgorICAgICAgICAq IFdlYktpdFRlc3RSdW5uZXIvZ3RrL21haW4uY3BwOgorCiAyMDIwLTA0LTE1ICBEZXZpbiBSb3Vz c28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBbRVNOZXh0XSBJbXBsZW1lbnQgbG9n aWNhbCBhc3NpZ25tZW50IG9wZXJhdG9ycwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXRHdGsvQWNjZXNzaWJpbGl0eVRlc3RTZXJ2ZXIuY3BwIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvQWNjZXNzaWJpbGl0eVRlc3RTZXJ2ZXIuY3BwCmlu ZGV4IGY4NWY3ZTc0OGRlZS4uMGIwYmE4YjFiNGJmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdEd0ay9BY2Nlc3NpYmlsaXR5VGVzdFNlcnZlci5jcHAKKysrIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvQWNjZXNzaWJpbGl0eVRlc3RTZXJ2 ZXIuY3BwCkBAIC0xOSw3ICsxOSw3IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKIAotI2luY2x1 ZGUgPGd0ay9ndGsuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL0d0a1ZlcnNpb25pbmcuaD4KICNpbmNs dWRlIDx3ZWJraXQyL3dlYmtpdDIuaD4KIAogc3RhdGljIGNvbnN0IGNoYXIgaW50cm9zcGVjdGlv blhNTFtdID0KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3Rr L0luc3BlY3RvclRlc3RTZXJ2ZXIuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRHdGsvSW5zcGVjdG9yVGVzdFNlcnZlci5jcHAKaW5kZXggYTY5M2E4YzYzYTQwLi5iY2NjMjlj NGZmMmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R3RrL0lu c3BlY3RvclRlc3RTZXJ2ZXIuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0R3RrL0luc3BlY3RvclRlc3RTZXJ2ZXIuY3BwCkBAIC0yNCw3ICsyNCw3IEBACiAKICNpbmNs dWRlICJjb25maWcuaCIKIAotI2luY2x1ZGUgPGd0ay9ndGsuaD4KKyNpbmNsdWRlIDxXZWJDb3Jl L0d0a1ZlcnNpb25pbmcuaD4KICNpbmNsdWRlIDx3ZWJraXQyL3dlYmtpdDIuaD4KIAogaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9ndGsvbWFpbi5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2d0ay9tYWluLmNwcAppbmRleCAy YzY4NTY1OTVhZTMuLmUxODc0ZjE4Y2QyNiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9ndGsvbWFpbi5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9ndGsvbWFpbi5jcHAKQEAg LTI2LDcgKzI2LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJUZXN0c0NvbnRy b2xsZXIuaCIKIAotI2luY2x1ZGUgPGd0ay9ndGsuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL0d0a1Zl cnNpb25pbmcuaD4KIAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogewpkaWZmIC0t Z2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvbWFpbi5jcHAgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL2d0ay9tYWluLmNwcAppbmRleCBhMjAzOTU2ZmMyMTAuLjhmMmVkOWYwOTBhOCAx MDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvbWFpbi5jcHAKKysrIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvbWFpbi5jcHAKQEAgLTI2LDggKzI2LDggQEAKICNpbmNs dWRlICJjb25maWcuaCIKIAogI2luY2x1ZGUgIlRlc3RDb250cm9sbGVyLmgiCisjaW5jbHVkZSA8 V2ViQ29yZS9HdGtWZXJzaW9uaW5nLmg+CiAjaW5jbHVkZSA8V2ViS2l0L1dLVGV4dENoZWNrZXJH dGsuaD4KLSNpbmNsdWRlIDxndGsvZ3RrLmg+CiAjaW5jbHVkZSA8d3RmL2dsaWIvR1JlZlB0ci5o PgogCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCg==