210546 2020-04-15 07:05:37 -0700 [GTK] Remove IconGtk 2020-04-15 07:33:39 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 210100 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1641776 0 cgarcia 2020-04-15 07:05:37 -0700 It's currently unused in GTK port since we never show an icon for file uploads. 1641777 1 396529 cgarcia 2020-04-15 07:07:34 -0700 Created attachment 396529 Patch 1641784 2 cgarcia 2020-04-15 07:33:39 -0700 Committed r260126: <https://trac.webkit.org/changeset/260126> 396529 2020-04-15 07:07:34 -0700 2020-04-15 07:16:11 -0700 Patch wkgtk-icon.diff text/plain 7051 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYmQxNzZkMmEwYzIuLjk4ZTM4NzFlMDBmZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDIwLTA0LTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBSZW1vdmUgSWNvbkd0aworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNTQ2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyBjdXJyZW50bHkgdW51c2Vk IGluIEdUSyBwb3J0IHNpbmNlIHdlIG5ldmVyIHNob3cgYW4gaWNvbiBmb3IgZmlsZSB1cGxvYWRz LgorCisgICAgICAgICogU291cmNlc0dUSy50eHQ6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvSWNvbi5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSWNvbi5oOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9JY29uR3RrLmNwcDogUmVtb3ZlZC4KKwogMjAyMC0w NC0xNSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEs0XSBBZGFwdCB0byBjdXJzb3IgQVBJIGNoYW5nZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL1NvdXJjZXNHVEsudHh0IGIvU291cmNlL1dlYkNvcmUvU291cmNlc0dUSy50eHQK aW5kZXggYjc1MTk4NmY2YjViLi5lNDhjNDdiNzkwZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL1NvdXJjZXNHVEsudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXNHVEsudHh0CkBA IC04NSw3ICs4NSw2IEBAIHBsYXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguY3BwCiBw bGF0Zm9ybS9ncmFwaGljcy9ndGsvQ29sb3JHdGsuY3BwCiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsv RGlzcGxheVJlZnJlc2hNb25pdG9yR3RrLmNwcAogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0dka0Nh aXJvVXRpbGl0aWVzLmNwcAotcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ljb25HdGsuY3BwCiBwbGF0 Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VHdGsuY3BwCiAKIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9JbWFnZUdTdHJlYW1lckNhaXJvLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvSWNvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9JY29uLmNwcAppbmRleCA1ZDNjYTgzMGU5ZjYuLmIzYTBhYmMxYTE5OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSWNvbi5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSWNvbi5jcHAKQEAgLTI2LDcgKzI2LDcgQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJJY29uLmgiCiAKLSNpZiAhUExBVEZPUk0oR1RL KSAmJiAhUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgIVBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JN KFdJTikKKyNpZiAhUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgIVBMQVRGT1JNKE1BQykgJiYgIVBM QVRGT1JNKFdJTikKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JY29uLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9JY29uLmgKaW5kZXggMTYyODExMmExYzBiLi5iNTk2MGFkNWZmN2MgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ljb24uaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JY29uLmgKQEAgLTMzLDggKzMzLDYgQEAKIE9C SkNfQ0xBU1MgTlNJbWFnZTsKICNlbGlmIFBMQVRGT1JNKFdJTikKIHR5cGVkZWYgc3RydWN0IEhJ Q09OX18qIEhJQ09OOwotI2VsaWYgUExBVEZPUk0oR1RLKQotdHlwZWRlZiBzdHJ1Y3QgX0dka1Bp eGJ1ZiBHZGtQaXhidWY7CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNzQsOSAr NzIsNiBAQCBwcml2YXRlOgogI2VsaWYgUExBVEZPUk0oV0lOKQogICAgIEljb24oSElDT04pOwog ICAgIEhJQ09OIG1faEljb247Ci0jZWxpZiBQTEFURk9STShHVEspCi0gICAgSWNvbigpOwotICAg IEdka1BpeGJ1ZiogbV9pY29uOwogI2VuZGlmCiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvSWNvbkd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ndGsvSWNvbkd0ay5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IGYwMzliYTY2M2ViMi4uMDAwMDAwMDAwMDAwCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2d0ay9JY29uR3RrLmNwcAorKysgL2Rldi9udWxsCkBAIC0xLDEyOSAr MCwwIEBACi0vKgotICogQ29weXJpZ2h0IChDKSAyMDA2LCAyMDA3IEFwcGxlIEluYy4gIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDcgSG9sZ2VyIEhhbnMgUGV0ZXIg RnJleXRoZXIKLSAqCi0gKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwotICogYXJlIG1ldDoKLSAq Ci0gKiAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBh Ym92ZSBjb3B5cmlnaHQKLSAqICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFu ZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCi0gKiAyLiAgUmVkaXN0cmlidXRpb25zIGluIGJp bmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAgICBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIg aW4gdGhlCi0gKiAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3Zp ZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KLSAqIDMuICBOZWl0aGVyIHRoZSBuYW1lIG9mIEFw cGxlIEluYy4gKCJBcHBsZSIpIG5vciB0aGUgbmFtZXMgb2YKLSAqICAgICBpdHMgY29udHJpYnV0 b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkCi0g KiAgICAgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBw ZXJtaXNzaW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQU5E IElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBBTkQgQU5ZCi0gKiBFWFBSRVNTIE9SIElNUExJRUQg V0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECi0g KiBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNV TEFSIFBVUlBPU0UgQVJFCi0gKiBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBP UiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZCi0gKiBESVJFQ1QsIElORElSRUNU LCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdF UwotICogKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJT VElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOwotICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJ VFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5ECi0gKiBPTiBB TlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJ TElUWSwgT1IgVE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJ U0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GCi0gKiBUSElTIFNPRlRXQVJFLCBFVkVO IElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLSNp bmNsdWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJJY29uLmgiCi0KLSNpbmNsdWRlICJHcmFwaGlj c0NvbnRleHQuaCIKLSNpbmNsdWRlICJNSU1FVHlwZVJlZ2lzdHJ5LmgiCi0jaW5jbHVkZSAiUGxh dGZvcm1Db250ZXh0Q2Fpcm8uaCIKLQotI2luY2x1ZGUgPGd0ay9ndGsuaD4KLQotI2luY2x1ZGUg PHd0Zi9SZWZQdHIuaD4KLSNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+Ci0KLW5hbWVzcGFj ZSBXZWJDb3JlIHsKLQotSWNvbjo6SWNvbigpCi0gICAgOiBtX2ljb24oMCkKLXsKLX0KLQotSWNv bjo6fkljb24oKQotewotICAgIGlmIChtX2ljb24pCi0gICAgICAgIGdfb2JqZWN0X3VucmVmKG1f aWNvbik7Ci19Ci0KLXN0YXRpYyBTdHJpbmcgbG9va3VwSWNvbk5hbWUoU3RyaW5nIE1JTUVUeXBl KQotewotICAgIC8qCi0gICAgIExvb2t1cCBhbiBhcHByb3ByaWF0ZSBpY29uIGFjY29yZGluZyB0 byBlaXRoZXIgdGhlIEljb24gTmFtaW5nIFNwZWMKLSAgICAgb3IgY29udmVudGlvbmFsIEdub21l IGljb24gbmFtZXMgcmVzcGVjdGl2ZWx5LgotCi0gICAgIFNlZSBodHRwOi8vc3RhbmRhcmRzLmZy ZWVkZXNrdG9wLm9yZy9pY29uLW5hbWluZy1zcGVjL2ljb24tbmFtaW5nLXNwZWMtbGF0ZXN0Lmh0 bWwKLQotICAgICBUaGUgaWNvbiB0aGVtZSBpcyBwcm9iZWQgZm9yIHRoZSBmb2xsb3dpbmcgbmFt ZXM6Ci0gICAgIDEuIG1lZGlhLXN1YnR5cGUKLSAgICAgMi4gZ25vbWUtbWltZS1tZWRpYS1zdWJ0 eXBlCi0gICAgIDMuIG1lZGlhLXgtZ2VuZXJpYwotICAgICA0LiBnbm9tZS1taW1lLW1lZGlhCi0K LSAgICAgSW4gdGhlIHdvcnN0IGNhc2UgaXQgZmFsbHMgYmFjayB0byB0aGUgc3RvY2sgZmlsZSBp Y29uLgotICAgICovCi0gICAgaW50IHBvcyA9IE1JTUVUeXBlLmZpbmQoJy8nKTsKLSAgICBpZihw b3MgPj0gMCkgewotICAgICAgICBTdHJpbmcgbWVkaWEgPSBNSU1FVHlwZS5zdWJzdHJpbmcoMCwg cG9zKTsKLSAgICAgICAgU3RyaW5nIHN1YnR5cGUgPSBNSU1FVHlwZS5zdWJzdHJpbmcocG9zICsg MSk7Ci0gICAgICAgIEd0a0ljb25UaGVtZSogaWNvblRoZW1lID0gZ3RrX2ljb25fdGhlbWVfZ2V0 X2RlZmF1bHQoKTsKLSAgICAgICAgU3RyaW5nIGljb25OYW1lID0gbWVkaWEgKyAiLSIgKyBzdWJ0 eXBlOwotICAgICAgICBpZihndGtfaWNvbl90aGVtZV9oYXNfaWNvbihpY29uVGhlbWUsIGljb25O YW1lLnV0ZjgoKS5kYXRhKCkpKQotICAgICAgICAgICAgcmV0dXJuIGljb25OYW1lOwotICAgICAg ICBpY29uTmFtZSA9ICJnbm9tZS1taW1lLSIgKyBtZWRpYSArICItIiArIHN1YnR5cGU7Ci0gICAg ICAgIGlmKGd0a19pY29uX3RoZW1lX2hhc19pY29uKGljb25UaGVtZSwgaWNvbk5hbWUudXRmOCgp LmRhdGEoKSkpCi0gICAgICAgICAgICByZXR1cm4gaWNvbk5hbWU7Ci0gICAgICAgIGljb25OYW1l ID0gbWVkaWEgKyAiLXgtZ2VuZXJpYyI7Ci0gICAgICAgIGlmKGd0a19pY29uX3RoZW1lX2hhc19p Y29uKGljb25UaGVtZSwgaWNvbk5hbWUudXRmOCgpLmRhdGEoKSkpCi0gICAgICAgICAgICByZXR1 cm4gaWNvbk5hbWU7Ci0gICAgICAgIGljb25OYW1lID0gbWVkaWEgKyAiZ25vbWUtbWltZS0iICsg bWVkaWE7Ci0gICAgICAgIGlmKGd0a19pY29uX3RoZW1lX2hhc19pY29uKGljb25UaGVtZSwgaWNv bk5hbWUudXRmOCgpLmRhdGEoKSkpCi0gICAgICAgICAgICByZXR1cm4gaWNvbk5hbWU7Ci0gICAg fQotICAgIHJldHVybiAidGV4dC14LWdlbmVyaWMiOwotfQotCi0vLyBGSVhNRTogTW92ZSB0aGUg Y29kZSB0byBDaHJvbWVDbGllbnQ6Omljb25Gb3JGaWxlcygpLgotUmVmUHRyPEljb24+IEljb246 OmNyZWF0ZUljb25Gb3JGaWxlcyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgZmlsZW5hbWVzKQotewot ICAgIGlmIChmaWxlbmFtZXMuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gbnVsbHB0cjsKLQot ICAgIGlmIChmaWxlbmFtZXMuc2l6ZSgpID09IDEpIHsKLSAgICAgICAgaWYgKCFnX3BhdGhfc2tp cF9yb290KGZpbGVuYW1lc1swXS51dGY4KCkuZGF0YSgpKSkKLSAgICAgICAgICAgIHJldHVybiBu dWxscHRyOwotCi0gICAgICAgIFN0cmluZyBNSU1FVHlwZSA9IE1JTUVUeXBlUmVnaXN0cnk6Omdl dE1JTUVUeXBlRm9yUGF0aChmaWxlbmFtZXNbMF0pOwotICAgICAgICBTdHJpbmcgaWNvbk5hbWUg PSBsb29rdXBJY29uTmFtZShNSU1FVHlwZSk7Ci0KLSAgICAgICAgUmVmUHRyPEljb24+IGljb24g PSBhZG9wdFJlZihuZXcgSWNvbik7Ci0gICAgICAgIGljb24tPm1faWNvbiA9IGd0a19pY29uX3Ro ZW1lX2xvYWRfaWNvbihndGtfaWNvbl90aGVtZV9nZXRfZGVmYXVsdCgpLCBpY29uTmFtZS51dGY4 KCkuZGF0YSgpLCAxNiwgR1RLX0lDT05fTE9PS1VQX1VTRV9CVUlMVElOLCAwKTsKLSAgICAgICAg aWYgKCFpY29uLT5tX2ljb24pCi0gICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICAgICAg cmV0dXJuIGljb247Ci0gICAgfQotCi0gICAgLy9GSVhNRTogSW1wbGVtZW50IHRoaXMKLSAgICBy ZXR1cm4gMDsKLX0KLQotdm9pZCBJY29uOjpwYWludChHcmFwaGljc0NvbnRleHQmIGNvbnRleHQs IGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKLXsKLSAgICBpZiAoY29udGV4dC5wYWludGluZ0Rpc2Fi bGVkKCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIC8vIFRPRE86IFNjYWxlL2NsaXAgdGhlIGlt YWdlIGlmIG5lY2Vzc2FyeS4KLSAgICBjYWlyb190KiBjciA9IGNvbnRleHQucGxhdGZvcm1Db250 ZXh0KCktPmNyKCk7Ci0gICAgY2Fpcm9fc2F2ZShjcik7Ci0gICAgZ2RrX2NhaXJvX3NldF9zb3Vy Y2VfcGl4YnVmKGNyLCBtX2ljb24sIHJlY3QueCgpLCByZWN0LnkoKSk7Ci0gICAgY2Fpcm9fcGFp bnQoY3IpOwotICAgIGNhaXJvX3Jlc3RvcmUoY3IpOwotfQotCi19Cg==