210532 2020-04-14 22:03:52 -0700 isNullFunctionPointer() can fail for symbols not explicitly marked as weakly linked. 2020-04-15 09:09:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble mitz sam thorton webkit-bug-importer oldest_to_newest 1641678 0 jer.noble 2020-04-14 22:03:52 -0700 isNullFunctionPointer() can fail for symbols not explicitly marked as weakly linked. 1641680 1 396499 jer.noble 2020-04-14 22:11:47 -0700 Created attachment 396499 Patch 1641808 2 ews-feeder 2020-04-15 08:32:25 -0700 Committed r260129: <https://trac.webkit.org/changeset/260129> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396499. 1641809 3 webkit-bug-importer 2020-04-15 08:33:14 -0700 <rdar://problem/61829150> 1641814 4 sam 2020-04-15 08:45:19 -0700 I don't think this is the right approach for this. If we are going to change libWebRTC, I think we should add a non-function symbol to use to check weak-linkage. And we should remove isNullFunctionPointer() or fix it it, but not leave it half working (see https://bugs.webkit.org/show_bug.cgi?id=208873) 396499 2020-04-14 22:11:47 -0700 2020-04-15 08:32:26 -0700 Patch bug-210532-20200414221147.patch text/plain 3788 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBmMmU5NjcxNWZjZWNhMDk2ZGQ4MzIzOGIwNTQ2MDQyZTBiODM4ZGFjLi40MGUw MjM3ODJkYWYwYTI1MzMwMGEzMTEzNWNiMTMxMmM0Y2Q5NzUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMC0wNC0xNCAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBpc051bGxGdW5jdGlvblBvaW50ZXIo KSBjYW4gZmFpbCBmb3Igc3ltYm9scyBub3QgZXhwbGljaXRseSBtYXJrZWQgYXMgd2Vha2x5IGxp bmtlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MDUzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1dlYktpdFV0aWxpdGllcy5oOgorCiAyMDIwLTA0LTA5 ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXQgRU5USVRM RU1FTlRTX1JFUVVJUkVEPU5PIGZvciBzb21lIFhjb2RlIGJ1aWxkIHRhcmdldHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCAwYjMwZGJhZTg2NWE4OTBhNDBkZTJiMDZlM2Y2ZTg5ODFmYzUyOGZiLi44OTA4OWFlZjcw ZmE4ODUxNzgyZTA4NWVhMWM4ZTRjNjBmYWRiNjNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMjAtMDQtMTQgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAg ICAgaXNOdWxsRnVuY3Rpb25Qb2ludGVyKCkgY2FuIGZhaWwgZm9yIHN5bWJvbHMgbm90IGV4cGxp Y2l0bHkgbWFya2VkIGFzIHdlYWtseSBsaW5rZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTA1MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTeW1ib2xzIHdob3NlIGRlY2xhcmF0aW9ucyBhcmUgZXhw bGljaXRseSBtYXJrZWQgYXMgd2Vha2x5IGltcG9ydGVkIGFyZSBndWFyYW50ZWVkIHRvIGJlCisg ICAgICAgIE5VTEwgd2hlbiB0aGUgbGlicmFyeSBjb250YWluaW5nIHRob3NlIHN5bWJvbHMgaXMg bm90IGF2YWlsYWJsZSBhdCBydW50aW1lLCBvciB3aGVuIHRoZQorICAgICAgICBzeW1ib2wgaXRz ZWxmIGlzbid0IHByZXNlbnQgaW4gdGhlIHZlcnNpb24gb2YgdGhlIGxpYnJhcnkgd2hpY2ggaXMg YXZhaWxhYmxlIGF0IHJ1bnRpbWUuIEZvcgorICAgICAgICBzeW1ib2xzIHdoaWNoIGFyZSBub3Qg ZXhwbGljaXRseSBtYXJrZWQgYXMgd2Vha2x5IGltcG9ydGVkIChiZWNhdXNlLCBlLmcuLCB0aGUg ZnJhbWV3b3JrCisgICAgICAgIGl0c2VsZiBpcyB3ZWFrbHkgaW1wb3J0ZWQpLCB0aGlzIHRlY2hu aXF1ZSBjYW4gZmFpbC4gUmF0aGVyIHRoYW4gdGVzdCB0aGUgbnVsbGl0eSBvZiBhCisgICAgICAg IHJhbmRvbSBzdGF0aWMgQysrIGNsYXNzIG1ldGhvZCB3aXRoIGlzTnVsbEZ1bmN0aW9uUG9pbnRl cigpLCBleHBsaWNpdGx5IG1hcmsgYXMgd2Vha19pbXBvcnQKKyAgICAgICAgYSB1dGlsaXR5IG1l dGhvZCBhZGRlZCBieSB0aGUgV2ViS2l0IHByb2plY3QsIHdoaWNoIGNvbnZlbmllbnRseSBpcyBh bHJlYWR5IHVzZWQgZnJvbSB3aXRoaW4KKyAgICAgICAgTGliV2ViUlRDUHJvdmlkZXJDb2NvYSwg YW5kIHRlc3QgdGhlIG51bGxpdHkgb2YgdGhhdCBtZXRob2QgaW5zdGVhZC4KKworICAgICAgICAq IHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckNvY29hLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ1Byb3ZpZGVyOjp3ZWJSVENBdmFpbGFibGUp OgorCiAyMDIwLTA0LTA2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFsgTWFjIHdrMiBdIGh0dHAvdGVzdHMvbWVkaWEvdHJhY2staW4tYmFuZC1obHMtbWV0YWRh dGEuaHRtbCBpcyBmbGFreSBjcmFzaGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvV2ViS2l0VXRpbGl0aWVzLmggYi9T b3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvV2ViS2l0L1dlYktp dFV0aWxpdGllcy5oCmluZGV4IDYzOTEzZjIwZGVjNDU4NGI2MDE1NGQzYmM2ZjAwMWE5Zjg3NmFm ODUuLmZhYzk1NjU1ZTc4MTk3MDQzYTQ5ZjM2YjIyZWJhNWMyZDRmYTZhM2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9XZWJLaXQvV2Vi S2l0VXRpbGl0aWVzLmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93 ZWJydGMvc2RrL1dlYktpdC9XZWJLaXRVdGlsaXRpZXMuaApAQCAtNDQsNyArNDQsNyBAQCBlbnVt IGNsYXNzIFdlYktpdENvZGVjU3VwcG9ydCB7IEgyNjRWUDhBbmRIMjY1LCBIMjY0QW5kVlA4IH07 CiBzdGQ6OnVuaXF1ZV9wdHI8d2VicnRjOjpWaWRlb0VuY29kZXJGYWN0b3J5PiBjcmVhdGVXZWJL aXRFbmNvZGVyRmFjdG9yeShXZWJLaXRDb2RlY1N1cHBvcnQpOwogc3RkOjp1bmlxdWVfcHRyPHdl YnJ0Yzo6VmlkZW9EZWNvZGVyRmFjdG9yeT4gY3JlYXRlV2ViS2l0RGVjb2RlckZhY3RvcnkoV2Vi S2l0Q29kZWNTdXBwb3J0KTsKIAotdm9pZCBzZXRBcHBsaWNhdGlvblN0YXR1cyhib29sIGlzQWN0 aXZlKTsKK3ZvaWQgc2V0QXBwbGljYXRpb25TdGF0dXMoYm9vbCBpc0FjdGl2ZSkgX19hdHRyaWJ1 dGVfXygod2Vha19pbXBvcnQpKTsKIAogdm9pZCBzZXRIMjY0SGFyZHdhcmVFbmNvZGVyQWxsb3dl ZChib29sKTsKIGJvb2wgaXNIMjY0SGFyZHdhcmVFbmNvZGVyQWxsb3dlZCgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJU Q1Byb3ZpZGVyQ29jb2EuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0v bGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyQ29jb2EuY3BwCmluZGV4IGM3MzcxNzQ0Zjc4ZTg2 ZmQ1MzRhYTk5MmIyODVkNTlkNWNmMTE2ZTQuLmQxOTE3NTZjMzU0ODdkMDZkZWFhOTBmMWVjZDEx ZTQ2YjJkM2EzNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckNvY29hLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXJDb2Nv YS5jcHAKQEAgLTc2LDcgKzc2LDcgQEAgYm9vbCBMaWJXZWJSVENQcm92aWRlcjo6d2ViUlRDQXZh aWxhYmxlKCkKICNpZiBQTEFURk9STShJT1MpCiAgICAgcmV0dXJuIHRydWU7CiAjZWxzZQotICAg IHJldHVybiAhaXNOdWxsRnVuY3Rpb25Qb2ludGVyKHJ0Yzo6TG9nTWVzc2FnZTo6TG9nVG9EZWJ1 Zyk7CisgICAgcmV0dXJuICFpc051bGxGdW5jdGlvblBvaW50ZXIod2VicnRjOjpzZXRBcHBsaWNh dGlvblN0YXR1cyk7CiAjZW5kaWYKIH0KIAo=