210531 2020-04-14 21:50:17 -0700 Data Detected Actions sheets are presented from odd locations. 2020-04-15 13:21:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1641673 0 megan_gardner 2020-04-14 21:50:17 -0700 Data Detected Actions sheets are presented from odd locations. 1641674 1 396498 megan_gardner 2020-04-14 21:51:44 -0700 Created attachment 396498 Patch 1641675 2 396498 thorton 2020-04-14 21:56:33 -0700 Comment on attachment 396498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757 > + if ([delegate respondsToSelector:@selector(_createTargetedContextMenuHintPreviewIfPossible)]) > + return [delegate _createTargetedContextMenuHintPreviewIfPossible]; Is this not important for other clients of WKActionSheetAssistant (whoever they are? WKPDFView?) 1641676 3 396498 wenson_hsieh 2020-04-14 21:57:30 -0700 Comment on attachment 396498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66 > +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible; Nit - delegate methods usually take the object that’s calling into the delegate as an argument. 1641677 4 396498 thorton 2020-04-14 21:57:45 -0700 Comment on attachment 396498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396498&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:66 > +- (UITargetedPreview *)_createTargetedContextMenuHintPreviewIfPossible; where's the parameter indicating which action sheet assistant the delegate should respond for? 1641840 5 396543 megan_gardner 2020-04-15 09:47:41 -0700 Created attachment 396543 Patch 1641851 6 396543 wenson_hsieh 2020-04-15 10:12:06 -0700 Comment on attachment 396543 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396543&action=review > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:757 > + if ([delegate respondsToSelector:@selector(createTargetedContextMenuHintForAcitionSheetAssistant:)]) > + return [delegate createTargetedContextMenuHintForAcitionSheetAssistant:self]; Nit - “Acition" 1641880 7 396552 megan_gardner 2020-04-15 11:19:45 -0700 Created attachment 396552 Patch for landing 1641925 8 ews-feeder 2020-04-15 12:57:15 -0700 Found 4 new test failures: imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html, imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html, imported/w3c/web-platform-tests/web-animations/interfaces/Animation/commitStyles.html 1641933 9 megan_gardner 2020-04-15 13:20:32 -0700 Committed r260146: <https://trac.webkit.org/changeset/260146> 1641935 10 webkit-bug-importer 2020-04-15 13:21:20 -0700 <rdar://problem/61844617> 396498 2020-04-14 21:51:44 -0700 2020-04-15 09:47:40 -0700 Patch bug-210531-20200414215143.patch text/plain 4399 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE3ZGViMWQ2ZmZjMDcwYjY5 ZDc5MzJhODNhZWYxYzNlYWQyY2YzZWUuLjFmMjg1NmIxM2I3MzEzMmQzMmEyZjhlZGUwOWUzNDI4 NGQ0NDk3NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDQtMTQgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRhIERldGVjdGVk IEFjdGlvbnMgc2hlZXRzIGFyZSBwcmVzZW50ZWQgZnJvbSBvZGQgbG9jYXRpb25zLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNTMxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82MDk0MTM0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVc2UgdGhlIGV4aXN0aW5nIGNvbnRleHQgbWVudSB0YXJnZXRl ZCBwcmV2aWV3IGNvZGUgdG8gZW5zdXJlIHRoYXQgdGhlCisgICAgICAgIGRhdGEgZGV0ZWN0ZWQg bWVudXMgYXJlIHByZXNlbnRlZCBpbiBhIGdvb2QgbG9jYXRpb24uCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv aW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW06CisgICAgICAgICgtW1dLQWN0aW9uU2hlZXRB c3Npc3RhbnQgY29udGV4dE1lbnVJbnRlcmFjdGlvbjpwcmV2aWV3Rm9ySGlnaGxpZ2h0aW5nTWVu dVdpdGhDb25maWd1cmF0aW9uOl0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNvbnRleHRNZW51 SW50ZXJhY3Rpb246d2lsbEVuZEZvckNvbmZpZ3VyYXRpb246YW5pbWF0b3I6XSk6CisKIDIwMjAt MDQtMTQgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaWxlIFVwbG9hZCBNZW51cyBwcmVzZW50ZWQgZnJvbSBvZGQgbG9jYXRpb25zLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQu aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50LmgK aW5kZXggMWQzMDk0NjMwYzhhNDRlMDA5YWU4NzEwOTc2NGVkZGY4ZDVkOTY2Yy4uNDAxZjk3YmJk NGE0YjhkMjMyZDg1ZDEzZDI4ZjE3NjQ3NjJjZTU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5oCkBAIC02Myw2ICs2Myw3 IEBAIHN0cnVjdCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjsKIC0gKE5TU3RyaW5n ICopc2VsZWN0ZWRUZXh0Rm9yQWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Np c3RhbnQgKilhc3Npc3RhbnQ7CiAtICh2b2lkKWFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlv blNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50IGdldEFsdGVybmF0ZVVSTEZvckltYWdlOihVSUlt YWdlICopaW1hZ2UgY29tcGxldGlvbjoodm9pZCAoXikoTlNVUkwgKmFsdGVybmF0ZVVSTCwgTlNE aWN0aW9uYXJ5ICp1c2VySW5mbykpY29tcGxldGlvbjsKIC0gKENHUG9pbnQpY29udGV4dE1lbnVQ cmVzZW50YXRpb25Mb2NhdGlvbkZvckFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0 QXNzaXN0YW50ICopYXNzaXN0YW50OworLSAoVUlUYXJnZXRlZFByZXZpZXcgKilfY3JlYXRlVGFy Z2V0ZWRDb250ZXh0TWVudUhpbnRQcmV2aWV3SWZQb3NzaWJsZTsKIAogQGVuZAogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1t CmluZGV4IDRlNWIwNWU0NTI4YjhlYmI5Mjg0Nzk4M2RkNDQwYWE4MjNjODQxZDkuLmNjZjU0NTAy NjBiYWY3N2FlZDE2ZjY3YmY1ZDY5ZWQ4YTY0M2UwNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCkBAIC03NTIsMTIg Kzc1MiwxNSBAQCAtIChVSVRhcmdldGVkUHJldmlldyAqKWNvbnRleHRNZW51SW50ZXJhY3Rpb246 KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVyYQogewogICAgIGF1dG8gZGVsZWdhdGUg PSBfZGVsZWdhdGUuZ2V0KCk7CiAgICAgQ0dQb2ludCBjZW50ZXIgPSBDR1BvaW50WmVybzsKKyAg ICAKKyAgICBpZiAoW2RlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX2NyZWF0 ZVRhcmdldGVkQ29udGV4dE1lbnVIaW50UHJldmlld0lmUG9zc2libGUpXSkKKyAgICAgICAgcmV0 dXJuIFtkZWxlZ2F0ZSBfY3JlYXRlVGFyZ2V0ZWRDb250ZXh0TWVudUhpbnRQcmV2aWV3SWZQb3Nz aWJsZV07CisgICAgCiAgICAgaWYgKFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVj dG9yKGNvbnRleHRNZW51UHJlc2VudGF0aW9uTG9jYXRpb25Gb3JBY3Rpb25TaGVldEFzc2lzdGFu dDopXSkKICAgICAgICAgY2VudGVyID0gW2RlbGVnYXRlIGNvbnRleHRNZW51UHJlc2VudGF0aW9u TG9jYXRpb25Gb3JBY3Rpb25TaGVldEFzc2lzdGFudDpzZWxmXTsKICAgICBSZXRhaW5QdHI8VUlQ cmV2aWV3UGFyYW1ldGVycz4gdW51c2VkUHJldmlld1BhcmFtZXRlcnMgPSBhZG9wdE5TKFtbVUlQ cmV2aWV3UGFyYW1ldGVycyBhbGxvY10gaW5pdF0pOwogICAgIFJldGFpblB0cjxVSVByZXZpZXdU YXJnZXQ+IHByZXZpZXdUYXJnZXQgPSBhZG9wdE5TKFtbVUlQcmV2aWV3VGFyZ2V0IGFsbG9jXSBp bml0V2l0aENvbnRhaW5lcjpfdmlldy5nZXRBdXRvcmVsZWFzZWQoKSBjZW50ZXI6Y2VudGVyXSk7 CiAgICAgUmV0YWluUHRyPFVJVGFyZ2V0ZWRQcmV2aWV3PiBwcmV2aWV3ID0gYWRvcHROUyhbW1VJ VGFyZ2V0ZWRQcmV2aWV3IGFsbG9jXSBpbml0V2l0aFZpZXc6X3ZpZXcuZ2V0QXV0b3JlbGVhc2Vk KCkgcGFyYW1ldGVyczp1bnVzZWRQcmV2aWV3UGFyYW1ldGVycy5nZXQoKSB0YXJnZXQ6cHJldmll d1RhcmdldC5nZXQoKV0pOwotCiAgICAgcmV0dXJuIHByZXZpZXcuYXV0b3JlbGVhc2UoKTsKIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KaW5kZXggZjA3YTdiMWIxYTgwMTM0OWQ0ZjkyZGFkZDY0Mzg4MzljODFl YWI4Yy4uOWIwOWFiYjczNDVmOWUzZGRkNWQyMzE2NDc5MmY5MzFkNmEyYzBhZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCkBAIC05MjY0LDkgKzkyNjQsMTIgQEAgLSAodm9pZCljb250ZXh0TWVudUludGVyYWN0 aW9uOihVSUNvbnRleHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiB3aWxsRW5kRm8KICAg ICAgICAgLy8gYW5kIHJlbW92aW5nIHRoZSBoaW50IGNvbnRhaW5lciB2aWV3IHdpbGwgY2F1c2Ug dGhlIGFuaW1hdGlvbiB0byBicmVhay4KICAgICAgICAgaWYgKHN0cm9uZ1NlbGYtPl9jb250ZXh0 TWVudUVsZW1lbnRJbmZvKQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAvLyBXZSBhcmUg YWxzbyB1c2luZyB0aGlzIGNvbnRhaW5lciBmb3IgdGhlIGZpbGUgdXBsb2FkIHBhbmVsCisgICAg ICAgIC8vIFdlIGFyZSBhbHNvIHVzaW5nIHRoaXMgY29udGFpbmVyIGZvciB0aGUgZmlsZSB1cGxv YWQgcGFuZWwuLi4KICAgICAgICAgaWYgKHN0cm9uZ1NlbGYtPl9maWxlVXBsb2FkUGFuZWwpCiAg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIC8vIGFuZCB0aGUgYWN0aW9uIHNoZWV0IGFzc2lz dGFudC4KKyAgICAgICAgaWYgKHN0cm9uZ1NlbGYtPl9hY3Rpb25TaGVldEFzc2lzdGFudCkKKyAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgW3N0ZDo6ZXhjaGFuZ2Uoc3Ryb25nU2VsZi0+X2Nv bnRleHRNZW51SGludENvbnRhaW5lclZpZXcsIG5pbCkgcmVtb3ZlRnJvbVN1cGVydmlld107CiAg ICAgfV07CiB9Cg== 396543 2020-04-15 09:47:41 -0700 2020-04-15 11:19:43 -0700 Patch bug-210531-20200415094740.patch text/plain 4883 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE3ZGViMWQ2ZmZjMDcwYjY5 ZDc5MzJhODNhZWYxYzNlYWQyY2YzZWUuLjFmMjg1NmIxM2I3MzEzMmQzMmEyZjhlZGUwOWUzNDI4 NGQ0NDk3NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDQtMTQgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRhIERldGVjdGVk IEFjdGlvbnMgc2hlZXRzIGFyZSBwcmVzZW50ZWQgZnJvbSBvZGQgbG9jYXRpb25zLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNTMxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82MDk0MTM0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVc2UgdGhlIGV4aXN0aW5nIGNvbnRleHQgbWVudSB0YXJnZXRl ZCBwcmV2aWV3IGNvZGUgdG8gZW5zdXJlIHRoYXQgdGhlCisgICAgICAgIGRhdGEgZGV0ZWN0ZWQg bWVudXMgYXJlIHByZXNlbnRlZCBpbiBhIGdvb2QgbG9jYXRpb24uCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv aW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW06CisgICAgICAgICgtW1dLQWN0aW9uU2hlZXRB c3Npc3RhbnQgY29udGV4dE1lbnVJbnRlcmFjdGlvbjpwcmV2aWV3Rm9ySGlnaGxpZ2h0aW5nTWVu dVdpdGhDb25maWd1cmF0aW9uOl0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNvbnRleHRNZW51 SW50ZXJhY3Rpb246d2lsbEVuZEZvckNvbmZpZ3VyYXRpb246YW5pbWF0b3I6XSk6CisKIDIwMjAt MDQtMTQgIE1lZ2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaWxlIFVwbG9hZCBNZW51cyBwcmVzZW50ZWQgZnJvbSBvZGQgbG9jYXRpb25zLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQu aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50LmgK aW5kZXggMWQzMDk0NjMwYzhhNDRlMDA5YWU4NzEwOTc2NGVkZGY4ZDVkOTY2Yy4uNWMwOGY0OTdk Y2MyODI2MmY0MTcwNTdlZWEyNjdkMzA1MDY1MjFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5oCkBAIC02Myw2ICs2Myw3 IEBAIHN0cnVjdCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjsKIC0gKE5TU3RyaW5n ICopc2VsZWN0ZWRUZXh0Rm9yQWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Np c3RhbnQgKilhc3Npc3RhbnQ7CiAtICh2b2lkKWFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlv blNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50IGdldEFsdGVybmF0ZVVSTEZvckltYWdlOihVSUlt YWdlICopaW1hZ2UgY29tcGxldGlvbjoodm9pZCAoXikoTlNVUkwgKmFsdGVybmF0ZVVSTCwgTlNE aWN0aW9uYXJ5ICp1c2VySW5mbykpY29tcGxldGlvbjsKIC0gKENHUG9pbnQpY29udGV4dE1lbnVQ cmVzZW50YXRpb25Mb2NhdGlvbkZvckFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0 QXNzaXN0YW50ICopYXNzaXN0YW50OworLSAoVUlUYXJnZXRlZFByZXZpZXcgKiljcmVhdGVUYXJn ZXRlZENvbnRleHRNZW51SGludEZvckFjaXRpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVl dEFzc2lzdGFudCAqKWFzc2lzdGFudDsKIAogQGVuZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbSBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCmluZGV4IDRlNWIwNWU0 NTI4YjhlYmI5Mjg0Nzk4M2RkNDQwYWE4MjNjODQxZDkuLjhkNjg2OTg4NzJhNTI1Yjk5MGZjM2Zl ZTdhMjEyMDBmMDkxYjJlNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCkBAIC03NTIsMTIgKzc1MiwxNSBAQCAtIChV SVRhcmdldGVkUHJldmlldyAqKWNvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29udGV4dE1lbnVJ bnRlcmFjdGlvbiAqKWludGVyYQogewogICAgIGF1dG8gZGVsZWdhdGUgPSBfZGVsZWdhdGUuZ2V0 KCk7CiAgICAgQ0dQb2ludCBjZW50ZXIgPSBDR1BvaW50WmVybzsKKyAgICAKKyAgICBpZiAoW2Rl bGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoY3JlYXRlVGFyZ2V0ZWRDb250ZXh0 TWVudUhpbnRGb3JBY2l0aW9uU2hlZXRBc3Npc3RhbnQ6KV0pCisgICAgICAgIHJldHVybiBbZGVs ZWdhdGUgY3JlYXRlVGFyZ2V0ZWRDb250ZXh0TWVudUhpbnRGb3JBY2l0aW9uU2hlZXRBc3Npc3Rh bnQ6c2VsZl07CisgICAgCiAgICAgaWYgKFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNl bGVjdG9yKGNvbnRleHRNZW51UHJlc2VudGF0aW9uTG9jYXRpb25Gb3JBY3Rpb25TaGVldEFzc2lz dGFudDopXSkKICAgICAgICAgY2VudGVyID0gW2RlbGVnYXRlIGNvbnRleHRNZW51UHJlc2VudGF0 aW9uTG9jYXRpb25Gb3JBY3Rpb25TaGVldEFzc2lzdGFudDpzZWxmXTsKICAgICBSZXRhaW5QdHI8 VUlQcmV2aWV3UGFyYW1ldGVycz4gdW51c2VkUHJldmlld1BhcmFtZXRlcnMgPSBhZG9wdE5TKFtb VUlQcmV2aWV3UGFyYW1ldGVycyBhbGxvY10gaW5pdF0pOwogICAgIFJldGFpblB0cjxVSVByZXZp ZXdUYXJnZXQ+IHByZXZpZXdUYXJnZXQgPSBhZG9wdE5TKFtbVUlQcmV2aWV3VGFyZ2V0IGFsbG9j XSBpbml0V2l0aENvbnRhaW5lcjpfdmlldy5nZXRBdXRvcmVsZWFzZWQoKSBjZW50ZXI6Y2VudGVy XSk7CiAgICAgUmV0YWluUHRyPFVJVGFyZ2V0ZWRQcmV2aWV3PiBwcmV2aWV3ID0gYWRvcHROUyhb W1VJVGFyZ2V0ZWRQcmV2aWV3IGFsbG9jXSBpbml0V2l0aFZpZXc6X3ZpZXcuZ2V0QXV0b3JlbGVh c2VkKCkgcGFyYW1ldGVyczp1bnVzZWRQcmV2aWV3UGFyYW1ldGVycy5nZXQoKSB0YXJnZXQ6cHJl dmlld1RhcmdldC5nZXQoKV0pOwotCiAgICAgcmV0dXJuIHByZXZpZXcuYXV0b3JlbGVhc2UoKTsK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggZjA3YTdiMWIxYTgwMTM0OWQ0ZjkyZGFkZDY0Mzg4Mzlj ODFlYWI4Yy4uMWE1Y2RhOTFhYjFiOTBjODU2YTk1OGE2YTIwNGEwZThkNGE4NjYzOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tCkBAIC02ODk5LDYgKzY4OTksMTEgQEAgLSAoQ0dQb2ludCljb250ZXh0TWVudVBy ZXNlbnRhdGlvbkxvY2F0aW9uRm9yQWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXQK ICAgICByZXR1cm4gW3NlbGYgbGFzdEludGVyYWN0aW9uTG9jYXRpb25dOwogfQogCistIChVSVRh cmdldGVkUHJldmlldyAqKWNyZWF0ZVRhcmdldGVkQ29udGV4dE1lbnVIaW50Rm9yQWNpdGlvblNo ZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50Cit7CisgICAg cmV0dXJuIFtzZWxmIF9jcmVhdGVUYXJnZXRlZENvbnRleHRNZW51SGludFByZXZpZXdJZlBvc3Np YmxlXTsKK30KKwogLSAoQk9PTClfc2hvdWxkVXNlQ29udGV4dE1lbnVzCiB7CiAjaWYgSEFWRShM SU5LX1BSRVZJRVcpICYmIFVTRShVSUNPTlRFWFRNRU5VKQpAQCAtOTI2NCw5ICs5MjY5LDEyIEBA IC0gKHZvaWQpY29udGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9u ICopaW50ZXJhY3Rpb24gd2lsbEVuZEZvCiAgICAgICAgIC8vIGFuZCByZW1vdmluZyB0aGUgaGlu dCBjb250YWluZXIgdmlldyB3aWxsIGNhdXNlIHRoZSBhbmltYXRpb24gdG8gYnJlYWsuCiAgICAg ICAgIGlmIChzdHJvbmdTZWxmLT5fY29udGV4dE1lbnVFbGVtZW50SW5mbykKICAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgLy8gV2UgYXJlIGFsc28gdXNpbmcgdGhpcyBjb250YWluZXIgZm9y IHRoZSBmaWxlIHVwbG9hZCBwYW5lbAorICAgICAgICAvLyBXZSBhcmUgYWxzbyB1c2luZyB0aGlz IGNvbnRhaW5lciBmb3IgdGhlIGZpbGUgdXBsb2FkIHBhbmVsLi4uCiAgICAgICAgIGlmIChzdHJv bmdTZWxmLT5fZmlsZVVwbG9hZFBhbmVsKQogICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAv LyBhbmQgdGhlIGFjdGlvbiBzaGVldCBhc3Npc3RhbnQuCisgICAgICAgIGlmIChzdHJvbmdTZWxm LT5fYWN0aW9uU2hlZXRBc3Npc3RhbnQpCisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIFtz dGQ6OmV4Y2hhbmdlKHN0cm9uZ1NlbGYtPl9jb250ZXh0TWVudUhpbnRDb250YWluZXJWaWV3LCBu aWwpIHJlbW92ZUZyb21TdXBlcnZpZXddOwogICAgIH1dOwogfQo= 396552 2020-04-15 11:19:45 -0700 2020-04-15 12:57:15 -0700 Patch for landing bug-210531-20200415111944.patch text/plain 4877 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE3ZGViMWQ2ZmZjMDcwYjY5 ZDc5MzJhODNhZWYxYzNlYWQyY2YzZWUuLjQ3NmE5MzM1Mjg1ODE2NzA0ZjAzYzNmZjA3MDE2NDY5 ZDgzZjA5NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDQtMTQgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBEYXRhIERldGVjdGVk IEFjdGlvbnMgc2hlZXRzIGFyZSBwcmVzZW50ZWQgZnJvbSBvZGQgbG9jYXRpb25zLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNTMxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS82MDk0MTM0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24g SHNpZWguCisKKyAgICAgICAgVXNlIHRoZSBleGlzdGluZyBjb250ZXh0IG1lbnUgdGFyZ2V0ZWQg cHJldmlldyBjb2RlIHRvIGVuc3VyZSB0aGF0IHRoZQorICAgICAgICBkYXRhIGRldGVjdGVkIG1l bnVzIGFyZSBwcmVzZW50ZWQgaW4gYSBnb29kIGxvY2F0aW9uLgorCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lmg6CisgICAgICAgICogVUlQcm9jZXNzL2lv cy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tOgorICAgICAgICAoLVtXS0FjdGlvblNoZWV0QXNz aXN0YW50IGNvbnRleHRNZW51SW50ZXJhY3Rpb246cHJldmlld0ZvckhpZ2hsaWdodGluZ01lbnVX aXRoQ29uZmlndXJhdGlvbjpdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjb250ZXh0TWVudUlu dGVyYWN0aW9uOndpbGxFbmRGb3JDb25maWd1cmF0aW9uOmFuaW1hdG9yOl0pOgorCiAyMDIwLTA0 LTE0ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAg RmlsZSBVcGxvYWQgTWVudXMgcHJlc2VudGVkIGZyb20gb2RkIGxvY2F0aW9ucy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lmgg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5oCmlu ZGV4IDFkMzA5NDYzMGM4YTQ0ZTAwOWFlODcxMDk3NjRlZGRmOGQ1ZDk2NmMuLmYyMGQ5ZjQ5ZTNh Mzc5MjI2YjczOTRlMmEwN2JkNTJkOGY4ZmE2ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50LmgKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQuaApAQCAtNjMsNiArNjMsNyBA QCBzdHJ1Y3QgSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb247CiAtIChOU1N0cmluZyAq KXNlbGVjdGVkVGV4dEZvckFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0 YW50ICopYXNzaXN0YW50OwogLSAodm9pZClhY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25T aGVldEFzc2lzdGFudCAqKWFzc2lzdGFudCBnZXRBbHRlcm5hdGVVUkxGb3JJbWFnZTooVUlJbWFn ZSAqKWltYWdlIGNvbXBsZXRpb246KHZvaWQgKF4pKE5TVVJMICphbHRlcm5hdGVVUkwsIE5TRGlj dGlvbmFyeSAqdXNlckluZm8pKWNvbXBsZXRpb247CiAtIChDR1BvaW50KWNvbnRleHRNZW51UHJl c2VudGF0aW9uTG9jYXRpb25Gb3JBY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFz c2lzdGFudCAqKWFzc2lzdGFudDsKKy0gKFVJVGFyZ2V0ZWRQcmV2aWV3ICopY3JlYXRlVGFyZ2V0 ZWRDb250ZXh0TWVudUhpbnRGb3JBY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFz c2lzdGFudCAqKWFzc2lzdGFudDsKIAogQGVuZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbSBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCmluZGV4IDRlNWIwNWU0NTI4 YjhlYmI5Mjg0Nzk4M2RkNDQwYWE4MjNjODQxZDkuLjI5NjZiZDgzNmMxMjg5ZTdmYWE4ZjhiYTJm NjU3OTdkYTM4ZDRjNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9X S0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCkBAIC03NTIsMTIgKzc1MiwxNSBAQCAtIChVSVRh cmdldGVkUHJldmlldyAqKWNvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29udGV4dE1lbnVJbnRl cmFjdGlvbiAqKWludGVyYQogewogICAgIGF1dG8gZGVsZWdhdGUgPSBfZGVsZWdhdGUuZ2V0KCk7 CiAgICAgQ0dQb2ludCBjZW50ZXIgPSBDR1BvaW50WmVybzsKKyAgICAKKyAgICBpZiAoW2RlbGVn YXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoY3JlYXRlVGFyZ2V0ZWRDb250ZXh0TWVu dUhpbnRGb3JBY3Rpb25TaGVldEFzc2lzdGFudDopXSkKKyAgICAgICAgcmV0dXJuIFtkZWxlZ2F0 ZSBjcmVhdGVUYXJnZXRlZENvbnRleHRNZW51SGludEZvckFjdGlvblNoZWV0QXNzaXN0YW50OnNl bGZdOworICAgIAogICAgIGlmIChbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rv cihjb250ZXh0TWVudVByZXNlbnRhdGlvbkxvY2F0aW9uRm9yQWN0aW9uU2hlZXRBc3Npc3RhbnQ6 KV0pCiAgICAgICAgIGNlbnRlciA9IFtkZWxlZ2F0ZSBjb250ZXh0TWVudVByZXNlbnRhdGlvbkxv Y2F0aW9uRm9yQWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2VsZl07CiAgICAgUmV0YWluUHRyPFVJUHJl dmlld1BhcmFtZXRlcnM+IHVudXNlZFByZXZpZXdQYXJhbWV0ZXJzID0gYWRvcHROUyhbW1VJUHJl dmlld1BhcmFtZXRlcnMgYWxsb2NdIGluaXRdKTsKICAgICBSZXRhaW5QdHI8VUlQcmV2aWV3VGFy Z2V0PiBwcmV2aWV3VGFyZ2V0ID0gYWRvcHROUyhbW1VJUHJldmlld1RhcmdldCBhbGxvY10gaW5p dFdpdGhDb250YWluZXI6X3ZpZXcuZ2V0QXV0b3JlbGVhc2VkKCkgY2VudGVyOmNlbnRlcl0pOwog ICAgIFJldGFpblB0cjxVSVRhcmdldGVkUHJldmlldz4gcHJldmlldyA9IGFkb3B0TlMoW1tVSVRh cmdldGVkUHJldmlldyBhbGxvY10gaW5pdFdpdGhWaWV3Ol92aWV3LmdldEF1dG9yZWxlYXNlZCgp IHBhcmFtZXRlcnM6dW51c2VkUHJldmlld1BhcmFtZXRlcnMuZ2V0KCkgdGFyZ2V0OnByZXZpZXdU YXJnZXQuZ2V0KCldKTsKLQogICAgIHJldHVybiBwcmV2aWV3LmF1dG9yZWxlYXNlKCk7CiB9CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tCmluZGV4IGYwN2E3YjFiMWE4MDEzNDlkNGY5MmRhZGQ2NDM4ODM5YzgxZWFi OGMuLjdmZTlkZDNmN2NhOGJkMzM3NTY5N2NhMmNiY2I1ZmI2ZTA2NGYxODggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbQpAQCAtNjg5OSw2ICs2ODk5LDExIEBAIC0gKENHUG9pbnQpY29udGV4dE1lbnVQcmVzZW50 YXRpb25Mb2NhdGlvbkZvckFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0CiAgICAg cmV0dXJuIFtzZWxmIGxhc3RJbnRlcmFjdGlvbkxvY2F0aW9uXTsKIH0KIAorLSAoVUlUYXJnZXRl ZFByZXZpZXcgKiljcmVhdGVUYXJnZXRlZENvbnRleHRNZW51SGludEZvckFjdGlvblNoZWV0QXNz aXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50Cit7CisgICAgcmV0dXJu IFtzZWxmIF9jcmVhdGVUYXJnZXRlZENvbnRleHRNZW51SGludFByZXZpZXdJZlBvc3NpYmxlXTsK K30KKwogLSAoQk9PTClfc2hvdWxkVXNlQ29udGV4dE1lbnVzCiB7CiAjaWYgSEFWRShMSU5LX1BS RVZJRVcpICYmIFVTRShVSUNPTlRFWFRNRU5VKQpAQCAtOTI2NCw5ICs5MjY5LDEyIEBAIC0gKHZv aWQpY29udGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50 ZXJhY3Rpb24gd2lsbEVuZEZvCiAgICAgICAgIC8vIGFuZCByZW1vdmluZyB0aGUgaGludCBjb250 YWluZXIgdmlldyB3aWxsIGNhdXNlIHRoZSBhbmltYXRpb24gdG8gYnJlYWsuCiAgICAgICAgIGlm IChzdHJvbmdTZWxmLT5fY29udGV4dE1lbnVFbGVtZW50SW5mbykKICAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgLy8gV2UgYXJlIGFsc28gdXNpbmcgdGhpcyBjb250YWluZXIgZm9yIHRoZSBm aWxlIHVwbG9hZCBwYW5lbAorICAgICAgICAvLyBXZSBhcmUgYWxzbyB1c2luZyB0aGlzIGNvbnRh aW5lciBmb3IgdGhlIGZpbGUgdXBsb2FkIHBhbmVsLi4uCiAgICAgICAgIGlmIChzdHJvbmdTZWxm LT5fZmlsZVVwbG9hZFBhbmVsKQogICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAvLyBhbmQg dGhlIGFjdGlvbiBzaGVldCBhc3Npc3RhbnQuCisgICAgICAgIGlmIChzdHJvbmdTZWxmLT5fYWN0 aW9uU2hlZXRBc3Npc3RhbnQpCisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIFtzdGQ6OmV4 Y2hhbmdlKHN0cm9uZ1NlbGYtPl9jb250ZXh0TWVudUhpbnRDb250YWluZXJWaWV3LCBuaWwpIHJl bW92ZUZyb21TdXBlcnZpZXddOwogICAgIH1dOwogfQo=