210523 2020-04-14 16:43:07 -0700 File Upload Menus presented from odd locations. 2020-04-14 21:13:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton wenson_hsieh oldest_to_newest 1641600 0 megan_gardner 2020-04-14 16:43:07 -0700 File Upload Menus presented from odd locations. 1641601 1 396476 megan_gardner 2020-04-14 16:45:07 -0700 Created attachment 396476 Patch 1641602 2 megan_gardner 2020-04-14 16:46:08 -0700 <rdar://problem/60390846> 1641607 3 wenson_hsieh 2020-04-14 16:53:47 -0700 Approach seems reasonable to me, but please test that presenting a context menu and then immediately tapping on a file picker (and vice versa) doesn’t break. We’ve had recent bugs where reusing preview containers for context menu/drag and drop have caused animation glitches. 1641618 4 396482 megan_gardner 2020-04-14 17:31:35 -0700 Created attachment 396482 Patch 1641667 5 ews-feeder 2020-04-14 21:13:51 -0700 Committed r260116: <https://trac.webkit.org/changeset/260116> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396482. 396476 2020-04-14 16:45:07 -0700 2020-04-14 17:31:34 -0700 Patch bug-210523-20200414164506.patch text/plain 3057 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMxYTEyN2VjZmIxOTA5NjZi ZWY2NzQwMjNhYWU4MDAwZjBlN2JlMjcuLjkwZGJiZTQwYmE2OTUxNjVjMGY2NDJmNDFmNjAwYWRj ZjkxYTA0OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDQtMTQgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaWxlIFVwbG9hZCBN ZW51cyBwcmVzZW50ZWQgZnJvbSBvZGQgbG9jYXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNTIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS82MDM5MDg0Nj4KKworICAgICAgICBVc2UgdGhlIGV4aXN0aW5nIGNvbnRleHQgbWVudSB0YXJn ZXRlZCBwcmV2aWV3IGNvZGUgdG8gZW5zdXJlIHRoYXQgdGhlCisgICAgICAgIGZpbGUgbWVudXMg YXJlIHByZXNlbnRlZCBpbiBhIGdvb2QgbG9jYXRpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2Fk UGFuZWwubW06CisgICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVsIGNvbnRleHRNZW51SW50ZXJh Y3Rpb246cHJldmlld0ZvckhpZ2hsaWdodGluZ01lbnVXaXRoQ29uZmlndXJhdGlvbjpdKToKKwog MjAyMC0wNC0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg RG8gbm90IHByb2Nlc3MgUlRDIE5ldHdvcmsgbWVzc2FnZXMgY29taW5nIGZyb20gTmV0d29ya1By b2Nlc3MgaWYgTGliV2ViUlRDTmV0d29yayBpcyBub3QgYWN0aXZlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmggYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKaW5kZXgg YmVjYTc2NmYxMWI5YmQzOGY0YTA2OGE1ZDFhNzg0NDliZTA3YjVjZS4uMjdjOWMyNTZkZGNlNTAx YjY5ODVjOGZiYmU5ZGNiMjdkMDMyZDcyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaApAQCAtNjEwLDYgKzYxMCw3 IEBAIEZPUl9FQUNIX1BSSVZBVEVfV0tDT05URU5UVklFV19BQ1RJT04oREVDTEFSRV9XS0NPTlRF TlRWSUVXX0FDVElPTl9GT1JfV0VCX1ZJRVcpCiAjZWxzZQogQGludGVyZmFjZSBXS0NvbnRlbnRW aWV3IChXS0ludGVyYWN0aW9uUHJldmlldykgPFVJUHJldmlld0l0ZW1EZWxlZ2F0ZT4KICNlbmRp ZgorLSAoVUlUYXJnZXRlZFByZXZpZXcgKilfY3JlYXRlVGFyZ2V0ZWRDb250ZXh0TWVudUhpbnRQ cmV2aWV3SWZQb3NzaWJsZTsKIC0gKHZvaWQpX3JlZ2lzdGVyUHJldmlldzsKIC0gKHZvaWQpX3Vu cmVnaXN0ZXJQcmV2aWV3OwogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCmluZGV4IGQ4YjMwMDZiNWQwMTkyYjAw OWMzZGFmMWUxZmIwNWZlNWFkZjgwMGYuLjBlYjk5YjBkM2I0ZTcwOTFmNWRiM2EzMDZjZjY1MjFj ZDIwMjYwOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9X S0ZpbGVVcGxvYWRQYW5lbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9y bXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KQEAgLTQxMCwxMSArNDEwLDcgQEAgLSAoTlNTdHJpbmcg KilfY2FtZXJhQnV0dG9uTGFiZWxBbGxvd2luZ1Bob3RvOihCT09MKWFsbG93UGhvdG8gYWxsb3dp bmdWaWRlbzooQk8KIAogLSAoVUlUYXJnZXRlZFByZXZpZXcgKiljb250ZXh0TWVudUludGVyYWN0 aW9uOihVSUNvbnRleHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBwcmV2aWV3Rm9ySGln aGxpZ2h0aW5nTWVudVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlv biAqKWNvbmZpZ3VyYXRpb24KIHsKLSAgICBSZXRhaW5QdHI8VUlQcmV2aWV3UGFyYW1ldGVycz4g dW51c2VkUHJldmlld1BhcmFtZXRlcnMgPSBhZG9wdE5TKFtbVUlQcmV2aWV3UGFyYW1ldGVycyBh bGxvY10gaW5pdF0pOwotICAgIFJldGFpblB0cjxVSVByZXZpZXdUYXJnZXQ+IHByZXZpZXdUYXJn ZXQgPSBhZG9wdE5TKFtbVUlQcmV2aWV3VGFyZ2V0IGFsbG9jXSBpbml0V2l0aENvbnRhaW5lcjpf dmlldy5nZXRBdXRvcmVsZWFzZWQoKSBjZW50ZXI6Q0dQb2ludE1ha2UoX2ludGVyYWN0aW9uUG9p bnQueCwgX2ludGVyYWN0aW9uUG9pbnQueSldKTsKLSAgICBSZXRhaW5QdHI8VUlUYXJnZXRlZFBy ZXZpZXc+IHByZXZpZXcgPSBhZG9wdE5TKFtbVUlUYXJnZXRlZFByZXZpZXcgYWxsb2NdIGluaXRX aXRoVmlldzpfdmlldy5nZXRBdXRvcmVsZWFzZWQoKSBwYXJhbWV0ZXJzOnVudXNlZFByZXZpZXdQ YXJhbWV0ZXJzLmdldCgpIHRhcmdldDpwcmV2aWV3VGFyZ2V0LmdldCgpXSk7Ci0KLSAgICByZXR1 cm4gcHJldmlldy5hdXRvcmVsZWFzZSgpOworICAgIHJldHVybiBbX3ZpZXcgX2NyZWF0ZVRhcmdl dGVkQ29udGV4dE1lbnVIaW50UHJldmlld0lmUG9zc2libGVdOwogfQogCiAtIChfVUlDb250ZXh0 TWVudVN0eWxlICopX2NvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29udGV4dE1lbnVJbnRlcmFj dGlvbiAqKWludGVyYWN0aW9uIHN0eWxlRm9yTWVudVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRl eHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24K 396482 2020-04-14 17:31:35 -0700 2020-04-14 21:13:51 -0700 Patch bug-210523-20200414173134.patch text/plain 3903 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMxYTEyN2VjZmIxOTA5NjZi ZWY2NzQwMjNhYWU4MDAwZjBlN2JlMjcuLjkwZGJiZTQwYmE2OTUxNjVjMGY2NDJmNDFmNjAwYWRj ZjkxYTA0OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDQtMTQgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaWxlIFVwbG9hZCBN ZW51cyBwcmVzZW50ZWQgZnJvbSBvZGQgbG9jYXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNTIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS82MDM5MDg0Nj4KKworICAgICAgICBVc2UgdGhlIGV4aXN0aW5nIGNvbnRleHQgbWVudSB0YXJn ZXRlZCBwcmV2aWV3IGNvZGUgdG8gZW5zdXJlIHRoYXQgdGhlCisgICAgICAgIGZpbGUgbWVudXMg YXJlIHByZXNlbnRlZCBpbiBhIGdvb2QgbG9jYXRpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2Fk UGFuZWwubW06CisgICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVsIGNvbnRleHRNZW51SW50ZXJh Y3Rpb246cHJldmlld0ZvckhpZ2hsaWdodGluZ01lbnVXaXRoQ29uZmlndXJhdGlvbjpdKToKKwog MjAyMC0wNC0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg RG8gbm90IHByb2Nlc3MgUlRDIE5ldHdvcmsgbWVzc2FnZXMgY29taW5nIGZyb20gTmV0d29ya1By b2Nlc3MgaWYgTGliV2ViUlRDTmV0d29yayBpcyBub3QgYWN0aXZlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmggYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKaW5kZXgg YmVjYTc2NmYxMWI5YmQzOGY0YTA2OGE1ZDFhNzg0NDliZTA3YjVjZS4uMjdjOWMyNTZkZGNlNTAx YjY5ODVjOGZiYmU5ZGNiMjdkMDMyZDcyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaApAQCAtNjEwLDYgKzYxMCw3 IEBAIEZPUl9FQUNIX1BSSVZBVEVfV0tDT05URU5UVklFV19BQ1RJT04oREVDTEFSRV9XS0NPTlRF TlRWSUVXX0FDVElPTl9GT1JfV0VCX1ZJRVcpCiAjZWxzZQogQGludGVyZmFjZSBXS0NvbnRlbnRW aWV3IChXS0ludGVyYWN0aW9uUHJldmlldykgPFVJUHJldmlld0l0ZW1EZWxlZ2F0ZT4KICNlbmRp ZgorLSAoVUlUYXJnZXRlZFByZXZpZXcgKilfY3JlYXRlVGFyZ2V0ZWRDb250ZXh0TWVudUhpbnRQ cmV2aWV3SWZQb3NzaWJsZTsKIC0gKHZvaWQpX3JlZ2lzdGVyUHJldmlldzsKIC0gKHZvaWQpX3Vu cmVnaXN0ZXJQcmV2aWV3OwogQGVuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggZThhZDE5MzhlNjJhMGU0 MGVhNTk1ZDc0ODRkMWY5MzU2Y2RkMDkxNy4uNDNiNjMzODJiZmFhMjhiNjgwYmFjNzZiNDVjMzMz MGYyMDY5MWE4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC05MjYzLDYgKzkyNjMsOSBAQCAtICh2b2lk KWNvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVy YWN0aW9uIHdpbGxFbmRGbwogICAgICAgICAvLyBhbmQgcmVtb3ZpbmcgdGhlIGhpbnQgY29udGFp bmVyIHZpZXcgd2lsbCBjYXVzZSB0aGUgYW5pbWF0aW9uIHRvIGJyZWFrLgogICAgICAgICBpZiAo c3Ryb25nU2VsZi0+X2NvbnRleHRNZW51RWxlbWVudEluZm8pCiAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIC8vIFdlIGFyZSBhbHNvIHVzaW5nIHRoaXMgY29udGFpbmVyIGZvciB0aGUgZmls ZSB1cGxvYWQgcGFuZWwKKyAgICAgICAgaWYgKHN0cm9uZ1NlbGYtPl9maWxlVXBsb2FkUGFuZWwp CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIFtzdGQ6OmV4Y2hhbmdlKHN0cm9uZ1NlbGYt Pl9jb250ZXh0TWVudUhpbnRDb250YWluZXJWaWV3LCBuaWwpIHJlbW92ZUZyb21TdXBlcnZpZXdd OwogICAgIH1dOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zv cm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zv cm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCmluZGV4IGQ4YjMwMDZiNWQwMTkyYjAwOWMzZGFmMWUx ZmIwNWZlNWFkZjgwMGYuLjBlYjk5YjBkM2I0ZTcwOTFmNWRiM2EzMDZjZjY1MjFjZDIwMjYwOWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxv YWRQYW5lbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxl VXBsb2FkUGFuZWwubW0KQEAgLTQxMCwxMSArNDEwLDcgQEAgLSAoTlNTdHJpbmcgKilfY2FtZXJh QnV0dG9uTGFiZWxBbGxvd2luZ1Bob3RvOihCT09MKWFsbG93UGhvdG8gYWxsb3dpbmdWaWRlbzoo Qk8KIAogLSAoVUlUYXJnZXRlZFByZXZpZXcgKiljb250ZXh0TWVudUludGVyYWN0aW9uOihVSUNv bnRleHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBwcmV2aWV3Rm9ySGlnaGxpZ2h0aW5n TWVudVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZp Z3VyYXRpb24KIHsKLSAgICBSZXRhaW5QdHI8VUlQcmV2aWV3UGFyYW1ldGVycz4gdW51c2VkUHJl dmlld1BhcmFtZXRlcnMgPSBhZG9wdE5TKFtbVUlQcmV2aWV3UGFyYW1ldGVycyBhbGxvY10gaW5p dF0pOwotICAgIFJldGFpblB0cjxVSVByZXZpZXdUYXJnZXQ+IHByZXZpZXdUYXJnZXQgPSBhZG9w dE5TKFtbVUlQcmV2aWV3VGFyZ2V0IGFsbG9jXSBpbml0V2l0aENvbnRhaW5lcjpfdmlldy5nZXRB dXRvcmVsZWFzZWQoKSBjZW50ZXI6Q0dQb2ludE1ha2UoX2ludGVyYWN0aW9uUG9pbnQueCwgX2lu dGVyYWN0aW9uUG9pbnQueSldKTsKLSAgICBSZXRhaW5QdHI8VUlUYXJnZXRlZFByZXZpZXc+IHBy ZXZpZXcgPSBhZG9wdE5TKFtbVUlUYXJnZXRlZFByZXZpZXcgYWxsb2NdIGluaXRXaXRoVmlldzpf dmlldy5nZXRBdXRvcmVsZWFzZWQoKSBwYXJhbWV0ZXJzOnVudXNlZFByZXZpZXdQYXJhbWV0ZXJz LmdldCgpIHRhcmdldDpwcmV2aWV3VGFyZ2V0LmdldCgpXSk7Ci0KLSAgICByZXR1cm4gcHJldmll dy5hdXRvcmVsZWFzZSgpOworICAgIHJldHVybiBbX3ZpZXcgX2NyZWF0ZVRhcmdldGVkQ29udGV4 dE1lbnVIaW50UHJldmlld0lmUG9zc2libGVdOwogfQogCiAtIChfVUlDb250ZXh0TWVudVN0eWxl ICopX2NvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWlu dGVyYWN0aW9uIHN0eWxlRm9yTWVudVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51Q29u ZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24K