210519 2020-04-14 15:48:08 -0700 Use CFArrayGetValues() in createArchiveList() in WebCoreArgumentCodersMac.mm 2020-04-14 18:09:15 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210456 InRadar P2 Normal --- 210448 1 ddkilzer ddkilzer darin webkit-bug-importer oldest_to_newest 1641578 0 ddkilzer 2020-04-14 15:48:08 -0700 Use CFArrayGetValues() in createArchiveList() in WebCoreArgumentCodersMac.mm. Via Darin Adler in Bug 210448, Comment #4: Separately, I suggest we rewrite this using CFArrayGetValues, rather than calling CFArrayGetValueAtIndex over and over again in a loop. We will still have to loop over the buffer to convert tokenNull into nullptr, but it should be more efficient to do it that way rather than call CFArrayGetValueAtIndex over and over again. 1641589 1 396472 ddkilzer 2020-04-14 16:07:45 -0700 Created attachment 396472 Patch v1 1641594 2 396472 darin 2020-04-14 16:23:54 -0700 Comment on attachment 396472 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396472&action=review > Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:127 > + for (size_t i = 0; i < static_cast<size_t>(*objectCount); ++i) { This line should not have been changed. There’s no reason to cast this just so we can use a different type for the loop. CFIndex is fine. 1641630 3 396472 ddkilzer 2020-04-14 18:04:16 -0700 Comment on attachment 396472 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=396472&action=review >> Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:127 >> + for (size_t i = 0; i < static_cast<size_t>(*objectCount); ++i) { > > This line should not have been changed. There’s no reason to cast this just so we can use a different type for the loop. CFIndex is fine. Will change back. I seem to recall there's a clang warning about using a signed type for an array index, which is why I changed it. 1641632 4 ddkilzer 2020-04-14 18:08:51 -0700 Committed r260111: <https://trac.webkit.org/changeset/260111> 1641633 5 webkit-bug-importer 2020-04-14 18:09:15 -0700 <rdar://problem/61800359> 396472 2020-04-14 16:07:45 -0700 2020-04-14 16:23:54 -0700 Patch v1 bug-210519-20200414160844.patch text/plain 1867 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU4YjI5YmQ4ZmZiOWY1NzQ1 ZGViZjkzYTQ5ODM1MzU3ZDQ3YmEwYzMuLjdkMzU5MjAyMzAwOWY4YzQ1MjQ3ZmRjYTAxOWNjMTRj ZDQ3YWQyMTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMTQgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgQ0ZBcnJheUdldFZhbHVl cygpIGluIGNyZWF0ZUFyY2hpdmVMaXN0KCkgaW4gV2ViQ29yZUFyZ3VtZW50Q29kZXJzTWFjLm1t CisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMTA1MTk+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvbWFjL1dlYkNvcmVBcmd1 bWVudENvZGVyc01hYy5tbToKKyAgICAgICAgKElQQzo6Y3JlYXRlQXJjaGl2ZUxpc3QpOgorICAg ICAgICAtIFVzZSBDRkFycmF5R2V0VmFsdWVzKCkgdG8gY29weSBhcnJheSBtb3JlIGVmZmljaWVu dGx5LgorICAgICAgICAtIFVzZSBzaXplX3QgdHlwZSBmb3IgaWRvbWF0aWMgYXJyYXkgaW5kZXgg dmFsdWVzLgorCiAyMDIwLTA0LTE0ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CiAKICAgICAgICAgY3JlYXRlQXJjaGl2ZUxpc3QoKSBpbiBXZWJDb3JlQXJndW1lbnRDb2RlcnNN YWMubW0gc2hvdWxkIGRvIG1vcmUgdmFsaWRpdHkgY2hlY2tzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9tYWMvV2ViQ29yZUFyZ3VtZW50Q29kZXJzTWFjLm1tIGIvU291cmNlL1dl YktpdC9TaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVyc01hYy5tbQppbmRleCA5MjZhNTMx OWEzMGM1ZDY0NmRjY2EwMDk1YWZiY2U1M2Y4OGMzZTcwLi42YTQwMDM0YTU2NWMyN2Y5ZWRkZGNl NTdmOGVjZmVmMjU0ZjgwNTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9tYWMv V2ViQ29yZUFyZ3VtZW50Q29kZXJzTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21h Yy9XZWJDb3JlQXJndW1lbnRDb2RlcnNNYWMubW0KQEAgLTEyMywxMiArMTIzLDEwIEBAIHN0YXRp YyBib29sIGNyZWF0ZUFyY2hpdmVMaXN0KENGRGljdGlvbmFyeVJlZiByZXByZXNlbnRhdGlvbiwg Q0ZUeXBlUmVmIHRva2VuTnVsCiAgICAgKm9iamVjdENvdW50ID0gYXJjaGl2ZUxpc3RBcnJheUNv dW50OwogICAgICpvYmplY3RzID0gc3RhdGljX2Nhc3Q8Q0ZUeXBlUmVmKj4obWFsbG9jKGJ1ZmZl clNpemUudW5zYWZlR2V0KCkpKTsKIAotICAgIGZvciAoQ0ZJbmRleCBpID0gMDsgaSA8ICpvYmpl Y3RDb3VudDsgKytpKSB7Ci0gICAgICAgIENGVHlwZVJlZiBvYmplY3QgPSBDRkFycmF5R2V0VmFs dWVBdEluZGV4KGFyY2hpdmVMaXN0QXJyYXksIGkpOwotICAgICAgICBpZiAob2JqZWN0ID09IHRv a2VuTnVsbCkKKyAgICBDRkFycmF5R2V0VmFsdWVzKGFyY2hpdmVMaXN0QXJyYXksIENGUmFuZ2VN YWtlKDAsICpvYmplY3RDb3VudCksICpvYmplY3RzKTsKKyAgICBmb3IgKHNpemVfdCBpID0gMDsg aSA8IHN0YXRpY19jYXN0PHNpemVfdD4oKm9iamVjdENvdW50KTsgKytpKSB7CisgICAgICAgIGlm ICgoKm9iamVjdHMpW2ldID09IHRva2VuTnVsbCkKICAgICAgICAgICAgICgqb2JqZWN0cylbaV0g PSBudWxscHRyOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICAoKm9iamVjdHMpW2ldID0gb2Jq ZWN0OwogICAgIH0KIAogICAgIGlmIChwcm90b2NvbFByb3BlcnRpZXMpCg==