210470 2020-04-13 18:18:50 -0700 REGRESSION (r259587): bterlson/eshost throws during init in strict mode 2020-04-13 20:06:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187526 InRadar P2 Minor --- 1 ashvayka ashvayka darin ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1641205 0 ashvayka 2020-04-13 18:18:50 -0700 bterlson/eshost is used by bterlson/test262-harness, which is used by https://test262.report. As of r259587, JSC fails all tests in strict mode. During init, bterlson/eshost does `$262.IsHTMLDDA = function() {...}`, which causes TypeError because "IsHTMLDDA" property has no setter. 1641211 1 396369 ashvayka 2020-04-13 18:33:18 -0700 Created attachment 396369 Patch 1641217 2 396369 ross.kirsling 2020-04-13 18:54:44 -0700 Comment on attachment 396369 Patch Holy cow, good work. I was having a hell of a time trying to track down where this was coming from myself. 1641224 3 ews-feeder 2020-04-13 20:05:27 -0700 Committed r260057: <https://trac.webkit.org/changeset/260057> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396369. 1641225 4 webkit-bug-importer 2020-04-13 20:06:14 -0700 <rdar://problem/61752521> 396369 2020-04-13 18:33:18 -0700 2020-04-13 20:05:28 -0700 Patch bug-210470-20200414043316.patch text/plain 3360 ashvayka SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYwMDUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDIwLTA0LTEzICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OIChyMjU5NTg3KTogYnRlcmxzb24vZXNob3N0IHRocm93cyBkdXJp bmcgaW5pdCBpbiBzdHJpY3QgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEwNDcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgbWFrZXMgJDI2Mi5Jc0hUTUxEREEgb2YgSlNDIHNo ZWxsIGEgQ3VzdG9tVmFsdWUsIGFsbG93aW5nIGl0IHRvIGJlIHJlYXNzaWduZWQKKyAgICAgICAg YW5kIHJlc3RvcmluZyBjb21wYXRpYmlsaXR5IHdpdGggYW55IHZlcnNpb24gb2YgaHR0cHM6Ly9n aXRodWIuY29tL2J0ZXJsc29uL2VzaG9zdC4KKworICAgICAgICBTaW5jZSBwdXREaXJlY3RDdXN0 b21BY2Nlc3NvcigpIGlzIG5vdyB1c2VkIGluc3RlYWQgb2YgcHV0R2V0dGVyKCksIHNjb3BlIGV4 Y2VwdGlvbiBhc3NlcnQKKyAgICAgICAgaXMgbm8gbG9uZ2VyIG5lZWRlZCBhbmQgY2FuIGJlIHNh ZmVseSByZW1vdmVkLCBhcyB3ZWxsIGFzIEpTT2JqZWN0OjpwdXRHZXR0ZXIoKSBleHBvcnQuCisK KyAgICAgICAgKiBqc2MuY3BwOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKwogMjAy MC0wNC0xMCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBb WUFSUl0gQWxsb3cgZm9yIFVuaWNvZGUgbmFtZWQgY2FwdHVyZSBncm91cCBpZGVudGlmaWVycyBp biBub24tVW5pY29kZSByZWd1bGFyIGV4cHJlc3Npb25zCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvanNjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNw cAkocmV2aXNpb24gMjYwMDAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ4Niw3ICs0ODYsNiBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAg dm9pZCBmaW5pc2hDcmVhdGlvbihWTSYgdm0sIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBhcmd1bWVu dHMpCiAgICAgewotICAgICAgICBhdXRvIGNhdGNoU2NvcGUgPSBERUNMQVJFX0NBVENIX1NDT1BF KHZtKTsKICAgICAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24odm0pOwogCiAgICAgICAgIGFkZEZ1 bmN0aW9uKHZtLCAiZGVidWciLCBmdW5jdGlvbkRlYnVnLCAxKTsKQEAgLTU5NywxMCArNTk2LDEy IEBAIHByb3RlY3RlZDoKICAgICAgICAgYWRkRnVuY3Rpb24odm0sIGRvbGxhciwgImV2YWxTY3Jp cHQiLCBmdW5jdGlvbkRvbGxhckV2YWxTY3JpcHQsIDEpOwogICAgICAgICAKICAgICAgICAgZG9s bGFyLT5wdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJnbG9iYWwiKSwg dGhpcyk7Ci0KLSAgICAgICAgSlNGdW5jdGlvbiogSXNIVE1MRERBR2V0dGVyID0gSlNGdW5jdGlv bjo6Y3JlYXRlKHZtLCB0aGlzLCAwLCAiSXNIVE1MRERBIl9zLCBmdW5jdGlvbk1ha2VNYXNxdWVy YWRlcik7Ci0gICAgICAgIGRvbGxhci0+cHV0R2V0dGVyKHRoaXMsIElkZW50aWZpZXI6OmZyb21T dHJpbmcodm0sICJJc0hUTUxEREEiKSwgSXNIVE1MRERBR2V0dGVyLCBzdGF0aWNfY2FzdDx1bnNp Z25lZD4oUHJvcGVydHlBdHRyaWJ1dGU6OkFjY2Vzc29yKSk7Ci0gICAgICAgIGNhdGNoU2NvcGUu cmVsZWFzZUFzc2VydE5vRXhjZXB0aW9uKCk7CisgICAgICAgIGRvbGxhci0+cHV0RGlyZWN0Q3Vz dG9tQWNjZXNzb3Iodm0sIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJJc0hUTUxEREEiKSwK KyAgICAgICAgICAgIEN1c3RvbUdldHRlclNldHRlcjo6Y3JlYXRlKHZtLCBbXShKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0LCBFbmNvZGVkSlNWYWx1ZSwgUHJvcGVydHlOYW1lKSB7CisgICAg ICAgICAgICAgICAgcmV0dXJuIGZ1bmN0aW9uTWFrZU1hc3F1ZXJhZGVyKGdsb2JhbE9iamVjdCwg bnVsbHB0cik7CisgICAgICAgICAgICB9LCBudWxscHRyKSwKKyAgICAgICAgICAgIHN0YXRpY19j YXN0PHVuc2lnbmVkPihQcm9wZXJ0eUF0dHJpYnV0ZTo6Q3VzdG9tVmFsdWUpCisgICAgICAgICk7 CiAKICAgICAgICAgSlNPYmplY3QqIGFnZW50ID0gSlNGaW5hbE9iamVjdDo6Y3JlYXRlKHZtLCBw bGFpbk9iamVjdFN0cnVjdHVyZSk7CiAgICAgICAgIGRvbGxhci0+cHV0RGlyZWN0KHZtLCBJZGVu dGlmaWVyOjpmcm9tU3RyaW5nKHZtLCAiYWdlbnQiKSwgYWdlbnQpOwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCShyZXZpc2lvbiAyNjAwMDMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC02 MDcsNyArNjA3LDcgQEAgcHVibGljOgogICAgIGJvb2wgcHV0RGlyZWN0QWNjZXNzb3IoSlNHbG9i YWxPYmplY3QqLCBQcm9wZXJ0eU5hbWUsIEdldHRlclNldHRlciosIHVuc2lnbmVkIGF0dHJpYnV0 ZXMpOwogICAgIEpTX0VYUE9SVF9QUklWQVRFIGJvb2wgcHV0RGlyZWN0Q3VzdG9tQWNjZXNzb3Io Vk0mLCBQcm9wZXJ0eU5hbWUsIEpTVmFsdWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMpOwogCi0gICAg SlNfRVhQT1JUX1BSSVZBVEUgYm9vbCBwdXRHZXR0ZXIoSlNHbG9iYWxPYmplY3QqLCBQcm9wZXJ0 eU5hbWUsIEpTVmFsdWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMpOworICAgIGJvb2wgcHV0R2V0dGVy KEpTR2xvYmFsT2JqZWN0KiwgUHJvcGVydHlOYW1lLCBKU1ZhbHVlLCB1bnNpZ25lZCBhdHRyaWJ1 dGVzKTsKICAgICBib29sIHB1dFNldHRlcihKU0dsb2JhbE9iamVjdCosIFByb3BlcnR5TmFtZSwg SlNWYWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcyk7CiAKICAgICBKU19FWFBPUlRfUFJJVkFURSBi b29sIGhhc1Byb3BlcnR5KEpTR2xvYmFsT2JqZWN0KiwgUHJvcGVydHlOYW1lKSBjb25zdDsK