210467 2020-04-13 16:53:59 -0700 YouTube sometimes navigates unexpectedly when invoking a context menu on a video link. 2020-04-14 09:38:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton wenson_hsieh oldest_to_newest 1641177 0 megan_gardner 2020-04-13 16:53:59 -0700 WebTouchEvents not cancelled soon enough in the life of a ContextMenu Gesture, causing TouchEvents and ContextMenus to fire at the same time. 1641178 1 396358 megan_gardner 2020-04-13 16:57:43 -0700 Created attachment 396358 Patch 1641179 2 megan_gardner 2020-04-13 16:58:48 -0700 <rdar://problem/58841584> 1641181 3 396358 thorton 2020-04-13 17:03:26 -0700 Comment on attachment 396358 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396358&action=review At all possible to test? > Source/WebKit/ChangeLog:3 > + TouchEvents not cancelled soon enough in the life of a ContextMenu Gesture, causing TouchEvents and ContextMenus to fire at the same time. How about "YouTube sometimes navigates unexpectedly when invoking a context menu on a video link" for the title. > Source/WebKit/ChangeLog:9 > + We need to cancel the touch events gesture when we are cleaing out things to make way for the ContextMenu Gesture and related events. And some more words here. And no "cleaing out things". Maybe something like: "Cancel any outstanding touches tracked by WebTouchEventsGestureRecognizer, so that we dispatch `touchcancel` to the page instead of `touchend`, so that the page does not misinterpret context menu invocation as a tap." 1641187 4 396362 megan_gardner 2020-04-13 17:11:14 -0700 Created attachment 396362 Patch 1641398 5 396425 megan_gardner 2020-04-14 09:15:58 -0700 Created attachment 396425 Patch for landing 1641416 6 ews-feeder 2020-04-14 09:38:55 -0700 Committed r260077: <https://trac.webkit.org/changeset/260077> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396425. 396358 2020-04-13 16:57:43 -0700 2020-04-14 09:15:55 -0700 Patch bug-210467-20200413165742.patch text/plain 1850 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI2ODZhZDdlY2I2MTFhZTQy NjdiYjYyMmZmMmE5MTcxYTg4ZTliYjYuLjNkMjM0ODY5MDgxZWIwMDI5YmVjZTlmOWU1OWI5Mzhi N2MwZjVmNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDQtMTMgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBUb3VjaEV2ZW50cyBu b3QgY2FuY2VsbGVkIHNvb24gZW5vdWdoIGluIHRoZSBsaWZlIG9mIGEgQ29udGV4dE1lbnUgR2Vz dHVyZSwgY2F1c2luZyBUb3VjaEV2ZW50cyBhbmQgQ29udGV4dE1lbnVzIHRvIGZpcmUgYXQgdGhl IHNhbWUgdGltZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMDQ2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg4NDE1ODQ+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBjYW5jZWwg dGhlIHRvdWNoIGV2ZW50cyBnZXN0dXJlIHdoZW4gd2UgYXJlIGNsZWFpbmcgb3V0IHRoaW5ncyB0 byBtYWtlIHdheSBmb3IgdGhlIENvbnRleHRNZW51IEdlc3R1cmUgYW5kIHJlbGF0ZWQgZXZlbnRz LgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06 CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgY29udGV4dE1lbnVJbnRlcmFjdGlvbjpwcmV2aWV3 Rm9ySGlnaGxpZ2h0aW5nTWVudVdpdGhDb25maWd1cmF0aW9uOl0pOgorCiAyMDIwLTA0LTEwICBQ ZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBZGQg cm91dGluZXMgdG8gbWVzc2FnZSBmaWx0ZXIgaW4gdGhlIFdlYkNvbnRlbnQgc2FuZGJveApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW0KaW5kZXggMGViMDhhOTA2ZjExZmM4NzAyMmY4NDI3ZGJiNGMxN2UwMTBiYWM3NS4u NTBhNjRkOTc4YzRlZGJlZWRkYjRkZDA5MzE4MGYxMjc4NGIyNWI3ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CkBAIC05MDQ5LDYgKzkwNDksNyBAQCAtIChVSVRhcmdldGVkUHJldmlldyAqKV9jcmVhdGVUYXJn ZXRlZENvbnRleHRNZW51SGludFByZXZpZXdJZlBvc3NpYmxlCiAtIChVSVRhcmdldGVkUHJldmll dyAqKWNvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWlu dGVyYWN0aW9uIHByZXZpZXdGb3JIaWdobGlnaHRpbmdNZW51V2l0aENvbmZpZ3VyYXRpb246KFVJ Q29udGV4dE1lbnVDb25maWd1cmF0aW9uICopY29uZmlndXJhdGlvbgogewogICAgIFtzZWxmIF9z dGFydFN1cHByZXNzaW5nU2VsZWN0aW9uQXNzaXN0YW50Rm9yUmVhc29uOldlYktpdDo6SW50ZXJh Y3Rpb25Jc0hhcHBlbmluZ107CisgICAgW3NlbGYgX2NhbmNlbFRvdWNoRXZlbnRHZXN0dXJlUmVj b2duaXplcl07CiAgICAgcmV0dXJuIFtzZWxmIF9jcmVhdGVUYXJnZXRlZENvbnRleHRNZW51SGlu dFByZXZpZXdJZlBvc3NpYmxlXTsKIH0KIAo= 396362 2020-04-13 17:11:14 -0700 2020-04-14 09:15:56 -0700 Patch bug-210467-20200413171113.patch text/plain 1900 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI2ODZhZDdlY2I2MTFhZTQy NjdiYjYyMmZmMmE5MTcxYTg4ZTliYjYuLjdhMzQzOGZjYjYwOTBkMTU4N2FjZGM2ZjY2N2JjZTgy ZTY4NDhkN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDQtMTMgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBZb3VUdWJlIHNvbWV0 aW1lcyBuYXZpZ2F0ZXMgdW5leHBlY3RlZGx5IHdoZW4gaW52b2tpbmcgYSBjb250ZXh0IG1lbnUg b24gYSB2aWRlbyBsaW5rLiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMDQ2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg4NDE1ODQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FuY2VsIGFueSBv dXRzdGFuZGluZyB0b3VjaGVzIHRyYWNrZWQgYnkgV2ViVG91Y2hFdmVudHNHZXN0dXJlUmVjb2du aXplciwgc28gdGhhdCB3ZSBkaXNwYXRjaAorICAgICAgICBgdG91Y2hjYW5jZWxgIHRvIHRoZSBw YWdlIGluc3RlYWQgb2YgYHRvdWNoZW5kYCwgc28gdGhhdCB0aGUgcGFnZSBkb2VzIG5vdCBtaXNp bnRlcnByZXQKKyAgICAgICAgY29udGV4dCBtZW51IGludm9jYXRpb24gYXMgYSB0YXAuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAg ICAgKC1bV0tDb250ZW50VmlldyBjb250ZXh0TWVudUludGVyYWN0aW9uOnByZXZpZXdGb3JIaWdo bGlnaHRpbmdNZW51V2l0aENvbmZpZ3VyYXRpb246XSk6CisKIDIwMjAtMDQtMTAgIFBlciBBcm5l IFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFkZCByb3V0aW5l cyB0byBtZXNzYWdlIGZpbHRlciBpbiB0aGUgV2ViQ29udGVudCBzYW5kYm94CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQppbmRleCAwZWIwOGE5MDZmMTFmYzg3MDIyZjg0MjdkYmI0YzE3ZTAxMGJhYzc1Li41MGE2NGQ5 NzhjNGVkYmVlZGRiNGRkMDkzMTgwZjEyNzg0YjI1YjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTkw NDksNiArOTA0OSw3IEBAIC0gKFVJVGFyZ2V0ZWRQcmV2aWV3ICopX2NyZWF0ZVRhcmdldGVkQ29u dGV4dE1lbnVIaW50UHJldmlld0lmUG9zc2libGUKIC0gKFVJVGFyZ2V0ZWRQcmV2aWV3ICopY29u dGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50ZXJhY3Rp b24gcHJldmlld0ZvckhpZ2hsaWdodGluZ01lbnVXaXRoQ29uZmlndXJhdGlvbjooVUlDb250ZXh0 TWVudUNvbmZpZ3VyYXRpb24gKiljb25maWd1cmF0aW9uCiB7CiAgICAgW3NlbGYgX3N0YXJ0U3Vw cHJlc3NpbmdTZWxlY3Rpb25Bc3Npc3RhbnRGb3JSZWFzb246V2ViS2l0OjpJbnRlcmFjdGlvbklz SGFwcGVuaW5nXTsKKyAgICBbc2VsZiBfY2FuY2VsVG91Y2hFdmVudEdlc3R1cmVSZWNvZ25pemVy XTsKICAgICByZXR1cm4gW3NlbGYgX2NyZWF0ZVRhcmdldGVkQ29udGV4dE1lbnVIaW50UHJldmll d0lmUG9zc2libGVdOwogfQogCg== 396425 2020-04-14 09:15:58 -0700 2020-04-14 09:38:55 -0700 Patch for landing bug-210467-20200414091557.patch text/plain 1896 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI2ODZhZDdlY2I2MTFhZTQy NjdiYjYyMmZmMmE5MTcxYTg4ZTliYjYuLjUzMWNkN2ExNjY4MTIyZmU3YjBjN2E4OTVjMWFlY2U1 ODY3NGUyZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDQtMTMgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBZb3VUdWJlIHNvbWV0 aW1lcyBuYXZpZ2F0ZXMgdW5leHBlY3RlZGx5IHdoZW4gaW52b2tpbmcgYSBjb250ZXh0IG1lbnUg b24gYSB2aWRlbyBsaW5rLiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMDQ2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg4NDE1ODQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBDYW5jZWwgYW55IG91dHN0 YW5kaW5nIHRvdWNoZXMgdHJhY2tlZCBieSBXZWJUb3VjaEV2ZW50c0dlc3R1cmVSZWNvZ25pemVy LCBzbyB0aGF0IHdlIGRpc3BhdGNoCisgICAgICAgIGB0b3VjaGNhbmNlbGAgdG8gdGhlIHBhZ2Ug aW5zdGVhZCBvZiBgdG91Y2hlbmRgLCBzbyB0aGF0IHRoZSBwYWdlIGRvZXMgbm90IG1pc2ludGVy cHJldAorICAgICAgICBjb250ZXh0IG1lbnUgaW52b2NhdGlvbiBhcyBhIHRhcC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAo LVtXS0NvbnRlbnRWaWV3IGNvbnRleHRNZW51SW50ZXJhY3Rpb246cHJldmlld0ZvckhpZ2hsaWdo dGluZ01lbnVXaXRoQ29uZmlndXJhdGlvbjpdKToKKwogMjAyMC0wNC0xMCAgUGVyIEFybmUgVm9s bGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWRkIHJvdXRpbmVzIHRv IG1lc3NhZ2UgZmlsdGVyIGluIHRoZSBXZWJDb250ZW50IHNhbmRib3gKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmlu ZGV4IDBlYjA4YTkwNmYxMWZjODcwMjJmODQyN2RiYjRjMTdlMDEwYmFjNzUuLjUwYTY0ZDk3OGM0 ZWRiZWVkZGI0ZGQwOTMxODBmMTI3ODRiMjViN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtOTA0OSw2 ICs5MDQ5LDcgQEAgLSAoVUlUYXJnZXRlZFByZXZpZXcgKilfY3JlYXRlVGFyZ2V0ZWRDb250ZXh0 TWVudUhpbnRQcmV2aWV3SWZQb3NzaWJsZQogLSAoVUlUYXJnZXRlZFByZXZpZXcgKiljb250ZXh0 TWVudUludGVyYWN0aW9uOihVSUNvbnRleHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBw cmV2aWV3Rm9ySGlnaGxpZ2h0aW5nTWVudVdpdGhDb25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51 Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24KIHsKICAgICBbc2VsZiBfc3RhcnRTdXBwcmVz c2luZ1NlbGVjdGlvbkFzc2lzdGFudEZvclJlYXNvbjpXZWJLaXQ6OkludGVyYWN0aW9uSXNIYXBw ZW5pbmddOworICAgIFtzZWxmIF9jYW5jZWxUb3VjaEV2ZW50R2VzdHVyZVJlY29nbml6ZXJdOwog ICAgIHJldHVybiBbc2VsZiBfY3JlYXRlVGFyZ2V0ZWRDb250ZXh0TWVudUhpbnRQcmV2aWV3SWZQ b3NzaWJsZV07CiB9CiAK