210459 2020-04-13 15:06:32 -0700 check-webkit-style should warn about attributes that appear after function definitions 2020-04-13 17:33:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210336 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen darin ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1641129 0 ddkilzer 2020-04-13 15:06:32 -0700 check-webkit-style should warn about attributes that appear after function definitions. Darin suggested it was better to be consistent and always put attributes before the function definition since placing them after the function definition (e.g., in a static function with no predeclaration) doesn't work. 1641135 1 396339 ddkilzer 2020-04-13 15:14:41 -0700 Created attachment 396339 Patch v1 1641191 2 ews-feeder 2020-04-13 17:32:30 -0700 Committed r260051: <https://trac.webkit.org/changeset/260051> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396339. 1641192 3 webkit-bug-importer 2020-04-13 17:33:15 -0700 <rdar://problem/61747702> 396339 2020-04-13 15:14:41 -0700 2020-04-13 17:32:31 -0700 Patch v1 bug-210459-20200413151533.patch text/plain 4989 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDEyNzkwMzhlY2UxMDBlZWE2ZDgwMWQ0Mjc4Y2IyMWM1 NGI3YmU0My4uYzkzNTE0OWVjNjM3YjZhM2RlYzI5Y2YwYWFlNDlhNDc1NTNjNGZkMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDIwLTA0LTEzICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZCB3YXJuIGFib3V0IGF0dHJpYnV0ZXMgdGhh dCBhcHBlYXIgYWZ0ZXIgZnVuY3Rpb24gZGVmaW5pdGlvbnMKKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzIxMDQ1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAg ICAgICAoX0Z1bmN0aW9uU3RhdGUuYXR0cmlidXRlc19hZnRlcl9kZWZpbml0aW9uKTogQWRkLgor ICAgICAgICAtIFJldHVybiBsaXN0IG9mIGF0dHJpYnV0ZXMgdGhhdCBhcHBlYXIgYWZ0ZXIgYSBm dW5jdGlvbgorICAgICAgICAgIGRlZmluaXRpb24uCisgICAgICAgIChjaGVja19mdW5jdGlvbl9k ZWZpbml0aW9uKToKKyAgICAgICAgLSBBZGQgbmV3IGNoZWNrIGZvciBhdHRyaWJ1dGVzIHRoYXQg YXBwZWFyIGFmdGVyIGEgZnVuY3Rpb24KKyAgICAgICAgICBkZWZpbml0aW9uLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAg ICAgIChDcHBTdHlsZVRlc3QudGVzdF9kZWNvZGVfZnVuY3Rpb25zX21pc3Npbmdfd2Fybl91bnVz ZWRfcmV0dXJuKToKKyAgICAgICAgLSBVcGRhdGUgdGVzdCB0byBmaXggbmV3IHdhcm5pbmcuCisg ICAgICAgIChDcHBTdHlsZVRlc3QudGVzdF9mdW5jdGlvbl9yZWFkYWJpbGl0eV9mb3JfYXR0cmli dXRlcyk6IEFkZC4KKyAgICAgICAgLSBBZGQgdGVzdHMuCisKIDIwMjAtMDQtMTMgIEFuZHJlcyBH b256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgV1RSOjpBY2Nl c3NpYmlsaXR5VUlFbGVtZW50IG1ldGhvZHMgcnVuIG9uIEFYIHNlY29uZGFyeSB0aHJlYWQuCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IGIxNzgz Njg0MjZmZmZmMjE5ZjRiNDdiYzgyN2E5MjkyMDI2YWI0MmUuLmViYTgyZTFhMThiOWRkMzZjOGNk MDQ5ZTliMTI3MDdhN2I5MzU4Y2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5CkBAIC01OTYsNiArNTk2LDkgQEAgY2xhc3MgX0Z1bmN0aW9uU3RhdGUo b2JqZWN0KToKICAgICAgICAgZWxpZGVkID0gc2VsZi5fY2xlYW5fbGluZXMuZWxpZGVkCiAgICAg ICAgIHJldHVybiBTaW5nbGVMaW5lVmlldyhlbGlkZWQsIHNlbGYucGFyYW1ldGVyX2VuZF9wb3Np dGlvbiwgc2VsZi5ib2R5X3N0YXJ0X3Bvc2l0aW9uKS5zaW5nbGVfbGluZS5zdHJpcCgpCiAKKyAg ICBkZWYgYXR0cmlidXRlc19hZnRlcl9kZWZpbml0aW9uKHNlbGYsIGF0dHJpYnV0ZV9yZWdleCk6 CisgICAgICAgIHJldHVybiByZS5maW5kYWxsKGF0dHJpYnV0ZV9yZWdleCwgc2VsZi5wb3N0X21v ZGlmaWVycygpKQorCiAgICAgZGVmIGhhc19hdHRyaWJ1dGUoc2VsZiwgYXR0cmlidXRlX3JlZ2V4 KToKICAgICAgICAgcmVnZXggPSByJ1xie2F0dHJpYnV0ZV9yZWdleH1cYicuZm9ybWF0KGF0dHJp YnV0ZV9yZWdleD1hdHRyaWJ1dGVfcmVnZXgpCiAgICAgICAgIHJldHVybiBib29sKHNlYXJjaChy ZWdleCwgc2VsZi5tb2RpZmllcnNfYW5kX3JldHVybl90eXBlKCkpKSBvciBib29sKHNlYXJjaChy ZWdleCwgc2VsZi5wb3N0X21vZGlmaWVycygpKSkKQEAgLTE4MjEsNiArMTgyNCwxNCBAQCBkZWYg Y2hlY2tfZnVuY3Rpb25fZGVmaW5pdGlvbihmaWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGNsZWFu X2xpbmVzLCBsaW5lX251bWJlcgogICAgICAgICAgICAgICAgICAgICBlcnJvcihsaW5lX251bWJl ciwgJ3NlY3VyaXR5L21pc3Npbmdfd2Fybl91bnVzZWRfcmV0dXJuJywgNSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgJ2RlY29kZSgpIGZ1bmN0aW9uIHJldHVybmluZyBhIHZhbHVlIGlzIG1p c3NpbmcgV0FSTl9VTlVTRURfUkVUVVJOIGF0dHJpYnV0ZScpCiAKKyAgICBhdHRyaWJ1dGVzID0g ZnVuY3Rpb25fc3RhdGUuYXR0cmlidXRlc19hZnRlcl9kZWZpbml0aW9uKHInKFxiV0FSTl9bMC05 QS1aX10rXGJ8X19hdHRyaWJ1dGVfX1woXChfX1thLXpfXStfX1wpXCkpJykKKyAgICBpZiBsZW4o YXR0cmlidXRlcykgPiAwOgorICAgICAgICBhdHRyaWJ1dGVfdGV4dCA9ICcsICcuam9pbihhdHRy aWJ1dGVzKQorICAgICAgICBwbHVyYWwgPSAncycgaWYgbGVuKGF0dHJpYnV0ZXMpID4gMSBlbHNl ICcnCisgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvZnVuY3Rpb24nLCA1 LAorICAgICAgICAgICAgICAnRnVuY3Rpb24gYXR0cmlidXRle3BsdXJhbH0gKHthdHRyaWJ1dGVz fSkgc2hvdWxkIGFwcGVhciBiZWZvcmUgdGhlIGZ1bmN0aW9uIGRlZmluaXRpb24nLgorICAgICAg ICAgICAgICBmb3JtYXQoYXR0cmlidXRlcz1hdHRyaWJ1dGVfdGV4dCwgcGx1cmFsPXBsdXJhbCkp CisKICAgICBwYXJhbWV0ZXJfbGlzdCA9IGZ1bmN0aW9uX3N0YXRlLnBhcmFtZXRlcl9saXN0KCkK ICAgICBmb3IgcGFyYW1ldGVyIGluIHBhcmFtZXRlcl9saXN0OgogICAgICAgICAjIERvIGNoZWNr cyBzcGVjaWZpYyB0byBmdW5jdGlvbiBkZWNsYXJhdGlvbnMgYW5kIHBhcmFtZXRlciBuYW1lcy4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkKaW5kZXggOTMwOTE5OWZkOTk1Y2Q3N2I0ZDEzYTdhYjc0YzM1N2Q2MmEwOTljMS4u ZTM4ZWRlZTY1Njk0ZjVhOGU3MzQyNTk5ZWViNjEzM2RkMWNlZTUyNCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAg LTMwMDAsNyArMzAwMCw3IEBAIGNsYXNzIENwcFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToK ICAgICAgICAgICAgIHdhcm5pbmdfZXhwZWN0ZWQpCiAgICAgICAgIHNlbGYucGVyZm9ybV9mdW5j dGlvbl9kZWZpbml0aW9uX2NoZWNrKAogICAgICAgICAgICAgJ1NvdXJjZS9XVEYvd3RmL2Zvby5o JywKLSAgICAgICAgICAgICdXVEZfRVhQT1JUX1BSSVZBVEUgc3RhdGljIGJvb2wgZGVjb2RlKERl Y29kZXImLCBBdG9tU3RyaW5nJikgV0FSTl9VTlVTRURfUkVUVVJOOycsCisgICAgICAgICAgICAn V1RGX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBXQVJOX1VOVVNFRF9SRVRVUk4gYm9vbCBkZWNvZGUo RGVjb2RlciYsIEF0b21TdHJpbmcmKTsnLAogICAgICAgICAgICAgd2FybmluZ19ub25lKQogCiAg ICAgICAgIHNlbGYucGVyZm9ybV9mdW5jdGlvbl9kZWZpbml0aW9uX2NoZWNrKApAQCAtMzA0NSw2 ICszMDQ1LDI0IEBAIGNsYXNzIENwcFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAg ICAgICAgICcgICAgc3RhdGljIFdBUk5fVU5VU0VEX1JFVFVSTiBib29sIHBsYXRmb3JtRGVjb2Rl KElQQzo6RGVjb2RlciYsIFdlYkhpdFRlc3RSZXN1bHREYXRhJik7JywKICAgICAgICAgICAgIHdh cm5pbmdfbm9uZSkKIAorICAgIGRlZiB0ZXN0X2Z1bmN0aW9uX3JlYWRhYmlsaXR5X2Zvcl9hdHRy aWJ1dGVzKHNlbGYpOgorICAgICAgICBzZWxmLnBlcmZvcm1fZnVuY3Rpb25fZGVmaW5pdGlvbl9j aGVjaygKKyAgICAgICAgICAgICdTb3VyY2UvV1RGL3d0Zi9mb28uaCcsCisgICAgICAgICAgICAn V1RGX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBib29sIGRlY29kZShEZWNvZGVyJiwgQXRvbVN0cmlu ZyYpIFdBUk5fVU5VU0VEX1JFVFVSTjsnLAorICAgICAgICAgICAgJ0Z1bmN0aW9uIGF0dHJpYnV0 ZSAoV0FSTl9VTlVTRURfUkVUVVJOKSBzaG91bGQgYXBwZWFyIGJlZm9yZSB0aGUgZnVuY3Rpb24g ZGVmaW5pdGlvbicKKyAgICAgICAgICAgICcgIFtyZWFkYWJpbGl0eS9mdW5jdGlvbl0gWzVdJykK KworICAgICAgICBzZWxmLnBlcmZvcm1fZnVuY3Rpb25fZGVmaW5pdGlvbl9jaGVjaygKKyAgICAg ICAgICAgICdmb28uaCcsCisgICAgICAgICAgICAnc3RhdGljIF9fYXR0cmlidXRlX18oKF9fd2Fy bl91bnVzZWRfcmVzdWx0X18pKSBib29sIGNoZWNrKERlY29kZXImLCBBdG9tU3RyaW5nJik7JywK KyAgICAgICAgICAgICcnKQorCisgICAgICAgIHNlbGYucGVyZm9ybV9mdW5jdGlvbl9kZWZpbml0 aW9uX2NoZWNrKAorICAgICAgICAgICAgJ2Zvby5oJywKKyAgICAgICAgICAgICdzdGF0aWMgYm9v bCBjaGVjayhEZWNvZGVyJiwgQXRvbVN0cmluZyYpIF9fYXR0cmlidXRlX18oKF9fd2Fybl91bnVz ZWRfcmVzdWx0X18pKTsnLAorICAgICAgICAgICAgJ0Z1bmN0aW9uIGF0dHJpYnV0ZSAoX19hdHRy aWJ1dGVfXygoX193YXJuX3VudXNlZF9yZXN1bHRfXykpKSBzaG91bGQgYXBwZWFyIGJlZm9yZSB0 aGUgZnVuY3Rpb24gZGVmaW5pdGlvbicKKyAgICAgICAgICAgICcgIFtyZWFkYWJpbGl0eS9mdW5j dGlvbl0gWzVdJykKKwogCiBjbGFzcyBDbGVhbnNlZExpbmVzVGVzdCh1bml0dGVzdC5UZXN0Q2Fz ZSk6CiAgICAgZGVmIHRlc3RfaW5pdChzZWxmKToK