21043 2008-09-23 15:38:48 -0700 REGRESSION: Leak of AnimationLists (and whole RenderStyles?) 2008-09-29 15:04:58 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://build.webkit.org/results/trunk-mac-intel-debug/5071/DumpRenderTree-leaks.txt LayoutTestFailure, Regression P1 Normal --- 20995 1 mitz webkit-unassigned dino simon.fraser oldest_to_newest 92414 0 mitz 2008-09-23 15:38:48 -0700 The leaks bot is showing many leaks beneath accessAnimations(). See URL. 92444 1 simon.fraser 2008-09-23 18:19:05 -0700 I don't see any leaks when I run the animation tests: wktests --debug --leaks LayoutTests/animations/ animations .............. ? checking for leaks in DumpRenderTree - no leaks found 92457 2 mitz 2008-09-23 20:30:56 -0700 (In reply to comment #1) > I don't see any leaks when I run the animation tests: > wktests --debug --leaks LayoutTests/animations/ > animations .............. > ? checking for leaks in DumpRenderTree > - no leaks found The leaks bot is running Tiger. The leaks command tends to be better at finding leaks under Tiger, which is what the leaks bot is running. There is also a chance that the leaks has been fixed since r36763. 92565 3 simon.fraser 2008-09-24 12:10:04 -0700 Adding some printfs shows that RenderStyles are being leaked, but that may change when Chris fixes bug 20995. 93287 4 simon.fraser 2008-09-29 14:38:46 -0700 Still leaking after bug 20995 landed. We're leaking RenderStyles: ... WebCore::Element::attach() WebCore::Node::createRendererIfNeeded() WebCore::Node::styleForRenderer(WebCore::RenderObject*) WebCore::CSSStyleSelector::styleForElement(WebCore::Element*, WebCore::RenderStyle*, bool, bool) WebCore::RenderStyle::operator new(unsigned long, WebCore::RenderArena*) WebCore::RenderArena::allocate(unsigned long) malloc 93289 5 23920 simon.fraser 2008-09-29 14:57:48 -0700 Created attachment 23920 Patch, changelog 93291 6 23920 andersca 2008-09-29 15:03:34 -0700 Comment on attachment 23920 Patch, changelog r=me 93292 7 simon.fraser 2008-09-29 15:04:58 -0700 Committed r37078 M WebCore/ChangeLog M WebCore/css/CSSStyleSelector.cpp M WebCore/page/animation/KeyframeAnimation.cpp r37078 = 8a565534699cd0513050a291fd34f009602cd903 (trunk) Ran various animation tests with this fix, saw no leaks. 23920 2008-09-29 14:57:48 -0700 2008-09-29 15:03:34 -0700 Patch, changelog 21043_patch.txt text/plain 1979 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cNaW5kZXgg M2VlMmUwOS4uYTIwYTY3NSAxMDA2NDQNLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cNKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cNQEAgLTEsMyArMSwxNiBAQA0rMjAwOC0wOS0yOSAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4NKw0rICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4NKw0rICAgICAgICBGaXggUmVuZGVyU3R5bGUgbGVhayBpbiBhbmltYXRpb24gY29k ZSwgYW5kIGFzc2VydCB0aGF0IA0rICAgICAgICBrZXlmcmFtZSByZXNvbHV0aW9uIGluIENTU1N0 eWxlU2VsZWN0b3IgaXMgbm90IGdvaW5nIHRvIGNsb2JiZXINKyAgICAgICAgbV9zdHlsZS4NKw0r ICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoNKyAgICAgICAgKFdlYkNvcmU6OkNT U1N0eWxlU2VsZWN0b3I6OmtleWZyYW1lU3R5bGVzRm9yQW5pbWF0aW9uKToNKyAgICAgICAgKiBw YWdlL2FuaW1hdGlvbi9LZXlmcmFtZUFuaW1hdGlvbi5jcHA6DSsgICAgICAgIChXZWJDb3JlOjpL ZXlmcmFtZUFuaW1hdGlvbjo6fktleWZyYW1lQW5pbWF0aW9uKToNKw0gMjAwOC0wOS0yOSAgQ2hy aXMgTWFycmluICA8Y21hcnJpbkBhcHBsZS5jb20+DSANICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 ZSBIeWF0dA1kaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAgYi9X ZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcA1pbmRleCBlZjVlMWJkLi5iMGJhYzY3IDEw MDY0NA0tLS0gYS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcA0rKysgYi9XZWJDb3Jl L2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcA1AQCAtMTIwMCw2ICsxMjAwLDggQEAgdm9pZCBDU1NT dHlsZVNlbGVjdG9yOjprZXlmcmFtZVN0eWxlc0ZvckFuaW1hdGlvbihFbGVtZW50KiBlLCBjb25z dCBSZW5kZXJTdHlsZSoNICAgICAgICAgY29uc3QgV2ViS2l0Q1NTS2V5ZnJhbWVSdWxlKiBrZiA9 IHJ1bGUtPml0ZW0oaSk7DSAgICAgICAgIGFkZE1hdGNoZWREZWNsYXJhdGlvbihrZi0+c3R5bGUo KSk7DSANKyAgICAgICAgQVNTRVJUKCFtX3N0eWxlKTsNKw0gICAgICAgICAvLyBDcmVhdGUgdGhl IHN0eWxlDSAgICAgICAgIG1fc3R5bGUgPSBuZXcgKGUtPmRvY3VtZW50KCktPnJlbmRlckFyZW5h KCkpIFJlbmRlclN0eWxlKCplbGVtZW50U3R5bGUpOw0gICAgICAgICBtX3N0eWxlLT5yZWYoKTsN ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vS2V5ZnJhbWVBbmltYXRpb24uY3Bw IGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9LZXlmcmFtZUFuaW1hdGlvbi5jcHANaW5kZXggODBh NGQ2Ni4uMzkzZjBjYiAxMDA2NDQNLS0tIGEvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9LZXlmcmFt ZUFuaW1hdGlvbi5jcHANKysrIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9LZXlmcmFtZUFuaW1h dGlvbi5jcHANQEAgLTYyLDYgKzYyLDkgQEAgS2V5ZnJhbWVBbmltYXRpb246On5LZXlmcmFtZUFu aW1hdGlvbigpDSAgICAgLy8gRG8gdGhlIGNsZWFudXAgaGVyZSBpbnN0ZWFkIG9mIGluIHRoZSBi YXNlIGNsYXNzIHNvIHRoZSBzcGVjaWFsaXplZCBtZXRob2RzIGdldCBjYWxsZWQNICAgICBpZiAo IXBvc3RBY3RpdmUoKSkNICAgICAgICAgdXBkYXRlU3RhdGVNYWNoaW5lKEFuaW1hdGlvblN0YXRl SW5wdXRFbmRBbmltYXRpb24sIC0xKTsNKw0rICAgIGlmIChtX3VuYW5pbWF0ZWRTdHlsZSkNKyAg ICAgICAgY29uc3RfY2FzdDxSZW5kZXJTdHlsZSo+KG1fdW5hbmltYXRlZFN0eWxlKS0+ZGVyZWYo cmVuZGVyZXIoKS0+cmVuZGVyQXJlbmEoKSk7DSB9DSANIHZvaWQgS2V5ZnJhbWVBbmltYXRpb246 OmFuaW1hdGUoQ29tcG9zaXRlQW5pbWF0aW9uKiBhbmltYXRpb24sIFJlbmRlck9iamVjdCogcmVu ZGVyZXIsIGNvbnN0IFJlbmRlclN0eWxlKiBjdXJyZW50U3R5bGUsIA0=