210429 2020-04-13 08:43:04 -0700 Fix various build warnings 2020-08-17 10:14:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro annulen cdumez dino esprehn+autocc ews-watchlist graouts gyuyoung.kim keith_miller kondapallykalyan mark.lam mcatanzaro mgorse msaboff ryuan.choi saam sergio tzagallo webkit-bug-importer oldest_to_newest 1640891 0 mcatanzaro 2020-04-13 08:43:04 -0700 Fix various build warnings: [269/1615] Building CXX object Source/JavaScriptCore/CMak...ScriptCore/unified-sources/UnifiedSource-bfc896e1-2.cpp.o In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-bfc896e1-2.cpp:2: /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/dfg/DFGArrayMode.cpp: In member function ‘bool JSC::DFG::ArrayMode::alreadyChecked(JSC::DFG::Graph&, JSC::DFG::Node*, const JSC::DFG::AbstractValue&) const’: /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/dfg/DFGArrayMode.cpp:565:9: warning: this statement may fall through [-Wimplicit-fallthrough=] 565 | } | ^ /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/dfg/DFGArrayMode.cpp:567:5: note: here 567 | case Array::DirectArguments: | ^~~~ [877/1615] Building CXX object Source/WebCore/CMakeFiles/...s/WebCore/unified-sources/UnifiedSource-950a39b6-27.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-27.cpp:7: /home/mcatanzaro/Projects/WebKit/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: In member function ‘void WebCore::WebGLRenderingContextBase::texImage2DBase(GCGLenum, GCGLint, GCGLenum, GCGLsizei, GCGLsizei, GCGLint, GCGLenum, GCGLenum, GCGLsizei, const void*)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4196:198: warning: unused parameter ‘byteLength’ [-Wunused-parameter] 4196 | void WebGLRenderingContextBase::texImage2DBase(GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLsizei width, GCGLsizei height, GCGLint border, GCGLenum format, GCGLenum type, GCGLsizei byteLength, const void* pixels) | ~~~~~~~~~~^~~~~~~~~~ [1072/1615] Generating ../../DerivedSources/webkit2gtk/WebKitWaylandClientProtocol.c Using "code" is deprecated - use private-code or public-code. See the help page for details. [1073/1615] Generating ../../DerivedSources/webkit2gtk/pointer-constraints-unstable-v1-protocol.c Using "code" is deprecated - use private-code or public-code. See the help page for details. [1074/1615] Generating ../../DerivedSources/webkit2gtk/relative-pointer-unstable-v1-protocol.c Using "code" is deprecated - use private-code or public-code. See the help page for details. 1640892 1 396289 mcatanzaro 2020-04-13 08:48:28 -0700 Created attachment 396289 Patch 1640899 2 396289 mark.lam 2020-04-13 09:05:59 -0700 Comment on attachment 396289 Patch r=me 1640913 3 ews-feeder 2020-04-13 09:33:38 -0700 Committed r260012: <https://trac.webkit.org/changeset/260012> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396289. 1640914 4 webkit-bug-importer 2020-04-13 09:34:13 -0700 <rdar://problem/61719974> 1680846 5 mgorse 2020-08-17 10:14:08 -0700 FYI, --private-code was added in wayland-scanner 1.16.0, so the build now fails if wayland is older than that. 396289 2020-04-13 08:48:28 -0700 2020-04-13 09:33:39 -0700 Patch bug-210429-20200413104828.patch text/plain 6575 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MWEwM2MwYmRmMmNkMWNkOThlZjMyNzM2N2YyZDA5NzdiZGY0NzZjLi4yMzQwOGM5NTg0ZmZjOGFi NmE1YTkwYjg5ZTBhMjQ5ODcxNmQzYjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNC0xMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBGaXggdmFyaW91cyBidWlsZCB3YXJuaW5ncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwNDI5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IC1XaW1wbGljaXQtZmFs bHRocm91Z2ggd2FybmluZyBieSBhZGRpbmcgYSBkZWZhdWx0IGNhc2UgQ1JBU0goKSB0byBwcmV2 ZW50IHRoZSBpbm5lcgorICAgICAgICBzd2l0Y2ggZnJvbSBmYWxsaW5nIHRocm91Z2ggdG8gdGhl IG91dGVyIHN3aXRjaC4KKworICAgICAgICAqIGRmZy9ERkdBcnJheU1vZGUuY3BwOgorICAgICAg ICAoSlNDOjpERkc6OkFycmF5TW9kZTo6YWxyZWFkeUNoZWNrZWQgY29uc3QpOgorCiAyMDIwLTA0 LTA5ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBQ cm94eU9iamVjdDo6ZGVmaW5lT3duUHJvcGVydHkoKSBzaG91bGQgY29uZGl0aW9uYWxseSB0aHJv dyBvbiBmYWxzeSB0cmFwIHJlc3VsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGYwYzcxNmQ1NjU0MDJkMzZkN2Ri NTVhMDdhMDc1ZTJhZGVjZmU1ZWMuLmJlYzEzOTdiYjk2M2ExYWJmYTcyNjVkODEwM2QzOWE2ZTdm ZjIwN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wNC0xMyAgTWljaGFlbCBD YXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KKworICAgICAgICBGaXggdmFyaW91cyBi dWlsZCB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEwNDI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IC1XdW51c2VkLXBhcmFtZXRlciB3YXJuaW5nLgorCisgICAgICAgICogaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX ZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjp0ZXhJbWFnZTJEQmFzZSk6CisKIDIwMjAtMDQtMDkg IEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Zl IGxlZ2FjeSBYLVdlYktpdC1DU1AgaGVhZGVyIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggYzI1MTllZjdh ZDcwNWY3MTEwNmNkZTVhNzQ4NDFjZWQ0NzZjMzM4My4uNDE4YTMwMGE0YTM1NmViNWE2YjNhMjRk OGU0ZmE4NDc1NzI1ZDViOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wNC0xMyAg TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KKworICAgICAgICBGaXgg dmFyaW91cyBidWlsZCB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEwNDI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXNlIHByaXZhdGUtY29kZSBpbnN0ZWFkIG9mIGRlcHJlY2F0ZWQgY29k ZSBjb21tYW5kIHRvIGJ1aWxkIHRoZSBXYXlsYW5kIHByb3RvY29sLgorCisgICAgICAgICogUGxh dGZvcm1HVEsuY21ha2U6CisKIDIwMjAtMDQtMDkgIEtlaXRoIFJvbGxpbiAgPGtyb2xsaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFNldCBFTlRJVExFTUVOVFNfUkVRVUlSRUQ9Tk8gZm9yIHNvbWUg WGNvZGUgYnVpbGQgdGFyZ2V0cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdBcnJheU1vZGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcnJheU1v ZGUuY3BwCmluZGV4IDhmNTI3ZDM4NjJiMjhkYTFmNjUwMzdjZDU0NDg5YTUxZTYxZWM5ZmUuLmYz MjI0NWZmN2UxMWE1MGUxNTEyZDQxNDE4NjA5OTIyMzM1OGRhMDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0FycmF5TW9kZS5jcHAKQEAgLTU2Miw2ICs1NjIsOCBAQCBib29sIEFy cmF5TW9kZTo6YWxyZWFkeUNoZWNrZWQoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlLCBjb25zdCBB YnN0cmFjdFZhbHVlJiB2YQogICAgICAgICAgICAgfQogICAgICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgICAgIH0KKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgIENSQVNIKCk7CiAgICAg ICAgIH0KICAgICAgICAgCiAgICAgY2FzZSBBcnJheTo6RGlyZWN0QXJndW1lbnRzOgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFz ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRC YXNlLmNwcAppbmRleCA0YmU5MDE2Zjk0NmI0ZmUyMDQyMDJjMzA3YmMzMWM2NjViZmU0MzRlLi4x YTkwNGI2ZWI4YjA0NDMwN2U4MWQ5MDAxNWUyNjRkOTUwZTQxOTdlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNw cApAQCAtNDE5OCw2ICs0MTk4LDcgQEAgdm9pZCBXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjp0 ZXhJbWFnZTJEQmFzZShHQ0dMZW51bSB0YXJnZXQsIEdDR0xpbnQgbGV2ZWwsIEcKICNpZiBVU0Uo QU5HTEUpCiAgICAgbV9jb250ZXh0LT5nZXRFeHRlbnNpb25zKCkudGV4SW1hZ2UyRFJvYnVzdEFO R0xFKHRhcmdldCwgbGV2ZWwsIGludGVybmFsRm9ybWF0LCB3aWR0aCwgaGVpZ2h0LCBib3JkZXIs IGZvcm1hdCwgdHlwZSwgYnl0ZUxlbmd0aCwgcGl4ZWxzKTsKICNlbHNlCisgICAgVU5VU0VEX1BB UkFNKGJ5dGVMZW5ndGgpOwogICAgIC8vIEZJWE1FOiBGb3Igbm93IHdlIGlnbm9yZSBhbnkgZXJy b3JzIHJldHVybmVkLgogICAgIGF1dG8gdGV4ID0gdmFsaWRhdGVUZXh0dXJlQmluZGluZygidGV4 SW1hZ2UyRCIsIHRhcmdldCwgdHJ1ZSk7CiAgICAgQVNTRVJUKHZhbGlkYXRlVGV4RnVuY1BhcmFt ZXRlcnMoInRleEltYWdlMkQiLCBUZXhJbWFnZSwgdGFyZ2V0LCBsZXZlbCwgaW50ZXJuYWxGb3Jt YXQsIHdpZHRoLCBoZWlnaHQsIGJvcmRlciwgZm9ybWF0LCB0eXBlKSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdU Sy5jbWFrZQppbmRleCA0ZmM2ZWMwZjNkZjVkNTFmYTQzMzRmNDEzY2IwM2ZiNjA5MDM0ODU5Li5i NzBmNTY1YmM4ZmEzYmU3YzJkODQwZTYzZWMyMzFhMDliZWYyOThkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1H VEsuY21ha2UKQEAgLTU1MCwxNCArNTUwLDE0IEBAIGlmIChFTkFCTEVfV0FZTEFORF9UQVJHRVQp CiAgICAgICAgIERFUEVORFMgJHtXRUJLSVRfRElSfS9TaGFyZWQvZ3RrL1dlYktpdFdheWxhbmRQ cm90b2NvbC54bWwKICAgICAgICAgQ09NTUFORCAke1dBWUxBTkRfU0NBTk5FUn0gc2VydmVyLWhl YWRlciAke1dFQktJVF9ESVJ9L1NoYXJlZC9ndGsvV2ViS2l0V2F5bGFuZFByb3RvY29sLnhtbCAk e0RFUklWRURfU09VUkNFU19XRUJLSVQyR1RLX0RJUn0vV2ViS2l0V2F5bGFuZFNlcnZlclByb3Rv Y29sLmgKICAgICAgICAgQ09NTUFORCAke1dBWUxBTkRfU0NBTk5FUn0gY2xpZW50LWhlYWRlciAk e1dFQktJVF9ESVJ9L1NoYXJlZC9ndGsvV2ViS2l0V2F5bGFuZFByb3RvY29sLnhtbCAke0RFUklW RURfU09VUkNFU19XRUJLSVQyR1RLX0RJUn0vV2ViS2l0V2F5bGFuZENsaWVudFByb3RvY29sLmgK LSAgICAgICAgQ09NTUFORCAke1dBWUxBTkRfU0NBTk5FUn0gY29kZSAke1dFQktJVF9ESVJ9L1No YXJlZC9ndGsvV2ViS2l0V2F5bGFuZFByb3RvY29sLnhtbCAke0RFUklWRURfU09VUkNFU19XRUJL SVQyR1RLX0RJUn0vV2ViS2l0V2F5bGFuZENsaWVudFByb3RvY29sLmMKKyAgICAgICAgQ09NTUFO RCAke1dBWUxBTkRfU0NBTk5FUn0gcHJpdmF0ZS1jb2RlICR7V0VCS0lUX0RJUn0vU2hhcmVkL2d0 ay9XZWJLaXRXYXlsYW5kUHJvdG9jb2wueG1sICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtf RElSfS9XZWJLaXRXYXlsYW5kQ2xpZW50UHJvdG9jb2wuYwogICAgICAgICBWRVJCQVRJTQogICAg ICkKIAogICAgIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICAgICAgT1VUUFVUICR7REVSSVZFRF9T T1VSQ0VTX1dFQktJVDJHVEtfRElSfS9wb2ludGVyLWNvbnN0cmFpbnRzLXVuc3RhYmxlLXYxLXBy b3RvY29sLmMKICAgICAgICAgREVQRU5EUyAke1dBWUxBTkRfUFJPVE9DT0xTX0RBVEFESVJ9L3Vu c3RhYmxlL3BvaW50ZXItY29uc3RyYWludHMvcG9pbnRlci1jb25zdHJhaW50cy11bnN0YWJsZS12 MS54bWwKLSAgICAgICAgQ09NTUFORCAke1dBWUxBTkRfU0NBTk5FUn0gY29kZSAke1dBWUxBTkRf UFJPVE9DT0xTX0RBVEFESVJ9L3Vuc3RhYmxlL3BvaW50ZXItY29uc3RyYWludHMvcG9pbnRlci1j b25zdHJhaW50cy11bnN0YWJsZS12MS54bWwgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19E SVJ9L3BvaW50ZXItY29uc3RyYWludHMtdW5zdGFibGUtdjEtcHJvdG9jb2wuYworICAgICAgICBD T01NQU5EICR7V0FZTEFORF9TQ0FOTkVSfSBwcml2YXRlLWNvZGUgJHtXQVlMQU5EX1BST1RPQ09M U19EQVRBRElSfS91bnN0YWJsZS9wb2ludGVyLWNvbnN0cmFpbnRzL3BvaW50ZXItY29uc3RyYWlu dHMtdW5zdGFibGUtdjEueG1sICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfRElSfS9wb2lu dGVyLWNvbnN0cmFpbnRzLXVuc3RhYmxlLXYxLXByb3RvY29sLmMKICAgICAgICAgQ09NTUFORCAk e1dBWUxBTkRfU0NBTk5FUn0gY2xpZW50LWhlYWRlciAke1dBWUxBTkRfUFJPVE9DT0xTX0RBVEFE SVJ9L3Vuc3RhYmxlL3BvaW50ZXItY29uc3RyYWludHMvcG9pbnRlci1jb25zdHJhaW50cy11bnN0 YWJsZS12MS54bWwgJHtERVJJVkVEX1NPVVJDRVNfV0VCS0lUMkdUS19ESVJ9L3BvaW50ZXItY29u c3RyYWludHMtdW5zdGFibGUtdjEtY2xpZW50LXByb3RvY29sLmgKICAgICAgICAgVkVSQkFUSU0K ICAgICApCkBAIC01NjUsNyArNTY1LDcgQEAgaWYgKEVOQUJMRV9XQVlMQU5EX1RBUkdFVCkKICAg ICBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgICAgIE9VVFBVVCAke0RFUklWRURfU09VUkNFU19X RUJLSVQyR1RLX0RJUn0vcmVsYXRpdmUtcG9pbnRlci11bnN0YWJsZS12MS1wcm90b2NvbC5jCiAg ICAgICAgIERFUEVORFMgJHtXQVlMQU5EX1BST1RPQ09MU19EQVRBRElSfS91bnN0YWJsZS9yZWxh dGl2ZS1wb2ludGVyL3JlbGF0aXZlLXBvaW50ZXItdW5zdGFibGUtdjEueG1sCi0gICAgICAgIENP TU1BTkQgJHtXQVlMQU5EX1NDQU5ORVJ9IGNvZGUgJHtXQVlMQU5EX1BST1RPQ09MU19EQVRBRElS fS91bnN0YWJsZS9yZWxhdGl2ZS1wb2ludGVyL3JlbGF0aXZlLXBvaW50ZXItdW5zdGFibGUtdjEu eG1sICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtfRElSfS9yZWxhdGl2ZS1wb2ludGVyLXVu c3RhYmxlLXYxLXByb3RvY29sLmMKKyAgICAgICAgQ09NTUFORCAke1dBWUxBTkRfU0NBTk5FUn0g cHJpdmF0ZS1jb2RlICR7V0FZTEFORF9QUk9UT0NPTFNfREFUQURJUn0vdW5zdGFibGUvcmVsYXRp dmUtcG9pbnRlci9yZWxhdGl2ZS1wb2ludGVyLXVuc3RhYmxlLXYxLnhtbCAke0RFUklWRURfU09V UkNFU19XRUJLSVQyR1RLX0RJUn0vcmVsYXRpdmUtcG9pbnRlci11bnN0YWJsZS12MS1wcm90b2Nv bC5jCiAgICAgICAgIENPTU1BTkQgJHtXQVlMQU5EX1NDQU5ORVJ9IGNsaWVudC1oZWFkZXIgJHtX QVlMQU5EX1BST1RPQ09MU19EQVRBRElSfS91bnN0YWJsZS9yZWxhdGl2ZS1wb2ludGVyL3JlbGF0 aXZlLXBvaW50ZXItdW5zdGFibGUtdjEueG1sICR7REVSSVZFRF9TT1VSQ0VTX1dFQktJVDJHVEtf RElSfS9yZWxhdGl2ZS1wb2ludGVyLXVuc3RhYmxlLXYxLWNsaWVudC1wcm90b2NvbC5oCiAgICAg ICAgIFZFUkJBVElNCiAgICAgKQo=