210426 2020-04-13 08:11:17 -0700 Add ccls config file to the list of ignored files 2020-09-20 13:16:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar svillar bfulgham don.olmstead keith_miller pnormand simon.fraser thorton webkit-bug-importer oldest_to_newest 1640870 0 svillar 2020-04-13 08:11:17 -0700 Add ccls config file to the list of ignored files 1640875 1 396280 svillar 2020-04-13 08:13:53 -0700 Created attachment 396280 Patch 1646631 2 svillar 2020-04-28 12:46:49 -0700 Ping reviewers. ccls is a stand-alone server implementing the Language Server Protocol for C, C++, and Objective-C languages. It can be used with any editor which provides an LSP client implementation. It originates from cquery. https://github.com/MaskRay/ccls/wiki It's basically used to provide semantic highlight and code navigation to big source code bases as WebKit. Many editors support LSP servers. 1646901 3 ews-feeder 2020-04-29 00:59:22 -0700 Committed r260885: <https://trac.webkit.org/changeset/260885> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396280. 1646902 4 webkit-bug-importer 2020-04-29 01:00:16 -0700 <rdar://problem/62581559> 1690065 5 396280 pnormand 2020-09-19 07:04:20 -0700 Comment on attachment 396280 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396280&action=review > ChangeLog:9 > + * .gitignore: ccls can read configuration options from a .ccls file in > + the project root directory. Let's just ignore it. I don't understand the reason for this change. I've been using a local .ccls file for months, ccls running from the SDK actually needs such file. So I would like to revert this change and commit my .ccls file because I think it would be useful for a wider audience :) Unless your IDE was generating a .ccls file? That seems to be what this patch implies, please elaborate :) 1690066 6 pnormand 2020-09-19 07:04:59 -0700 cat .ccls %compile_commands.json %h -x %h c++-header %h --include=config.h %cpp --include=config.h 1690213 7 svillar 2020-09-20 13:16:32 -0700 (In reply to Philippe Normand from comment #5) > Comment on attachment 396280 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=396280&action=review > > > ChangeLog:9 > > + * .gitignore: ccls can read configuration options from a .ccls file in > > + the project root directory. Let's just ignore it. > > I don't understand the reason for this change. I've been using a local .ccls > file for months, ccls running from the SDK actually needs such file. So I > would like to revert this change and commit my .ccls file because I think it > would be useful for a wider audience :) > Unless your IDE was generating a .ccls file? That seems to be what this > patch implies, please elaborate :) Having a .ccls file is optional for ccls to work. That's the reason why I decided to add it to the list of ignored files instead of committing it. But I don't have a strong opinion here, i.e. I'm fine with you adding a .ccls file. 396280 2020-04-13 08:13:53 -0700 2020-04-29 00:59:22 -0700 Patch bug-210426-20200413171351.patch text/plain 937 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDA2CmRpZmYgLS1naXQgYS8uZ2l0aWdub3JlIGIvLmdp dGlnbm9yZQppbmRleCBmMGMyNWZhMjYwMmMyMDk5YTIzMGI0YzFiMWE3ZGM0MDNkYzNlNjAyLi40 ZDc1MmYyN2Y2YWVkMDk1NDE0ZDc0NDMxZDQxNTAzN2IzNzJmOWUwIDEwMDY0NAotLS0gYS8uZ2l0 aWdub3JlCisrKyBiLy5naXRpZ25vcmUKQEAgLTI2LDYgKzI2LDcgQEAgeGN1c2VyZGF0YQogdGFn cwogKn4KIC4qLnN3W2EtcF0KKy5jY2xzCiAuY2xhbmdkCiBjb21waWxlX2NvbW1hbmRzLmpzb24K IApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGNjOTU5Y2I0YWFiNjc5 MWM0ZDA2MmY2NDNjNWRkNGI3ZmE0NzFlNDQuLjkyMzYyMmIyOGUxMTFlZGVmNTE2MzMxNGE3NTZk MDZhYTQ5MjFiZmYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMC0wNC0xMyAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdh bGlhLmNvbT4KKworICAgICAgICBBZGQgY2NscyBjb25maWcgZmlsZSB0byB0aGUgbGlzdCBvZiBp Z25vcmVkIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTA0MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIC5naXRpZ25vcmU6IGNjbHMgY2FuIHJlYWQgY29uZmlndXJhdGlvbiBvcHRpb25zIGZy b20gYSAuY2NscyBmaWxlIGluCisgICAgICAgIHRoZSBwcm9qZWN0IHJvb3QgZGlyZWN0b3J5LiBM ZXQncyBqdXN0IGlnbm9yZSBpdC4KKwogMjAyMC0wNC0xMyAgQWRyaWFuIFBlcmV6IGRlIENhc3Ry byAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdW0NNYWtlXSBJbnRyb2R1Y2Ug YW4gVVNFX0dUSzQgYnVpbGQgb3B0aW9uCg==