210377 2020-04-11 05:26:10 -0700 [ews] Improve handling of unexpected network issues while communicating with Bugzilla 2020-07-01 17:45:42 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1640518 0 aakash_jain 2020-04-11 05:26:10 -0700 Noticed following exception in ews-app logs. We should handle it in a better manner. Traceback (most recent call last): File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py", line 50, in run BugzillaPatchFetcher().fetch() File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/fetcher.py", line 65, in fetch patch_ids = Bugzilla.get_list_of_patches_needing_reviews() File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py", line 135, in get_list_of_patches_needing_reviews ids_needing_review = set(BugzillaBeautifulSoup().fetch_attachment_ids_from_review_queue(current_time - timedelta(7))) File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py", line 202, in fetch_attachment_ids_from_review_queue return self._parse_attachment_ids_request_query(self._load_query(review_queue_url), since) File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py", line 213, in _load_query self.authenticate() File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py", line 183, in authenticate response = self.browser.submit() File "/usr/lib/python2.7/site-packages/mechanize/_mechanize.py", line 684, in submit return self.open(self.click(*args, **kwds)) File "/usr/lib/python2.7/site-packages/mechanize/_mechanize.py", line 253, in open return self._mech_open(url_or_request, data, timeout=timeout) File "/usr/lib/python2.7/site-packages/mechanize/_mechanize.py", line 309, in _mech_open raise response httperror_seek_wrapper: HTTP Error 500: Internal Server Error 1640519 1 396159 aakash_jain 2020-04-11 05:30:32 -0700 Created attachment 396159 Patch 1640905 2 ews-feeder 2020-04-13 09:21:08 -0700 Committed r260010: <https://trac.webkit.org/changeset/260010> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396159. 1640906 3 webkit-bug-importer 2020-04-13 09:22:18 -0700 <rdar://problem/61719265> 1668116 4 aakash_jain 2020-07-01 17:45:42 -0700 This change seems to be working fine and improved robustness of ews django app. Logs indicates that this retry helped multiple times. e.g.: 2020-04-26 01:34:56,962 - Unexpected error while authenticating to bugzilla. 2020-04-26 01:34:58,252 - 28 r? patches, 0 patches need to be sent to Buildbot: [] 2020-05-29 06:51:26,148 - Unexpected error while authenticating to bugzilla. 2020-05-29 06:51:27,487 - 34 r? patches, 0 patches need to be sent to Buildbot: [] 2020-05-29 06:51:27,984 - Starting new HTTPS connection (1): bugs.webkit.org 2020-05-29 06:51:28,082 - 0 cq+ patches, 0 patches need to be sent to commit queue: [] 396159 2020-04-11 05:30:32 -0700 2020-04-13 09:21:09 -0700 Patch bug-210377-20200411083031.patch text/plain 2182 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTkyNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA0LTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBJbXByb3ZlIGhhbmRsaW5nIG9mIHVuZXhwZWN0ZWQgbmV0d29y ayBpc3N1ZXMgd2hpbGUgY29tbXVuaWNhdGluZyB3aXRoIEJ1Z3ppbGxhCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzNzcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL2NvbW1vbi9idWd6aWxsYS5weToKKyAgICAgICAgKEJ1Z3ppbGxhQmVhdXRpZnVs U291cC5hdXRoZW50aWNhdGUpOgorCiAyMDIwLTA0LTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9q YWluQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZGJvdDogRm9yY2UgY3Jhc2ggbG9nIHN1Ym1p c3Npb24gYWZ0ZXIgZWFjaCB0ZXN0IHJ1biAoZm9sbG93LXVwIGZpeCkKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWd6aWxsYS5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVnemlsbGEu cHkJKHJldmlzaW9uIDI1OTkyNikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAv ZXdzL2NvbW1vbi9idWd6aWxsYS5weQkod29ya2luZyBjb3B5KQpAQCAtMTgwLDE4ICsxODAsMjIg QEAgY2xhc3MgQnVnemlsbGFCZWF1dGlmdWxTb3VwKCk6CiAgICAgICAgICAgICBzZWxmLmJyb3dz ZXJbJ0J1Z3ppbGxhX2xvZ2luJ10gPSB1c2VybmFtZQogICAgICAgICAgICAgc2VsZi5icm93c2Vy WydCdWd6aWxsYV9wYXNzd29yZCddID0gcGFzc3dvcmQKICAgICAgICAgICAgIHNlbGYuYnJvd3Nl ci5maW5kX2NvbnRyb2woIkJ1Z3ppbGxhX3Jlc3RyaWN0bG9naW4iKS5pdGVtc1swXS5zZWxlY3Rl ZCA9IEZhbHNlCi0gICAgICAgICAgICByZXNwb25zZSA9IHNlbGYuYnJvd3Nlci5zdWJtaXQoKQor ICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIHJlc3BvbnNlID0gc2VsZi5icm93c2Vy LnN1Ym1pdCgpCisgICAgICAgICAgICBleGNlcHQ6CisgICAgICAgICAgICAgICAgX2xvZy5lcnJv cignVW5leHBlY3RlZCBlcnJvciB3aGlsZSBhdXRoZW50aWNhdGluZyB0byBidWd6aWxsYS4nKQor ICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAKICAgICAgICAgICAgIG1hdGNoID0gcmUuc2VhcmNo KCI8dGl0bGU+KC4rPyk8L3RpdGxlPiIsIHJlc3BvbnNlLnJlYWQoKSkKICAgICAgICAgICAgICMg SWYgdGhlIHJlc3VsdGluZyBwYWdlIGhhcyBhIHRpdGxlLCBhbmQgaXQgY29udGFpbnMgdGhlIHdv cmQKICAgICAgICAgICAgICMgImludmFsaWQiIGFzc3VtZSBpdCdzIHRoZSBsb2dpbiBmYWlsdXJl IHBhZ2UuCiAgICAgICAgICAgICBpZiBtYXRjaCBhbmQgcmUuc2VhcmNoKCJJbnZhbGlkIiwgbWF0 Y2guZ3JvdXAoMSksIHJlLklHTk9SRUNBU0UpOgogICAgICAgICAgICAgICAgIGVycm9yTWVzc2Fn ZSA9ICdCdWd6aWxsYSBsb2dpbiBmYWlsZWQ6IHt9Jy5mb3JtYXQobWF0Y2guZ3JvdXAoMSkpCi0g ICAgICAgICAgICAgICAgaWYgYXR0ZW1wdHMgPj0gNToKKyAgICAgICAgICAgICAgICBpZiBhdHRl bXB0cyA+PSAzOgogICAgICAgICAgICAgICAgICAgICAjIHJhaXNlIGFuIGV4Y2VwdGlvbiBvbmx5 IGlmIHRoaXMgd2FzIHRoZSBsYXN0IGF0dGVtcHQKICAgICAgICAgICAgICAgICAgICAgcmFpc2Ug RXhjZXB0aW9uKGVycm9yTWVzc2FnZSkKICAgICAgICAgICAgICAgICBfbG9nLmVycm9yKGVycm9y TWVzc2FnZSkKLSAgICAgICAgICAgICAgICB0aW1lLnNsZWVwKDUpCisgICAgICAgICAgICAgICAg dGltZS5zbGVlcCgzKQogICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICBhdXRoZW50 aWNhdGVkID0gVHJ1ZQogCg==