21037 2008-09-23 13:12:31 -0700 Use the Array.remove helper function in more places 2008-09-23 19:13:57 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy aroben kmccullough oldest_to_newest 92364 0 timothy 2008-09-23 13:12:31 -0700 We should use the Array.remove helper function in more places in the Inspector's code. 92373 1 23717 timothy 2008-09-23 13:49:25 -0700 Created attachment 23717 Proposed patch 92447 2 timothy 2008-09-23 19:13:57 -0700 Landed in r36829. 23717 2008-09-23 13:49:25 -0700 2008-09-23 14:16:00 -0700 Proposed patch 0004--Use-the-Array.remove-helper-function-in-more.patch text/plain 4211 timothy RnJvbSA5OTk4YWU4YWQ5N2ZjMjZmNjdiYjU4MGEzZmI0NzE3M2M4ZWVmMjc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUdWUsIDIzIFNlcCAyMDA4IDEzOjQ2OjE0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBVc2UgdGhlIEFycmF5LnJlbW92ZSBoZWxwZXIgZnVuY3Rpb24gaW4gbW9yZSBwbGFjZXMu CgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzNwoK ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBwYWdlL2luc3Bl Y3Rvci9SZXNvdXJjZUNhdGVnb3J5LmpzOgogICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VD YXRlZ29yeS5wcm90b3R5cGUucmVtb3ZlUmVzb3VyY2UpOiBVc2UgQXJyYXkucmVtb3ZlLgogICAg ICAgICogcGFnZS9pbnNwZWN0b3IvUmVzb3VyY2VzUGFuZWwuanM6CiAgICAgICAgKFdlYkluc3Bl Y3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUucmVtb3ZlUmVzb3VyY2UpOiBEaXR0by4KICAg ICAgICAqIHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qczoKICAgICAgICAoV2ViSW5zcGVjdG9y LnJlbW92ZVJlc291cmNlKTogRGl0dG8uCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYkNvcmUvcGFnZS9pbnNw ZWN0b3IvUmVzb3VyY2VDYXRlZ29yeS5qcyB8ICAgIDggKy0tLS0tLS0KIFdlYkNvcmUvcGFnZS9p bnNwZWN0b3IvUmVzb3VyY2VzUGFuZWwuanMgICB8ICAgIDggKy0tLS0tLS0KIFdlYkNvcmUvcGFn ZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzICAgICAgICB8ICAgIDggKy0tLS0tLS0KIDQgZmlsZXMg Y2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNDBlYTlhLi42NTEz NjlmIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSw1ICsxLDIwIEBACiAyMDA4LTA5LTIzICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5 QGFwcGxlLmNvbT4KIAorICAgICAgICBVc2UgdGhlIEFycmF5LnJlbW92ZSBoZWxwZXIgZnVuY3Rp b24gaW4gbW9yZSBwbGFjZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMDM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9SZXNvdXJjZUNhdGVnb3J5LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlJlc291cmNlQ2F0ZWdvcnkucHJvdG90eXBlLnJlbW92ZVJlc291cmNl KTogVXNlIEFycmF5LnJlbW92ZS4KKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9SZXNvdXJjZXNQ YW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUu cmVtb3ZlUmVzb3VyY2UpOiBEaXR0by4KKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9pbnNwZWN0 b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IucmVtb3ZlUmVzb3VyY2UpOiBEaXR0by4KKwor MjAwOC0wOS0yMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKICAgICAg ICAgRml4ZXMgYSBidWcgd2hlcmUgaW5zcGVjdGluZyBhIG5vZGUgYWZ0ZXIgcmVsb2FkaW5nIHRo ZSBwYWdlCiAgICAgICAgIHdvdWxkIG5vdCByZXZlYWwgdGhlIG5vZGUgaW4gdGhlIERPTSB0cmVl LiBUaGUgVHJlZU91dGxpbmUKICAgICAgICAgd2FzIG5vdCBiZWluZyB0b2xkIHRvIGZvcmdldCBk ZWNlbmRhbnRzIG9mIGEgcmVtb3ZlZCBjaGlsZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9p bnNwZWN0b3IvUmVzb3VyY2VDYXRlZ29yeS5qcyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvUmVz b3VyY2VDYXRlZ29yeS5qcwppbmRleCBjNTU5MWVhLi5mYzUwOGQwIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BhZ2UvaW5zcGVjdG9yL1Jlc291cmNlQ2F0ZWdvcnkuanMKKysrIGIvV2ViQ29yZS9wYWdl L2luc3BlY3Rvci9SZXNvdXJjZUNhdGVnb3J5LmpzCkBAIC01OCwxMyArNTgsNyBAQCBXZWJJbnNw ZWN0b3IuUmVzb3VyY2VDYXRlZ29yeS5wcm90b3R5cGUgPSB7CiAKICAgICByZW1vdmVSZXNvdXJj ZTogZnVuY3Rpb24ocmVzb3VyY2UpCiAgICAgewotICAgICAgICB2YXIgcmVzb3VyY2VzTGVuZ3Ro ID0gdGhpcy5yZXNvdXJjZXMubGVuZ3RoOwotICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHJl c291cmNlc0xlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICBpZiAodGhpcy5yZXNvdXJjZXNbaV0g PT09IHJlc291cmNlKSB7Ci0gICAgICAgICAgICAgICAgdGhpcy5yZXNvdXJjZXMuc3BsaWNlKGks IDEpOwotICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgfQotICAgICAgICB9Cisg ICAgICAgIHRoaXMucmVzb3VyY2VzLnJlbW92ZShyZXNvdXJjZSwgdHJ1ZSk7CiAgICAgfSwKIAog ICAgIHJlbW92ZUFsbFJlc291cmNlczogZnVuY3Rpb24ocmVzb3VyY2UpCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1Jlc291cmNlc1BhbmVsLmpzIGIvV2ViQ29yZS9wYWdlL2lu c3BlY3Rvci9SZXNvdXJjZXNQYW5lbC5qcwppbmRleCA3MWFkNDY5Li40NjFhMjA3IDEwMDY0NAot LS0gYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL1Jlc291cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvUmVzb3VyY2VzUGFuZWwuanMKQEAgLTMwMiwxMyArMzAyLDcgQEAg V2ViSW5zcGVjdG9yLlJlc291cmNlc1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKHRo aXMudmlzaWJsZVJlc291cmNlVmlldyA9PT0gcmVzb3VyY2UuX3Jlc291cmNlc1ZpZXcpCiAgICAg ICAgICAgICB0aGlzLmNsb3NlVmlzaWJsZVJlc291cmNlKCk7CiAKLSAgICAgICAgdmFyIHJlc291 cmNlc0xlbmd0aCA9IHRoaXMuX3Jlc291cmNlcy5sZW5ndGg7Ci0gICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgcmVzb3VyY2VzTGVuZ3RoOyArK2kpIHsKLSAgICAgICAgICAgIGlmICh0aGlzLl9y ZXNvdXJjZXNbaV0gPT09IHJlc291cmNlKSB7Ci0gICAgICAgICAgICAgICAgdGhpcy5fcmVzb3Vy Y2VzLnNwbGljZShpLCAxKTsKLSAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIH0K LSAgICAgICAgfQorICAgICAgICB0aGlzLl9yZXNvdXJjZXMucmVtb3ZlKHJlc291cmNlLCB0cnVl KTsKIAogICAgICAgICB0aGlzLnJlc291cmNlc1RyZWVFbGVtZW50LnJlbW92ZUNoaWxkKHJlc291 cmNlLl9yZXNvdXJjZXNUcmVlRWxlbWVudCk7CiAgICAgICAgIHRoaXMucmVzb3VyY2VzR3JhcGhz RWxlbWVudC5yZW1vdmVDaGlsZChyZXNvdXJjZS5fcmVzb3VyY2VzVHJlZUVsZW1lbnQuX3Jlc291 cmNlR3JhcGguZ3JhcGhFbGVtZW50KTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9pbnNwZWN0 b3IvaW5zcGVjdG9yLmpzIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanMKaW5k ZXggOWUzM2ViMy4uYTc5NGQ4NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9p bnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanMKQEAg LTg0OSwxMyArODQ5LDcgQEAgV2ViSW5zcGVjdG9yLnJlbW92ZVJlc291cmNlID0gZnVuY3Rpb24o cmVzb3VyY2UpCiAgICAgcmVzb3VyY2UuY2F0ZWdvcnkucmVtb3ZlUmVzb3VyY2UocmVzb3VyY2Up OwogICAgIGRlbGV0ZSB0aGlzLnJlc291cmNlVVJMTWFwW3Jlc291cmNlLnVybF07CiAKLSAgICB2 YXIgcmVzb3VyY2VzTGVuZ3RoID0gdGhpcy5yZXNvdXJjZXMubGVuZ3RoOwotICAgIGZvciAodmFy IGkgPSAwOyBpIDwgcmVzb3VyY2VzTGVuZ3RoOyArK2kpIHsKLSAgICAgICAgaWYgKHRoaXMucmVz b3VyY2VzW2ldID09PSByZXNvdXJjZSkgewotICAgICAgICAgICAgdGhpcy5yZXNvdXJjZXMuc3Bs aWNlKGksIDEpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICB9CisgICAgdGhp cy5yZXNvdXJjZXMucmVtb3ZlKHJlc291cmNlLCB0cnVlKTsKIAogICAgIHRoaXMucGFuZWxzLnJl c291cmNlcy5yZW1vdmVSZXNvdXJjZShyZXNvdXJjZSk7CiB9Ci0tIAoxLjYuMC4yCgo=