21036 2008-09-23 13:07:41 -0700 Inspecting a node after reloading the page with the Inspector open does not reveal the node 2008-09-23 19:14:19 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy aroben kmccullough oldest_to_newest 92363 0 timothy 2008-09-23 13:07:41 -0700 Inspecting a node after reloading the page with the Inspector open does not reveal the node. This is happening because the TreeOutline thinks it knows about TreeElemnts that no long exist in the tree for some nodes. 92372 1 23716 timothy 2008-09-23 13:48:53 -0700 Created attachment 23716 Proposed patch 92391 2 23716 kmccullough 2008-09-23 14:21:24 -0700 Comment on attachment 23716 Proposed patch - if (child.treeOutline) + if (child.treeOutline) { child.treeOutline._forgetTreeElement(child); + child.treeOutline._forgetChildrenRecursive(child); + } Should we always assume _forgetChildrenRecursive should follow _forgetTreeElement and thus include it in _forgetTree Element? 92448 3 timothy 2008-09-23 19:14:19 -0700 Landed in r36828. 23716 2008-09-23 13:48:53 -0700 2008-09-23 14:21:24 -0700 Proposed patch 0003--Fixes-a-bug-where-inspecting-a-node-after-re.patch text/plain 6107 timothy RnJvbSA5NTk1MGM0ODcyNDA4ZjRlZmYyZWY4MGZjNjI2OTY1NGM3OTYwM2Q0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUdWUsIDIzIFNlcCAyMDA4IDEzOjQ0OjA5IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBGaXhlcyBhIGJ1ZyB3aGVyZSBpbnNwZWN0aW5nIGEgbm9kZSBhZnRlciByZWxvYWRpbmcg dGhlIHBhZ2UKICAgICAgICAgd291bGQgbm90IHJldmVhbCB0aGUgbm9kZSBpbiB0aGUgRE9NIHRy ZWUuIFRoZSBUcmVlT3V0bGluZQogICAgICAgICB3YXMgbm90IGJlaW5nIHRvbGQgdG8gZm9yZ2V0 IGRlY2VuZGFudHMgb2YgYSByZW1vdmVkIGNoaWxkLgogICAgICAgICBTbyBvbGQgVHJlZUVsZW1l bnRzIHdvdWxkIGJlIGZvdW5kIHRoYXQgYXJlIG5vdCBpbiB0aGUgdHJlZS4KCiAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDM2CgogICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL3RyZWVvdXRs aW5lLmpzOgogICAgICAgIChUcmVlT3V0bGluZS5fcmVtb3ZlQ2hpbGRBdEluZGV4KTogQ2FsbCBf Zm9yZ2V0Q2hpbGRyZW5SZWN1cnNpdmUKICAgICAgICBpbiBhZGRpdGlvbiB0byBfZm9yZ2V0VHJl ZUVsZW1lbnQuCiAgICAgICAgKFRyZWVPdXRsaW5lLl9yZW1vdmVDaGlsZHJlbik6IENhbGwgX2Zv cmdldENoaWxkcmVuUmVjdXJzaXZlCiAgICAgICAgaW4gYWRkaXRpb24gdG8gX2ZvcmdldFRyZWVF bGVtZW50LgogICAgICAgIChUcmVlT3V0bGluZS5fcmVtZW1iZXJUcmVlRWxlbWVudCk6IFVzZSBB cnJheS5pbmRleE9mIHRvIHF1aWNrbHkKICAgICAgICBzZWFyY2ggZm9yIGtub3duIGVsZW1lbnRz LgogICAgICAgIChUcmVlT3V0bGluZS5fZm9yZ2V0VHJlZUVsZW1lbnQpOiBVc2UgQXJyYXkucmVt b3ZlIHRvIHJlbW92ZSBlbGVtZW50cy4KICAgICAgICAoVHJlZU91dGxpbmUuX2ZvcmdldENoaWxk cmVuUmVjdXJzaXZlKTogUmVjdXJzaXZlbHkgdHJhdmVyc2UgdGhlCiAgICAgICAgZGVzY2VuZGFu dHMgYW5kIGNhbGwgX2ZvcmdldFRyZWVFbGVtZW50LgogICAgICAgICogcGFnZS9pbnNwZWN0b3Iv dXRpbGl0aWVzLmpzOgogICAgICAgIChBcnJheS5wcm90b3R5cGUucmVtb3ZlKTogU3BlZWQgdXAg dGhpcyBmdW5jdGlvbiBieSB1c2luZyBBcnJheS5pbmRleE9mCiAgICAgICAgd2hlbiBvbmx5Rmly c3QgaXMgdHJ1ZS4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwg ICAyNSArKysrKysrKysrKysrKysrKysrKysrKysrCiBXZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL3Ry ZWVvdXRsaW5lLmpzIHwgICAzMSArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCiBXZWJD b3JlL3BhZ2UvaW5zcGVjdG9yL3V0aWxpdGllcy5qcyAgIHwgICAxMiArKysrKysrKy0tLS0KIDMg ZmlsZXMgY2hhbmdlZCwgNTIgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNjJhZmMy Li5hNDBlYTlhIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDA4LTA5LTIzICBUaW1vdGh5IEhhdGNoZXIgIDx0 aW1vdGh5QGFwcGxlLmNvbT4KIAorICAgICAgICBGaXhlcyBhIGJ1ZyB3aGVyZSBpbnNwZWN0aW5n IGEgbm9kZSBhZnRlciByZWxvYWRpbmcgdGhlIHBhZ2UKKyAgICAgICAgd291bGQgbm90IHJldmVh bCB0aGUgbm9kZSBpbiB0aGUgRE9NIHRyZWUuIFRoZSBUcmVlT3V0bGluZQorICAgICAgICB3YXMg bm90IGJlaW5nIHRvbGQgdG8gZm9yZ2V0IGRlY2VuZGFudHMgb2YgYSByZW1vdmVkIGNoaWxkLgor ICAgICAgICBTbyBvbGQgVHJlZUVsZW1lbnRzIHdvdWxkIGJlIGZvdW5kIHRoYXQgYXJlIG5vdCBp biB0aGUgdHJlZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEwMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBhZ2UvaW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpzOgorICAgICAgICAoVHJlZU91dGxp bmUuX3JlbW92ZUNoaWxkQXRJbmRleCk6IENhbGwgX2ZvcmdldENoaWxkcmVuUmVjdXJzaXZlCisg ICAgICAgIGluIGFkZGl0aW9uIHRvIF9mb3JnZXRUcmVlRWxlbWVudC4KKyAgICAgICAgKFRyZWVP dXRsaW5lLl9yZW1vdmVDaGlsZHJlbik6IENhbGwgX2ZvcmdldENoaWxkcmVuUmVjdXJzaXZlCisg ICAgICAgIGluIGFkZGl0aW9uIHRvIF9mb3JnZXRUcmVlRWxlbWVudC4KKyAgICAgICAgKFRyZWVP dXRsaW5lLl9yZW1lbWJlclRyZWVFbGVtZW50KTogVXNlIEFycmF5LmluZGV4T2YgdG8gcXVpY2ts eQorICAgICAgICBzZWFyY2ggZm9yIGtub3duIGVsZW1lbnRzLgorICAgICAgICAoVHJlZU91dGxp bmUuX2ZvcmdldFRyZWVFbGVtZW50KTogVXNlIEFycmF5LnJlbW92ZSB0byByZW1vdmUgZWxlbWVu dHMuCisgICAgICAgIChUcmVlT3V0bGluZS5fZm9yZ2V0Q2hpbGRyZW5SZWN1cnNpdmUpOiBSZWN1 cnNpdmVseSB0cmF2ZXJzZSB0aGUKKyAgICAgICAgZGVzY2VuZGFudHMgYW5kIGNhbGwgX2Zvcmdl dFRyZWVFbGVtZW50LgorICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL3V0aWxpdGllcy5qczoKKyAg ICAgICAgKEFycmF5LnByb3RvdHlwZS5yZW1vdmUpOiBTcGVlZCB1cCB0aGlzIGZ1bmN0aW9uIGJ5 IHVzaW5nIEFycmF5LmluZGV4T2YKKyAgICAgICAgd2hlbiBvbmx5Rmlyc3QgaXMgdHJ1ZS4KKwor MjAwOC0wOS0yMyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKICAgICAg ICAgRml4ZXMgYSBidWcgd2hlcmUgaW5zcGVjdGluZyBzb21lIHNob3J0IHRleHQgbm9kZXMgZG9l cwogICAgICAgICBub3QgcmV2ZWFsIHRoZW0gaW4gdGhlIEVsZW1lbnRzIHBhbmVsIERPTSB0cmVl LgogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpzIGIv V2ViQ29yZS9wYWdlL2luc3BlY3Rvci90cmVlb3V0bGluZS5qcwppbmRleCBjYWZkNTE3Li41Nzll N2ZiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpzCisr KyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvdHJlZW91dGxpbmUuanMKQEAgLTE0OCw4ICsxNDgs MTEgQEAgVHJlZU91dGxpbmUuX3JlbW92ZUNoaWxkQXRJbmRleCA9IGZ1bmN0aW9uKGNoaWxkSW5k ZXgpCiAgICAgaWYgKGNoaWxkLm5leHRTaWJsaW5nKQogICAgICAgICBjaGlsZC5uZXh0U2libGlu Zy5wcmV2aW91c1NpYmxpbmcgPSBjaGlsZC5wcmV2aW91c1NpYmxpbmc7CiAKLSAgICBpZiAoY2hp bGQudHJlZU91dGxpbmUpCisgICAgaWYgKGNoaWxkLnRyZWVPdXRsaW5lKSB7CiAgICAgICAgIGNo aWxkLnRyZWVPdXRsaW5lLl9mb3JnZXRUcmVlRWxlbWVudChjaGlsZCk7CisgICAgICAgIGNoaWxk LnRyZWVPdXRsaW5lLl9mb3JnZXRDaGlsZHJlblJlY3Vyc2l2ZShjaGlsZCk7CisgICAgfQorCiAg ICAgY2hpbGQuX2RldGFjaCgpOwogICAgIGNoaWxkLnRyZWVPdXRsaW5lID0gbnVsbDsKICAgICBj aGlsZC5wYXJlbnQgPSBudWxsOwpAQCAtMTc0LDggKzE3NywxMiBAQCBUcmVlT3V0bGluZS5fcmVt b3ZlQ2hpbGRyZW4gPSBmdW5jdGlvbigpCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLmNo aWxkcmVuLmxlbmd0aDsgKytpKSB7CiAgICAgICAgIHZhciBjaGlsZCA9IHRoaXMuY2hpbGRyZW5b aV07CiAgICAgICAgIGNoaWxkLmRlc2VsZWN0KCk7Ci0gICAgICAgIGlmIChjaGlsZC50cmVlT3V0 bGluZSkKKworICAgICAgICBpZiAoY2hpbGQudHJlZU91dGxpbmUpIHsKICAgICAgICAgICAgIGNo aWxkLnRyZWVPdXRsaW5lLl9mb3JnZXRUcmVlRWxlbWVudChjaGlsZCk7CisgICAgICAgICAgICBj aGlsZC50cmVlT3V0bGluZS5fZm9yZ2V0Q2hpbGRyZW5SZWN1cnNpdmUoY2hpbGQpOworICAgICAg ICB9CisKICAgICAgICAgY2hpbGQuX2RldGFjaCgpOwogICAgICAgICBjaGlsZC50cmVlT3V0bGlu ZSA9IG51bGw7CiAgICAgICAgIGNoaWxkLnBhcmVudCA9IG51bGw7CkBAIC0yMjAsOCArMjI3LDcg QEAgVHJlZU91dGxpbmUucHJvdG90eXBlLl9yZW1lbWJlclRyZWVFbGVtZW50ID0gZnVuY3Rpb24o ZWxlbWVudCkKIAogICAgIC8vIGNoZWNrIGlmIHRoZSBlbGVtZW50IGlzIGFscmVhZHkga25vd24K ICAgICB2YXIgZWxlbWVudHMgPSB0aGlzLl9rbm93blRyZWVFbGVtZW50c1tlbGVtZW50LmlkZW50 aWZpZXJdOwotICAgIGZvciAodmFyIGkgPSAwOyBpIDwgZWxlbWVudHMubGVuZ3RoOyArK2kpCi0g ICAgICAgIGlmIChlbGVtZW50c1tpXSA9PT0gZWxlbWVudCkKKyAgICBpZiAoZWxlbWVudHMuaW5k ZXhPZihlbGVtZW50KSAhPT0gLTEpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAvLyBhZGQg dGhlIGVsZW1lbnQKQEAgLTIzMCwxNSArMjM2LDE2IEBAIFRyZWVPdXRsaW5lLnByb3RvdHlwZS5f cmVtZW1iZXJUcmVlRWxlbWVudCA9IGZ1bmN0aW9uKGVsZW1lbnQpCiAKIFRyZWVPdXRsaW5lLnBy b3RvdHlwZS5fZm9yZ2V0VHJlZUVsZW1lbnQgPSBmdW5jdGlvbihlbGVtZW50KQogewotICAgIGlm ICghdGhpcy5fa25vd25UcmVlRWxlbWVudHNbZWxlbWVudC5pZGVudGlmaWVyXSkKLSAgICAgICAg cmV0dXJuOworICAgIGlmICh0aGlzLl9rbm93blRyZWVFbGVtZW50c1tlbGVtZW50LmlkZW50aWZp ZXJdKQorICAgICAgICB0aGlzLl9rbm93blRyZWVFbGVtZW50c1tlbGVtZW50LmlkZW50aWZpZXJd LnJlbW92ZShlbGVtZW50LCB0cnVlKTsKK30KIAotICAgIHZhciBlbGVtZW50cyA9IHRoaXMuX2tu b3duVHJlZUVsZW1lbnRzW2VsZW1lbnQuaWRlbnRpZmllcl07Ci0gICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBlbGVtZW50cy5sZW5ndGg7ICsraSkgewotICAgICAgICBpZiAoZWxlbWVudHNbaV0gPT09 IGVsZW1lbnQpIHsKLSAgICAgICAgICAgIGVsZW1lbnRzLnNwbGljZShpLCAxKTsKLSAgICAgICAg ICAgIGJyZWFrOwotICAgICAgICB9CitUcmVlT3V0bGluZS5wcm90b3R5cGUuX2ZvcmdldENoaWxk cmVuUmVjdXJzaXZlID0gZnVuY3Rpb24ocGFyZW50RWxlbWVudCkKK3sKKyAgICB2YXIgY2hpbGQg PSBwYXJlbnRFbGVtZW50LmNoaWxkcmVuWzBdOworICAgIHdoaWxlIChjaGlsZCkgeworICAgICAg ICB0aGlzLl9mb3JnZXRUcmVlRWxlbWVudChjaGlsZCk7CisgICAgICAgIGNoaWxkID0gY2hpbGQu dHJhdmVyc2VOZXh0VHJlZUVsZW1lbnQoZmFsc2UsIHRoaXMsIHRydWUpOwogICAgIH0KIH0KIApk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci91dGlsaXRpZXMuanMgYi9XZWJDb3Jl L3BhZ2UvaW5zcGVjdG9yL3V0aWxpdGllcy5qcwppbmRleCAzMTIyMWY5Li44Zjg2NTA0IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL3V0aWxpdGllcy5qcworKysgYi9XZWJDb3Jl L3BhZ2UvaW5zcGVjdG9yL3V0aWxpdGllcy5qcwpAQCAtOTIzLDEzICs5MjMsMTcgQEAgSFRNTFRl eHRBcmVhRWxlbWVudC5wcm90b3R5cGUubW92ZUN1cnNvclRvRW5kID0gZnVuY3Rpb24oKQogCiBB cnJheS5wcm90b3R5cGUucmVtb3ZlID0gZnVuY3Rpb24odmFsdWUsIG9ubHlGaXJzdCkKIHsKKyAg ICBpZiAob25seUZpcnN0KSB7CisgICAgICAgIHZhciBpbmRleCA9IHRoaXMuaW5kZXhPZih2YWx1 ZSk7CisgICAgICAgIGlmIChpbmRleCAhPT0gLTEpCisgICAgICAgICAgICB0aGlzLnNwbGljZShp bmRleCwgMSk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICB2YXIgbGVuZ3RoID0gdGhp cy5sZW5ndGg7CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewotICAgICAg ICBpZiAodGhpc1tpXSA9PT0gdmFsdWUpIHsKKyAgICAgICAgaWYgKHRoaXNbaV0gPT09IHZhbHVl KQogICAgICAgICAgICAgdGhpcy5zcGxpY2UoaSwgMSk7Ci0gICAgICAgICAgICBpZiAob25seUZp cnN0KQotICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CiAgICAgfQogfQogCi0tIAox LjYuMC4yCgo=