210353 2020-04-10 13:27:22 -0700 Null ptr Deref in RadioButtonGroups::updateCheckedState 2020-04-10 16:16:02 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pgyanchandani webkit-unassigned cdumez esprehn+autocc ews-watchlist kangil.han webkit-bug-importer wenson_hsieh oldest_to_newest 1640331 0 pgyanchandani 2020-04-10 13:27:22 -0700 Crash is observed when default checked is called for HTML Input element and radioButtonGroup is NULL. 1640335 1 pgyanchandani 2020-04-10 13:29:25 -0700 rdar://problem/61290022 1640343 2 396118 pgyanchandani 2020-04-10 13:37:51 -0700 Created attachment 396118 Patch 1640344 3 396118 wenson_hsieh 2020-04-10 13:44:32 -0700 Comment on attachment 396118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396118&action=review > Source/WebCore/ChangeLog:8 > + Crash happend when default checked setter was called an input element and RadioButtonGroup was NULL. Nit - “This crash happened when the default…" > Source/WebCore/ChangeLog:9 > + Added a NULL pointer check before derefercing. Nit - “dereferencing" > LayoutTests/fast/forms/input-element-default-checked-setter-crash.html:1 > +<!DOCHTML> Nit - <!DOCTYPE html>? 1640347 4 396118 wenson_hsieh 2020-04-10 13:52:40 -0700 Comment on attachment 396118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396118&action=review > LayoutTests/fast/forms/input-element-default-checked-setter-crash.html:16 > +<meta id="meta1"> </meta> I don’t think this meta tag is necessary to reproduce this crash. Here’s a slightly simpler version of this test case: <!DOCTYPE html> <html> <body> <p>This test passes if there is no crash</p> <div id="container"> <iframe id="frame"></iframe> <input id="input" name=" " type="radio"> </div> <script> if (window.testRunner) testRunner.dumpAsText(); frame.onload = () => input.defaultChecked = true; document.body.appendChild(container); </script> </body> </html> 1640348 5 396118 cdumez 2020-04-10 13:54:40 -0700 Comment on attachment 396118 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396118&action=review > Source/WebCore/dom/RadioButtonGroups.cpp:231 > + auto* group = m_nameToGroupMap.get(element.name().impl()); if (auto* group = m_nameToGroupMap.get(element.name().impl())) group->updateCheckedState(element) would be more concise. 1640369 6 396125 pgyanchandani 2020-04-10 14:26:42 -0700 Created attachment 396125 Patch 1640370 7 pgyanchandani 2020-04-10 14:27:59 -0700 Hi Chirs and Wensen, Thanks for quick review comments. I have incorporated the comments. Regards, Pinki 1640372 8 396125 cdumez 2020-04-10 14:29:59 -0700 Comment on attachment 396125 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396125&action=review > Source/WebCore/ChangeLog:8 > + This crash happend when the default checked setter was called for an input element and RadioButtonGroup was NULL. typo: happend > Source/WebCore/ChangeLog:9 > + Added condition to deference the group only if it is valid. typo: deference -> dereference s/valid/non-null > LayoutTests/fast/forms/input-element-default-checked-setter-crash.html:4 > +<p>This test passes if there is no crash</p> nit: There should be a period at the end of your sentence. 1640403 9 396131 pgyanchandani 2020-04-10 15:45:31 -0700 Created attachment 396131 Patch 1640411 10 ews-feeder 2020-04-10 16:16:01 -0700 Committed r259911: <https://trac.webkit.org/changeset/259911> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396131. 396118 2020-04-10 13:37:51 -0700 2020-04-10 14:26:39 -0700 Patch bug-210353-20200410133750.patch text/plain 3712 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uOTU2ZTA2ODM3NGVmMTI5ODE3Mjg2NWQyYmY3NDUx NjlmZjVhOWFkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA0LTEwICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IHB0ciBEZXJlZiBpbiBSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzNTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmFzaCBoYXBwZW5k IHdoZW4gZGVmYXVsdCBjaGVja2VkIHNldHRlciB3YXMgY2FsbGVkIGFuIGlucHV0IGVsZW1lbnQg YW5kIFJhZGlvQnV0dG9uR3JvdXAgd2FzIE5VTEwuCisgICAgICAgIEFkZGVkIGEgTlVMTCBwb2lu dGVyIGNoZWNrIGJlZm9yZSBkZXJlZmVyY2luZy4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1z L2lucHV0LWVsZW1lbnQtZGVmYXVsdC1jaGVja2VkLXNldHRlci1jcmFzaC5odG1sCisKKyAgICAg ICAgKiBkb20vUmFkaW9CdXR0b25Hcm91cHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmFkaW9C dXR0b25Hcm91cHM6OnVwZGF0ZUNoZWNrZWRTdGF0ZSk6CisKIDIwMjAtMDMtMTAgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGxvZ2dpbmcgZm9yIE1vZGVy biBFTUUgbWV0aG9kcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9SYWRpb0J1dHRv bkdyb3Vwcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vUmFkaW9CdXR0b25Hcm91cHMuY3BwCmlu ZGV4IGI5OGVhYThkNzIyMDkzODA4NWJmOTgxYTlkZGZmMTMyNDNiNzBlNGYuLjk4NTBmMDM4MjNh MTBkNDYyZWE1MWEyOGNiNjU0ZmM2MDY4Y2I1ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9SYWRpb0J1dHRvbkdyb3Vwcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1JhZGlv QnV0dG9uR3JvdXBzLmNwcApAQCAtMjI4LDcgKzIyOCwxMCBAQCB2b2lkIFJhZGlvQnV0dG9uR3Jv dXBzOjp1cGRhdGVDaGVja2VkU3RhdGUoSFRNTElucHV0RWxlbWVudCYgZWxlbWVudCkKICAgICBB U1NFUlQoZWxlbWVudC5pc1JhZGlvQnV0dG9uKCkpOwogICAgIGlmIChlbGVtZW50Lm5hbWUoKS5p c0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKLSAgICBtX25hbWVUb0dyb3VwTWFwLmdldChlbGVt ZW50Lm5hbWUoKS5pbXBsKCkpLT51cGRhdGVDaGVja2VkU3RhdGUoZWxlbWVudCk7CisgICAgYXV0 byogZ3JvdXAgPSBtX25hbWVUb0dyb3VwTWFwLmdldChlbGVtZW50Lm5hbWUoKS5pbXBsKCkpOwor ICAgIGlmICghZ3JvdXApCisgICAgICAgIHJldHVybjsKKyAgICBncm91cC0+dXBkYXRlQ2hlY2tl ZFN0YXRlKGVsZW1lbnQpOwogfQogCiB2b2lkIFJhZGlvQnV0dG9uR3JvdXBzOjpyZXF1aXJlZFN0 YXRlQ2hhbmdlZChIVE1MSW5wdXRFbGVtZW50JiBlbGVtZW50KQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGEzNjY3MjM1NjAw YjQxZDc2YTQ0NzA2ZDNlOWIxY2IwNjE1NDQ3MjkuLjU3ZWI3Y2YzNzQzZjkzN2ExZWQyOWNiYWQ4 ZGQzNTMyNjlmYzBkNGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wNC0xMCAgUGlua2kg R3lhbmNoYW5kYW5pICA8cGd5YW5jaGFuZGFuaUBhcHBsZS5jb20+CisKKyAgICAgICAgTnVsbCBw dHIgRGVyZWYgaW4gUmFkaW9CdXR0b25Hcm91cHM6OnVwZGF0ZUNoZWNrZWRTdGF0ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMzUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNz aW9uIHRlc3QuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lucHV0LWVsZW1lbnQtZGVmYXVsdC1j aGVja2VkLXNldHRlci1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Zm9ybXMvaW5wdXQtZWxlbWVudC1kZWZhdWx0LWNoZWNrZWQtc2V0dGVyLWNyYXNoLmh0bWw6IEFk ZGVkLgorCiAyMDIwLTAzLTEwICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW1dQRV0gR2FyZGVuaW5nLCBlbWl0IG5ldyBiYXNlbGluZXMgb2YgV2ViR0wg MS4wLjMgY29uZm9ybWFuY2UgdGVzdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvaW5wdXQtZWxlbWVudC1kZWZhdWx0LWNoZWNrZWQtc2V0dGVyLWNyYXNoLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1kZWZhdWx0LWNoZWNrZWQt c2V0dGVyLWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lY2U3OWFlOTRlYjRiMGVlNTE3 YjQ1MTIxNTM2YTdkMmYxMGVkYzMzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1zZXR0ZXItY3Jhc2gtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgdGhlcmUgaXMgbm8gY3Jh c2gKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1kZWZh dWx0LWNoZWNrZWQtc2V0dGVyLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lu cHV0LWVsZW1lbnQtZGVmYXVsdC1jaGVja2VkLXNldHRlci1jcmFzaC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjYxOTVhMGQ4NmVmOTU2ZjFlMzEyMDRlYmI5NjZjZTJkZWI0ODdjZTYKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWVsZW1lbnQtZGVmYXVsdC1jaGVja2Vk LXNldHRlci1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMjEgQEAKKzwhRE9DSFRNTD4KKzxodG1sPgor PHNjcmlwdD4KKworZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5u ZXIpCisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAgaWQxLm9ubG9hZCA9 ICgpID0+IGlucHV0MS5kZWZhdWx0Q2hlY2tlZCA9IHRydWU7CisgICAgbWV0YTEuYXBwZW5kQ2hp bGQob3V0MSk7Cit9Cis8L3NjcmlwdD4KKworPGJvZHkgb25sb2FkPXJ1blRlc3QoKT4KKzxwPlRo aXMgdGVzdCBwYXNzZXMgaWYgdGhlcmUgaXMgbm8gY3Jhc2ggPC9wPgorPG1ldGEgaWQ9Im1ldGEx Ij4gPC9tZXRhPgorPG91dHB1dCBpZD0ib3V0MSI+Cis8aWZyYW1lIGlkPSJpZDEiID48L2lmcmFt ZT4KKzxpbnB1dCBpZD0iaW5wdXQxIiBuYW1lPSIgIiB0eXBlPSJyYWRpbyI+Cis8L2JvZHk+Cis8 L2h0bWw+Cg== 396125 2020-04-10 14:26:42 -0700 2020-04-10 15:45:28 -0700 Patch bug-210353-20200410142641.patch text/plain 3664 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uNGJiNmQ2OTEyM2FhM2IyMDEzZmRlYTcwYTRkNjE4 MGM0YjhmYWE4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA0LTEwICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IHB0ciBEZXJlZiBpbiBSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzNTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNyYXNoIGhh cHBlbmQgd2hlbiB0aGUgZGVmYXVsdCBjaGVja2VkIHNldHRlciB3YXMgY2FsbGVkIGZvciBhbiBp bnB1dCBlbGVtZW50IGFuZCBSYWRpb0J1dHRvbkdyb3VwIHdhcyBOVUxMLgorICAgICAgICBBZGRl ZCBjb25kaXRpb24gdG8gZGVmZXJlbmNlIHRoZSBncm91cCBvbmx5IGlmIGl0IGlzIHZhbGlkLgor CisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1kZWZhdWx0LWNoZWNrZWQt c2V0dGVyLWNyYXNoLmh0bWwKKworICAgICAgICAqIGRvbS9SYWRpb0J1dHRvbkdyb3Vwcy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRl KToKKwogMjAyMC0wMy0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgbG9nZ2luZyBmb3IgTW9kZXJuIEVNRSBtZXRob2RzLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL1JhZGlvQnV0dG9uR3JvdXBzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9SYWRpb0J1dHRvbkdyb3Vwcy5jcHAKaW5kZXggYjk4ZWFhOGQ3MjIwOTM4MDg1YmY5ODFhOWRk ZmYxMzI0M2I3MGU0Zi4uZGFjNzgwMzQ4ZWExMzc4ZDc3NTNjMmQzMzM2MWU3YWMzYmY5NTQwMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1JhZGlvQnV0dG9uR3JvdXBzLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vUmFkaW9CdXR0b25Hcm91cHMuY3BwCkBAIC0yMjgsNyArMjI4 LDggQEAgdm9pZCBSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRlKEhUTUxJbnB1 dEVsZW1lbnQmIGVsZW1lbnQpCiAgICAgQVNTRVJUKGVsZW1lbnQuaXNSYWRpb0J1dHRvbigpKTsK ICAgICBpZiAoZWxlbWVudC5uYW1lKCkuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47Ci0gICAg bV9uYW1lVG9Hcm91cE1hcC5nZXQoZWxlbWVudC5uYW1lKCkuaW1wbCgpKS0+dXBkYXRlQ2hlY2tl ZFN0YXRlKGVsZW1lbnQpOworICAgIGlmIChhdXRvKiBncm91cCA9IG1fbmFtZVRvR3JvdXBNYXAu Z2V0KGVsZW1lbnQubmFtZSgpLmltcGwoKSkpCisgICAgICAgIGdyb3VwLT51cGRhdGVDaGVja2Vk U3RhdGUoZWxlbWVudCk7CiB9CiAKIHZvaWQgUmFkaW9CdXR0b25Hcm91cHM6OnJlcXVpcmVkU3Rh dGVDaGFuZ2VkKEhUTUxJbnB1dEVsZW1lbnQmIGVsZW1lbnQpCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTM2NjcyMzU2MDBi NDFkNzZhNDQ3MDZkM2U5YjFjYjA2MTU0NDcyOS4uNTdlYjdjZjM3NDNmOTM3YTFlZDI5Y2JhZDhk ZDM1MzI2OWZjMGQ0ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTEwICBQaW5raSBH eWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxsIHB0 ciBEZXJlZiBpbiBSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzNTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIHJlZ3Jlc3Np b24gdGVzdC4KKworICAgICAgICAqIGZhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1kZWZhdWx0LWNo ZWNrZWQtc2V0dGVyLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9m b3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1zZXR0ZXItY3Jhc2guaHRtbDogQWRk ZWQuCisKIDIwMjAtMDMtMTAgIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4K IAogICAgICAgICBbV1BFXSBHYXJkZW5pbmcsIGVtaXQgbmV3IGJhc2VsaW5lcyBvZiBXZWJHTCAx LjAuMyBjb25mb3JtYW5jZSB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1zZXR0ZXItY3Jhc2gtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1z ZXR0ZXItY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI0NjhlZjBiNDVhMzhiZWQwNjQx ZTZjZDllYjAyMjE5MTkxZDRhMzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2lucHV0LWVsZW1lbnQtZGVmYXVsdC1jaGVja2VkLXNldHRlci1jcmFzaC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNy YXNoCisKKyAgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LWVsZW1l bnQtZGVmYXVsdC1jaGVja2VkLXNldHRlci1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1zZXR0ZXItY3Jhc2guaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi41ZjJmYzgwNjJmM2IxZGU5YmU3ZmU3ZjgyZGFmMjk5M2MyNThjNWMxCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQt Y2hlY2tlZC1zZXR0ZXItY3Jhc2guaHRtbApAQCAtMCwwICsxLDE2IEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPGJvZHk+Cis8cD5UaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlzIG5vIGNy YXNoPC9wPgorPGRpdiBpZD0iY29udGFpbmVyIj4KKyAgICA8aWZyYW1lIGlkPSJmcmFtZSI+PC9p ZnJhbWU+CisgICAgPGlucHV0IGlkPSJpbnB1dCIgbmFtZT0iICIgdHlwZT0icmFkaW8iPgorPC9k aXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworZnJhbWUub25sb2FkID0gKCkgPT4gaW5wdXQuZGVmYXVsdENoZWNrZWQgPSB0 cnVlOworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChjb250YWluZXIpOworPC9zY3JpcHQ+Cis8 L2JvZHk+Cis8L2h0bWw+Cg== 396131 2020-04-10 15:45:31 -0700 2020-04-10 16:16:02 -0700 Patch bug-210353-20200410154530.patch text/plain 3672 pgyanchandani U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc1ZjNhNzViNjEyY2Jh ZDZhYjI5YjVjN2NlOTU3MzM2ZjQ5OWNlYS4uMzUwMDAwNDU0ZThiNjU5MjRjNjIyYjE0YTUwOWU0 YWZmN2JkMjBhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA0LTEwICBQaW5r aSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxs IHB0ciBEZXJlZiBpbiBSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzNTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNyYXNoIGhh cHBlbmVkIHdoZW4gdGhlIGRlZmF1bHQgY2hlY2tlZCBzZXR0ZXIgd2FzIGNhbGxlZCBmb3IgYW4g aW5wdXQgZWxlbWVudCBhbmQgUmFkaW9CdXR0b25Hcm91cCB3YXMgTlVMTC4KKyAgICAgICAgQWRk ZWQgY29uZGl0aW9uIHRvIGRlcmVmZXJlbmNlIHRoZSBncm91cCBvbmx5IGlmIGl0IGlzIG5vbi1u dWxsLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1kZWZhdWx0LWNo ZWNrZWQtc2V0dGVyLWNyYXNoLmh0bWwKKworICAgICAgICAqIGRvbS9SYWRpb0J1dHRvbkdyb3Vw cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tl ZFN0YXRlKToKKwogMjAyMC0wMy0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgbG9nZ2luZyBmb3IgTW9kZXJuIEVNRSBtZXRob2RzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL1JhZGlvQnV0dG9uR3JvdXBzLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9SYWRpb0J1dHRvbkdyb3Vwcy5jcHAKaW5kZXggYjk4ZWFhOGQ3MjIwOTM4MDg1YmY5 ODFhOWRkZmYxMzI0M2I3MGU0Zi4uZGFjNzgwMzQ4ZWExMzc4ZDc3NTNjMmQzMzM2MWU3YWMzYmY5 NTQwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1JhZGlvQnV0dG9uR3JvdXBzLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vUmFkaW9CdXR0b25Hcm91cHMuY3BwCkBAIC0yMjgs NyArMjI4LDggQEAgdm9pZCBSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRlKEhU TUxJbnB1dEVsZW1lbnQmIGVsZW1lbnQpCiAgICAgQVNTRVJUKGVsZW1lbnQuaXNSYWRpb0J1dHRv bigpKTsKICAgICBpZiAoZWxlbWVudC5uYW1lKCkuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47 Ci0gICAgbV9uYW1lVG9Hcm91cE1hcC5nZXQoZWxlbWVudC5uYW1lKCkuaW1wbCgpKS0+dXBkYXRl Q2hlY2tlZFN0YXRlKGVsZW1lbnQpOworICAgIGlmIChhdXRvKiBncm91cCA9IG1fbmFtZVRvR3Jv dXBNYXAuZ2V0KGVsZW1lbnQubmFtZSgpLmltcGwoKSkpCisgICAgICAgIGdyb3VwLT51cGRhdGVD aGVja2VkU3RhdGUoZWxlbWVudCk7CiB9CiAKIHZvaWQgUmFkaW9CdXR0b25Hcm91cHM6OnJlcXVp cmVkU3RhdGVDaGFuZ2VkKEhUTUxJbnB1dEVsZW1lbnQmIGVsZW1lbnQpCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTM2Njcy MzU2MDBiNDFkNzZhNDQ3MDZkM2U5YjFjYjA2MTU0NDcyOS4uNTdlYjdjZjM3NDNmOTM3YTFlZDI5 Y2JhZDhkZDM1MzI2OWZjMGQ0ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTEwICBQ aW5raSBHeWFuY2hhbmRhbmkgIDxwZ3lhbmNoYW5kYW5pQGFwcGxlLmNvbT4KKworICAgICAgICBO dWxsIHB0ciBEZXJlZiBpbiBSYWRpb0J1dHRvbkdyb3Vwczo6dXBkYXRlQ2hlY2tlZFN0YXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzNTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIHJl Z3Jlc3Npb24gdGVzdC4KKworICAgICAgICAqIGZhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1kZWZh dWx0LWNoZWNrZWQtc2V0dGVyLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9mb3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1zZXR0ZXItY3Jhc2guaHRt bDogQWRkZWQuCisKIDIwMjAtMDMtMTAgIERpZWdvIFBpbm8gR2FyY2lhICA8ZHBpbm9AaWdhbGlh LmNvbT4KIAogICAgICAgICBbV1BFXSBHYXJkZW5pbmcsIGVtaXQgbmV3IGJhc2VsaW5lcyBvZiBX ZWJHTCAxLjAuMyBjb25mb3JtYW5jZSB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1zZXR0ZXItY3Jhc2gtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC1lbGVtZW50LWRlZmF1bHQtY2hl Y2tlZC1zZXR0ZXItY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjAzNDA4M2YyZTAwNmUy OTBlNTdlNmJjMGFkYWFjNzU3Yzg0NzQyZDcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2lucHV0LWVsZW1lbnQtZGVmYXVsdC1jaGVja2VkLXNldHRlci1jcmFzaC1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIHRoZXJlIGlz IG5vIGNyYXNoLgorCisgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1 dC1lbGVtZW50LWRlZmF1bHQtY2hlY2tlZC1zZXR0ZXItY3Jhc2guaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1kZWZhdWx0LWNoZWNrZWQtc2V0dGVyLWNyYXNoLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMGFlNzlmYjc5ZGFiZTQxN2NjN2MxYzBlNjc2OGRiZGUwODYxY2ZiNgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5wdXQtZWxlbWVudC1k ZWZhdWx0LWNoZWNrZWQtc2V0dGVyLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxNiBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGVyZSBp cyBubyBjcmFzaC48L3A+Cis8ZGl2IGlkPSJjb250YWluZXIiPgorICAgIDxpZnJhbWUgaWQ9ImZy YW1lIj48L2lmcmFtZT4KKyAgICA8aW5wdXQgaWQ9ImlucHV0IiBuYW1lPSIgIiB0eXBlPSJyYWRp byI+Cis8L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1 bm5lci5kdW1wQXNUZXh0KCk7CitmcmFtZS5vbmxvYWQgPSAoKSA9PiBpbnB1dC5kZWZhdWx0Q2hl Y2tlZCA9IHRydWU7Citkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGNvbnRhaW5lcik7Cis8L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K