210351 2020-04-10 13:22:12 -0700 [ macOS ] scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html is flaky timing out 2020-06-02 20:08:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jacob_uphoff simon.fraser simon.fraser thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1640326 0 jacob_uphoff 2020-04-10 13:22:12 -0700 scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html This test started to flaky timeout after it was added in r259872 History: https://results.webkit.org/?suite=layout-tests&test=scrollingcoordinator%2Fmac%2Flatching%2Fhorizontal-overflow-back-swipe.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/tiled-drawing/simple-document-with-margin-tiles-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/tiled-drawing/simple-document-with-margin-tiles-actual.txt @@ -10,12 +10,12 @@ (bounds 1208.00 2021.00) (contentsOpaque 1) (visible rect 0.00, 0.00 785.00 x 585.00) - (coverage rect -392.50, -512.00 1570.00 x 1755.00) + (coverage rect 0.00, 0.00 785.00 x 585.00) (intersects coverage rect 1) (contentsScale 1.00) - (tile cache coverage -512, -512 2048 x 2048) + (tile cache coverage 0, 0 1024 x 1024) (tile size 512 x 512) - (top left tile -1, -1 tiles grid 4 x 4) + (top left tile 0, 0 tiles grid 2 x 2) (in window 1) ) ) 1640327 1 webkit-bug-importer 2020-04-10 13:23:21 -0700 <rdar://problem/61601449> 1640328 2 webkit-bug-importer 2020-04-10 13:23:25 -0700 <rdar://problem/61601464> 1640334 3 jacob_uphoff 2020-04-10 13:28:37 -0700 Sorry, wrong diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe-actual.txt @@ -1,14 +1,5 @@ -Scrolls vertically -Scrolls horizontally -A back swipe, over a scrolled-to-left overflow, should start a navigation gesture. +#PID UNRESPONSIVE - WebKitTestRunner (pid 16747) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -Swipe to the left -PASS minXOffset is 0 -PASS maxXOffset is -1000 -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF 1641860 4 jacob_uphoff 2020-04-15 10:28:24 -0700 Set expectations here: https://trac.webkit.org/changeset/260138/webkit 1642105 5 simon.fraser 2020-04-15 19:26:47 -0700 (In reply to Jacob Uphoff from comment #4) > Set expectations here: https://trac.webkit.org/changeset/260138/webkit This was done incorrectly. LayoutTests/TestExpectations skips all of scrollingcoordinator (line 55) and LayoutTests/TestExpectations/platform/mac-wk2/ enables them, but this added an expectation in LayoutTests/platform/mac/TestExpectations:1978 which makes scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html run (and always time out) in WebKit1. 1658371 6 400838 simon.fraser 2020-06-02 10:49:55 -0700 Created attachment 400838 Patch 1658433 7 ews-feeder 2020-06-02 13:44:10 -0700 Committed r262438: <https://trac.webkit.org/changeset/262438> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400838. 1658590 8 simon.fraser 2020-06-02 20:08:36 -0700 https://trac.webkit.org/r262472 400838 2020-06-02 10:49:55 -0700 2020-06-02 13:44:10 -0700 Patch bug-210351-20200602104955.patch text/plain 2612 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMzkwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2Q1OTljZjQ2NmFkMWNlYzE4MDg3 OWEyMGFmYWFjNzk4ZDA4NTFkYi4uYjA5M2YzNjQ1NTQ2MGFlMWI0OWZlZTY3NzAyYTRiYjkzZDk5 NzcxMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA2LTAyICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFsgbWFjT1MgXSBzY3JvbGxpbmdjb29y ZGluYXRvci9tYWMvbGF0Y2hpbmcvaG9yaXpvbnRhbC1vdmVyZmxvdy1iYWNrLXN3aXBlLmh0bWwg aXMgZmxha3kgdGltaW5nIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjEwMzUxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTYwMTQ2ND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcnkgdG8gZGVm bGFrZSB0aGlzIHRlc3QuIEl0IHRpbWVkIG91dCB3aGVuIGFsbCB0aGUgd2hlZWwgZXZlbnRzIHdl cmUgcmVjZWl2ZWQgaW4gdGhlIFVJIHByb2Nlc3MKKyAgICAgICAgYmVmb3JlIHRoZSBWaWV3R2Vz dHVyZUNvbnRyb2xsZXIgaGFkIHJlY2VpdmVkIGEgcmVzcG9uc2UgZnJvbSB0aGUgd2ViIHByb2Nl c3MgYWJvdXQgd2hldGhlciB0aGUKKyAgICAgICAgZmlyc3QgZXZlbnQgaGFkIGJlZW4gaGFuZGxl ZC4gRml4IGJ5IGFkZGluZyBhIHJBRigpIHdhaXQgaW4gdGhlIG1pZGRsZSBvZiBzZW5kaW5nIHRo ZSBldmVudHMuCisgICAgICAgIAorICAgICAgICBBbHNvIHJlZ2lzdGVyIHRoZSBzd2lwZSBjYWxs YmFjayBiZWZvcmUgc3RhcnRpbmcgdGhlIGV2ZW50IHNlbmRpbmcuCisKKyAgICAgICAgKiBzY3Jv bGxpbmdjb29yZGluYXRvci9tYWMvbGF0Y2hpbmcvaG9yaXpvbnRhbC1vdmVyZmxvdy1iYWNrLXN3 aXBlLmh0bWw6CisKIDIwMjAtMDYtMDEgIEphc29uIExhd3JlbmNlICA8bGF3cmVuY2UuakBhcHBs ZS5jb20+CiAKICAgICAgICAgKHIyNjExMDMpIFsgTWFjIFdLMiBdIGluc3BlY3Rvci9wYWdlL292 ZXJyaWRlU2V0dGluZy1JVFBEZWJ1Z01vZGVFbmFibGVkLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJl CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zY3JvbGxpbmdjb29yZGluYXRvci9tYWMvbGF0Y2hp bmcvaG9yaXpvbnRhbC1vdmVyZmxvdy1iYWNrLXN3aXBlLmh0bWwgYi9MYXlvdXRUZXN0cy9zY3Jv bGxpbmdjb29yZGluYXRvci9tYWMvbGF0Y2hpbmcvaG9yaXpvbnRhbC1vdmVyZmxvdy1iYWNrLXN3 aXBlLmh0bWwKaW5kZXggZDQ3ZWQ2OWFkN2UxNjdlYzYxM2Y2MmE0MGJmNTA0YTcxZmYyMTYyOS4u YWEyZjg5OGMzMTNhN2U3ZWQ1ZjBlM2EyZjJiNmJjZjY2MDllZDlkNiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvc2Nyb2xsaW5nY29vcmRpbmF0b3IvbWFjL2xhdGNoaW5nL2hvcml6b250YWwtb3Zl cmZsb3ctYmFjay1zd2lwZS5odG1sCisrKyBiL0xheW91dFRlc3RzL3Njcm9sbGluZ2Nvb3JkaW5h dG9yL21hYy9sYXRjaGluZy9ob3Jpem9udGFsLW92ZXJmbG93LWJhY2stc3dpcGUuaHRtbApAQCAt NDksNiArNDksNyBAQAogICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhX aGVlbEFuZE1vbWVudHVtUGhhc2VzKDEsIDAsICJiZWdhbiIsICJub25lIik7CiAgICAgICAgICAg ICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFzZXMoMTAs IDAsICJjaGFuZ2VkIiwgIm5vbmUiKTsKICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlU2Ny b2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygxMCwgMCwgImNoYW5nZWQiLCAibm9uZSIp OworICAgICAgICAgICAgYXdhaXQgVUlIZWxwZXIuYW5pbWF0aW9uRnJhbWUoKTsKICAgICAgICAg ICAgIGV2ZW50U2VuZGVyLm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygx MCwgMCwgImNoYW5nZWQiLCAibm9uZSIpOwogICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VT Y3JvbGxCeVdpdGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIDAsICJlbmRlZCIsICJub25lIik7 CiAgICAgICAgICAgICByZXR1cm4gVUlIZWxwZXIud2FpdEZvclNjcm9sbENvbXBsZXRpb24oKTsK QEAgLTg2LDcgKzg3LDcgQEAKIAogICAgICAgICAgICAgZGVidWcoJ1N3aXBlIHRvIHRoZSBsZWZ0 Jyk7CiAgICAgICAgICAgICAKLSAgICAgICAgICAgIGF3YWl0IFByb21pc2UuYWxsKFtvblNjcm9s bENvbXBsZXRpb24obW91c2VMb2NhdGlvblgsIG1vdXNlTG9jYXRpb25ZKSwgb25Td2lwZUNhbGxi YWNrKCldKTsKKyAgICAgICAgICAgIGF3YWl0IFByb21pc2UuYWxsKFtvblN3aXBlQ2FsbGJhY2so KSwgb25TY3JvbGxDb21wbGV0aW9uKG1vdXNlTG9jYXRpb25YLCBtb3VzZUxvY2F0aW9uWSldKTsK IAogICAgICAgICAgICAgLy8gU2hvdWxkIG5vdCBoYXZlIHJlY2VpdmVkIGFueSBzY3JvbGwgZXZl bnRzLgogICAgICAgICAgICAgc2hvdWxkQmUoJ21pblhPZmZzZXQnLCAnMCcpOwo=