210349 2020-04-10 11:16:33 -0700 [ Mac wk2 Debug ] media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out. 2020-04-16 08:53:08 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j graouts eric.carlson ews-watchlist glenn graouts graouts jer.noble philipj sergio webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1640272 0 Lawrence.j 2020-04-10 11:16:33 -0700 media/modern-media-controls/media-controller/media-controller-auto-hide.html Description: This test is flaky failing on Mac wk2 Debug. The flaky failures are apparent throughout the visible history. History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-auto-hide.html&flavor=wk2&style=debug&platform=mac Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-actual.txt @@ -1,13 +1,5 @@ -Testing the controls bar fades out as expected after the auto-hide delay expires upon first play. +#PID UNRESPONSIVE - WebKitTestRunner (pid 82861) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS !!shadowRoot.querySelector('.media-controls') became true -PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false -PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true - -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF 1640273 1 webkit-bug-importer 2020-04-10 11:17:12 -0700 <rdar://problem/61594098> 1640277 2 Lawrence.j 2020-04-10 11:23:34 -0700 I have marked this test as flaky timing out while this issue is investigated. https://trac.webkit.org/changeset/259884/webkit 1642224 3 graouts 2020-04-16 06:21:15 -0700 Using the test list for the worker where this test times out in the most recent failure reproduces the issue, see https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/8860. 1642267 4 396652 graouts 2020-04-16 08:46:44 -0700 Created attachment 396652 Patch 1642269 5 396652 eric.carlson 2020-04-16 08:49:34 -0700 Comment on attachment 396652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396652&action=review > LayoutTests/ChangeLog:19 > + This test had several things wrong about it. First, it manually created a MediaController in the test page and set a custom auto-hide delay on it. > + However, it would test the proper behavior of the auto-hide behavior on the MediaController created by the media element, querying the state of > + the media controls markup within that media element's shadow root. In that world, the auto-hide delay was the default delay, and not the custom > + one set on the page-created MediaController. > + > + The cause of the timeout was that the media clip used in this test is barely longer than the auto-hide delay, and it could happen that under slow > + conditions, the media would end and the auto-hide timer would never have a chance to fire since it would be canceled due to auto-hide being disabled > + when the media is not playing, such as when it ended. > + > + We make this test saner and more realistic by not customizing the auto-hide delay, removing the page MediaController and simply setting "loop" on the > + media element such that it never stops playing, givin the auto-hide timer additional time to fire with no risk of it being canceled by the media ending. A+ for the ChangeLog comments! 1642270 6 graouts 2020-04-16 08:53:08 -0700 Committed r260189: <https://trac.webkit.org/changeset/260189> 396652 2020-04-16 08:46:44 -0700 2020-04-16 08:49:34 -0700 Patch bug-210349-20200416174643.patch text/plain 4551 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMTc0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmQ1NWVjNjZjNjY5YWVjNDI1NjU3 OThiNmU3YThlNDAwNTU2Zjc1OC4uZjBmMTE4YzllMTFmOGNjYWM0ODVmMGRkYjY3MDlhN2U0NjVk N2NjZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIwLTA0LTE2ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgWyBNYWMgd2syIERlYnVnIF0gbWVkaWEvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzL21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxlci1hdXRv LWhpZGUuaHRtbCBpcyBmbGFreSB0aW1pbmcgb3V0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMzQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82 MTU5NDA5OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIHRlc3QgaGFkIHNldmVyYWwgdGhpbmdzIHdyb25nIGFib3V0IGl0LiBGaXJzdCwgaXQg bWFudWFsbHkgY3JlYXRlZCBhIE1lZGlhQ29udHJvbGxlciBpbiB0aGUgdGVzdCBwYWdlIGFuZCBz ZXQgYSBjdXN0b20gYXV0by1oaWRlIGRlbGF5IG9uIGl0LgorICAgICAgICBIb3dldmVyLCBpdCB3 b3VsZCB0ZXN0IHRoZSBwcm9wZXIgYmVoYXZpb3Igb2YgdGhlIGF1dG8taGlkZSBiZWhhdmlvciBv biB0aGUgTWVkaWFDb250cm9sbGVyIGNyZWF0ZWQgYnkgdGhlIG1lZGlhIGVsZW1lbnQsIHF1ZXJ5 aW5nIHRoZSBzdGF0ZSBvZgorICAgICAgICB0aGUgbWVkaWEgY29udHJvbHMgbWFya3VwIHdpdGhp biB0aGF0IG1lZGlhIGVsZW1lbnQncyBzaGFkb3cgcm9vdC4gSW4gdGhhdCB3b3JsZCwgdGhlIGF1 dG8taGlkZSBkZWxheSB3YXMgdGhlIGRlZmF1bHQgZGVsYXksIGFuZCBub3QgdGhlIGN1c3RvbQor ICAgICAgICBvbmUgc2V0IG9uIHRoZSBwYWdlLWNyZWF0ZWQgTWVkaWFDb250cm9sbGVyLgorCisg ICAgICAgIFRoZSBjYXVzZSBvZiB0aGUgdGltZW91dCB3YXMgdGhhdCB0aGUgbWVkaWEgY2xpcCB1 c2VkIGluIHRoaXMgdGVzdCBpcyBiYXJlbHkgbG9uZ2VyIHRoYW4gdGhlIGF1dG8taGlkZSBkZWxh eSwgYW5kIGl0IGNvdWxkIGhhcHBlbiB0aGF0IHVuZGVyIHNsb3cKKyAgICAgICAgY29uZGl0aW9u cywgdGhlIG1lZGlhIHdvdWxkIGVuZCBhbmQgdGhlIGF1dG8taGlkZSB0aW1lciB3b3VsZCBuZXZl ciBoYXZlIGEgY2hhbmNlIHRvIGZpcmUgc2luY2UgaXQgd291bGQgYmUgY2FuY2VsZWQgZHVlIHRv IGF1dG8taGlkZSBiZWluZyBkaXNhYmxlZAorICAgICAgICB3aGVuIHRoZSBtZWRpYSBpcyBub3Qg cGxheWluZywgc3VjaCBhcyB3aGVuIGl0IGVuZGVkLgorCisgICAgICAgIFdlIG1ha2UgdGhpcyB0 ZXN0IHNhbmVyIGFuZCBtb3JlIHJlYWxpc3RpYyBieSBub3QgY3VzdG9taXppbmcgdGhlIGF1dG8t aGlkZSBkZWxheSwgcmVtb3ZpbmcgdGhlIHBhZ2UgTWVkaWFDb250cm9sbGVyIGFuZCBzaW1wbHkg c2V0dGluZyAibG9vcCIgb24gdGhlCisgICAgICAgIG1lZGlhIGVsZW1lbnQgc3VjaCB0aGF0IGl0 IG5ldmVyIHN0b3BzIHBsYXlpbmcsIGdpdmluIHRoZSBhdXRvLWhpZGUgdGltZXIgYWRkaXRpb25h bCB0aW1lIHRvIGZpcmUgd2l0aCBubyByaXNrIG9mIGl0IGJlaW5nIGNhbmNlbGVkIGJ5IHRoZSBt ZWRpYSBlbmRpbmcuCisKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVk aWEtY29udHJvbGxlci9tZWRpYS1jb250cm9sbGVyLWF1dG8taGlkZS5odG1sOgorICAgICAgICAq IHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wNC0xNSAgTXlsZXMg Qy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gUGFz c3dvcmQgb2JzY3VyaW5nIGRvdHMgZHJhd24gd2l0aCB0aGUgc3lzdGVtIGZvbnQgYXJlIHRvbyBz bWFsbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xz L21lZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxlci1hdXRvLWhpZGUuaHRtbCBiL0xheW91 dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS1jb250cm9sbGVyL21lZGlh LWNvbnRyb2xsZXItYXV0by1oaWRlLmh0bWwKaW5kZXggNWQ3ZTkyMDk1YjA2N2ZlZjk0YmRlNGI1 ODVmMGU2Yjc2NTgwYTdiZC4uZjdlY2RhYTUzZjE5ODA2Y2ZiZDZlMDY5NDU2MmExNDYyOWEwNDZi ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL21l ZGlhLWNvbnRyb2xsZXIvbWVkaWEtY29udHJvbGxlci1hdXRvLWhpZGUuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEtY29udHJvbGxlci9tZWRp YS1jb250cm9sbGVyLWF1dG8taGlkZS5odG1sCkBAIC0xLDExICsxLDggQEAKIDwhRE9DVFlQRSBo dG1sPgogPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+Ci08c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL21lZGlhLWNvbnRyb2xzLWxvYWRlci5q cyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3NjcmlwdD4KLTxzY3JpcHQgc3JjPSIuLi9yZXNv dXJjZXMvbWVkaWEtY29udHJvbHMtdXRpbHMuanMiIHR5cGU9InRleHQvamF2YXNjcmlwdCI+PC9z Y3JpcHQ+CiA8c2NyaXB0IHNyYz0iLi4vLi4vY29udGVudC90ZXN0Lm1wNC5qcyI+PC9zY3JpcHQ+ CiA8Ym9keT4KLSAgICA8dmlkZW8gc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogMDsg dG9wOiAwOyB3aWR0aDogMzIwcHg7IGhlaWdodDogMjQwcHg7IiBjb250cm9scyBhdXRvcGxheT48 L3ZpZGVvPgotICAgIDxkaXYgaWQ9Imhvc3QiPjwvZGl2PgorICAgIDx2aWRlbyBzdHlsZT0icG9z aXRpb246IGFic29sdXRlOyBsZWZ0OiAwOyB0b3A6IDA7IHdpZHRoOiAzMjBweDsgaGVpZ2h0OiAy NDBweDsiIGNvbnRyb2xzIGF1dG9wbGF5IGxvb3A+PC92aWRlbz4KIAogICAgIDxzY3JpcHQgdHlw ZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgICAgICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVl OwpAQCAtMTYsMTAgKzEzLDYgQEAKICAgICAgICAgbWVkaWEuc3JjID0gYmFzZTY0TVA0VVJMKCk7 CiAKICAgICAgICAgY29uc3Qgc2hhZG93Um9vdCA9IHdpbmRvdy5pbnRlcm5hbHMuc2hhZG93Um9v dChtZWRpYSk7Ci0gICAgICAgIGNvbnN0IGNvbnRhaW5lciA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoImRpdiNob3N0Iik7Ci0gICAgICAgIGNvbnN0IG1lZGlhQ29udHJvbGxlciA9IGNyZWF0ZUNv bnRyb2xzKGNvbnRhaW5lciwgbWVkaWEsIG51bGwpOwotCi0gICAgICAgIG1lZGlhQ29udHJvbGxl ci5jb250cm9scy5hdXRvSGlkZUNvbnRyb2xsZXIuYXV0b0hpZGVEZWxheSA9IDEwMDsKICAgICAg ICAgbWVkaWEuYWRkRXZlbnRMaXN0ZW5lcigicGxheSIsIChldmVudCkgPT4gewogICAgICAgICAg ICAgc2hvdWxkQmVjb21lRXF1YWwoIiEhc2hhZG93Um9vdC5xdWVyeVNlbGVjdG9yKCcubWVkaWEt Y29udHJvbHMnKSIsICJ0cnVlIiwgKCkgPT4gewogICAgICAgICAgICAgICAgIHNob3VsZEJlY29t ZUVxdWFsKCJzaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJy5tZWRpYS1jb250cm9scycpLmNsYXNz TGlzdC5jb250YWlucygnZmFkZWQnKSIsICJmYWxzZSIsICgpID0+IHsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwMmMwODJhMmI5MDYzNjJh NjdkYTY1MjQwYjAwZDYyZjgwOWZkY2NjLi5mNDQ5Y2UyM2QyZDhkOTFkOTU0ZjhjY2IwNjE2Yjg2 MWM2MWI0ZDdkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zCkBAIC0xMDQ0LDYgKzEwNDQsNCBAQCB3ZWJraXQub3JnL2IvMjA5ODc4ICBbIERlYnVn IF0gd2VicnRjL2RhdGFjaGFubmVsL211bHRpcGxlLWNvbm5lY3Rpb25zLmh0bWwgWyBTbAogCiB3 ZWJraXQub3JnL2IvMjEwMTY1IFsgQ2F0YWxpbmEgXSB3ZWJydGMvcGVlci1jb25uZWN0aW9uLWF1 ZGlvLW11dGUyLmh0bWwgWyBQYXNzIFRpbWVvdXQgRmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8y MTAzNDkgWyBEZWJ1ZyBdIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS1jb250cm9s bGVyL21lZGlhLWNvbnRyb2xsZXItYXV0by1oaWRlLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQotCiB3 ZWJraXQub3JnL2IvMjEwNDMzIHN3aXBlL2Jhc2ljLWNhY2hlZC1iYWNrLXN3aXBlLmh0bWwgWyBQ YXNzIENyYXNoIFRpbWVvdXQgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK