210334 2020-04-10 07:27:37 -0700 [GTK4] Use ThemeAdwaita instead of ThemeGtk 2020-04-13 22:13:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 aperez aperez aperez bugs-noreply cgarcia csaavedra oldest_to_newest 1640158 0 aperez 2020-04-10 07:27:37 -0700 With GTK4 we cannot obtain the selection theme colors, so instead use ThemeAdwaita which uses the colors from the default theme used by GTK. 1640160 1 396080 aperez 2020-04-10 07:32:04 -0700 Created attachment 396080 Patch 1640371 2 csaavedra 2020-04-10 14:29:32 -0700 With GTK3 the selection colors are actually deprecated, so this is also a problem if we want to completely remove deprecated API usage. Do we want to continue using them? 1640373 3 csaavedra 2020-04-10 14:30:08 -0700 I meant the style context selection color APIs, for what it's worth. 1640410 4 aperez 2020-04-10 16:15:06 -0700 (In reply to Claudio Saavedra from comment #2) > With GTK3 the selection colors are actually deprecated, so this is also a > problem if we want to completely remove deprecated API usage. Do we want to > continue using them? Carlos Garcia specifically added ThemeGtk to have a minimum degree of integration with the system theme, so I think we should keep using it for now when building against GTK3. 1640510 5 cgarcia 2020-04-11 02:52:27 -0700 (In reply to Adrian Perez from comment #4) > (In reply to Claudio Saavedra from comment #2) > > With GTK3 the selection colors are actually deprecated, so this is also a > > problem if we want to completely remove deprecated API usage. Do we want to > > continue using them? > > Carlos Garcia specifically added ThemeGtk to have a minimum degree of > integration with the system theme, so I think we should keep using it > for now when building against GTK3. Yes, let's add deprecation guards if needed. 1640965 6 396304 aperez 2020-04-13 10:31:45 -0700 Created attachment 396304 Patch v2 Same as before, adding deprecation guards in ThemeGtk.cpp 1641249 7 ews-feeder 2020-04-13 22:13:04 -0700 Committed r260058: <https://trac.webkit.org/changeset/260058> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396304. 396080 2020-04-10 07:32:04 -0700 2020-04-13 10:31:40 -0700 Patch bug-210334-20200410173202.patch text/plain 2591 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5ODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmNkOTQ4NThlOGIxNDc0 Y2E1ZDY5Yzk4ZTAzODIwOWZiNjI1YTNhOS4uNmNmYmU3ZDJiYmEwODcwNTFhY2YzMjE4YWFhMmM2 NTlmYjYxNjE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTEwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUSzRd IFVzZSBUaGVtZUFkd2FpdGEgaW5zdGVhZCBvZiBUaGVtZUd0aworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMzM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAg ICAgICAqIHBsYXRmb3JtL2Fkd2FpdGEvVGhlbWVBZHdhaXRhLmNwcDogQnVpbGQgdGhlIFRoZW1l OjpzaW5nbGV0b24oKSBmYWN0b3J5IGFsc28gd2l0aCBVU0UoR1RLNCkuCisgICAgICAgICogcGxh dGZvcm0vZ3RrL1RoZW1lR3RrLmNwcDogQ29uZGl0aW9uYWxseSBidWlsZCBpZiAhVVNFKEdUSzQp LgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9UaGVtZUd0ay5oOiBDb25kaXRpb25hbGx5IGJ1aWxk IGlmICFVU0UoR1RLNCkuCisKIDIwMjAtMDQtMDcgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxh cGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLNF0gRml4IHVzYWdlIG9mIEdESyBldmVu dCBmdW5jdGlvbnMgaW4gUGxhdGZvcm1XaGVlbEV2ZW50R3RrCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9hZHdhaXRhL1RoZW1lQWR3YWl0YS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hZHdhaXRhL1RoZW1lQWR3YWl0YS5jcHAKaW5kZXggZWUzZWJlMDhiMTMyNzQy Y2IwMmY4NTdmMTEwNWE5MGRjZTYwYjJjZi4uZWEyNWQzMjQyMmY1ZjA4YzhlZTE5MjAyYmVmNzI0 N2U2M2ZkZjdlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYWR3YWl0YS9U aGVtZUFkd2FpdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Fkd2FpdGEvVGhl bWVBZHdhaXRhLmNwcApAQCAtNTksNyArNTksNyBAQCBzdGF0aWMgY29uc3QgQ29sb3Igc3BpbkJ1 dHRvbkJhY2tncm91bmRDb2xvciA9IG1ha2VSR0IoMjUyLCAyNTIsIDI1Mik7CiBzdGF0aWMgY29u c3QgQ29sb3Igc3BpbkJ1dHRvbkJhY2tncm91bmRIb3ZlcmVkQ29sb3IgPSBtYWtlUkdCQSg0Niwg NTIsIDU0LCA1MCk7CiBzdGF0aWMgY29uc3QgQ29sb3Igc3BpbkJ1dHRvbkJhY2tncm91bmRQcmVz c2VkQ29sb3IgPSBtYWtlUkdCQSg0NiwgNTIsIDU0LCA3MCk7CiAKLSNpZiAhUExBVEZPUk0oR1RL KQorI2lmICFQTEFURk9STShHVEspIHx8IFVTRShHVEs0KQogVGhlbWUmIFRoZW1lOjpzaW5nbGV0 b24oKQogewogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxUaGVtZUFkd2FpdGE+IHRoZW1lOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1RoZW1lR3RrLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9UaGVtZUd0ay5jcHAKaW5kZXggZjBlZGE2MGI0Yjcz YmIzY2VhYjY3MmI2Y2FlODlkMmEzYjdkNWQ5Ni4uN2ZkMTllYzQ2YzRkYWYxMDFiMjIwNmE5ZTc4 ZWMyMzhlMWY0Y2EwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Ro ZW1lR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVGhlbWVHdGsuY3Bw CkBAIC0yNCw2ICsyNCw5IEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgorCisjaWYgIVVT RShHVEs0KQorCiAjaW5jbHVkZSAiVGhlbWVHdGsuaCIKIAogI2luY2x1ZGUgIkdSZWZQdHJHdGsu aCIKQEAgLTEwNSwzICsxMDgsNSBAQCBDb2xvciBUaGVtZUd0azo6aW5hY3RpdmVTZWxlY3Rpb25C YWNrZ3JvdW5kQ29sb3IoKSBjb25zdAogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKKyNl bmRpZiAvLyAhVVNFKEdUSzQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvVGhlbWVHdGsuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9UaGVtZUd0ay5oCmlu ZGV4IDVjZjI5ZTRjZjFkYTZjMmE2NDVlZTQ3OGUwMGEwY2ZjZDc5ZDJlMjUuLjJjZmM0MmJlZTcy ODgzZTg5MGE1OWY3YWRhN2U5NTQ2OWIwODQ4OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9UaGVtZUd0ay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9UaGVtZUd0ay5oCkBAIC0yNSw2ICsyNSw4IEBACiAKICNwcmFnbWEgb25jZQogCisjaWYgIVVT RShHVEs0KQorCiAjaW5jbHVkZSAiQ29sb3IuaCIKICNpbmNsdWRlICJUaGVtZUFkd2FpdGEuaCIK IApAQCAtNDcsMyArNDksNSBAQCBwcml2YXRlOgogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQorCisjZW5kaWYgLy8gIVVTRShHVEs0KQo= 396304 2020-04-13 10:31:45 -0700 2020-04-13 22:13:05 -0700 Patch v2 bug-210334-20200413203143.patch text/plain 3405 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwMDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg2ZGQ3YTFjZmU2OGEy NTUyMTY1NGRhMmI2MTg4YTNjMmEwZWI5Ny4uNzE5ODI4ODNlZWFhYmViZjEwNjU3NDc4YjM1NjE5 ZGE0MjNiMmY5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTEzICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUSzRd IFVzZSBUaGVtZUFkd2FpdGEgaW5zdGVhZCBvZiBUaGVtZUd0aworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMzM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAg ICAgICAqIHBsYXRmb3JtL2Fkd2FpdGEvVGhlbWVBZHdhaXRhLmNwcDogQnVpbGQgdGhlIFRoZW1l OjpzaW5nbGV0b24oKSBmYWN0b3J5IGFsc28gd2l0aCBVU0UoR1RLNCkuCisgICAgICAgICogcGxh dGZvcm0vZ3RrL1RoZW1lR3RrLmNwcDogQ29uZGl0aW9uYWxseSBidWlsZCBpZiAhVVNFKEdUSzQp LgorICAgICAgICAoV2ViQ29yZTo6VGhlbWVHdGs6OmVuc3VyZVBsYXRmb3JtQ29sb3JzIGNvbnN0 KTogQWRkIGRlcHJlY2F0aW9uIGlnbm9yZSBndWFyZHMuCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1RoZW1lR3RrLmg6IENvbmRpdGlvbmFsbHkgYnVpbGQgaWYgIVVTRShHVEs0KS4KKwogMjAyMC0w NC0xMyAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAg ICAgIFdoZW4gZHJhd2luZyBhbiBpbWFnZSBzcmNSZWN0IGFuZCBpbWFnZVJlY3QgaGF2ZSB0byBi ZSBpbiB0aGUgb3JpZW50YXRpb24gb2YgZGVzdFJlY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Fkd2FpdGEvVGhlbWVBZHdhaXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2Fkd2FpdGEvVGhlbWVBZHdhaXRhLmNwcAppbmRleCBlZTNlYmUwOGIxMzI3NDJjYjAy Zjg1N2YxMTA1YTkwZGNlNjBiMmNmLi5lYTI1ZDMyNDIyZjVmMDhjOGVlMTkyMDJiZWY3MjQ3ZTYz ZmRmN2U3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hZHdhaXRhL1RoZW1l QWR3YWl0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYWR3YWl0YS9UaGVtZUFk d2FpdGEuY3BwCkBAIC01OSw3ICs1OSw3IEBAIHN0YXRpYyBjb25zdCBDb2xvciBzcGluQnV0dG9u QmFja2dyb3VuZENvbG9yID0gbWFrZVJHQigyNTIsIDI1MiwgMjUyKTsKIHN0YXRpYyBjb25zdCBD b2xvciBzcGluQnV0dG9uQmFja2dyb3VuZEhvdmVyZWRDb2xvciA9IG1ha2VSR0JBKDQ2LCA1Miwg NTQsIDUwKTsKIHN0YXRpYyBjb25zdCBDb2xvciBzcGluQnV0dG9uQmFja2dyb3VuZFByZXNzZWRD b2xvciA9IG1ha2VSR0JBKDQ2LCA1MiwgNTQsIDcwKTsKIAotI2lmICFQTEFURk9STShHVEspCisj aWYgIVBMQVRGT1JNKEdUSykgfHwgVVNFKEdUSzQpCiBUaGVtZSYgVGhlbWU6OnNpbmdsZXRvbigp CiB7CiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFRoZW1lQWR3YWl0YT4gdGhlbWU7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVGhlbWVHdGsuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1RoZW1lR3RrLmNwcAppbmRleCBmMGVkYTYwYjRiNzNiYjNj ZWFiNjcyYjZjYWU4OWQyYTNiN2Q1ZDk2Li5mMmY0YTVmMGY2NzYwY2I3YmYyZTk4MjQ0MmJlMGU0 YjVjNWMxMjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVGhlbWVH dGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9UaGVtZUd0ay5jcHAKQEAg LTI0LDYgKzI0LDkgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCisKKyNpZiAhVVNFKEdU SzQpCisKICNpbmNsdWRlICJUaGVtZUd0ay5oIgogCiAjaW5jbHVkZSAiR1JlZlB0ckd0ay5oIgpA QCAtNDQsNiArNDcsOCBAQCB2b2lkIFRoZW1lR3RrOjplbnN1cmVQbGF0Zm9ybUNvbG9ycygpIGNv bnN0CiAgICAgaWYgKG1fYWN0aXZlU2VsZWN0aW9uQmFja2dyb3VuZENvbG9yLmlzVmFsaWQoKSkK ICAgICAgICAgcmV0dXJuOwogCisgICAgR19HTlVDX0JFR0lOX0lHTk9SRV9ERVBSRUNBVElPTlM7 CisKICAgICBHUmVmUHRyPEd0a1dpZGdldFBhdGg+IGVudHJ5UGF0aCA9IGFkb3B0R1JlZihndGtf d2lkZ2V0X3BhdGhfbmV3KCkpOwogICAgIGd0a193aWRnZXRfcGF0aF9hcHBlbmRfdHlwZShlbnRy eVBhdGguZ2V0KCksIEdfVFlQRV9OT05FKTsKICAgICBndGtfd2lkZ2V0X3BhdGhfaXRlcl9zZXRf b2JqZWN0X25hbWUoZW50cnlQYXRoLmdldCgpLCAtMSwgImVudHJ5Iik7CkBAIC03Myw2ICs3OCw4 IEBAIHZvaWQgVGhlbWVHdGs6OmVuc3VyZVBsYXRmb3JtQ29sb3JzKCkgY29uc3QKIAogICAgIGd0 a19zdHlsZV9jb250ZXh0X2dldF9jb2xvcihzZWxlY3Rpb25Db250ZXh0LmdldCgpLCBndGtfc3R5 bGVfY29udGV4dF9nZXRfc3RhdGUoc2VsZWN0aW9uQ29udGV4dC5nZXQoKSksICZjb2xvcik7CiAg ICAgbV9pbmFjdGl2ZVNlbGVjdGlvbkZvcmVncm91bmRDb2xvciA9IGNvbG9yOworCisgICAgR19H TlVDX0VORF9JR05PUkVfREVQUkVDQVRJT05TOwogfQogCiB2b2lkIFRoZW1lR3RrOjpwbGF0Zm9y bUNvbG9yc0RpZENoYW5nZSgpCkBAIC0xMDUsMyArMTEyLDUgQEAgQ29sb3IgVGhlbWVHdGs6Omlu YWN0aXZlU2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKCkgY29uc3QKIH0KIAogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQorCisjZW5kaWYgLy8gIVVTRShHVEs0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL1RoZW1lR3RrLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvVGhlbWVHdGsuaAppbmRleCA1Y2YyOWU0Y2YxZGE2YzJhNjQ1ZWU0NzhlMDBhMGNmY2Q3OWQy ZTI1Li4yY2ZjNDJiZWU3Mjg4M2U4OTBhNTlmN2FkYTdlOTU0NjliMDg0ODk3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVGhlbWVHdGsuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvVGhlbWVHdGsuaApAQCAtMjUsNiArMjUsOCBAQAogCiAjcHJhZ21h IG9uY2UKIAorI2lmICFVU0UoR1RLNCkKKwogI2luY2x1ZGUgIkNvbG9yLmgiCiAjaW5jbHVkZSAi VGhlbWVBZHdhaXRhLmgiCiAKQEAgLTQ3LDMgKzQ5LDUgQEAgcHJpdmF0ZToKIH07CiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKKworI2VuZGlmIC8vICFVU0UoR1RLNCkK