210312 2020-04-09 16:43:03 -0700 Don't emit the rhs twice in `AssignResolveNode` 2020-04-13 12:41:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi ews-watchlist hi keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1639960 0 hi 2020-04-09 16:43:03 -0700 [Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp](http://trac.webkit.org/changeset/259781/webkit/trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp): ``` RefPtr<RegisterID> result = generator.emitNode(dst, m_right); if (isReadOnly) { RegisterID* result = generator.emitNode(dst, m_right); // Execute side effects first. ``` 1639961 1 396026 hi 2020-04-09 16:45:12 -0700 Created attachment 396026 Patch 1639967 2 396027 hi 2020-04-09 17:01:19 -0700 Created attachment 396027 Patch 1639970 3 396027 ysuzuki 2020-04-09 17:07:42 -0700 Comment on attachment 396027 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=396027&action=review r=me > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:2913 > + RefPtr<RegisterID> result = generator.emitNode(dst, m_right); // Execute side effects first. Nice. 1639976 4 ews-feeder 2020-04-09 17:28:16 -0700 Committed r259841: <https://trac.webkit.org/changeset/259841> All reviewed patches have been landed. Closing bug and clearing flags on attachment 396027. 1639977 5 webkit-bug-importer 2020-04-09 17:29:13 -0700 <rdar://problem/61552585> 1640802 6 396027 saam 2020-04-13 01:13:30 -0700 Comment on attachment 396027 Patch No test? 1641040 7 ross.kirsling 2020-04-13 12:41:09 -0700 (In reply to Saam Barati from comment #6) > Comment on attachment 396027 [details] > Patch > > No test? This didn't cause incorrect behavior, it was just redundant. 396026 2020-04-09 16:45:12 -0700 2020-04-09 17:01:18 -0700 Patch bug-210312-20200409174512.patch text/plain 1689 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk4MzlhODNkNzNmOWVmOWJmN2YwY2UwOTNiYTEx OTQ0MTEyZTI5NDkuLjg2Y2NjMTgzMjc4OTFmNmY4OTU2OWU2ZWFhM2RhNGUzNjkyZTQxNDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA0LTA5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBlbWl0IHRoZSBy aHMgdHdpY2UgaW4gYEFzc2lnblJlc29sdmVOb2RlYAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcDoK KyAgICAgICAgKEpTQzo6QXNzaWduUmVzb2x2ZU5vZGU6OmVtaXRCeXRlY29kZSk6CisKIDIwMjAt MDQtMDkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlND XSBNb2R1bGVFbnZpcm9ubWVudCBkbyBub3QgaGF2ZSBKU0dsb2JhbExleGljYWxFbnZpcm9ubWVu dCBhcyBpdHMgdXBwZXIgc2NvcGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAppbmRleCBhNWU0Y2ViNDYyZmE0MmNhYWNlNjQyNGEy MTA2MDY4NWQ1NjkyZGJhLi4yNThiZDY0MDUxNjQwOWMxODRjNTBjOGJkMzEyMDU4MDZjZjQ3MTM2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29k ZWdlbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0Nv ZGVnZW4uY3BwCkBAIC0yOTEwLDkgKzI5MTAsOCBAQCBSZWdpc3RlcklEKiBBc3NpZ25SZXNvbHZl Tm9kZTo6ZW1pdEJ5dGVjb2RlKEJ5dGVjb2RlR2VuZXJhdG9yJiBnZW5lcmF0b3IsIFJlZ2lzdAog ICAgICAgICBnZW5lcmF0b3IuZW1pdFREWkNoZWNrSWZOZWNlc3NhcnkodmFyLCBudWxscHRyLCBz Y29wZS5nZXQoKSk7CiAgICAgaWYgKGRzdCA9PSBnZW5lcmF0b3IuaWdub3JlZFJlc3VsdCgpKQog ICAgICAgICBkc3QgPSAwOwotICAgIFJlZlB0cjxSZWdpc3RlcklEPiByZXN1bHQgPSBnZW5lcmF0 b3IuZW1pdE5vZGUoZHN0LCBtX3JpZ2h0KTsKKyAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gcmVzdWx0 ID0gZ2VuZXJhdG9yLmVtaXROb2RlKGRzdCwgbV9yaWdodCk7ICAvLyBFeGVjdXRlIHNpZGUgZWZm ZWN0cyBmaXJzdC4KICAgICBpZiAoaXNSZWFkT25seSkgewotICAgICAgICBSZWdpc3RlcklEKiBy ZXN1bHQgPSBnZW5lcmF0b3IuZW1pdE5vZGUoZHN0LCBtX3JpZ2h0KTsgLy8gRXhlY3V0ZSBzaWRl IGVmZmVjdHMgZmlyc3QuCiAgICAgICAgIGJvb2wgdGhyZXdFeGNlcHRpb24gPSBnZW5lcmF0b3Iu ZW1pdFJlYWRPbmx5RXhjZXB0aW9uSWZOZWVkZWQodmFyKTsKICAgICAgICAgaWYgKHRocmV3RXhj ZXB0aW9uKQogICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsK 396027 2020-04-09 17:01:19 -0700 2020-04-09 17:28:17 -0700 Patch bug-210312-20200409180119.patch text/plain 1847 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk4MzlhODNkNzNmOWVmOWJmN2YwY2UwOTNiYTEx OTQ0MTEyZTI5NDkuLjg2Y2NjMTgzMjc4OTFmNmY4OTU2OWU2ZWFhM2RhNGUzNjkyZTQxNDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA0LTA5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBlbWl0IHRoZSBy aHMgdHdpY2UgaW4gYEFzc2lnblJlc29sdmVOb2RlYAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcDoK KyAgICAgICAgKEpTQzo6QXNzaWduUmVzb2x2ZU5vZGU6OmVtaXRCeXRlY29kZSk6CisKIDIwMjAt MDQtMDkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlND XSBNb2R1bGVFbnZpcm9ubWVudCBkbyBub3QgaGF2ZSBKU0dsb2JhbExleGljYWxFbnZpcm9ubWVu dCBhcyBpdHMgdXBwZXIgc2NvcGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAppbmRleCBhNWU0Y2ViNDYyZmE0MmNhYWNlNjQyNGEy MTA2MDY4NWQ1NjkyZGJhLi40YzQzNDg4ODJjZmJjMjY5MjQ3YTc3MjJhNzJlYWIzOWJlMmVjNDlh IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29k ZWdlbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0Nv ZGVnZW4uY3BwCkBAIC0yOTEwLDEyICsyOTEwLDExIEBAIFJlZ2lzdGVySUQqIEFzc2lnblJlc29s dmVOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNvZGVHZW5lcmF0b3ImIGdlbmVyYXRvciwgUmVnaXN0 CiAgICAgICAgIGdlbmVyYXRvci5lbWl0VERaQ2hlY2tJZk5lY2Vzc2FyeSh2YXIsIG51bGxwdHIs IHNjb3BlLmdldCgpKTsKICAgICBpZiAoZHN0ID09IGdlbmVyYXRvci5pZ25vcmVkUmVzdWx0KCkp CiAgICAgICAgIGRzdCA9IDA7Ci0gICAgUmVmUHRyPFJlZ2lzdGVySUQ+IHJlc3VsdCA9IGdlbmVy YXRvci5lbWl0Tm9kZShkc3QsIG1fcmlnaHQpOworICAgIFJlZlB0cjxSZWdpc3RlcklEPiByZXN1 bHQgPSBnZW5lcmF0b3IuZW1pdE5vZGUoZHN0LCBtX3JpZ2h0KTsgLy8gRXhlY3V0ZSBzaWRlIGVm ZmVjdHMgZmlyc3QuCiAgICAgaWYgKGlzUmVhZE9ubHkpIHsKLSAgICAgICAgUmVnaXN0ZXJJRCog cmVzdWx0ID0gZ2VuZXJhdG9yLmVtaXROb2RlKGRzdCwgbV9yaWdodCk7IC8vIEV4ZWN1dGUgc2lk ZSBlZmZlY3RzIGZpcnN0LgogICAgICAgICBib29sIHRocmV3RXhjZXB0aW9uID0gZ2VuZXJhdG9y LmVtaXRSZWFkT25seUV4Y2VwdGlvbklmTmVlZGVkKHZhcik7CiAgICAgICAgIGlmICh0aHJld0V4 Y2VwdGlvbikKLSAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CisgICAgICAgICAgICByZXR1cm4g cmVzdWx0LmdldCgpOwogICAgIH0KICAgICBnZW5lcmF0b3IuZW1pdEV4cHJlc3Npb25JbmZvKGRp dm90KCksIGRpdm90U3RhcnQoKSwgZGl2b3RFbmQoKSk7CiAgICAgUmVnaXN0ZXJJRCogcmV0dXJu UmVzdWx0ID0gcmVzdWx0LmdldCgpOwo=