21030 2008-09-23 11:20:10 -0700 The JS debugger breaks on the do of a do-while not the while (where the conditional statement is) 2008-09-23 11:40:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 kmccullough kmccullough oldest_to_newest 92349 0 kmccullough 2008-09-23 11:20:10 -0700 <rdar://problem/6204189> the do get's hit because statementListEmitCode emits a debug hook for the first line of the statement but for do-whiiles we really want it to be on the last line. 92350 1 23709 kmccullough 2008-09-23 11:21:35 -0700 Created attachment 23709 Test file which shows the issue 92351 2 23710 kmccullough 2008-09-23 11:25:26 -0700 Created attachment 23710 Patch 92352 3 23710 darin 2008-09-23 11:28:20 -0700 Comment on attachment 23710 Patch r=me Is there any way to do automated testing of debugger hook changes? + * kjs/nodes.h: + (JSC::StatementNode::): + (JSC::DoWhileNode::): This is kind of weak. When prepare-ChangeLog puts nonsense in the ChangeLog you should fix it instead of just checking it in. 92355 4 kmccullough 2008-09-23 11:40:16 -0700 Committed revision 36809. I fixed the change log and I'll look into automated debugger hook testing. 23709 2008-09-23 11:21:35 -0700 2008-09-23 11:21:35 -0700 Test file which shows the issue curly.html text/html 1026 kmccullough PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIg Imh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQiPgo8aHRt bCB4bWw6bGFuZz0iZW4iIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiBsYW5n PSJlbiI+PGhlYWQ+CgoKCgk8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9 InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+CiAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj cmlwdCIgY2hhcnNldD0idXRmLTgiPgogICAgICAgIGZ1bmN0aW9uIHNob3VsZEJyZWFrKCkgewog ICAgICAgIGlmKHRydWUpCiAgICAgICAgICAgIGNvbnNvbGUubG9nKCdpIGhvcGUgeW91IHJlYWQg dGhpcyBhZnRlciBhIGJyZWFrIHBvaW50Jyk7CgogICAgICAgIGZvcih2YXIgaSA9IDA7IGkgPCAz OyArK2kpIHsKICAgICAgICAgICAgY29uc29sZS5sb2coJ3BhcnQxJyk7CiAgICAgICAgfQoKICAg ICAgICB2YXIgeSA9IG5ldyBBcnJheSgxLDIsMyw0LDUpOwogICAgICAgIGZvciAoeCBpbiB5KSB7 CiAgICAgICAgICAgIGNvbnNvbGUubG9nKCdwYXJ0MicpOwogICAgICAgIH0KCiAgICAgICAgdmFy IGkgPSAwOwogICAgICAgIHdoaWxlKGkrKyA8IDMpIHsKICAgICAgICAgICAgY29uc29sZS5sb2co J3BhcnQzJyk7CiAgICAgICAgfQoKICAgICAgICBpID0gMDsKICAgICAgICBkbyB7CiAgICAgICAg ICAgIGNvbnNvbGUubG9nKCdwYXJ0NCcpOwogICAgICAgIH0gd2hpbGUgKGkrKyA8IDMpCgogICAg ICAgIH0KICAgIDwvc2NyaXB0PgoJPHRpdGxlPkJyZWFrcG9pbnRzIGluIGNvbmRpdGlvbnMgd2l0 aG91dCBjdXJseSBicmFjZXMgZG9uJ3QgYnJlYWs8L3RpdGxlPgoJCjwvaGVhZD48Ym9keT4KUHV0 IGEgYnJlYWtwb2ludCBvbiBsaW5lIDEwIGFuZCB0aGVuLCA8YSBocmVmPSIjIiBvbmNsaWNrPSJz aG91bGRCcmVhaygpOyByZXR1cm4gZmFsc2U7Ij5jbGljayBtZTwvYT4KCjwvYm9keT48L2h0bWw+ 23710 2008-09-23 11:25:26 -0700 2008-09-23 11:28:20 -0700 Patch doWhileBreak.txt text/plain 2374 kmccullough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM2ODA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMDkt MjMgIEtldmluIE1jQ3VsbG91Z2ggIDxrbWNjdWxsb3VnaEBhcHBsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIxMDMwOiBUaGUgSlMg ZGVidWdnZXIgYnJlYWtzIG9uIHRoZSBkbyBvZiBhIGRvLXdoaWxlIG5vdCB0aGUgd2hpbGUKKyAg ICAgICAgKHdoZXJlIHRoZSBjb25kaXRpb25hbCBzdGF0ZW1lbnQgaXMpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAzMAorICAgICAgICBOb3cgdGhl IHN0YXRlbWVudExpc3RFbWl0Q29kZSBkZXRlY3RzIGlmIGEgZG8td2hpbGUgbm9kZSBpcyBiZWlu ZworICAgICAgICBlbWl0ZWQgYW5kIGVtaXRzIHRoZSBkZWJ1ZyBob29rIG9uIHRoZSBsYXN0IGxp bmUgaW5zdGVhZCBvZiB0aGUgZmlyc3QuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgaGFkIG5vIGVm ZmVjdCBvbiBzdW5zcGlkZXIuCisKKyAgICAgICAgKiBranMvbm9kZXMuY3BwOgorICAgICAgICAo SlNDOjpzdGF0ZW1lbnRMaXN0RW1pdENvZGUpOgorICAgICAgICAqIGtqcy9ub2Rlcy5oOgorICAg ICAgICAoSlNDOjpTdGF0ZW1lbnROb2RlOjopOgorICAgICAgICAoSlNDOjpEb1doaWxlTm9kZTo6 KToKKwogMjAwOC0wOS0yMyAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IENhbXJvbiBad2FyaWNoLgpJbmRleDoga2pzL25vZGVzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBranMvbm9kZXMuY3BwCShyZXZpc2lvbiAzNjU0MikKKysrIGtqcy9ub2Rl cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwODQsNyArMTA4NCw3IEBAIHN0YXRpYyBpbmxpbmUg UmVnaXN0ZXJJRCogc3RhdGVtZW50TGlzdEUKICAgICBTdGF0ZW1lbnRWZWN0b3I6Oml0ZXJhdG9y IGVuZCA9IHN0YXRlbWVudHMuZW5kKCk7CiAgICAgZm9yIChTdGF0ZW1lbnRWZWN0b3I6Oml0ZXJh dG9yIGl0ID0gc3RhdGVtZW50cy5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpIHsKICAgICAgICAg U3RhdGVtZW50Tm9kZSogbiA9IGl0LT5nZXQoKTsKLSAgICAgICAgZ2VuZXJhdG9yLmVtaXREZWJ1 Z0hvb2soV2lsbEV4ZWN1dGVTdGF0ZW1lbnQsIG4tPmZpcnN0TGluZSgpLCBuLT5sYXN0TGluZSgp KTsKKyAgICAgICAgZ2VuZXJhdG9yLmVtaXREZWJ1Z0hvb2soV2lsbEV4ZWN1dGVTdGF0ZW1lbnQs IG4tPmlzRG9XaGlsZSgpID8gbi0+bGFzdExpbmUoKSA6IG4tPmZpcnN0TGluZSgpLCBuLT5sYXN0 TGluZSgpKTsKICAgICAgICAgZ2VuZXJhdG9yLmVtaXROb2RlKGRzdCwgbik7CiAgICAgfQogICAg IHJldHVybiAwOwpJbmRleDoga2pzL25vZGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL25vZGVzLmgJ KHJldmlzaW9uIDM2NTQyKQorKysga2pzL25vZGVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzNCw2 ICsyMzQsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgdmlydHVhbCBib29sIGlzRW1wdHlT dGF0ZW1lbnQoKSBjb25zdCBKU0NfRkFTVF9DQUxMIHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICAg ICAgdmlydHVhbCBib29sIGlzQmxvY2soKSBjb25zdCBKU0NfRkFTVF9DQUxMIHsgcmV0dXJuIGZh bHNlOyB9CisgICAgICAgIHZpcnR1YWwgYm9vbCBpc0RvV2hpbGUoKSBjb25zdCBKU0NfRkFTVF9D QUxMIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgcHJvdGVjdGVkOgogICAgICAgICBMYWJlbFN0YWNr IG1fbGFiZWxTdGFjazsKIApAQCAtMTkzNiw2ICsxOTM3LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAg ICAgICAgIHZpcnR1YWwgUmVnaXN0ZXJJRCogZW1pdENvZGUoQ29kZUdlbmVyYXRvciYsIFJlZ2lz dGVySUQqID0gMCkgSlNDX0ZBU1RfQ0FMTDsKICAgICAgICAgdmlydHVhbCB2b2lkIHN0cmVhbVRv KFNvdXJjZVN0cmVhbSYpIGNvbnN0IEpTQ19GQVNUX0NBTEw7CiAKKyAgICAgICAgdmlydHVhbCBi b29sIGlzRG9XaGlsZSgpIGNvbnN0IEpTQ19GQVNUX0NBTEwgeyByZXR1cm4gdHJ1ZTsgfQogICAg IHByaXZhdGU6CiAgICAgICAgIFJlZlB0cjxTdGF0ZW1lbnROb2RlPiBtX3N0YXRlbWVudDsKICAg ICAgICAgUmVmUHRyPEV4cHJlc3Npb25Ob2RlPiBtX2V4cHI7Cg==