210289 2020-04-09 10:20:11 -0700 [ews] Add unit tests to ensure that step names are valid identifier 2020-04-09 12:43:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1639704 0 aakash_jain 2020-04-09 10:20:11 -0700 Add unit tests to ensure that step names used in steps.py are valid identifier (e.g.: doesn't contain space). Buildbot 0.9+ requires step names to be identifiers, and identifier can't contain spaces http://docs.buildbot.net/0.9.8/manual/installation/nine-upgrade.html#identifiers 1639706 1 395973 aakash_jain 2020-04-09 10:25:35 -0700 Created attachment 395973 Patch 1639708 2 aakash_jain 2020-04-09 10:28:04 -0700 This would prevent people from accidentally using spaces in step name (e.g.: https://bugs.webkit.org/show_bug.cgi?id=210202#c15) 1639790 3 ews-feeder 2020-04-09 12:42:08 -0700 Committed r259815: <https://trac.webkit.org/changeset/259815> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395973. 1639793 4 webkit-bug-importer 2020-04-09 12:43:17 -0700 <rdar://problem/61533468> 395973 2020-04-09 10:25:35 -0700 2020-04-09 12:42:08 -0700 Patch bug-210289-20200409132534.patch text/plain 2514 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTgwNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA0LTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgdW5pdCB0ZXN0cyB0byBlbnN1cmUgdGhhdCBzdGVwIG5h bWVzIGFyZSB2YWxpZCBpZGVudGlmaWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTAyODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0 dGVzdC5weToKKyAgICAgICAgKFRlc3RTdGVwTmFtZVNob3VsZEJlVmFsaWRJZGVudGlmaWVyKToK KyAgICAgICAgKFRlc3RTdGVwTmFtZVNob3VsZEJlVmFsaWRJZGVudGlmaWVyLnRlc3Rfc3RlcF9u YW1lc19hcmVfdmFsaWQpOiB1bml0LXRlc3QgdG8gdmFsaWRhdGUgc3RlcCBuYW1lcy4KKwogMjAy MC0wNC0wOSAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIENsZWFuLXVwIHVzZSBvZiBkZXByZWNhdGVkIEd0a0FjdGlvbgpJbmRleDogVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5w eQkocmV2aXNpb24gMjU5ODA1KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMCw2ICsyMCw3IEBACiAjIE9S IFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkg V0FZIE9VVCBPRiBUSEUgVVNFCiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBP RiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKK2ltcG9ydCBpbnNwZWN0CiBpbXBv cnQgb3BlcmF0b3IKIGltcG9ydCBvcwogaW1wb3J0IHNodXRpbApAQCAtMjksNiArMzAsNyBAQCBm cm9tIGJ1aWxkYm90LnByb2Nlc3MgaW1wb3J0IHJlbW90ZXRyYW5zCiBmcm9tIGJ1aWxkYm90LnBy b2Nlc3MucmVzdWx0cyBpbXBvcnQgUmVzdWx0cywgU1VDQ0VTUywgRkFJTFVSRSwgV0FSTklOR1Ms IFNLSVBQRUQsIEVYQ0VQVElPTiwgUkVUUlkKIGZyb20gYnVpbGRib3QudGVzdC5mYWtlLnJlbW90 ZWNvbW1hbmQgaW1wb3J0IEV4cGVjdCwgRXhwZWN0UmVtb3RlUmVmLCBFeHBlY3RTaGVsbAogZnJv bSBidWlsZGJvdC50ZXN0LnV0aWwuc3RlcHMgaW1wb3J0IEJ1aWxkU3RlcE1peGluCitmcm9tIGJ1 aWxkYm90LnV0aWwgaW1wb3J0IGlkZW50aWZpZXJzIGFzIGJ1aWxkYm90X2lkZW50aWZpZXJzCiBm cm9tIG1vY2sgaW1wb3J0IGNhbGwKIGZyb20gdHdpc3RlZC5pbnRlcm5ldCBpbXBvcnQgZXJyb3Is IHJlYWN0b3IKIGZyb20gdHdpc3RlZC5weXRob24gaW1wb3J0IGZhaWx1cmUsIGxvZwpAQCAtMjA0 LDYgKzIwNiwxNyBAQCBkZWYgdXBsb2FkRmlsZVdpdGhDb250ZW50c09mU3RyaW5nKHN0cmluCiAg ICAgcmV0dXJuIGJlaGF2aW9yCiAKIAorY2xhc3MgVGVzdFN0ZXBOYW1lU2hvdWxkQmVWYWxpZElk ZW50aWZpZXIoQnVpbGRTdGVwTWl4aW5BZGRpdGlvbnMsIHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAg ICBkZWYgdGVzdF9zdGVwX25hbWVzX2FyZV92YWxpZChzZWxmKToKKyAgICAgICAgaW1wb3J0IHN0 ZXBzCisgICAgICAgIGJ1aWxkX3N0ZXBfY2xhc3NlcyA9IGluc3BlY3QuZ2V0bWVtYmVycyhzdGVw cywgaW5zcGVjdC5pc2NsYXNzKQorICAgICAgICBmb3IgYnVpbGRfc3RlcCBpbiBidWlsZF9zdGVw X2NsYXNzZXM6CisgICAgICAgICAgICBpZiAnbmFtZScgaW4gdmFycyhidWlsZF9zdGVwWzFdKToK KyAgICAgICAgICAgICAgICBuYW1lID0gYnVpbGRfc3RlcFsxXS5uYW1lCisgICAgICAgICAgICAg ICAgc2VsZi5hc3NlcnRGYWxzZSgnICcgaW4gbmFtZSwgJ3N0ZXAgbmFtZSAie30iIGNvbnRhaW4g c3BhY2UuJy5mb3JtYXQobmFtZSkpCisgICAgICAgICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKGJ1 aWxkYm90X2lkZW50aWZpZXJzLmlkZW50X3JlLm1hdGNoKG5hbWUpLCAnc3RlcCBuYW1lICJ7fSIg aXMgbm90IGEgdmFsaWQgYnVpbGRib3QgaWRlbnRpZmllci4nLmZvcm1hdChuYW1lKSkKKworCiBj bGFzcyBUZXN0Q2hlY2tTdHlsZShCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVz dENhc2UpOgogICAgIGRlZiBzZXRVcChzZWxmKToKICAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9 IFRydWUK