210287 2020-04-09 10:01:41 -0700 [GTK] Disable PSON unless WPE_RENDERER is enabled 2020-04-10 14:07:27 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=209345 https://bugs.webkit.org/show_bug.cgi?id=208091 P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia dpa-webkit ews-watchlist gustavo mcatanzaro oldest_to_newest 1639692 0 mcatanzaro 2020-04-09 10:01:41 -0700 I've failed to fix WPE_RENDERER in F32 (bug #209118) and failed to fix WaylandCompositor to work with PSON (bug #209345). We should disable PSON when using WaylandCompositor until bug #209345 is fixed. 1639700 1 395970 mcatanzaro 2020-04-09 10:15:12 -0700 Created attachment 395970 Patch 1639701 2 395971 mcatanzaro 2020-04-09 10:15:30 -0700 Created attachment 395971 Patch 1639702 3 ews-watchlist 2020-04-09 10:16:12 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1639717 4 dpa-webkit 2020-04-09 10:52:46 -0700 https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebContext.html#WebKitWebContext--process-swap-on-cross-site-navigation-enabled why does it say that by default PSON defaults to FALSE? 1639718 5 dpa-webkit 2020-04-09 10:54:19 -0700 Why do I need WPE (renderer)? 1639756 6 mcatanzaro 2020-04-09 11:41:38 -0700 (In reply to Дилян Палаузов from comment #4) > https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebContext. > html#WebKitWebContext--process-swap-on-cross-site-navigation-enabled > > why does it say that by default PSON defaults to FALSE? Because it breaks apps that aren't prepared for it. Epiphany enables it because it's an important security feature. 1639838 7 mcatanzaro 2020-04-09 13:39:35 -0700 (In reply to Дилян Палаузов from comment #5) > Why do I need WPE (renderer)? You don't. It's just faster. 1639865 8 mcatanzaro 2020-04-09 14:14:23 -0700 Backport for 2.28 branch: diff --git a/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp b/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp index 33a9b7d5ad060f275dcf7156a8cff3f37644e736..70b485da05a92caa91bf91b9653740b8e93cf96c 100644 --- a/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp +++ b/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp @@ -376,6 +376,9 @@ static void webkitWebContextConstructed(GObject* object) API::ProcessPoolConfiguration configuration; configuration.setInjectedBundlePath(FileSystem::stringFromFileSystemRepresentation(bundleFilename.get())); #if PLATFORM(GTK) +// FIXME: PSON is currently broken unless WPE_RENDERER is enabled. +// https://bugs.webkit.org/show_bug.cgi?id=209345 +#if USE(WPE_RENDERER) configuration.setProcessSwapsOnNavigation(priv->psonEnabled); if (!priv->psonEnabled) { const char* useSingleWebProcess = getenv("WEBKIT_USE_SINGLE_WEB_PROCESS"); @@ -387,6 +390,8 @@ static void webkitWebContextConstructed(GObject* object) configuration.setUsesSingleWebProcess(true); } } +#else + configuration.setProcessSwapsOnNavigation(false); #endif if (!priv->websiteDataManager) 1639866 9 mcatanzaro 2020-04-09 14:17:43 -0700 Backport is busted, sorry.... 1639874 10 mcatanzaro 2020-04-09 14:24:54 -0700 Better backport: diff --git a/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp b/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp index 33a9b7d5ad060f275dcf7156a8cff3f37644e736..70b485da05a92caa91bf91b9653740b8e93cf96c 100644 --- a/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp +++ b/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp @@ -376,7 +376,11 @@ static void webkitWebContextConstructed(GObject* object) API::ProcessPoolConfiguration configuration; configuration.setInjectedBundlePath(FileSystem::stringFromFileSystemRepresentation(bundleFilename.get())); #if PLATFORM(GTK) +#if USE(WPE_RENDERER) + configuration.setProcessSwapsOnNavigation(priv->psonEnabled); +#else configuration.setProcessSwapsOnNavigation(false); +#endif if (!priv->psonEnabled) { const char* useSingleWebProcess = getenv("WEBKIT_USE_SINGLE_WEB_PROCESS"); if (useSingleWebProcess && strcmp(useSingleWebProcess, "0")) 1640147 11 395971 cgarcia 2020-04-10 06:28:29 -0700 Comment on attachment 395971 Patch You know I prefer to fix bugs instead of disabling features to work around them. 1640350 12 mcatanzaro 2020-04-10 14:07:27 -0700 :) 395970 2020-04-09 10:15:12 -0700 2020-04-09 10:15:28 -0700 Patch bug-210287-20200409121511.patch text/plain 2073 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzYzdhNDFlOTIzODdkNmUy MzU5NzQxZjYwM2EzZmZmMmM4ODQ3ODQuLjNhZjc1Njc0YjY0Njc0MWYyNzA0ODhjYjBkN2RmNWVl NjY3MmI2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDQtMDkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW0dUS10gRGlzYWJs ZSBQU09OIHVubGVzcyBXUEVfUkVOREVSRVIgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMjg3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyB5dWNreSwgYnV0IHdlIG5lZWQg YW4gZW1lcmdlbmN5IHdvcmthcm91bmQuIFR1cm5zIG91dCBQU09OIG9ubHkgd29ya3Mgd2hlbgor ICAgICAgICBXUEVfUkVOREVSRVIgaXMgZW5hYmxlZC4gV1BFX1JFTkRFUkVSIGlzIGN1cnJlbnRs eSBicm9rZW4gaW4gRmVkb3JhIDMyIGZvciB1bmtub3duIHJlYXNvbnMsCisgICAgICAgIGFuZCBJ IGZhaWxlZCB0byBmaXggdGhlIGZhbGxiYWNrIFdheWxhbmRDb21wb3NpdG9yIHRvIHdvcmsgcHJv cGVybHkgd2l0aCBQU09OLgorCisgICAgICAgIEJlc2lkZXMgRmVkb3JhLCB3aGVyZSBXUEUgaXMg YnJva2VuLCB0aGlzIGlzIGFsc28gdXJnZW50IGZvciB0aGUgbWFueSBkaXN0cm9zIHRoYXQgaGF2 ZQorICAgICAgICBzaW1wbHkgbm90IHBhY2thZ2VkIFdQRSBhdCBhbGwsIGxpa2UgRGViaWFuLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwOgorICAg ICAgICAod2Via2l0V2ViQ29udGV4dENvbnN0cnVjdGVkKToKKwogMjAyMC0wMy0yNiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjI1ODk0OSkg U2FmYXJpIHNvbWV0aW1lcyBjcmFzaGVzIHdoZW4gYmVjb21pbmcgdGhlIGZvcmVncm91bmQgYXBw bGljYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0V2ViQ29udGV4dC5jcHAKaW5kZXggMzNhOWI3ZDVhZDA2MGYyNzVkY2Y3MTU2YThjZmYzZjM3 NjQ0ZTczNi4uODNiYTEwOTVlNjA0ODkyMzlkZDc0MGNkOGEwZTQ5MzAxNWJmNzNjZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4 dC5jcHAKQEAgLTM3Niw3ICszNzYsMTMgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViQ29udGV4dENv bnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkKICAgICBBUEk6OlByb2Nlc3NQb29sQ29uZmlndXJh dGlvbiBjb25maWd1cmF0aW9uOwogICAgIGNvbmZpZ3VyYXRpb24uc2V0SW5qZWN0ZWRCdW5kbGVQ YXRoKEZpbGVTeXN0ZW06OnN0cmluZ0Zyb21GaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oYnVuZGxl RmlsZW5hbWUuZ2V0KCkpKTsKICNpZiBQTEFURk9STShHVEspCisvLyBGSVhNRTogUFNPTiBpcyBj dXJyZW50bHkgYnJva2VuIHVubGVzcyBXUEVfUkVOREVSRVIgaXMgZGlzYWJsZWQuCisvLyBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MzQ1CisjaWYgVVNFKFdQRV9S RU5ERVJFUikKICAgICBjb25maWd1cmF0aW9uLnNldFByb2Nlc3NTd2Fwc09uTmF2aWdhdGlvbihw cml2LT5wc29uRW5hYmxlZCk7CisjZWxzZQorICAgIGNvbmZpZ3VyYXRpb24uc2V0UHJvY2Vzc1N3 YXBzT25OYXZpZ2F0aW9uKGZhbHNlKTsKKyNlbmRpZgogI2VuZGlmCiAKICAgICBpZiAoIXByaXYt PndlYnNpdGVEYXRhTWFuYWdlcikK 395971 2020-04-09 10:15:30 -0700 2020-04-10 06:28:29 -0700 Patch bug-210287-20200409121529.patch text/plain 2072 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzYzdhNDFlOTIzODdkNmUy MzU5NzQxZjYwM2EzZmZmMmM4ODQ3ODQuLjNhZjc1Njc0YjY0Njc0MWYyNzA0ODhjYjBkN2RmNWVl NjY3MmI2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDQtMDkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW0dUS10gRGlzYWJs ZSBQU09OIHVubGVzcyBXUEVfUkVOREVSRVIgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMjg3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyB5dWNreSwgYnV0IHdlIG5lZWQg YW4gZW1lcmdlbmN5IHdvcmthcm91bmQuIFR1cm5zIG91dCBQU09OIG9ubHkgd29ya3Mgd2hlbgor ICAgICAgICBXUEVfUkVOREVSRVIgaXMgZW5hYmxlZC4gV1BFX1JFTkRFUkVSIGlzIGN1cnJlbnRs eSBicm9rZW4gaW4gRmVkb3JhIDMyIGZvciB1bmtub3duIHJlYXNvbnMsCisgICAgICAgIGFuZCBJ IGZhaWxlZCB0byBmaXggdGhlIGZhbGxiYWNrIFdheWxhbmRDb21wb3NpdG9yIHRvIHdvcmsgcHJv cGVybHkgd2l0aCBQU09OLgorCisgICAgICAgIEJlc2lkZXMgRmVkb3JhLCB3aGVyZSBXUEUgaXMg YnJva2VuLCB0aGlzIGlzIGFsc28gdXJnZW50IGZvciB0aGUgbWFueSBkaXN0cm9zIHRoYXQgaGF2 ZQorICAgICAgICBzaW1wbHkgbm90IHBhY2thZ2VkIFdQRSBhdCBhbGwsIGxpa2UgRGViaWFuLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwOgorICAg ICAgICAod2Via2l0V2ViQ29udGV4dENvbnN0cnVjdGVkKToKKwogMjAyMC0wMy0yNiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjI1ODk0OSkg U2FmYXJpIHNvbWV0aW1lcyBjcmFzaGVzIHdoZW4gYmVjb21pbmcgdGhlIGZvcmVncm91bmQgYXBw bGljYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0V2ViQ29udGV4dC5jcHAKaW5kZXggMzNhOWI3ZDVhZDA2MGYyNzVkY2Y3MTU2YThjZmYzZjM3 NjQ0ZTczNi4uNzBiNDg1ZGEwNWE5MmNhYTkxYmY5MWI5NjUzNzQwYjhlOTNjZjk2YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4 dC5jcHAKQEAgLTM3Niw3ICszNzYsMTMgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViQ29udGV4dENv bnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkKICAgICBBUEk6OlByb2Nlc3NQb29sQ29uZmlndXJh dGlvbiBjb25maWd1cmF0aW9uOwogICAgIGNvbmZpZ3VyYXRpb24uc2V0SW5qZWN0ZWRCdW5kbGVQ YXRoKEZpbGVTeXN0ZW06OnN0cmluZ0Zyb21GaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oYnVuZGxl RmlsZW5hbWUuZ2V0KCkpKTsKICNpZiBQTEFURk9STShHVEspCisvLyBGSVhNRTogUFNPTiBpcyBj dXJyZW50bHkgYnJva2VuIHVubGVzcyBXUEVfUkVOREVSRVIgaXMgZW5hYmxlZC4KKy8vIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkzNDUKKyNpZiBVU0UoV1BFX1JF TkRFUkVSKQogICAgIGNvbmZpZ3VyYXRpb24uc2V0UHJvY2Vzc1N3YXBzT25OYXZpZ2F0aW9uKHBy aXYtPnBzb25FbmFibGVkKTsKKyNlbHNlCisgICAgY29uZmlndXJhdGlvbi5zZXRQcm9jZXNzU3dh cHNPbk5hdmlnYXRpb24oZmFsc2UpOworI2VuZGlmCiAjZW5kaWYKIAogICAgIGlmICghcHJpdi0+ d2Vic2l0ZURhdGFNYW5hZ2VyKQo=