210271 2020-04-09 06:47:24 -0700 [GStreamer][MediaStream] Doesn't build with GStreamer 1.10 2020-04-28 07:15:26 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya pnormand annulen bugs-noreply calvaris ews-watchlist gyuyoung.kim pnormand ryuan.choi sergio vjaquez oldest_to_newest 1639610 0 aboya 2020-04-09 06:47:24 -0700 According to our CMake files, the minimum gst required version for WebRTC is 1.10: if (PC_GSTREAMER_VERSION VERSION_LESS "1.10") message(FATAL_ERROR "GStreamer 1.10 is needed for ENABLE_MEDIA_STREAM or ENABLE_WEB_RTC") On the other hand, I built WebKit with 1.10 and found this error. ../../Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp: In member function ‘virtual rtc::scoped_refptr<webrtc::I420BufferInterface> WebCore::GStreamerVideoFrameLibWebRTC::ToI420()’: ../../Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:126:13: error: ‘GST_VIDEO_CONVERTER_OPT_THREADS’ was not declared in this scope; did you mean ‘GST_VIDEO_CONVERTER_OPT_SRC_X’? GST_VIDEO_CONVERTER_OPT_THREADS is indeed missing from gst-plugins-base 1.10.5 source code, but is present in 1.12.0. 1646420 1 397821 pnormand 2020-04-28 01:47:15 -0700 Created attachment 397821 Patch 1646471 2 pnormand 2020-04-28 07:15:26 -0700 Committed r260821: <https://trac.webkit.org/changeset/260821> 397821 2020-04-28 01:47:15 -0700 2020-04-28 07:09:13 -0700 Patch bug-210271-20200428094714.patch text/plain 1324 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYwODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvR1N0 cmVhbWVyQ2hlY2tzLmNtYWtlIGIvU291cmNlL2NtYWtlL0dTdHJlYW1lckNoZWNrcy5jbWFrZQpp bmRleCAxOGIxMmY4MmE4ZDI4YzM0MjNmM2U2ZjMxNDczODg5OGMxZjY0NzZjLi5jYmYxZmUyMGVm NGFhNjRmMDY1Zjk0MGVjOWI1MWNjZmNmNjRjYzgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv R1N0cmVhbWVyQ2hlY2tzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9HU3RyZWFtZXJDaGVja3Mu Y21ha2UKQEAgLTQyLDYgKzQyLDkgQEAgaWYgKEVOQUJMRV9NRURJQV9TT1VSQ0UgQU5EIFBDX0dT VFJFQU1FUl9WRVJTSU9OIFZFUlNJT05fTEVTUyAiMS4xNCIpCiBlbmRpZiAoKQogCiBpZiAoRU5B QkxFX01FRElBX1NUUkVBTSBPUiBFTkFCTEVfV0VCX1JUQykKKyAgICBpZiAoUENfR1NUUkVBTUVS X1ZFUlNJT04gVkVSU0lPTl9MRVNTICIxLjEyIikKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJP UiAiR1N0cmVhbWVyIDEuMTIgaXMgbmVlZGVkIGZvciBFTkFCTEVfV0VCX1JUQy4iKQorICAgIGVu ZGlmICgpCiAgICAgU0VUX0FORF9FWFBPU0VfVE9fQlVJTEQoVVNFX0xJQldFQlJUQyBUUlVFKQog ICAgIFNFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKFdFQlJUQ19XRUJLSVRfQlVJTEQgVFJVRSkKIGVs c2UgKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2MjJmOWVkZjVi OGM1ZWFhNDdlYjgyMzczMzhlNjdlMjE5Y2M3MTNmLi41ZTFkMTBlNmNkZjIwNDhlNDc1ODEzZDVi Zjg4Nzc0YjU2ZTAzNjg0IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMjAtMDQtMjggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdW01lZGlhU3RyZWFtXSBEb2Vzbid0IGJ1 aWxkIHdpdGggR1N0cmVhbWVyIDEuMTAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxMDI3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0dTdHJlYW1lckNoZWNrcy5jbWFrZTogUmVx dWlyZSBhdCBsZWFzdCBHU3RyZWFtZXIKKyAgICAgICAgMS4xMiB3aGVuIGJ1aWxkaW5nIHdpdGgg V2ViUlRDL01lZGlhU3RyZWFtIGVuYWJsZWQuCisKIDIwMjAtMDQtMjcgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEVOQUJMRShPUEVOR0wp IHJlbW1hbnRzLi4uCg==