210265 2020-04-09 05:14:02 -0700 [ews] rename CompileJSCToT to CompileJSCWithoutPatch 2020-04-09 11:19:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210190 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1639580 0 aakash_jain 2020-04-09 05:14:02 -0700 Rename CompileJSCToT to CompileJSCWithoutPatch since that's more accurate name. In EWS, when the CompileJSC fails, we un-apply the patch and compile same revision without patch, not the ToT. This naming would also make it consistent with other similar steps like: CompileWebKitWithoutPatch, RunWebKitTestsWithout, RunAPITestsWithoutPatch and RunJSCTestsWithoutPatch. 1639583 1 395938 aakash_jain 2020-04-09 05:22:24 -0700 Created attachment 395938 Patch 1639737 2 ews-feeder 2020-04-09 11:18:02 -0700 Committed r259809: <https://trac.webkit.org/changeset/259809> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395938. 1639738 3 webkit-bug-importer 2020-04-09 11:19:13 -0700 <rdar://problem/61528367> 395938 2020-04-09 05:22:24 -0700 2020-04-09 11:18:03 -0700 Patch bug-210265-20200409082223.patch text/plain 6570 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTc5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDIwLTA0LTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSByZW5hbWUgQ29tcGlsZUpTQ1RvVCB0byBDb21waWxlSlNDV2l0 aG91dFBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTAyNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENvbXBp bGVXZWJLaXRXaXRob3V0UGF0Y2gpOiBEcml2ZS1ieSBmaXggdG8gcmVuYW1lIHNpbWlsYXIgbmFt ZS4KKyAgICAgICAgKEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cy5zdGFydCk6IERpdHRvLgor ICAgICAgICAoQ29tcGlsZVdlYktpdC5ldmFsdWF0ZUNvbW1hbmQpOiBSZW5hbWVkIENvbXBpbGVK U0NUb1QgdG8gQ29tcGlsZUpTQ1dpdGhvdXRQYXRjaC4KKyAgICAgICAgKENvbXBpbGVKU0NXaXRo b3V0UGF0Y2gpOiBEaXR0by4KKyAgICAgICAgKFJlUnVuSmF2YVNjcmlwdENvcmVUZXN0cy5ldmFs dWF0ZUNvbW1hbmQpOiBEaXR0by4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHk6IFVwZGF0ZWQgdW5pdC10ZXN0cy4KKwogMjAyMC0wNC0wOSAg QWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3c10gcmVu YW1lIENvbXBpbGVXZWJLaXRUb1QgdG8gQ29tcGlsZVdlYktpdFdpdGhvdXRQYXRjaApJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjU5 NzkxKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0xMzA4LDcgKzEzMDgsNyBAQCBjbGFzcyBDb21waWxlV2ViS2l0KHNoZWxs LkNvbXBpbGUpOgogICAgICAgICAgICAgZWxpZiBwbGF0Zm9ybSA9PSAnZ3RrJzoKICAgICAgICAg ICAgICAgICBzdGVwc190b19hZGQuYXBwZW5kKEluc3RhbGxHdGtEZXBlbmRlbmNpZXMoKSkKICAg ICAgICAgICAgIGlmIHNlbGYuZ2V0UHJvcGVydHkoJ2dyb3VwJykgPT0gJ2pzYyc6Ci0gICAgICAg ICAgICAgICAgc3RlcHNfdG9fYWRkLmFwcGVuZChDb21waWxlSlNDVG9UKCkpCisgICAgICAgICAg ICAgICAgc3RlcHNfdG9fYWRkLmFwcGVuZChDb21waWxlSlNDV2l0aG91dFBhdGNoKCkpCiAgICAg ICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgIHN0ZXBzX3RvX2FkZC5hcHBlbmQoQ29tcGls ZVdlYktpdFdpdGhvdXRQYXRjaCgpKQogICAgICAgICAgICAgc3RlcHNfdG9fYWRkLmFwcGVuZChB bmFseXplQ29tcGlsZVdlYktpdFJlc3VsdHMoKSkKQEAgLTEzMjgsNyArMTMyOCw3IEBAIGNsYXNz IENvbXBpbGVXZWJLaXQoc2hlbGwuQ29tcGlsZSk6CiAKIAogY2xhc3MgQ29tcGlsZVdlYktpdFdp dGhvdXRQYXRjaChDb21waWxlV2ViS2l0KToKLSAgICBuYW1lID0gJ2NvbXBpbGUtd2Via2l0LXRv dCcKKyAgICBuYW1lID0gJ2NvbXBpbGUtd2Via2l0LXdpdGhvdXQtcGF0Y2gnCiAgICAgaGFsdE9u RmFpbHVyZSA9IEZhbHNlCiAKICAgICBkZWYgZG9TdGVwSWYoc2VsZiwgc3RlcCk6CkBAIC0xMzQ3 LDEyICsxMzQ3LDEyIEBAIGNsYXNzIEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cyhidWlsZHMK ICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ2FuYWx5emUtY29tcGlsZS13ZWJraXQtcmVzdWx0cydd CiAKICAgICBkZWYgc3RhcnQoc2VsZik6Ci0gICAgICAgIGNvbXBpbGVfdG90X3N0ZXAgPSBDb21w aWxlV2ViS2l0V2l0aG91dFBhdGNoLm5hbWUKKyAgICAgICAgY29tcGlsZV93aXRob3V0X3BhdGNo X3N0ZXAgPSBDb21waWxlV2ViS2l0V2l0aG91dFBhdGNoLm5hbWUKICAgICAgICAgaWYgc2VsZi5n ZXRQcm9wZXJ0eSgnZ3JvdXAnKSA9PSAnanNjJzoKLSAgICAgICAgICAgIGNvbXBpbGVfdG90X3N0 ZXAgPSBDb21waWxlSlNDVG9ULm5hbWUKLSAgICAgICAgY29tcGlsZV93ZWJraXRfdG90X3Jlc3Vs dCA9IHNlbGYuZ2V0U3RlcFJlc3VsdChjb21waWxlX3RvdF9zdGVwKQorICAgICAgICAgICAgY29t cGlsZV93aXRob3V0X3BhdGNoX3N0ZXAgPSBDb21waWxlSlNDV2l0aG91dFBhdGNoLm5hbWUKKyAg ICAgICAgY29tcGlsZV93aXRob3V0X3BhdGNoX3Jlc3VsdCA9IHNlbGYuZ2V0U3RlcFJlc3VsdChj b21waWxlX3dpdGhvdXRfcGF0Y2hfc3RlcCkKIAotICAgICAgICBpZiBjb21waWxlX3dlYmtpdF90 b3RfcmVzdWx0ID09IEZBSUxVUkU6CisgICAgICAgIGlmIGNvbXBpbGVfd2l0aG91dF9wYXRjaF9y ZXN1bHQgPT0gRkFJTFVSRToKICAgICAgICAgICAgIHNlbGYuZmluaXNoZWQoRkFJTFVSRSkKICAg ICAgICAgICAgIG1lc3NhZ2UgPSAnVW5hYmxlIHRvIGJ1aWxkIFdlYktpdCB3aXRob3V0IHBhdGNo LCByZXRyeWluZyBidWlsZCcKICAgICAgICAgICAgIHNlbGYuZGVzY3JpcHRpb25Eb25lID0gbWVz c2FnZQpAQCAtMTM5NCw4ICsxMzk0LDggQEAgY2xhc3MgQ29tcGlsZUpTQyhDb21waWxlV2ViS2l0 KToKICAgICAgICAgcmV0dXJuIHNoZWxsLkNvbXBpbGUuZ2V0UmVzdWx0U3VtbWFyeShzZWxmKQog CiAKLWNsYXNzIENvbXBpbGVKU0NUb1QoQ29tcGlsZUpTQyk6Ci0gICAgbmFtZSA9ICdjb21waWxl LWpzYy10b3QnCitjbGFzcyBDb21waWxlSlNDV2l0aG91dFBhdGNoKENvbXBpbGVKU0MpOgorICAg IG5hbWUgPSAnY29tcGlsZS1qc2Mtd2l0aG91dC1wYXRjaCcKIAogICAgIGRlZiBldmFsdWF0ZUNv bW1hbmQoc2VsZiwgY21kKToKICAgICAgICAgcmV0dXJuIHNoZWxsLkNvbXBpbGUuZXZhbHVhdGVD b21tYW5kKHNlbGYsIGNtZCkKQEAgLTE1MTQsNyArMTUxNCw3IEBAIGNsYXNzIFJlUnVuSmF2YVNj cmlwdENvcmVUZXN0cyhSdW5KYXZhU2MKICAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3Bh dGNoRmFpbGVkVGVzdHMnLCBUcnVlKQogICAgICAgICAgICAgc2VsZi5idWlsZC5hZGRTdGVwc0Fm dGVyQ3VycmVudFN0ZXAoW1VuQXBwbHlQYXRjaElmUmVxdWlyZWQoKSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFZhbGlkYXRlUGF0Y2godmVyaWZ5QnVn Q2xvc2VkPUZhbHNlLCBhZGRVUkxzPUZhbHNlKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIENvbXBpbGVKU0NUb1QoKSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENvbXBpbGVKU0NXaXRob3V0UGF0Y2goKSwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFZhbGlkYXRl UGF0Y2godmVyaWZ5QnVnQ2xvc2VkPUZhbHNlLCBhZGRVUkxzPUZhbHNlKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEtpbGxPbGRQcm9jZXNzZXMoKSwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFJ1bkpTQ1Rl c3RzV2l0aG91dFBhdGNoKCksCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTk3OTEpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcg Y29weSkKQEAgLTM3LDcgKzM3LDcgQEAgZnJvbSB0d2lzdGVkLnRyaWFsIGltcG9ydCB1bml0dGVz dAogZnJvbSBzdGVwcyBpbXBvcnQgKEFuYWx5emVBUElUZXN0c1Jlc3VsdHMsIEFuYWx5emVDb21w aWxlV2ViS2l0UmVzdWx0cywgQW5hbHl6ZUpTQ1Rlc3RzUmVzdWx0cywKICAgICAgICAgICAgICAg ICAgICBBbmFseXplTGF5b3V0VGVzdHNSZXN1bHRzLCBBcHBseVBhdGNoLCBBcHBseVdhdGNoTGlz dCwgQXJjaGl2ZUJ1aWx0UHJvZHVjdCwgQXJjaGl2ZVRlc3RSZXN1bHRzLAogICAgICAgICAgICAg ICAgICAgIENoZWNrT3V0U291cmNlLCBDaGVja091dFNwZWNpZmljUmV2aXNpb24sIENoZWNrUGF0 Y2hSZWxldmFuY2UsIENoZWNrUGF0Y2hTdGF0dXNPbkVXU1F1ZXVlcywgQ2hlY2tTdHlsZSwKLSAg ICAgICAgICAgICAgICAgICBDbGVhbkJ1aWxkLCBDbGVhblVwR2l0SW5kZXhMb2NrLCBDbGVhbldv cmtpbmdEaXJlY3RvcnksIENvbXBpbGVKU0MsIENvbXBpbGVKU0NUb1QsIENvbXBpbGVXZWJLaXQs CisgICAgICAgICAgICAgICAgICAgQ2xlYW5CdWlsZCwgQ2xlYW5VcEdpdEluZGV4TG9jaywgQ2xl YW5Xb3JraW5nRGlyZWN0b3J5LCBDb21waWxlSlNDLCBDb21waWxlSlNDV2l0aG91dFBhdGNoLCBD b21waWxlV2ViS2l0LAogICAgICAgICAgICAgICAgICAgIENvbXBpbGVXZWJLaXRXaXRob3V0UGF0 Y2gsIENvbmZpZ3VyZUJ1aWxkLCBDcmVhdGVMb2NhbEdJVENvbW1pdCwKICAgICAgICAgICAgICAg ICAgICBEb3dubG9hZEJ1aWx0UHJvZHVjdCwgRG93bmxvYWRCdWlsdFByb2R1Y3RGcm9tTWFzdGVy LCBFeHRyYWN0QnVpbHRQcm9kdWN0LCBFeHRyYWN0VGVzdFJlc3VsdHMsCiAgICAgICAgICAgICAg ICAgICAgRmluZE1vZGlmaWVkQ2hhbmdlTG9ncywgSW5zdGFsbEd0a0RlcGVuZGVuY2llcywgSW5z dGFsbFdwZURlcGVuZGVuY2llcywgS2lsbE9sZFByb2Nlc3NlcywKQEAgLTEwODIsNyArMTA4Miw3 IEBAIGNsYXNzIFRlc3RBbmFseXplQ29tcGlsZVdlYktpdFJlc3VsdHMoQnUKICAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbChzZWxmLmdldFByb3BlcnR5KCdidWlsZF9maW5pc2hfc3VtbWFyeScpLCAn UGF0Y2ggMTIzNCBkb2VzIG5vdCBidWlsZCcpCiAgICAgICAgIHJldHVybiByYwogCi0gICAgZGVm IHRlc3RfcGF0Y2hfd2l0aF9Ub1RfZmFpbHVyZShzZWxmKToKKyAgICBkZWYgdGVzdF9wYXRjaF93 aXRoX3RydW5rX2ZhaWx1cmUoc2VsZik6CiAgICAgICAgIHByZXZpb3VzX3N0ZXBzID0gWwogICAg ICAgICAgICAgbW9ja19zdGVwKENvbXBpbGVXZWJLaXQoKSwgcmVzdWx0cz1GQUlMVVJFKSwKICAg ICAgICAgICAgIG1vY2tfc3RlcChDb21waWxlV2ViS2l0V2l0aG91dFBhdGNoKCksIHJlc3VsdHM9 RkFJTFVSRSksCkBAIC0xMTMwLDcgKzExMzAsNyBAQCBjbGFzcyBUZXN0Q29tcGlsZUpTQyhCdWls ZFN0ZXBNaXhpbkFkZGl0CiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAKLWNsYXNz IFRlc3RDb21waWxlSlNDVG9UKEJ1aWxkU3RlcE1peGluQWRkaXRpb25zLCB1bml0dGVzdC5UZXN0 Q2FzZSk6CitjbGFzcyBUZXN0Q29tcGlsZUpTQ1dpdGhvdXRQYXRjaChCdWlsZFN0ZXBNaXhpbkFk ZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBzZXRVcChzZWxmKToKICAgICAg ICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUKICAgICAgICAgcmV0dXJuIHNlbGYuc2V0VXBCdWls ZFN0ZXAoKQpAQCAtMTEzOSw3ICsxMTM5LDcgQEAgY2xhc3MgVGVzdENvbXBpbGVKU0NUb1QoQnVp bGRTdGVwTWl4aW5BZAogICAgICAgICByZXR1cm4gc2VsZi50ZWFyRG93bkJ1aWxkU3RlcCgpCiAK ICAgICBkZWYgdGVzdF9zdWNjZXNzKHNlbGYpOgotICAgICAgICBzZWxmLnNldHVwU3RlcChDb21w aWxlSlNDVG9UKCkpCisgICAgICAgIHNlbGYuc2V0dXBTdGVwKENvbXBpbGVKU0NXaXRob3V0UGF0 Y2goKSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ2pzYy1vbmx5 JykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdyZWxlYXNlJykK ICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hGYWlsZWRUb0J1aWxkJywgJ1RydWUnKQpA QCAtMTE1NCw3ICsxMTU0LDcgQEAgY2xhc3MgVGVzdENvbXBpbGVKU0NUb1QoQnVpbGRTdGVwTWl4 aW5BZAogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogICAgIGRlZiB0ZXN0X2ZhaWx1 cmUoc2VsZik6Ci0gICAgICAgIHNlbGYuc2V0dXBTdGVwKENvbXBpbGVKU0NUb1QoKSkKKyAgICAg ICAgc2VsZi5zZXR1cFN0ZXAoQ29tcGlsZUpTQ1dpdGhvdXRQYXRjaCgpKQogICAgICAgICBzZWxm LnNldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nLCAnanNjLW9ubHknKQogICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ2RlYnVnJykKICAgICAgICAgc2VsZi5leHBlY3RS ZW1vdGVDb21tYW5kcygK