21026 2008-09-23 09:20:33 -0700 No favicon during first load 2009-01-29 08:02:00 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 1 phanna webkit-unassigned beidson darin ddkilzer mitz oldest_to_newest 92336 0 phanna 2008-09-23 09:20:33 -0700 Safari -> Reset Safari... Go to a site known to have a favicon (google.com, yahoo.com, ebay.com, etc). Notice there is no favicon until you refresh the site. I turned on logging and I think the issue is that the favicon data has not been committed to the database in dispatchDidReceiveIcon and dispatchDidAddIconForPageURL so that the Image stored in the IconRecord has m_data set to NULL. 92388 1 mrowe 2008-09-23 14:14:06 -0700 <rdar://problem/6240826> 94353 2 phanna 2008-10-07 06:44:19 -0700 I have a local change that switches the order of readFromDatabase() and writeToDatabase() inside IconDatabase::syncThreadMainLoop() that appears to fix the issue. I haven't seen any adverse affects but I'm not sure what to look for. 102139 3 ddkilzer 2008-12-10 13:31:18 -0800 See also Bug 12892. 102143 4 ddkilzer 2008-12-10 13:55:45 -0800 I believe Attachment #25925 from Bug 22795 contains a (webarchive) test case that reproduces this issue reliably on Mac OS X, which should make it easier to fix. 103415 5 darin 2008-12-25 10:17:23 -0800 Could this be related to the "write before read" change in bug 22963? 103745 6 ddkilzer 2008-12-29 16:18:44 -0800 (In reply to comment #5) > Could this be related to the "write before read" change in bug 22963? I don't believe that patch fixes the issue. See Bug 22963 Comment #3. 105791 7 ddkilzer 2009-01-14 14:18:07 -0800 (In reply to comment #4) > I believe Attachment #25925 [review] from Bug 22795 contains a (webarchive) test case > that reproduces this issue reliably on Mac OS X, which should make it easier to > fix. The fix for Bug 22795 landed, but the layout test fails in different ways on different buildbots (see Bug 23331), so it's currently disabled. 107449 8 ddkilzer 2009-01-28 19:49:54 -0800 I think this may have been fixed with <http://trac.webkit.org/changeset/40335>. Patrick, could you verify this with a nightly build? 107513 9 phanna 2009-01-29 05:28:39 -0800 I think change 40335 and the fix for bug 22963 have resolved this issue. 107525 10 ddkilzer 2009-01-29 08:02:00 -0800 (In reply to comment #9) > I think change 40335 and the fix for bug 22963 have resolved this issue. Resolving as fixed.