21025 2008-09-23 07:22:16 -0700 CSS transition with duration=0 and delay=0 doesn't override ongoing transition 2008-10-21 01:11:15 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 VERIFIED FIXED http://hiitola.net/webkitbugreport01.html P2 Normal --- 1 kari.hiitola cmarrin dino simon.fraser oldest_to_newest 92330 0 kari.hiitola 2008-09-23 07:22:16 -0700 When setting -webkit-transition-duration and -webkit-transition-delay to zero and starting a new transition during another transition, the new transition doesn't override the ongoing one but instead is completed after the ongoing transition is finished. In the supplied test page the moving text on the top (#bug) should move immediately back to the upper left corner after the 2s timeout (When the text changes). Changing the delay or duration in function "test_bug" to 1ms overcomes this as demonstrated on the bottom part (#ok). There is an explicit test for the zero-zero condition in the source code (WebCore/page/animation/CompositeAnimation.cpp) , and removing the test makes the problem disappear with the test page. I'm not sure if there would be any side-effects, though. It's not apparent to me, why immediate and undelayed transforms should not override the ongoing transition. As I've understood it, that wouldn't indicate an empty transition, as the code comments hint (// If this is an empty transition, skip it). 93310 1 23925 cmarrin 2008-09-29 17:52:30 -0700 Created attachment 23925 LayoutTest file 93311 2 cmarrin 2008-09-29 17:54:10 -0700 Bug was as you suspected. But I had to add a bit of logic to make sure to not add a transition if the delay and duration were 0. To do so would, at least, fire an end transition event erroneously. I also added an optimization to avoid doing the property equality test if the duration and delay were 0. 93315 3 23925 darin 2008-09-29 18:02:19 -0700 Comment on attachment 23925 LayoutTest file This is just the layout test file, not the patch at all! 93318 4 23928 cmarrin 2008-09-29 18:05:35 -0700 Created attachment 23928 Patch, including LayoutTest file 93319 5 23928 cmarrin 2008-09-29 18:06:06 -0700 Comment on attachment 23928 Patch, including LayoutTest file Sorry, grabbed the wrong file. I need a better naming scheme! 94895 6 23928 mitz 2008-10-10 11:16:53 -0700 Comment on attachment 23928 Patch, including LayoutTest file r=me 94897 7 cmarrin 2008-10-10 11:44:05 -0700 Sending LayoutTests/ChangeLog Adding LayoutTests/transitions/interrupt-zero-duration-expected.txt Adding LayoutTests/transitions/interrupt-zero-duration.html Sending WebCore/ChangeLog Sending WebCore/page/animation/CompositeAnimation.cpp Sending WebCore/page/animation/KeyframeAnimation.h Transmitting file data ...... Committed revision 37485. 23925 2008-09-29 17:52:30 -0700 2008-09-29 18:05:35 -0700 LayoutTest file 21025.html text/html 557 cmarrin PGh0bWw+DTxib2R5IG9ubG9hZD0ic3RhcnRfdHJhbnNpdGlvbigpOyI+DQ08c2NyaXB0IGxhbmd1 YWdlPSJqYXZhc2NyaXB0IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPg1mdW5jdGlvbiB0ZXN0X2J1 ZygpIHsNCWJ1Zy5zdHlsZS53ZWJraXRUcmFuc2l0aW9uRHVyYXRpb24gPSAiMHMiOw0gICAgYnVn LnN0eWxlLmxlZnQgPSAwOw0gICAgZG9jdW1lbnQuYWxsLmJ1Zy5pbm5lckhUTUwgPSAiSW1tZWRp YXRlIHRyYW5zaXRpb24hIg19ICAgIA1mdW5jdGlvbiBzdGFydF90cmFuc2l0aW9uKCkgew0JYnVn LnN0eWxlLmxlZnQgPSA2NDA7DQlzZXRUaW1lb3V0KCJ0ZXN0X2J1ZygpIiwgMjAwMCk7DSAgICAN fQ08L3NjcmlwdD4NDTxzdHlsZT4NI2J1ZywgI29rew0JcG9zaXRpb246IGFic29sdXRlOw0JLXdl YmtpdC10cmFuc2l0aW9uLXByb3BlcnR5OiBsZWZ0LCB0b3A7DQktd2Via2l0LXRyYW5zaXRpb24t ZHVyYXRpb246IDVzOw19DSNidWcgew0gICAgdG9wOiAxMHB4Ow19DTwvc3R5bGU+DQ08ZGl2IGlk PSJidWciPg01cyB0cmFuc2l0aW9uDTwvZGl2Pg08L2JvZHk+DTwvaHRtbD4= 23928 2008-09-29 18:05:35 -0700 2008-10-10 11:16:53 -0700 Patch, including LayoutTest file 21025.patch text/plain 6501 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzA4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDktMjkgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDI1CisgICAg ICAgIENTUyB0cmFuc2l0aW9uIHdpdGggZHVyYXRpb249MCBhbmQgZGVsYXk9MCBkb2Vzbid0IG92 ZXJyaWRlIG9uZ29pbmcgdHJhbnNpdGlvbgorCisgICAgICAgIFRlc3Q6IHRyYW5zaXRpb25zL2lu dGVycnVwdC16ZXJvLWR1cmF0aW9uLmh0bWwKKworICAgICAgICAqIHBhZ2UvYW5pbWF0aW9uL0Nv bXBvc2l0ZUFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGVBbmltYXRp b246OnVwZGF0ZVRyYW5zaXRpb25zKToKKwogMjAwOC0wOS0yOSAgRGF2aWQgSHlhdHQgIDxoeWF0 dEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHRoZSBuZXcgSG9zdFdpbmRvdyBiYXNlIGNsYXNz LiAgQSBIb3N0V2luZG93IGhvc3RzIGEgaGllcmFyY2h5IG9mIFdpZGdldHMuICBUaGUgQ2hyb21l IG9iamVjdCBvbiBQYWdlCkluZGV4OiBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NvbXBvc2l0ZUFu aW1hdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9Db21wb3Np dGVBbmltYXRpb24uY3BwCShyZXZpc2lvbiAzNzA4MikKKysrIFdlYkNvcmUvcGFnZS9hbmltYXRp b24vQ29tcG9zaXRlQW5pbWF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTMsMTIgKzUzLDcg QEAgdm9pZCBDb21wb3NpdGVBbmltYXRpb246OnVwZGF0ZVRyYW5zaXRpbwogICAgIC8vIENoZWNr IHRvIHNlZSBpZiB3ZSBuZWVkIHRvIHVwZGF0ZSB0aGUgYWN0aXZlIHRyYW5zaXRpb25zCiAgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCB0YXJnZXRTdHlsZS0+dHJhbnNpdGlvbnMoKS0+c2l6ZSgp OyArK2kpIHsKICAgICAgICAgY29uc3QgQW5pbWF0aW9uKiBhbmltID0gdGFyZ2V0U3R5bGUtPnRy YW5zaXRpb25zKCktPmFuaW1hdGlvbihpKTsKLSAgICAgICAgZG91YmxlIGR1cmF0aW9uID0gYW5p bS0+ZHVyYXRpb24oKTsKLSAgICAgICAgZG91YmxlIGRlbGF5ID0gYW5pbS0+ZGVsYXkoKTsKLQot ICAgICAgICAvLyBJZiB0aGlzIGlzIGFuIGVtcHR5IHRyYW5zaXRpb24sIHNraXAgaXQKLSAgICAg ICAgaWYgKGR1cmF0aW9uID09IDAgJiYgZGVsYXkgPD0gMCkKLSAgICAgICAgICAgIGNvbnRpbnVl OworICAgICAgICBib29sIGlzQWN0aXZlVHJhbnNpdGlvbiA9IGFuaW0tPmR1cmF0aW9uKCkgfHwg YW5pbS0+ZGVsYXkoKSA+IDA7CiAKICAgICAgICAgaW50IHByb3AgPSBhbmltLT5wcm9wZXJ0eSgp OwogCkBAIC05NCwxNCArODksMTQgQEAgdm9pZCBDb21wb3NpdGVBbmltYXRpb246OnVwZGF0ZVRy YW5zaXRpbwogICAgICAgICAgICAgICAgLy8geW91IGhhdmUgYm90aCBhbiBleHBsaWNpdCB0cmFu c2l0aW9uLXByb3BlcnR5IGFuZCAnYWxsJyBpbiB0aGUgc2FtZQogICAgICAgICAgICAgICAgLy8g bGlzdC4gSW4gdGhpcyBjYXNlLCB0aGUgbGF0dGVyIG9uZSBvdmVycmlkZXMgdGhlIGVhcmxpZXIg b25lLCBzbyB3ZQogICAgICAgICAgICAgICAgLy8gYmVoYXZlIGFzIHRob3VnaCB0aGlzIGlzIGEg cnVubmluZyBhbmltYXRpb24gYmVpbmcgcmVwbGFjZWQuCi0gICAgICAgICAgICAgICAgaWYgKCFp bXBsQW5pbS0+aXNUYXJnZXRQcm9wZXJ0eUVxdWFsKHByb3AsIHRhcmdldFN0eWxlKSkgeworICAg ICAgICAgICAgICAgIGlmICghaXNBY3RpdmVUcmFuc2l0aW9uIHx8ICFpbXBsQW5pbS0+aXNUYXJn ZXRQcm9wZXJ0eUVxdWFsKHByb3AsIHRhcmdldFN0eWxlKSkgewogICAgICAgICAgICAgICAgICAg ICBkZWxldGUgaW1wbEFuaW07CiAgICAgICAgICAgICAgICAgICAgIG1fdHJhbnNpdGlvbnMucmVt b3ZlKHByb3ApOwotICAgICAgICAgICAgICAgICAgICBlcXVhbCA9IGZhbHNlOworICAgICAgICAg ICAgICAgICAgICBlcXVhbCA9ICFpc0FjdGl2ZVRyYW5zaXRpb247CiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAvLyBTZWUgaWYgd2UgbmVl ZCB0byBzdGFydCBhIG5ldyB0cmFuc2l0aW9uCi0gICAgICAgICAgICAgICAgZXF1YWwgPSBBbmlt YXRpb25CYXNlOjpwcm9wZXJ0aWVzRXF1YWwocHJvcCwgZnJvbVN0eWxlLCB0YXJnZXRTdHlsZSk7 CisgICAgICAgICAgICAgICAgLy8gV2UgbmVlZCB0byBzdGFydCBhIHRyYW5zaXRpb24gaWYgaXQg aXMgYWN0aXZlIGFuZCB0aGUgcHJvcGVydGllcyBkb24ndCBtYXRjaAorICAgICAgICAgICAgICAg IGVxdWFsID0gIWlzQWN0aXZlVHJhbnNpdGlvbiB8fCBBbmltYXRpb25CYXNlOjpwcm9wZXJ0aWVz RXF1YWwocHJvcCwgZnJvbVN0eWxlLCB0YXJnZXRTdHlsZSk7CiAgICAgICAgICAgICB9CiAKICAg ICAgICAgICAgIGlmICghZXF1YWwpIHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM3MDg2KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgt MDktMjkgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RjYXNlIGZvciBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMjUKKyAgICAgICAgQ1NTIHRyYW5zaXRp b24gd2l0aCBkdXJhdGlvbj0wIGFuZCBkZWxheT0wIGRvZXNuJ3Qgb3ZlcnJpZGUgb25nb2luZyB0 cmFuc2l0aW9uCisKKyAgICAgICAgKiB0cmFuc2l0aW9ucy9pbnRlcnJ1cHQtemVyby1kdXJhdGlv bi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHRyYW5zaXRpb25zL2ludGVycnVwdC16 ZXJvLWR1cmF0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDA4LTA5LTI5ICBHZW9mZnJleSBHYXJlbiAg PGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2FtZXJvbiBad2FyaWNo LgpJbmRleDogTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvaW50ZXJydXB0LXplcm8tZHVyYXRpb24t ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3RyYW5zaXRpb25zL2ludGVy cnVwdC16ZXJvLWR1cmF0aW9uLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL3RyYW5zaXRpb25zL2ludGVycnVwdC16ZXJvLWR1cmF0aW9uLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3RzIGNoYW5naW5nIGEgdHJhbnNpdGlv bmluZyBwcm9wZXJ0eSB3aGlsZSBydW5uaW5nIGFuZCByZXNldHRpbmcgaXRzIGR1cmF0aW9uIHRv IDAuIFRoZSBib3ggc2hvdWxkIHN0YXJ0IG1vdmluZyBsZWZ0IGFuZCBhZnRlciA1MDBtcyBzbmFw IGJhY2sgdG8gMAorCitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy90cmFuc2l0aW9ucy9pbnRlcnJ1 cHQtemVyby1kdXJhdGlvbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3RyYW5zaXRp b25zL2ludGVycnVwdC16ZXJvLWR1cmF0aW9uLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy90cmFuc2l0aW9ucy9pbnRlcnJ1cHQtemVyby1kdXJhdGlvbi5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDgxIEBACis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIEhU TUwgNC4wMSBUcmFuc2l0aW9uYWwvL0VOIgorICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0 L2xvb3NlLmR0ZCI+CisKKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorICAgIDxtZXRhIGh0dHAt ZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4K KyAgICA8dGl0bGU+SW50ZXJydXB0IFRyYW5zaXRpb24gYW5kIENoYW5nZSBJdHMgRHVyYXRpb24g dG8gWmVybzwvdGl0bGU+CisgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVu Ij4KKyAgICAjYm94IHsKKyAgICAgICAgcG9zaXRpb246IHJlbGF0aXZlOworICAgICAgICBoZWln aHQ6IDEwMHB4OworICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgIGJhY2tncm91bmQtY29s b3I6IGJsdWU7CisgICAgICAgIC13ZWJraXQtdHJhbnNpdGlvbi1wcm9wZXJ0eTogbGVmdDsKKyAg ICAgICAgLXdlYmtpdC10cmFuc2l0aW9uLWR1cmF0aW9uOiAyczsKKyAgICAgICAgLXdlYmtpdC10 cmFuc2l0aW9uLXRpbWluZy1mdW5jdGlvbjogbGluZWFyOworICAgIH0KKyAgICA8L3N0eWxlPgor ICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+CisgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRV bnRpbERvbmUoKTsKKyAgICB9CisKKyAgICByZXN1bHQgPSAiUEFTUyI7CisgICAgCisgICAgZnVu Y3Rpb24gaXNFcXVhbChhY3R1YWwsIGRlc2lyZWQsIHRvbGVyYW5jZSkKKyAgICB7CisgICAgICAg IHZhciBkaWZmID0gTWF0aC5hYnMoYWN0dWFsIC0gZGVzaXJlZCk7CisgICAgICAgIHJldHVybiBk aWZmIDw9IHRvbGVyYW5jZTsKKyAgICB9CisgICAgCisgICAgZnVuY3Rpb24gc25hcHNob3QoZXhw ZWN0ZWQsIHRvbGVyYW5jZSkKKyAgICB7CisgICAgICAgIGlmIChyZXN1bHQgIT0gIlBBU1MiKQor ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgCisgICAgICAgIHZhciBsZWZ0ID0gcGFy c2VJbnQod2luZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Jv eCcpKS5sZWZ0KTsKKyAgICAgICAgaWYgKCFpc0VxdWFsKGxlZnQsIGV4cGVjdGVkLCB0b2xlcmFu Y2UpKQorICAgICAgICAgICAgcmVzdWx0ID0gIkZBSUwod2FzOiIrbGVmdCsiLCBleHBlY3RlZDoi K2V4cGVjdGVkKyIpIjsKKyAgICB9CisgICAgCisgICAgZnVuY3Rpb24gcmVzZXQoKQorICAgIHsK KyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2JveCcpLnN0eWxlLndlYmtpdFRyYW5z aXRpb25EdXJhdGlvbiA9ICIwcyI7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdi b3gnKS5zdHlsZS5sZWZ0ID0gIjBweCI7CisgICAgfQorICAgIAorICAgIGZ1bmN0aW9uIHN0YXJ0 VHJhbnNpdGlvbigpCisgICAgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94 Jykuc3R5bGUubGVmdCA9ICI0MDBweCI7CisgICAgfQorCisgICAgZnVuY3Rpb24gc3RhcnQoKQor ICAgIHsKKyAgICAgICAgc2V0VGltZW91dCgic3RhcnRUcmFuc2l0aW9uKCkiLCAwKTsKKyAgICAg ICAgc2V0VGltZW91dCgic25hcHNob3QoMTAwLCA4MCkiLCA1MDApOworICAgICAgICBzZXRUaW1l b3V0KCJyZXNldCgpIiwgNjAwKTsKKyAgICAgICAgc2V0VGltZW91dCgic25hcHNob3QoMCwgMCki LCA3MDApOworICAgICAgICAKKyAgICAgICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7 CisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1M ID0gcmVzdWx0OworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK KyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAg ICAgIH0sIDgwMCk7CisgICAgfQorICAgIAorICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCds b2FkJywgc3RhcnQsIGZhbHNlKQorICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorCis8cD4K K1RoaXMgdGVzdHMgY2hhbmdpbmcgYSB0cmFuc2l0aW9uaW5nIHByb3BlcnR5IHdoaWxlIHJ1bm5p bmcgYW5kIHJlc2V0dGluZyBpdHMgZHVyYXRpb24gdG8gMC4KK1RoZSBib3ggc2hvdWxkIHN0YXJ0 IG1vdmluZyBsZWZ0IGFuZCBhZnRlciA1MDBtcyBzbmFwIGJhY2sgdG8gMDwvcD4KKzxkaXYgaWQ9 ImJveCI+Cis8L2Rpdj4KKzxkaXYgaWQ9InJlc3VsdCI+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRt bD4K