210237 2020-04-08 19:02:44 -0700 Web Inspector: Storage: should be able to set a cookie with no value 2020-04-09 17:41:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1639427 0 hi 2020-04-08 19:02:44 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. go to the Storage Tab 3. click on the + in the navigation bar 4. delete any value in the Value <input> 5. press enter/esc or click outside the popover => a cookie is added with the value `value` 1639438 1 395901 hi 2020-04-08 19:44:52 -0700 Created attachment 395901 Patch 1639981 2 ews-feeder 2020-04-09 17:40:09 -0700 Committed r259842: <https://trac.webkit.org/changeset/259842> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395901. 1639983 3 webkit-bug-importer 2020-04-09 17:41:22 -0700 <rdar://problem/61553178> 395901 2020-04-08 19:44:52 -0700 2020-04-09 17:40:09 -0700 Patch bug-210237-20200408204451.patch text/plain 5285 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGI2ZDE0YzM3MDAxNTA2ODA0ZmI3YzE2ZWIxODEz NzdjZDI4M2NiNGYuLjZjOTEyNTY0MGI5M2UwYjI1Yjg4Y2ZhZTY5ZmFiNjkyMmI0ZmRhMWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA0LTA4ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT dG9yYWdlOiBzaG91bGQgYmUgYWJsZSB0byBzZXQgYSBjb29raWUgd2l0aCBubyB2YWx1ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMjM3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL0Nvb2tpZVBvcG92ZXIuanM6CisgICAgICAgIChXSS5Db29raWVQb3BvdmVyLnBy b3RvdHlwZS5nZXQgc2VyaWFsaXplZERhdGEpOgorICAgICAgICBSZXF1aXJlIGFuIGV4cGxpY2l0 bHkgc2V0IGBuYW1lYCBpbnN0ZWFkIG9mIGZhbGxpbmcgYmFjayB0byB0aGUgYHBsYWNlaG9sZGVy YC4gQWxsb3cgdGhlCisgICAgICAgIGB2YWx1ZWAgdG8gYmUgYW4gZW1wdHkgc3RyaW5nLgorCisg ICAgICAgIChXSS5Db29raWVQb3BvdmVyLnByb3RvdHlwZS5zaG93KToKKyAgICAgICAgRG9uJ3Qg aGF2ZSBkZWZhdWx0IHBsYWNlaG9sZGVyIHZhbHVlcyBmb3IgYG5hbWVgIG9yIGB2YWx1ZWAgZm9y IHRoZSByZWFzb25zIGFib3ZlLgorICAgICAgICBEcml2ZS1ieTogaWYgYW4gZXhpc3RpbmcgYFdJ LkNvb2tpZWAgaXMgcHJvdmlkZWQsIHVzZSBpdHMgYFNhbWVTaXRlYCB2YWx1ZS4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llUG9wb3Zlci5jc3M6IEFkZGVkLgorICAgICAg ICAoLnBvcG92ZXIgLmNvb2tpZS1wb3BvdmVyLWNvbnRlbnQgPiB0YWJsZSA+IHRyID4gdGQgPiBp bnB1dDptYXRjaGVzKFt0eXBlPSJ0ZXh0Il0sIFt0eXBlPSJkYXRldGltZS1sb2NhbCJdKTptYXRj aGVzKDppbnZhbGlkLCAuaW52YWxpZCkpOiBBZGRlZC4KKyAgICAgICAgKC5wb3BvdmVyIC5jb29r aWUtcG9wb3Zlci1jb250ZW50ID4gdGFibGUgPiB0ciA+IHRkID4gaW5wdXQ6bWF0Y2hlcyhbdHlw ZT0idGV4dCJdLCBbdHlwZT0iZGF0ZXRpbWUtbG9jYWwiXSkuaW52YWxpZCk6IERlbGV0ZWQuCisg ICAgICAgIEluc3RlYWQgb2YgY2hhbmdpbmcgdGhlIHRleHQgY29sb3IsIGNoYW5nZSB0aGUgYm9y ZGVyIGNvbG9yLgorCiAyMDIwLTA0LTA4ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTZWFyY2g6IHBvcHVsYXRlIHRoZSBzZWFyY2gg ZmllbGQgd2l0aCB0aGUgY3VycmVudCBzZWxlY3Rpb24gd2hlbiB1c2luZyB0aGUgZ2xvYmFsIHNl YXJjaCBzaG9ydGN1dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ29va2llUG9wb3Zlci5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Db29raWVQb3BvdmVyLmNzcwppbmRleCBiNWYyOWExNWYxMTU3ZGVj MmVjOGM2ZDlhYjQyMGFhZDliNmJkMzFlLi4yNjgxZTljYmYwMjIzZDIwM2MyNjQ0MDk0YTdjZmVk ZDFmYjNhMzUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db29raWVQb3BvdmVyLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Db29raWVQb3BvdmVyLmNzcwpAQCAtNTYsOCArNTYsOCBAQAogICAg IC13ZWJraXQtYXBwZWFyYW5jZTogbm9uZTsKIH0KIAotLnBvcG92ZXIgLmNvb2tpZS1wb3BvdmVy LWNvbnRlbnQgPiB0YWJsZSA+IHRyID4gdGQgPiBpbnB1dDptYXRjaGVzKFt0eXBlPSJ0ZXh0Il0s IFt0eXBlPSJkYXRldGltZS1sb2NhbCJdKS5pbnZhbGlkIHsKLSAgICBjb2xvcjogdmFyKC0tZXJy b3ItdGV4dC1jb2xvcik7CisucG9wb3ZlciAuY29va2llLXBvcG92ZXItY29udGVudCA+IHRhYmxl ID4gdHIgPiB0ZCA+IGlucHV0Om1hdGNoZXMoW3R5cGU9InRleHQiXSwgW3R5cGU9ImRhdGV0aW1l LWxvY2FsIl0pOm1hdGNoZXMoOmludmFsaWQsIC5pbnZhbGlkKSB7CisgICAgYm9yZGVyLWNvbG9y OiB2YXIoLS1lcnJvci10ZXh0LWNvbG9yKTsKIH0KIAogQG1lZGlhIChwcmVmZXJzLWNvbG9yLXNj aGVtZTogZGFyaykgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvQ29va2llUG9wb3Zlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVBvcG92ZXIuanMKaW5kZXggODU4ZmIyMjM0ZDIxNzAxMjhm YWJkNDJkNGZhNWM5ZDY2OWM0YzI3NS4uN2ZkOGM5ZTVkOWZhNTYwYzhiYjc3NTE5YzAxZGUxMmQz OTIyYTM4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQ29va2llUG9wb3Zlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9Db29raWVQb3BvdmVyLmpzCkBAIC01MSwxNCArNTEsMTAgQEAgV0kuQ29v a2llUG9wb3ZlciA9IGNsYXNzIENvb2tpZVBvcG92ZXIgZXh0ZW5kcyBXSS5Qb3BvdmVyCiAgICAg ICAgIGlmICghdGhpcy5fdGFyZ2V0RWxlbWVudCkKICAgICAgICAgICAgIHJldHVybiBudWxsOwog Ci0gICAgICAgIGxldCBuYW1lID0gdGhpcy5fbmFtZUlucHV0RWxlbWVudC52YWx1ZSB8fCB0aGlz Ll9uYW1lSW5wdXRFbGVtZW50LnBsYWNlaG9sZGVyOworICAgICAgICBsZXQgbmFtZSA9IHRoaXMu X25hbWVJbnB1dEVsZW1lbnQudmFsdWU7CiAgICAgICAgIGlmICghbmFtZSkKICAgICAgICAgICAg IHJldHVybiBudWxsOwogCi0gICAgICAgIGxldCB2YWx1ZSA9IHRoaXMuX3ZhbHVlSW5wdXRFbGVt ZW50LnZhbHVlIHx8IHRoaXMuX3ZhbHVlSW5wdXRFbGVtZW50LnBsYWNlaG9sZGVyOwotICAgICAg ICBpZiAoIXZhbHVlKQotICAgICAgICAgICAgcmV0dXJuIG51bGw7Ci0KICAgICAgICAgbGV0IGRv bWFpbiA9IHRoaXMuX2RvbWFpbklucHV0RWxlbWVudC52YWx1ZSB8fCB0aGlzLl9kb21haW5JbnB1 dEVsZW1lbnQucGxhY2Vob2xkZXI7CiAgICAgICAgIGlmICghZG9tYWluKQogICAgICAgICAgICAg cmV0dXJuIG51bGw7CkBAIC04Myw3ICs3OSw3IEBAIFdJLkNvb2tpZVBvcG92ZXIgPSBjbGFzcyBD b29raWVQb3BvdmVyIGV4dGVuZHMgV0kuUG9wb3ZlcgogCiAgICAgICAgIGxldCBkYXRhID0gewog ICAgICAgICAgICAgbmFtZSwKLSAgICAgICAgICAgIHZhbHVlLAorICAgICAgICAgICAgdmFsdWU6 IHRoaXMuX3ZhbHVlSW5wdXRFbGVtZW50LnZhbHVlLAogICAgICAgICAgICAgZG9tYWluLAogICAg ICAgICAgICAgcGF0aCwKICAgICAgICAgICAgIGh0dHBPbmx5OiB0aGlzLl9odHRwT25seUNoZWNr Ym94RWxlbWVudC5jaGVja2VkLApAQCAtMTI0LDggKzEyMCw4IEBAIFdJLkNvb2tpZVBvcG92ZXIg PSBjbGFzcyBDb29raWVQb3BvdmVyIGV4dGVuZHMgV0kuUG9wb3ZlcgogICAgICAgICAgICAgZGF0 YS5zYW1lU2l0ZSA9IGNvb2tpZS5zYW1lU2l0ZTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgIGxldCB1cmxDb21wb25lbnRzID0gV0kubmV0d29ya01hbmFnZXIubWFpbkZyYW1lLm1haW5S ZXNvdXJjZS51cmxDb21wb25lbnRzOwotICAgICAgICAgICAgZGF0YS5uYW1lID0gV0kudW5sb2Nh bGl6ZWRTdHJpbmcoIm5hbWUiKTsKLSAgICAgICAgICAgIGRhdGEudmFsdWUgPSBXSS51bmxvY2Fs aXplZFN0cmluZygidmFsdWUiKTsKKyAgICAgICAgICAgIGRhdGEubmFtZSA9ICIiOworICAgICAg ICAgICAgZGF0YS52YWx1ZSA9ICIiOwogICAgICAgICAgICAgZGF0YS5kb21haW4gPSB1cmxDb21w b25lbnRzLmhvc3Q7CiAgICAgICAgICAgICBkYXRhLnBhdGggPSB1cmxDb21wb25lbnRzLnBhdGg7 CiAgICAgICAgICAgICBkYXRhLmV4cGlyZXMgPSB0aGlzLl9kZWZhdWx0RXhwaXJlcygpLnRvTG9j YWxlU3RyaW5nKCk7CkBAIC0xODAsNiArMTc2LDcgQEAgV0kuQ29va2llUG9wb3ZlciA9IGNsYXNz IENvb2tpZVBvcG92ZXIgZXh0ZW5kcyBXSS5Qb3BvdmVyCiAgICAgICAgIH0KIAogICAgICAgICB0 aGlzLl9uYW1lSW5wdXRFbGVtZW50ID0gY3JlYXRlSW5wdXRSb3coIm5hbWUiLCBXSS5VSVN0cmlu ZygiTmFtZSIpLCAidGV4dCIsIGRhdGEubmFtZSkuaW5wdXRFbGVtZW50OworICAgICAgICB0aGlz Ll9uYW1lSW5wdXRFbGVtZW50LnJlcXVpcmVkID0gdHJ1ZTsKIAogICAgICAgICB0aGlzLl92YWx1 ZUlucHV0RWxlbWVudCA9IGNyZWF0ZUlucHV0Um93KCJ2YWx1ZSIsIFdJLlVJU3RyaW5nKCJWYWx1 ZSIpLCAidGV4dCIsIGRhdGEudmFsdWUpLmlucHV0RWxlbWVudDsKIApAQCAtMjAyLDggKzE5OSwx MCBAQCBXSS5Db29raWVQb3BvdmVyID0gY2xhc3MgQ29va2llUG9wb3ZlciBleHRlbmRzIFdJLlBv cG92ZXIKICAgICAgICAgdGhpcy5fc2FtZVNpdGVTZWxlY3RFbGVtZW50ID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgic2VsZWN0Iik7CiAgICAgICAgIGZvciAobGV0IHNhbWVTaXRlVHlwZSBvZiBP YmplY3QudmFsdWVzKFdJLkNvb2tpZS5TYW1lU2l0ZVR5cGUpKSB7CiAgICAgICAgICAgICBsZXQg b3B0aW9uRWxlbWVudCA9IHRoaXMuX3NhbWVTaXRlU2VsZWN0RWxlbWVudC5hcHBlbmRDaGlsZChk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJvcHRpb24iKSk7Ci0gICAgICAgICAgICBvcHRpb25FbGVt ZW50LnRleHRDb250ZW50ID0gc2FtZVNpdGVUeXBlOworICAgICAgICAgICAgb3B0aW9uRWxlbWVu dC52YWx1ZSA9IHNhbWVTaXRlVHlwZTsKKyAgICAgICAgICAgIG9wdGlvbkVsZW1lbnQudGV4dENv bnRlbnQgPSBXSS5Db29raWUuZGlzcGxheU5hbWVGb3JTYW1lU2l0ZVR5cGUoc2FtZVNpdGVUeXBl KTsKICAgICAgICAgfQorICAgICAgICB0aGlzLl9zYW1lU2l0ZVNlbGVjdEVsZW1lbnQudmFsdWUg PSBkYXRhLnNhbWVTaXRlOwogICAgICAgICBjcmVhdGVSb3coInNhbWUtc2l0ZSIsIFdJLnVubG9j YWxpemVkU3RyaW5nKCJTYW1lU2l0ZSIpLCB0aGlzLl9zYW1lU2l0ZVNlbGVjdEVsZW1lbnQpOwog CiAgICAgICAgIGxldCB0b2dnbGVFeHBpcmVzUm93ID0gKCkgPT4gewo=